osmo-hlr[master]: add osmo-hlr-db-tool, program to migrate from osmo-nitb db

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Oct 27 09:50:04 UTC 2017


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/4441/1/src/hlr_db_tool.c
File src/hlr_db_tool.c:

PS1, Line 53: [--import-nitb-db <nitb.db>]
not sure what you had exactly in mind.  To me, the generic name "osmo-hlr-db-tool" indicates that in the future you want to do other things with it (e.g. import of CSV files with sim card data, ...).  This is great and I like that idea.  However, in that case I would suggest that the actual operation (such as import-nitb-db) becomes a "command" and not an optional argument.  So basically one would call the tool with a set of comamnd line arguments (generic ones?), then issue a command, and then that command could have optional arguments.  So

"osmo-hlr-db-tool -d -T import-nitb-db my_db_file"

At that point it's clear that the command "import-nitb-db" is not an option/flag, and that there is only one for each invocation of the tool.


-- 
To view, visit https://gerrit.osmocom.org/4441
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dfa6ec033dd93161c1adc2ce1637195fe5b7a63
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list