This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: For an example, see rsl_act_type_name() in libosmocore/include/osmocom/gsm/rsl.h > So now > there's the conflict in whether we align with current best > practises or with the style that's used in the file so far. Adding a static inline function to the header for this function alone is what I'd do. (And also publish the _names[] if it's not published yet.) And leave all the rest the way it is, for hysterical raisins. > Also, this is yet another change that will break compilation with > older libosmocore version. For I believe *very* questionable gain. What change will break anything? Aligning the rest of the file to static inline functions? Then let's not? -- To view, visit https://gerrit.osmocom.org/4355 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieace734aaff3f07606113feddde65b75202d96d6 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: No