libosmocore[master]: abis_nm: Add abis_nm_admin_name() API

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Oct 20 11:13:37 UTC 2017


Patch Set 1:

I think we decided quote some time ago not to introduce such helper functions anymore - and/or if at all, make them inline wrappers around the access to the respective value string array.  So now there's the conflict in whether we align with current best practises or with the style that's used in the file so far.

Also, this is yet another change that will break compilation with older libosmocore version.  For I believe *very* questionable gain.  So we spend time on writing this code, changing all the existing users, reviewing it, merging it and then it will cause more build failures.  Interested in other opinions, but my gut feeling is to not merge this.

-- 
To view, visit https://gerrit.osmocom.org/4355
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieace734aaff3f07606113feddde65b75202d96d6
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list