This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPatch Set 1: (9 comments) https://gerrit.osmocom.org/#/c/4151/1/suites/aoip_debug/interactive.py File suites/aoip_debug/interactive.py: Line 26: cmd = prompt('Enter command: (q)uit (s)ms (g)et-registered (w)ait-registered, call-list [<ms_msisdn>], call-dial <src_msisdn> <dst_msisdn>, call-answer <ms_msisdn> <call_id>, call-hangup <ms_msisdn> <call_id>') > that prompt line is getting awfully long. We may need to a) split it up or I'd go for b, otherwise it's annoying while using it. I think it's better to keep that for a later patch though. Line 52: elif cmd.startswith('call-list'): > evangelism: before, commands could be abbreviated to their least unique len I know, I understand, but then you cannot pass parameters and you need to keep looking for different prefix for each new command, which doesn't scale nice. Line 58: print('call_list: %r' % ms.call_id_list()) > nitpick: command is 'call-list', py function is call_id_list(), yet this pr I'll move it to call-list Line 65: print('dial %s->%s, %s' % (params[1],params[2],str(mo.call_dial(params[2])))) > 'dialing'? Might be better to first print 'dialing' and then start dialing? I'll split this into 2 prints. Line 69: continue > would make more readable: I wanted to avoid extra lines, but I can do that too yes. Line 72: print('answer %s' % params[2]) > 'answering'? Agree Line 77: continue > would make more readable: I'll do it. Line 80: print('hang up %s' % params[2]) > 'hanging up' ? Agree https://gerrit.osmocom.org/#/c/4151/1/suites/debug/interactive.py File suites/debug/interactive.py: Line 45: elif cmd.startswith('call-list'): > oh damn, are we really duplicating all this? we should fix that... At a later stage it may make sense to move it to a library, or to make it generic (running a python console directly so we have all python syntax and osmo-gsm-tester API available directly?). -- To view, visit https://gerrit.osmocom.org/4151 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2df68bf4fba0fb542eebdeb515a3dac6d5e575e Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes