This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: To elaborate further. Before this change I had to know what test_successive_allocation is doing. If I understand it correctly you are confused that for min_class and max_class sometimes the same class and sometimes different classes are passed. You try to solve this by introducing another method for the min_class == max_class case and put _single as suffix to the method name. With bike shedding maybe _single_class _one_class might be better but the point is.. after the change one needs to know the original method with all its parameters and now the overload as well. >From my point of view this is not an improvement. The human brain can only keep a few things in its memory/registers. So by knowing the new overload, something else must be spilled. I don't think a _single function in a test adds so much value to spill something else... leave alone to spend time changing it right now. -- To view, visit https://gerrit.osmocom.org/4956 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3feeb92237ffb9557ac6998540b740f1f67186b3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-HasComments: No