This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (4 comments) I don't get this churn.. It is different to what Jacob wrote but in which way is it better or needed? You remove one test (function) and inline it. Change some parameters. Say you remove one wrapper, add another? Why? https://gerrit.osmocom.org/#/c/4956/1//COMMIT_MSG Commit Message: Line 10: * rename top-level function to avoid confusion Which confusion? How is it better? Is there a bonus scheme for touching as many lines as possible? Line 11: * reformat to improve readability and destroying git blame.. Line 12: * drop confusing wrapper By which metric is it confusing? https://gerrit.osmocom.org/#/c/4956/1/tests/alloc/AllocTest.cpp File tests/alloc/AllocTest.cpp: Line 700: static inline void test_successive_allocation_single(algo_t algo, unsigned ms_class, enum test_mode mode, Single what? single ms? single class? single timeslot? single direction? -- To view, visit https://gerrit.osmocom.org/4956 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3feeb92237ffb9557ac6998540b740f1f67186b3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes