osmo-gsm-tester[master]: ofono/dbus: detach from signals as appropriate

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed May 10 12:47:19 UTC 2017


Patch Set 3:

(3 comments)

https://gerrit.osmocom.org/#/c/2554/3/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:

Line 157:         for subscription in subscriptions:
> missing indent here? It does makes no sense to iterate over subrscription i
it will never be None because above [] would be returned. It made more sense when the dbg() call wasn't there, but now with that in there it does look a bit weird indeed.


Line 164:                 I_SMS: ( ('IncomingMessage', self._on_incoming_message), ),
> Shouldn't this be [ () ] as in array of tuples?
it's a tuple of tuples. we're not planning to change the list dynamically.

  (item, )

is semantically the same as

  [item]

only that the tuple version is immutable. Note the comma  which makes it a tuple instead of just a brace around a statement.

The [] would be more clear for the reader, easy to miss the comma in the end.


Line 175:         for signal, cb in want:
> I'd prefer using "signal_name" for this
indeed


-- 
To view, visit https://gerrit.osmocom.org/2554
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0939ef414bc599ee8742df48da04d8d9569d00ba
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list