This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Patch Set 3:
(3 comments)
https://gerrit.osmocom.org/#/c/2554/3/src/osmo_gsm_tester/ofono_client.py
File src/osmo_gsm_tester/ofono_client.py:
Line 157: for subscription in subscriptions:
missing indent here? It does makes no sense to iterate over subrscription if it's None right?
Line 164: I_SMS: ( ('IncomingMessage', self._on_incoming_message), ),
Shouldn't this be [ () ] as in array of tuples?
Line 175: for signal, cb in want:
I'd prefer using "signal_name" for this
--
To view, visit https://gerrit.osmocom.org/2554
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0939ef414bc599ee8742df48da04d8d9569d00ba
Gerrit-PatchSet: 3
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: Yes