This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 3:
(2 comments)
https://gerrit.osmocom.org/#/c/1962/3/include/osmocom/ctrl/control_cmd.h
File include/osmocom/ctrl/control_cmd.h:
Line 25: CTRL_TYPE_UNKNOWN,
> that is still 0...so maybe omit?
The ctrl code checks for CTRL_TYPE_UNKNOWN in some places. It's not needed really, but I like that a struct talloc_zero'd reflects a clearly defined invalid enum value. Anyway, if we want to remove CTRL_TYPE_UNKNOWN, that would probably be a separate patch. For me it's most important to patch up that other commit I didn't like much, so that I can also add the value_string[] termination check to jenkins in G#1940 (and finally end the deadlock between Max and me).
https://gerrit.osmocom.org/#/c/1962/3/src/ctrl/control_cmd.c
File src/ctrl/control_cmd.c:
Line 50: { 0, NULL }
> Okay.. so if the value_string array is used without the enum..
since I'm not sufficiently telepathic, would you mind completing the sentence? :)
--
To view, visit https://gerrit.osmocom.org/1962
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia99f37464c7b36b587da2cc78f52c82725f02cbc
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes