libosmocore[master]: ctrl_type_vals: explicitly terminate

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Mar 8 10:39:50 UTC 2017


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/1962/3/include/osmocom/ctrl/control_cmd.h
File include/osmocom/ctrl/control_cmd.h:

Line 25: 	CTRL_TYPE_UNKNOWN,
that is still 0...so maybe omit?


https://gerrit.osmocom.org/#/c/1962/3/src/ctrl/control_cmd.c
File src/ctrl/control_cmd.c:

Line 50: 	{ 0, NULL }
Okay.. so if the value_string array is used without the enum..


-- 
To view, visit https://gerrit.osmocom.org/1962
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia99f37464c7b36b587da2cc78f52c82725f02cbc
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list