[MERGED] osmo-bts[master]: VIRT-PHY: Report virtual RACH bursts with plausible burst type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jul 19 14:17:35 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: VIRT-PHY: Report virtual RACH bursts with plausible burst type
......................................................................


VIRT-PHY: Report virtual RACH bursts with plausible burst type

Change-Id: I35b103c512993fc52d4e608f07115a4bb4b21022
---
M src/osmo-bts-virtual/l1_if.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-virtual/l1_if.c b/src/osmo-bts-virtual/l1_if.c
index 3ef8c72..4fe1ec8 100644
--- a/src/osmo-bts-virtual/l1_if.c
+++ b/src/osmo-bts-virtual/l1_if.c
@@ -119,7 +119,9 @@
 		l1sap.u.rach_ind.acc_delay = 0; /* probably not used in virt um */
 		l1sap.u.rach_ind.is_11bit = 0;
 		l1sap.u.rach_ind.fn = fn;
-		l1sap.u.rach_ind.burst_type = GSM_L1_BURST_TYPE_NONE; /* FIXME: what comes here */
+		/* we don't rally know which RACH bursrt type the virtual MS is using, as this field is not
+		 * part of information present in the GSMTAP header.  So we simply report all of them as 0 */
+		l1sap.u.rach_ind.burst_type = GSM_L1_BURST_TYPE_ACCESS_0;
 		break;
 	case GSMTAP_CHANNEL_TCH_F:
 	case GSMTAP_CHANNEL_TCH_H:

-- 
To view, visit https://gerrit.osmocom.org/3297
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35b103c512993fc52d4e608f07115a4bb4b21022
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list