[PATCH] osmo-bts[master]: scheduler: Fix wrong log subsystem: L1C is L1 *control* not ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jul 19 14:02:52 UTC 2017


Review at  https://gerrit.osmocom.org/3298

scheduler: Fix wrong log subsystem: L1C is L1 *control* not user data

RTS.ind, DATA.* and TCH.* primitives are L1P, not L1C.

Change-Id: I4a32b83225e931ced561fdf457fa962e8ad44bd2
---
M src/common/scheduler.c
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/98/3298/1

diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index 121475a..08603d2 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -282,7 +282,7 @@
 		l1sap = msgb_l1sap_prim(msg);
 		if (l1sap->oph.operation != PRIM_OP_REQUEST) {
 wrong_type:
-			LOGP(DL1C, LOGL_ERROR, "Prim for ts=%u at fn=%u has "
+			LOGP(DL1P, LOGL_ERROR, "Prim for ts=%u at fn=%u has "
 				"wrong type.\n", tn, fn);
 free_msg:
 			/* unlink and free message */
@@ -305,7 +305,7 @@
 			goto wrong_type;
 		}
 		if (prim_fn > 100) {
-			LOGP(DL1C, LOGL_NOTICE, "Prim %u for trx=%u ts=%u at "
+			LOGP(DL1P, LOGL_NOTICE, "Prim %u for trx=%u ts=%u at "
 			     "fn=%u is out of range (100), or channel %s with "
 			     "type %s is already disabled. If this happens in "
 			     "conjunction with PCU, increase 'rts-advance' by 5."
@@ -329,7 +329,7 @@
 found_msg:
 	if ((chan_nr ^ (trx_chan_desc[chan].chan_nr | tn))
 	 || ((link_id & 0xc0) ^ trx_chan_desc[chan].link_id)) {
-		LOGP(DL1C, LOGL_ERROR, "Prim for ts=%u at fn=%u has wrong "
+		LOGP(DL1P, LOGL_ERROR, "Prim for ts=%u at fn=%u has wrong "
 			"chan_nr=%02x link_id=%02x, expecting chan_nr=%02x "
 			"link_id=%02x.\n", tn, fn, chan_nr, link_id,
 			trx_chan_desc[chan].chan_nr | tn,
@@ -418,7 +418,7 @@
 	uint8_t tn = l1sap->u.data.chan_nr & 7;
 	struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn);
 
-	LOGP(DL1C, LOGL_INFO, "PH-DATA.req: chan_nr=0x%02x link_id=0x%02x "
+	LOGP(DL1P, LOGL_INFO, "PH-DATA.req: chan_nr=0x%02x link_id=0x%02x "
 		"fn=%u ts=%u trx=%u\n", l1sap->u.data.chan_nr,
 		l1sap->u.data.link_id, l1sap->u.data.fn, tn, l1t->trx->nr);
 
@@ -441,7 +441,7 @@
 	uint8_t tn = l1sap->u.tch.chan_nr & 7;
 	struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn);
 
-	LOGP(DL1C, LOGL_INFO, "TCH.req: chan_nr=0x%02x "
+	LOGP(DL1P, LOGL_INFO, "TCH.req: chan_nr=0x%02x "
 		"fn=%u ts=%u trx=%u\n", l1sap->u.tch.chan_nr,
 		l1sap->u.tch.fn, tn, l1t->trx->nr);
 
@@ -477,12 +477,12 @@
 	link_id = trx_chan_desc[chan].link_id;
 
 	if (!chan_nr) {
-		LOGP(DL1C, LOGL_FATAL, "RTS func for %s with non-existing "
+		LOGP(DL1P, LOGL_FATAL, "RTS func for %s with non-existing "
 			"chan_nr %d\n", trx_chan_desc[chan].name, chan_nr);
 		return -ENODEV;
 	}
 
-	LOGP(DL1C, LOGL_INFO, "PH-RTS.ind: chan=%s chan_nr=0x%02x "
+	LOGP(DL1P, LOGL_INFO, "PH-RTS.ind: chan=%s chan_nr=0x%02x "
 		"link_id=0x%02x fn=%u ts=%u trx=%u\n", trx_chan_desc[chan].name,
 		chan_nr, link_id, fn, tn, l1t->trx->nr);
 
@@ -514,12 +514,12 @@
 	link_id = trx_chan_desc[chan].link_id;
 
 	if (!chan_nr) {
-		LOGP(DL1C, LOGL_FATAL, "RTS func for %s with non-existing "
+		LOGP(DL1P, LOGL_FATAL, "RTS func for %s with non-existing "
 			"chan_nr %d\n", trx_chan_desc[chan].name, chan_nr);
 		return -ENODEV;
 	}
 
-	LOGP(DL1C, LOGL_INFO, "TCH RTS.ind: chan=%s chan_nr=0x%02x "
+	LOGP(DL1P, LOGL_INFO, "TCH RTS.ind: chan=%s chan_nr=0x%02x "
 		"fn=%u ts=%u trx=%u\n", trx_chan_desc[chan].name,
 		chan_nr, fn, tn, l1t->trx->nr);
 

-- 
To view, visit https://gerrit.osmocom.org/3298
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a32b83225e931ced561fdf457fa962e8ad44bd2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list