[MERGED] libosmocore[master]: gsup decode: fix expectation of AUTS length, should be 14

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 22 01:49:46 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: gsup decode: fix expectation of AUTS length, should be 14
......................................................................


gsup decode: fix expectation of AUTS length, should be 14

The wrong expectation caused OsmoHLR to fail on Auth Sync.

Change-Id: I277fb3d407396dffa5c07a9c5454d87a415d393f
---
M src/gsm/gsup.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c
index ec1dc90..a813ed8 100644
--- a/src/gsm/gsup.c
+++ b/src/gsm/gsup.c
@@ -339,9 +339,9 @@
 			break;
 
 		case OSMO_GSUP_AUTS_IE:
-			if (value_len != 16) {
+			if (value_len != 14) {
 				LOGP(DLGSUP, LOGL_ERROR,
-					"AUTS length != 16 received\n");
+					"AUTS length != 14 received\n");
 				return -GMM_CAUSE_COND_IE_ERR;
 			}
 			gsup_msg->auts = value;

-- 
To view, visit https://gerrit.osmocom.org/1860
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I277fb3d407396dffa5c07a9c5454d87a415d393f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list