libosmocore[master]: gsup decode: fix expectation of AUTS length, should be 14

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 22 01:49:44 UTC 2017


Patch Set 1: Code-Review+2

> Don't we have #define somewhere in libosmocore?

No, all the code just assumes literally 14 all the time :/
I agree that it should be a constant, but let's not hold up this important fix because of that...

Actually I'm fast tracking this now because both MSC's and SGSN's UMTS AKA implementations depend on this to be able to do AUTS resync.

Introducing size constants to GSUP shall be a separate cosmetic patch.

-- 
To view, visit https://gerrit.osmocom.org/1860
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I277fb3d407396dffa5c07a9c5454d87a415d393f
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list