This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pablo Neira Ayuso gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/3540/1/openbsc/include/openbsc/gsm_data.h File openbsc/include/openbsc/gsm_data.h: Line 460: time_t created; This creates a "hole" in the structure, I would place it before "bool is_report;" See "pahole" utility for what I mean, it shows the structure layout in binary, including alignments. This is not a big issue here, since neither reducing memory is a real concern nor trying to fit this structure into a cacheline to speed up things (performance) is a major goal I would say... but it's a good thing in general to keep things tidy in this regard. It's just a matter of placing this new field definition before bool is_report; so it doesn't take much time to do this. -- To view, visit https://gerrit.osmocom.org/3540 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9056429d40bf02731f004b7833f1de45a0d1add8 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org> Gerrit-HasComments: Yes