openbsc[master]: SMS Delivery reports: Use actual delivery time, not time of ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pablo Neira Ayuso gerrit-no-reply at lists.osmocom.org
Thu Aug 17 08:54:58 UTC 2017


Patch Set 1: Code-Review+1

(3 comments)

Apart from the obvious the existing issues, it's great you have tracked down and fixed this little aspect, so this is my +1 :)

https://gerrit.osmocom.org/#/c/3540/1//COMMIT_MSG
Commit Message:

Line 7: SMS Delivery reports: Use actual delivery time, not time of report creation.
Probably good to keep using consistent names in patch titles, so I would propose as patch title:

"libmsc: Use actual delivery time in delivery reports"

Not sure there's a policy in osmocom, but this info is good for grepping in logs from time to time.

Anyway, not a big issue.


https://gerrit.osmocom.org/#/c/3540/1/openbsc/src/libmsc/db.c
File openbsc/src/libmsc/db.c:

Line 1708: 		"SELECT datetime(SMS.created,'localtime') as created, SMS.* "
> Hmm, this passes the test on my build box, but I guess I was being lazy her
Probably this is breaking openbsc/tests/db/db_test ?


https://gerrit.osmocom.org/#/c/3540/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:

Line 313: 	gsm340_gen_scts(smsp, sms->created);
> Maybe this one should be "now"
Not sure what your question is? :-)


-- 
To view, visit https://gerrit.osmocom.org/3540
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9056429d40bf02731f004b7833f1de45a0d1add8
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list