This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 if you do this, then you can remove the entire osmo_rtcp_fd_cb() function and make sure to set rs->rtcp_bfd.when = 0, while keeping rs->rtp_bfd.when = BSC_FD_READ. After all, why request the select() loop to wake you up to call a call-back function which then does nothing? I intentionally called the private libortp API as it was the only way that I could see to fully take advantage of select() based trigger for reading the RTCP socket and still processing the RTCP data. Maybe it is a bad idea and we should simply rely on the ortp internal polling of RTCP. But please make sure that the RTCP data is actually received before changing any part of this. -- To view, visit https://gerrit.osmocom.org/908 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff1b15c68efca3e02267e0308142c6a7a0c2a974 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No