This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.org
Review at https://gerrit.osmocom.org/908
Remove use of private oRTP function
ortp: the rtp_session_rtcp_recv() function is not part of public oRTP
API so we shouldn't use it. Besides it is called internally by oRTP in
rtp_session_recvm_with_ts() which we call anyway.
Change-Id: Iff1b15c68efca3e02267e0308142c6a7a0c2a974
---
M src/trau/osmo_ortp.c
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/08/908/1
diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c
index cc1d748..1ada83d 100644
--- a/src/trau/osmo_ortp.c
+++ b/src/trau/osmo_ortp.c
@@ -205,12 +205,10 @@
static int osmo_rtcp_fd_cb(struct osmo_fd *fd, unsigned int what)
{
- struct osmo_rtp_socket *rs = fd->data;
-
- /* We probably don't need this at all, as
+ /* Nothing to see here, move along:
* rtp_session_recvm_with_ts() will alway also poll the RTCP
* file descriptor for new data */
- return rtp_session_rtcp_recv(rs->sess);
+ return 0;
}
static int osmo_rtp_socket_fdreg(struct osmo_rtp_socket *rs)
--
To view, visit https://gerrit.osmocom.org/908
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff1b15c68efca3e02267e0308142c6a7a0c2a974
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>