osmo-bts[master]: DTX: check Marker bit to send ONSET to L1

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Sat Sep 17 11:25:37 UTC 2016


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/691/4/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:

Line 503: 	if (l1sap->u.tch.marker) { /* Send voice after ONSET was sent */
> I think it might be more elegant to first handle the if (marker) send_onset
I think it's more intuitive to place tail recursive call at the end of the function but I agree - it's more of stylistic question.


-- 
To view, visit https://gerrit.osmocom.org/691
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88c41568bcb0d82699f617adc4ad192603dd1bb6
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list