This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 4: Code-Review-1
(3 comments)
https://gerrit.osmocom.org/#/c/691/4/src/common/l1sap.c
File src/common/l1sap.c:
Line 1071: msgb_put_u8(msg, marker);
i think the more elegant way would be to store the marker somewhere in the msgb->cb, rather than to push it as a pseudo-header in front of the data.
https://gerrit.osmocom.org/#/c/691/4/src/osmo-bts-litecell15/l1_if.c
File src/osmo-bts-litecell15/l1_if.c:
Line 503: if (l1sap->u.tch.marker) { /* Send voice after ONSET was sent */
I think it might be more elegant to first handle the if (marker) send_onset_primitive inside an if clause and then do the common processing for actual voice data below that. But that's probably just a stylistic question. Right now in your implementation I think it's a bit un-intuitive to see what's happening.
https://gerrit.osmocom.org/#/c/691/4/src/osmo-bts-litecell15/tch.c
File src/osmo-bts-litecell15/tch.c:
Line 337: enum osmo_amr_type ft;
we don't do late variable declarations. they should be declared at the beginning of the block (which is the function in this case).
--
To view, visit https://gerrit.osmocom.org/691
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88c41568bcb0d82699f617adc4ad192603dd1bb6
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes