This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
tnt gerrit-no-reply at lists.osmocom.orgPatch Set 8: Code-Review+1 Ideally in the future I'd like the number of digits ( '%2d' '%3d' ) to be automatically computed based on the table content. Maybe even compute the number of items per line automatically. I'm also not a big fan of mixing the "print >>fi" and the fi.write() approach but tbh I much prefer the .write approach that this patch uses and so we can in the future move everything to it. But this is definitely an improvement over the existing and since what I describe above would change anything for the current codes, I don't see any reason not to merge this. -- To view, visit https://gerrit.osmocom.org/829 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95256c4ad402a3c088bdb6c5a5cda8b17c31881c Gerrit-PatchSet: 8 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: tnt <tnt at 246tNt.com> Gerrit-HasComments: No