libosmocore[master]: utils/conv_gen.py: improve output formatting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Oct 19 07:25:30 UTC 2016


Patch Set 7:

(4 comments)

https://gerrit.osmocom.org/#/c/829/6/utils/conv_gen.py
File utils/conv_gen.py:

Line 142: 
> counter == 0 will only happen at the very first iteration, so you can put t
Done


Line 164: 		print_formatted(self.puncture, "%3d, ", 12, fi)
> same
Done


Line 179: 		if self.recursive:
> same
Done


Line 185: 				"};\n\nstatic const uint8_t %s_term_output[] = {" % self.name
> Actually, the output loop with the 'counter % 12' algorithm and whitespace 
Done


-- 
To view, visit https://gerrit.osmocom.org/829
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95256c4ad402a3c088bdb6c5a5cda8b17c31881c
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list