This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 > And gsm48_rx_mm_auth_resp will call the CB GSM_SECURITY_AUTH_FAILED? This is actually a slightly old commit I still found in my queue. It seems I overlooked the gsm48_rx_mm_auth_resp() case, so you're completely right and _AUTH_FAILED is indeed invoked. So we should handle the _AUTH_FAILED properly, and it's not exclusive to 3G. So then this question remains: On auth failure, do we reply with a LU reject, or do we just close down the connection? (The current code just terminates the connection without a LU reject.) (And 3G would then behave the same as 2G) -- To view, visit https://gerrit.osmocom.org/331 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44aac24811785c4b6f95f830b8b35d5fbe644e0f Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: No