openbsc[master]: Remove unused auth code and add comment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon Jun 20 11:58:30 UTC 2016


Patch Set 1:

(1 comment)

What am I missing?


static int gsm0408_authorize(struct gsm_subscriber_connection *conn, struct msgb *msg) will check for LU (loc_operation) and pass _gsm0408_authorize_sec_cb as callback?

authorize_subscriber will check if there is a subscriber and we are not waiting for an answer and then call gsm48_secure_channel.

And gsm48_rx_mm_auth_resp will call the CB GSM_SECURITY_AUTH_FAILED?

Is there something wrong going from gsm48_rx_mm_auth_resp to the LU handling for auth failed? Did you find the issue while trying to provoke auth failures?

https://gerrit.osmocom.org/#/c/331/1/openbsc/src/libmsc/gsm_04_08.c
File openbsc/src/libmsc/gsm_04_08.c:

Line 382: 			 */
But that will keep the radio resources allocated longer than necessary?


-- 
To view, visit https://gerrit.osmocom.org/331
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44aac24811785c4b6f95f830b8b35d5fbe644e0f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list