This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/239/2/src/osmo-bts-litecell15/lc15bts.h File src/osmo-bts-litecell15/lc15bts.h: Line 81: #define GSM_BTS_MAX_CELL_SIZE_DEFAULT 166 /* 166 qbits is default value */ I also commented on this before, but somehow it got lost in gerrit. Are you sure you submitted your updated patch with the same change-id as the old patch? In either case, the #defines are LC15 specific and they should not pollute the global namespace with GSM_BTS_ prefix, which implies they are applicable to any type of BTS. https://gerrit.osmocom.org/#/c/239/2/src/osmo-bts-litecell15/lc15bts_vty.c File src/osmo-bts-litecell15/lc15bts_vty.c: Line 354: "max-cell-size <0-166>", and here my comment was that normally, all of this is configured via A-bis OML, as the BTS should not have any local configuration beyond how to reach the BSC and how to identify to it. Local config settings breaks the data model that operators generally expect, i.e. all configuration is maintained (and under revision control, ...) at the central BSC, and not at the remote BTSs. -- To view, visit https://gerrit.osmocom.org/239 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3622d5b6f22525b798b0c75bbc2bab3767aba923 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes