This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/239/2/include/osmo-bts/gsm_data.h
File include/osmo-bts/gsm_data.h:
Line 115: /* specific to LC15 BTS */
I think I commented on this before, but somehow the comment doesn't seem to show up in gerrit anymore.
Please don't add members to struct gsm_bts_role_bts like this. Don't introduce #ifdefs in the code. My first question is: Does this data really belong here, or does it belong into the phy_link structure? If it does belong here, then please introduce a
union u {
struct {
} lc15;
};
for your private data members, and skip the #ifdef. Thanks!
--
To view, visit https://gerrit.osmocom.org/239
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3622d5b6f22525b798b0c75bbc2bab3767aba923
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes