This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/500/5/openbsc/include/openbsc/gsm_data.h
File openbsc/include/openbsc/gsm_data.h:
Line 188: {"chreq.total", "Received channel requests."},
there is nothing that ensures the enum above is in sync with this array here. It would be best to use [MSC_CTR_CALL_MT_CONNECT] = {...} style to avoid any errors.
Line 223: "mobile switch center",
it's a mobile switchING center. Also, as discussed verbally before, I think it would be best to split the counters into separate groups.
In terms of terminology: The former struct's "chreq, handover, chan, bts" all logically belong to the BSC, hence I don't like them to be part of a "MSC" structure.
--
To view, visit https://gerrit.osmocom.org/500
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie749cebd53a0bb618d0e23d375885712078bf8dd
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes