This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 1: (5 comments) Logs introduced in this patch are under one main log present earlier. so no need to dump TBF with it. if introduced, other sub logs present earlier will not be aligned with this log. https://gerrit.osmocom.org/#/c/537/1/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 396: uint8_t *rlc_data = &(block->block[0]); > no parenthesis needed. I agree. I will modify the same Line 442: static uint8_t seg_data[RLC_MAX_LEN]; > why do we need it? block->block remains valid and we could do a memmove to I agree. I will modify the same. Line 478: "-- Got SPB(%d) " > NOTICE is too verbose. I agree. I will modify NOTICE to DEBUG. Line 495: OSMO_ASSERT(false); > I don't think we want to crash if somebody gives us bad input. I agree. I will modify the same. Line 520: OSMO_ASSERT(false); > crash is probably too harsh or why are you certain that it can't be reached valid combination of assembling are MCS1->MCS4, MCS2->MCS5, MCS3->MCS6 (refer Table 10.3a.0.5 of 44.060). So in any case if the control enters the default case there is something erroneous with SPB handling in UL. So the assert is added to stop the further execution. -- To view, visit https://gerrit.osmocom.org/537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ca53218b6e0982abc2ab9c703c24c8bf0a09c0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes