This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (6 comments) A general comment on log messages. Imagine you have 1000 subscribers that try to do a routing area update. How to know which debug message applies to which TBF? In general we dump the TBF with it. https://gerrit.osmocom.org/#/c/537/1/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 396: uint8_t *rlc_data = &(block->block[0]); no parenthesis needed. Line 442: static uint8_t seg_data[RLC_MAX_LEN]; why do we need it? block->block remains valid and we could do a memmove to move it? Line 478: "-- Got SPB(%d) " NOTICE is too verbose. Line 495: OSMO_ASSERT(false); I don't think we want to crash if somebody gives us bad input. Line 520: OSMO_ASSERT(false); crash is probably too harsh or why are you certain that it can't be reached? https://gerrit.osmocom.org/#/c/537/1/tests/tbf/TbfTest.err File tests/tbf/TbfTest.err: Line 3354: Sending data request: trx=0 ts=7 sapi=5 arfcn=0 fn=2654270 block=8 data=4f 28 5e 24 46 68 90 f8 0a 39 00 00 88 00 08 2b 2b 2b 2b 2b 2b 2b 2b good that captures the SEGMENTATION bit now -- To view, visit https://gerrit.osmocom.org/537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ca53218b6e0982abc2ab9c703c24c8bf0a09c0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes