osmo-pcu[master]: Modify DL tbf flow for ARQ-II in EGPRS DL Retx

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Jul 13 13:05:18 UTC 2016


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/334/3/src/tbf_dl.cpp
File src/tbf_dl.cpp:

Line 423: 		cs2 = force_cs ? force_cs : current_cs();
> cs2 being calculated based on force_cs present or not. if it is present tha
Thank you for the explanation and the side effect in create_new_bsn.

I would like you to move the cs2 declaration into this scope as it seems to be the only place left using it. And maybe "cs2" is not a good name either, e.g. new_cs? Any other idea about the name?


-- 
To view, visit https://gerrit.osmocom.org/334
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a845c98f2018795f0f62240f228411b0bc030c7
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list