This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/334/3/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 423: cs2 = force_cs ? force_cs : current_cs(); > this is inconsistent with the *may_combine. a couple of lines below. It loo cs2 being calculated based on force_cs present or not. if it is present that value will be copied to cs2 and create_new_bsn will copy the cs2 to cs_current_trans. and same cs_current_trans will be used at *may_combine few line below. if force_cs is not valid cs2 being calculated from current_cs and create_new_bsn will copy the same to cs_current_trans for perticulat BSN. and same cs_current_trans will be used at *may_combine few line below. so nothing is inconsistent. Please let me know if any other queries. -- To view, visit https://gerrit.osmocom.org/334 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a845c98f2018795f0f62240f228411b0bc030c7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes