[PATCH] openbsc[master]: mgcp_protocol: Ensure we don't call strtok_r with NULL data

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1324

to look at the new patch set (#4).

mgcp_protocol: Ensure we don't call strtok_r with NULL data

Change-Id: I1dce4df6a49fe95db592b0598194e3a8b8b1b994
Fixes: Coverity CID 135181
---
M openbsc/src/libmgcp/mgcp_protocol.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/24/1324/4

diff --git a/openbsc/src/libmgcp/mgcp_protocol.c b/openbsc/src/libmgcp/mgcp_protocol.c
index 2e728cb..18398fc 100644
--- a/openbsc/src/libmgcp/mgcp_protocol.c
+++ b/openbsc/src/libmgcp/mgcp_protocol.c
@@ -447,6 +447,7 @@
 	int i = 0;
 	char *elem, *save = NULL;
 
+	OSMO_ASSERT(data);
 	pdata->trans = "000000";
 
 	for (elem = strtok_r(data, " ", &save); elem;

-- 
To view, visit https://gerrit.osmocom.org/1324
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1dce4df6a49fe95db592b0598194e3a8b8b1b994
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder