[PATCH] openbsc[master]: bsc_ctrl: Ensure we don't pass NULL string into strtok_r()

[Harald Welte]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1323

to look at the new patch set (#4).

bsc_ctrl: Ensure we don't pass NULL string into strtok_r()

Change-Id: I03bea132377c0136b55b6fdad99a5d92da12e692
Fixes: Coverity CID 135180
---
M openbsc/src/osmo-bsc/osmo_bsc_ctrl.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/23/1323/4

diff --git a/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c b/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c
index 3010b55..78647d3 100644
--- a/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c
+++ b/openbsc/src/osmo-bsc/osmo_bsc_ctrl.c
@@ -612,6 +612,7 @@
 	char *saveptr = NULL;
 	char *inp, *cic, *alert, *text;
 
+	OSMO_ASSERT(cmd);
 	inp = talloc_strdup(cmd, value);
 
 	cic = strtok_r(inp, ",", &saveptr);

-- 
To view, visit https://gerrit.osmocom.org/1323
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03bea132377c0136b55b6fdad99a5d92da12e692
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder