osmo-pcu[master]: Fix DL window calculation during tbf update

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Tue Aug 30 11:50:44 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/798/1/src/tbf.cpp
File src/tbf.cpp:

Line 387: 		ws = OSMO_MIN(128 * num_pdch, ws);
> This calculation is a code duplication from a part of tbf_alloc_dl_tbf() be
in this functions bts is of type BTS*(member variable). in another function what you mentioned bts is of type gprs_rlcmac_bts *bts_data. we need a content inside gprs_rlcmac_bts for this purpose. In any case I will write separate function.


-- 
To view, visit https://gerrit.osmocom.org/798
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41aa807068520460fd665a55e3529e60f6bbb630
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list