This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/798/1/src/tbf.cpp File src/tbf.cpp: Line 387: ws = OSMO_MIN(128 * num_pdch, ws); This calculation is a code duplication from a part of tbf_alloc_dl_tbf() below. Rather have a static function to calculate, and call in both places. Combine as much common code as possible, i.e. pass dl_slots() and bts as argument, having pcu_bitcount() and ws in the function. I am uncertain ... here you use bts->bts_data()->ws_base and ->ws_pdch, while tbf_alloc_dl_tbf() uses bts->ws_base and ->ws_pdch. Could you please explain this difference if it is valid? -- To view, visit https://gerrit.osmocom.org/798 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41aa807068520460fd665a55e3529e60f6bbb630 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes