osmo-pcu[master]: Add decoding of compressed bitmap in EPDAN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pravin gerrit-no-reply at lists.osmocom.org
Tue Aug 9 07:11:08 UTC 2016


Patch Set 9:

(2 comments)

https://gerrit.osmocom.org/#/c/416/8/src/egprs_rlc_compression.cpp
File src/egprs_rlc_compression.cpp:

Line 14: void *tall_tree_ctx;
> Every allocation by talloc is a talloc context, no need to create an artifi
This context is under root context tall_pcu_ctx (Similar to tall_ms_ctx defined in gprs_ms.cpp)


Line 22: 	new_node = talloc(tall_tree_ctx, Node);
> pass the parent or root as talloc context and use that and use that.. use t
tall_tree_ctx is the parent for all new nodes.
I will use talloc_zero instead of talloc.


-- 
To view, visit https://gerrit.osmocom.org/416
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce
Gerrit-PatchSet: 9
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: pravin <pravin.manoharan at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list