osmo-pcu[master]: Add decoding of compressed bitmap in EPDAN

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pravin gerrit-no-reply at lists.osmocom.org
Tue Aug 9 05:56:47 UTC 2016


Patch Set 9:

(1 comment)

https://gerrit.osmocom.org/#/c/416/8/src/pcu_main.cpp
File src/pcu_main.cpp:

Line 172: 	tall_tree_ctx = talloc_named_const(tall_pcu_ctx, 0, "decode-tree context");
> nack.
We have taken the reference of MS object creation for hierarchical talloc usage. In gprs_ms.cpp, talloc_named_const is used to create tall_ms_ctx under tall_pcu_ctx and hence, tall_pcu_ctx will be the parent of tall_ms_ctx.
Similarly,tall_tree_ctx is created under tall_pcu_ctx. All the tree nodes are created under tall_tree_ctx. This is verified using talloc report.Please let me know if you have further comments.


-- 
To view, visit https://gerrit.osmocom.org/416
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce
Gerrit-PatchSet: 9
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: pravin <pravin.manoharan at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list