[PATCH] COMP128v23 improvements

Harald Welte laforge at gnumonks.org
Sat Dec 7 17:13:17 UTC 2013

Hi Max,

On Mon, Dec 02, 2013 at 11:36:08AM +0100, ☎ wrote:
> Hmm... it applies with
> patch --dry-run -p1 < 0001-Refactor-COMP128v23-implementation-and-add-test-suit-v5.patch
> just fine. What exactly is wrong and how do I fix it?
> I've made a patch using "git format-patch" - is there some better way?

my apologies. It was a broken setup on my side.  'git format-patch' (on
top of master branch) is the best way, of course.

> With all due respect - those are shorter than the line they are
> replacing which is already committed to the git.

Yes.  The original code is not perfect, and sometimes we bend the rules
accidentially or intentionally.  Also, the code normally doesn't go
through the kernels checkpatch.pl - we simply write it with the coding
style in mind.  Also, as holger has indicated, those are warnings and
not errors.

Thanks for taking the extra time to clean it up, even if you are
personally not convinced it would be neccessary.  Please continue to do
so with any other patches that you may have pending.  We do want to get
things merged and avoid fragmentation.

- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

More information about the baseband-devel mailing list