[nuttx-bb][PATCH 1/3] Fix console by sending chunk blocks lesser than 32 bytes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/baseband-devel@lists.osmocom.org/.

Sylvain Munaut 246tnt at gmail.com
Sat Feb 25 21:59:06 UTC 2012


> > +     if (buflen >= 31)
> > +             cnt = 31;
> >       else
> > -             return buflen;
> > +             cnt = buflen;
> > +
>
> I could simplify this if/else by:
>
>       cnt = buflen & 0x1F;
>
> but I think it will not be readable for other people.
>
> > +

It would also be wrong ...

32 & 0x1F = 0 ...

Cheers,

    Sylvain
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20120225/5f93dd7e/attachment.htm>


More information about the baseband-devel mailing list