This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/baseband-devel@lists.osmocom.org/.
Tim Ehlers osmocom at ehlers.infoOn Sun, 12 Feb 2012, Sylvain Munaut wrote: Hi Sylvain, > Actually, I have a couple more points: > > * why declare it in networks.h ? there is a subscriber.h which seem > more appropriate > * I would actually call it gsm_subscr_get_key_seq , it seems to be > the convention of that file for exported functions > * The convention for vty commands uses '-' instead of '_', so call it > "force-key" rather than "force_key" > * Actually maybe call if "force-rekey" everywhere (vty, variable name, > ...) since this seems more decriptive (you don't force the key, you > force the negotiation of a new key) ok, I hope its correct and conventional now. Cheers Tim -------------- next part -------------- A non-text attachment was scrubbed... Name: force_rekey.patch Type: text/x-patch Size: 5490 bytes Desc: URL: <http://lists.osmocom.org/pipermail/baseband-devel/attachments/20120212/f628770a/attachment.bin>