simtrace2-remsim set-atr flag - code offer
Hey there SIMTrace-Community! In the context of my current project I needed to set the ATR, which the SIMTrace2(cardem firmware) sends to the SIM-Terminal. To this end I added a cli flag (--set-atr) to the simtrace2-remsim host software which takes an ATR and signals to the cardem firmware to use this ATR. The later functionality is already present and therefore I only implemented the cli flag and the string to hex transformation (using osmo_hexparse). Would you be interested in this code? If you are, how can I contribute it? It currently lives inside a git branch on my machine. Thank you very much for making the code freely available! Leonard Hübner
Hi Leonhard, thanks for reaching out.
Would you be interested in this code? If you are, how can I contribute it? It currently lives inside a git branch on my machine.
We're happy to review + merge your patch, please submit it using gerrit, see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit If you have troubles setting that up, and it's just a small patch, and you don't expect to contribute more in the future, you can also simply use git send-email to send the patch [series] to this mailing list. Regards, Harald -- - Harald Welte <laforge@osmocom.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
Hey Harald! Unfortunately, I was unable to properly setup Gerrit on my system, as my firewall prevents me from accessing the required ssh port. As I won't be able to contribute much more, I decided to submit the 'feature' via git send-email. I hope this is fine. Best regards, Leo ________________________________ From: Harald Welte <laforge@osmocom.org> Sent: Friday, October 23, 2020 10:37 AM To: Leonard Hübner <leonard.huebner@commsolid.com> Cc: simtrace@lists.osmocom.org <simtrace@lists.osmocom.org> Subject: Re: simtrace2-remsim set-atr flag - code offer Hi Leonhard, thanks for reaching out.
Would you be interested in this code? If you are, how can I contribute it? It currently lives inside a git branch on my machine.
We're happy to review + merge your patch, please submit it using gerrit, see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit If you have troubles setting that up, and it's just a small patch, and you don't expect to contribute more in the future, you can also simply use git send-email to send the patch [series] to this mailing list. Regards, Harald -- - Harald Welte <laforge@osmocom.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
participants (2)
-
Harald Welte -
Leonard Hübner