wireshark.git branch laforge/om2000-201610 created. 348788e892bf9fe73e9551a233848bfd73f2af2c
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "wireshark with Osmocom specific dissectors". The branch, laforge/om2000-201610 has been created at 348788e892bf9fe73e9551a233848bfd73f2af2c (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/wireshark/commit/?id=348788e892bf9fe73e9551a233848bf... commit 348788e892bf9fe73e9551a233848bfd73f2af2c Author: Harald Welte <laforge@gnumonks.org> Date: Sat Oct 15 20:04:41 2016 +0200 gsm_abis_om2000: Introduce expoert info for unusual situations In OM2000, it is not usual to receive NACK, REJECT or "performed not according to request" type messages. Let's highlight them using expert info as a convenience to the user. http://cgit.osmocom.org/wireshark/commit/?id=4e08f3171acc399495fdcd6bcd44b3c... commit 4e08f3171acc399495fdcd6bcd44b3c30492e4b3 Author: Harald Welte <laforge@gnumonks.org> Date: Sat Oct 15 19:16:39 2016 +0200 gsm_abis_om2000: Decode the IWD Type/Gen/Rev in Negotiation Request The Negotiation Request and Negotiation Requeset ACK contain IWD (Inter Working Document) revision numbers for the different A-bis protocols OML, RSL, GSL (GPRS) and TRA (TRAU). Decode them in a way suitable for human consumption. Change-Id: I5b11e64ca252b7349900ba5b700c2faefd568441 http://cgit.osmocom.org/wireshark/commit/?id=e84c8063d87c601167495a20e3922da... commit e84c8063d87c601167495a20e3922da8e2a88fcc Author: Harald Welte <laforge@gnumonks.org> Date: Mon May 9 18:19:07 2016 +0200 WIP: GSMTAP LTE support http://cgit.osmocom.org/wireshark/commit/?id=d8665395c77a4c6180fc33c15d8e4ea... commit d8665395c77a4c6180fc33c15d8e4ea6e88dfe4c Author: Harald Welte <laforge@gnumonks.org> Date: Sun Jul 17 16:22:19 2016 +0200 l2tp: Introduce preference for default pseudowire In some cases, the establishment of the L2TP session is not captured in the pcap file, and thus wireshark cannot determine the l2tp pseudowire to be used for decode. So rather than using a ocmpile-time hard-coded default of cisco hdlc, let's introduce a prference where the user can select the default pseudowire in such cases. Change-Id: I44a6373d4812c9ab5a919514273a41a2ab57142c http://cgit.osmocom.org/wireshark/commit/?id=c94f125a21099d2b14aa40150ea3d82... commit c94f125a21099d2b14aa40150ea3d8285f6df553 Author: Harald Welte <laforge@gnumonks.org> Date: Sat Jul 16 15:39:17 2016 +0200 L2TP: Add preference to select Ericsson HDLC flavor At some point over the wireshark last years, the connection between the L2TP dissector and the Ericsson HDLC dissector (packet-ehdlc.c) got broken. I cannot poinpoint the exact change when it broke. However, traces with Ericsson L2TP that used to display correctly no longer do so. The problem with Ericsson L2TP is that they simply re-use the HDLC pseudowire (0x0006), but then have frames completely different than what's specified in the RFCs for that. To address this, let's add a protocol preference to allow the user to choose. Change-Id: Idce022ef0f233c01ecffc67dca7f428bde31ef6b http://cgit.osmocom.org/wireshark/commit/?id=a19c12b4a973d8f514db3824ed16f66... commit a19c12b4a973d8f514db3824ed16f664fb9f1151 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Oct 14 14:36:27 2016 +0200 udpdump: fix issues from coverity. Change-Id: I1d82d8166abe8eda6588ae2970ae9f2d096adf9d Reviewed-on: https://code.wireshark.org/review/18198 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=fb9ce2796cff7c896b0fec5042711b6... commit fb9ce2796cff7c896b0fec5042711b695f88be08 Author: Guy Harris <guy@alum.mit.edu> Date: Sat Oct 15 01:07:44 2016 -0700 Add the directory containing the executables to a file in /etc/paths.d. Do for executables what we do for man pages. Change-Id: I066f0199fd6064cae21e6ad079a1f344e1002c66 Reviewed-on: https://code.wireshark.org/review/18205 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=38682523f9ce3ed378c782a848ba1ba... commit 38682523f9ce3ed378c782a848ba1ba5a6fe430f Author: Jeff Morriss <jeff.morriss.ws@gmail.com> Date: Thu Oct 6 10:26:27 2016 -0400 Lua: allow creating TVBs after calling other (Lua) dissectors. Don't set `lua_tvb` (or any of the other global variables) to NULL after a Lua dissector is called: it's possible that the caller is also a Lua dissector which may want/need that (global) variable to still be set (to the value it had before the sub-dissector was called). This fixes the problem reported in: https://ask.wireshark.org/questions/56110/lua-error-tvbs-can-only-be-created... Making these variables not be a globals (as suggested at the top of init_wslua.c) might be a better solution--for another day. Change-Id: I14fb8ec35b62abeda3f3471a323b88c80537a06e Reviewed-on: https://code.wireshark.org/review/18095 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=3a08906ca7c1e66037977f0e701af6a... commit 3a08906ca7c1e66037977f0e701af6a7c89bd4f9 Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Fri Oct 14 08:07:18 2016 +0200 Retrieve CLNP option values from the right place Use proper offsets when getting and presenting option values for error reports. Limit the use of the error position highlighting feature to 'field' only. Bug: 12993 Change-Id: Ie9d6644203cf849dbb8efe15e87249a3aace3b5c Reviewed-on: https://code.wireshark.org/review/18195 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=db690aa4444322d85f40ecef7892ec1... commit db690aa4444322d85f40ecef7892ec12b3e423b9 Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Thu Oct 13 21:16:55 2016 +0200 Append Integer32 value to varbind also. Integer32 is handled slightly different from other values, but that doesn't mean its pi_value shouldn't be saved to add to the varbind later on. Bug: 13013 Change-Id: I6789a75ffd3bb95b7dd68f9cb356dbd85fc669d4 Reviewed-on: https://code.wireshark.org/review/18189 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0aae3b1eaacc1cdb74ef81875776b7b... commit 0aae3b1eaacc1cdb74ef81875776b7b496a46939 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Oct 14 08:20:02 2016 +0200 MAC LTE: add dissection of NB-IoT RAR Change-Id: I81b6ad65732dd11e5af040ec79b0175a7f06b070 Reviewed-on: https://code.wireshark.org/review/18196 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=66f1baa64957f42edb8927fcdb2f641... commit 66f1baa64957f42edb8927fcdb2f64131fd415ad Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Oct 13 18:24:37 2016 +0200 CQL: Enhance version dissection Display on hex (like spec) Add (sub) field for protocol version and direction Ping-Bug 12818 Change-Id: I6947f82915f54095f86cd0e2125982af42e9bbf9 Reviewed-on: https://code.wireshark.org/review/18188 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d9c4f607ba444536b34803012374d03... commit d9c4f607ba444536b34803012374d03c098f7ab7 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Sep 6 07:49:09 2016 +0200 CQL: Add support of version 4 Add new flag and new option Bug: 12818 Change-Id: I36a49cef407a5049f45ff3746d809a46c2520164 Reviewed-on: https://code.wireshark.org/review/17628 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1a42bc06d4d3baec0039eb4ac2d0522... commit 1a42bc06d4d3baec0039eb4ac2d0522bc2b86ea3 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Oct 13 07:51:45 2016 +0200 CQL: Enhance flags dissection Always display unused/reserved field 5th argument of proto_tree_add_bitmask is ett_ value add a display field for query flags Ping-Bug: 12818 Change-Id: I9f906f75c5fe8328bba41e560878dafdb6b6608d Reviewed-on: https://code.wireshark.org/review/18187 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=37252634c4f102054057c2bdbb32949... commit 37252634c4f102054057c2bdbb32949642506bbc Author: Gerald Combs <gerald@wireshark.org> Date: Thu Oct 13 15:45:45 2016 -0700 UI: Free up the -m flag. The -m (monospace font) flag was deprecated in 2.2. Go ahead and remove it in 2.3 / 2.4. Change-Id: I6b4911174675cedec979621c2776353314e73eb1 Reviewed-on: https://code.wireshark.org/review/18193 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9a6539990d16c02954a6eebfaf500d4... commit 9a6539990d16c02954a6eebfaf500d401d25b29a Author: Uli Heilmeier <uh@heilmeier.eu> Date: Wed Oct 12 21:55:54 2016 +0200 CMakeLists: Add man files Current Wireshark.app bundle on OS X doesn't include man pages. This is the second try after commit 7da23ca1a5bba4af5e1104f4d3d3d44e918552b0 has been reverted. Now cmake gets the information that the man files are generated. Bug: 12746 Change-Id: I34dfec65bd57587ee048d7e1e2557fc9ab2b32eb Reviewed-on: https://code.wireshark.org/review/18170 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=25e7b63ea557baaef05b4672fb33bae... commit 25e7b63ea557baaef05b4672fb33bae04653e4d7 Author: Jeff Morriss <jeff.morriss.ws@gmail.com> Date: Thu Oct 13 16:12:11 2016 -0400 Fix a few typos in the Diameter XML to make it (mostly) valid XML again. Fix up some white space while at it. Change-Id: I41efa63ad33288046b56c2eee6a20e066ac6b334 Reviewed-on: https://code.wireshark.org/review/18190 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b1cc056b12702435f6ebdc6ba0a8e17... commit b1cc056b12702435f6ebdc6ba0a8e17a41e159a0 Author: Balint Reczey <balint@balintreczey.hu> Date: Fri Aug 26 15:18:29 2016 +0200 Remove nghttp2 code and use system' nghttp2 Update debian, macos (setup / homebrew) download script Update testsuite (don't try HPACK when build without nghttp2) Change-Id: I365e5e17bc4fab4acd81b4c39ea7189a5d1ee112 Reviewed-on: https://code.wireshark.org/review/17347 Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ad0a016bd2f7f82e4db8bbac13f959a... commit ad0a016bd2f7f82e4db8bbac13f959ad3bc7ecf4 Author: Gerald Combs <gerald@wireshark.org> Date: Wed Oct 12 10:48:59 2016 -0700 Qt+macOS: Fix the default font name. "SF Mono" is the name of the new monospace font in Sierra. Note that it appears to have limited availability and that we're outside those limits. Fix up a comment. Change-Id: I97f0077098ea78d4550b58fb92645f4d62342b2e Reviewed-on: https://code.wireshark.org/review/18168 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=fcbb77191bbae90b1b193e9b3d7dc57... commit fcbb77191bbae90b1b193e9b3d7dc57610e444ca Author: Dario Lombardo <lomato@gmail.com> Date: Tue Oct 11 09:29:26 2016 +0200 iso8583: use unsigned and fix bug in conversion routine. Change-Id: I0ba30bda3abec004f51f9402d65c38b3b1081113 Reviewed-on: https://code.wireshark.org/review/18144 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Paulo Roberto Brandão <betobrandao@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2534b8ece13136ddd3a6e12c7bb6c2a... commit 2534b8ece13136ddd3a6e12c7bb6c2acce0f77dc Author: Vladlen Popov <vladlen.popov@yahoo.com> Date: Thu Oct 13 13:02:26 2016 +0300 ZigBee Green Power: dissect endpoint and security_counter for gpdf with app_id = 010 and 001 Change-Id: I94ec94dbd6c81cf6a209e26c132557279d3c6ee2 Reviewed-on: https://code.wireshark.org/review/18182 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a40f3eebce646aed1cdb303c6d0e332... commit a40f3eebce646aed1cdb303c6d0e3321bb95a5bc Author: Dario Lombardo <lomato@gmail.com> Date: Thu Oct 13 14:26:59 2016 +0200 Fix compilation error without PCAP. Change-Id: I414f11387ec5a48dfe7c1debb3bcef1dbc846b28 Reviewed-on: https://code.wireshark.org/review/18184 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7ce85a92f95df8db0da85ce61c19de1... commit 7ce85a92f95df8db0da85ce61c19de132c6914ea Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Oct 13 14:10:26 2016 +0200 MAC LTE: fix dissection of Extended PHR Control Element It has the same value as the DL SC-MCCH/SC-MTCH CE, so take into account direction Change-Id: I75848f92342cfc67f2e6aee1f8bc42616e662cdc Reviewed-on: https://code.wireshark.org/review/18183 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4f6ed3852dcba51ef19604a090ecfc9... commit 4f6ed3852dcba51ef19604a090ecfc91bc997940 Author: Roland Knall <roland.knall@br-automation.com> Date: Thu Oct 13 09:11:50 2016 +0200 Interface List: Fix display of zero entries If WS is started with zero entries, no text is being displayed, and pushing a button does not yield the display of the list. This fixes it. Change-Id: I70b0637e5f95e805b54780afb7eb2e43b3e5f21c Reviewed-on: https://code.wireshark.org/review/18180 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8b0e66f22c059533643195ba7571caf... commit 8b0e66f22c059533643195ba7571cafe9f006f58 Author: Jonathan Muñoz <jonathan.munoz@inria.fr> Date: Tue Oct 11 10:19:11 2016 +0200 Add support for 6P-sixtop protocol in the IEEE802.15.4 dissector. This patch adds one more Payload Information Element called 6P or sixtop defined by the IETF 6TiSCH Working Group. Here it is shown the following 6P-sixtop information: -The 6P-sixtop version. -The 6P-sixtop code. -The 6P-sixtop Scheduling Function ID. Then, depending of the 6P-sixtop code, a specific information is shown. The supported codes -commands- for this patch are: -Add. -Delete. -Count. -List. -Clear. -Return Code Success. For more information about the 6P-sixtop protocol, go to: https://tools.ietf.org/html/draft-ietf-6tisch-6top-protocol-02 Bug 13005 Change-Id: I46b015dd8acd1515bff4090c5b39ad3897606f67 Reviewed-on: https://code.wireshark.org/review/18151 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2e3e285f03f32ebdb6a0079aeaebe6b... commit 2e3e285f03f32ebdb6a0079aeaebe6be7e0961b3 Author: Robert Grange <robionekenobi@bluewin.ch> Date: Sat Oct 8 12:49:49 2016 +0200 packet-mq: Handle MQV9 Handle Put Message Option V3 Add various new defines Fix a typo Bug: 13006 Change-Id: I022de9f131558bb8a0144d840a6484944f75cffe Reviewed-on: https://code.wireshark.org/review/18121 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5da38b6c110f4bae1c3a8d4eacaa9d5... commit 5da38b6c110f4bae1c3a8d4eacaa9d5d3a3006f1 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Oct 12 22:37:30 2016 +0200 QUIC: Add STTL (Server Config TTL) tag and add FHOL forget value_string Change-Id: I0473ca17fba3c277124a46309c4b7d158d1b9f72 Reviewed-on: https://code.wireshark.org/review/18173 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ddb6513db32ea322f68a72a770417b6... commit ddb6513db32ea322f68a72a770417b62af669e8e Author: Guy Harris <guy@alum.mit.edu> Date: Thu Oct 13 00:16:57 2016 -0700 Fix call to ws_strtoi32(). Change-Id: I536ee3fbda563f4b544eea334c5d7e9a642c69e2 Reviewed-on: https://code.wireshark.org/review/18181 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=198df02f8a8e7f17a46dab5ac0638dc... commit 198df02f8a8e7f17a46dab5ac0638dcf44fc6512 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Oct 11 12:51:24 2016 +0200 idl2wrs: use ws_strtou function. Missed from previous patch gb15079b. Change-Id: I3fce792608e989c8ac100f1f57cb11fdb7b35142 Reviewed-on: https://code.wireshark.org/review/18147 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2eb7b05b8c9c6408268f0d1e81f0a18... commit 2eb7b05b8c9c6408268f0d1e81f0a18a02610f1c Author: Michael Mann <mmann78@netscape.net> Date: Wed Oct 5 16:33:54 2016 -0400 Convert most UDP dissectors to use "auto" preferences. Similar to the "tcp.port" changes in I99604f95d426ad345f4b494598d94178b886eb67, convert dissectors that use "udp.port". More cleanup done on dissectors that use both TCP and UDP dissector tables, so that less preference callbacks exist. Change-Id: If07be9b9e850c244336a7069599cd554ce312dd3 Reviewed-on: https://code.wireshark.org/review/18120 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4d8581d7e15fe4a80a53496b83a8532... commit 4d8581d7e15fe4a80a53496b83a853271fc674b6 Author: D. Ulis <daulis0@gmail.com> Date: Wed Oct 12 09:36:24 2016 -0400 CIP: Improve string handling 1. Add support for STRINGI 2. Add File Name attribute that is a STRINGI 3. CCO Get/Set Attr All: Connection Name is STRING2 not ASCII 4. TCP/IP Host Name attribute is not just a STRING. It also needs a pad byte. 5. Minor: Fix byte highlighting for CCO I/O Mapping tree 6. Minor: All back byte highlighting for Get Attr All Rsp individual attributes Change-Id: Ib10d6f2e86e39e8cd6335dc6b6dbebbd1c4d8e64 Reviewed-on: https://code.wireshark.org/review/18166 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=464e6cdc997ebb42e2a2a5476cff420... commit 464e6cdc997ebb42e2a2a5476cff42051c229bcf Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Oct 10 21:18:57 2016 +0200 .mailmap: fix typo Change-Id: Iff3d1c4d74a8cf03111cb776cfce09120afb361d Reviewed-on: https://code.wireshark.org/review/18139 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b36382a9ce1bfec94527b41e5bf50e2... commit b36382a9ce1bfec94527b41e5bf50e2467787fe3 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Oct 12 22:30:23 2016 +0200 TLS(1.3): with draft-16, Server Hello return draft release (0x7fxx) set server_version to TLS 1.3 Change-Id: Id4d3d5d21ae996f447d826e98c0cf60880e7c0ce Reviewed-on: https://code.wireshark.org/review/18171 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=f404ac064f888d573326ead0384251f... commit f404ac064f888d573326ead0384251f8072386a8 Author: Gerald Combs <gerald@wireshark.org> Date: Wed Oct 12 16:00:44 2016 -0700 WSDG: Add Qt installation information. Change-Id: I7c468c9d22f1923acb488bd06176314c4f023f09 Reviewed-on: https://code.wireshark.org/review/18179 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=e4fd25060e2e5ba22e91bba6a8318f3... commit e4fd25060e2e5ba22e91bba6a8318f3e720e8384 Author: Olga Kornievskaia <olga.kornievskaia@gmail.com> Date: Wed Oct 12 15:06:54 2016 -0400 nfs: Fixing COPY decoding to match the spec Current decoding of the COPY operation gets a netloc4 instead of a stateid from the write_response4 structure. Change-Id: Icde8adde8613d50e7a03ee779aad4c62f6f195f4 Reviewed-on: https://code.wireshark.org/review/18169 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5ace3b9405e4845ad7df1a3b2966af7... commit 5ace3b9405e4845ad7df1a3b2966af7bca6c2194 Author: Binh Trinh <beango@gmail.com> Date: Tue Sep 13 00:46:06 2016 -0400 MTP3: Added SS7 Point Code Name Resolution bug: 7592 Change-Id: I1af2c5d6664e172c358cd19bc20e9352c2582eae Reviewed-on: https://code.wireshark.org/review/17677 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=04143d1100342353c95c87dcaaa8d82... commit 04143d1100342353c95c87dcaaa8d82258c25ec3 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Oct 12 22:49:39 2016 +0200 MQ: fix typo found by lintian Change-Id: I8fefb89116685b39567fe8041ca781612f67dbce Reviewed-on: https://code.wireshark.org/review/18177 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=750b10a1c5eb3368a4f6c45f3819010... commit 750b10a1c5eb3368a4f6c45f3819010205e98a51 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Oct 12 22:48:29 2016 +0200 OPA MAD: fix typo found by lintian Change-Id: I93ee3f1fed97b06ff582909f4c59da60c783e909 Reviewed-on: https://code.wireshark.org/review/18176 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7eaa5b7484aa4c86d750b2d05b25e1b... commit 7eaa5b7484aa4c86d750b2d05b25e1b7cf0a4eb6 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Oct 12 22:47:23 2016 +0200 PPP: fix typo found by lintian Change-Id: I2634a3b07b36133f14eeb91911338c51a34e35b4 Reviewed-on: https://code.wireshark.org/review/18175 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0674a92cffa2a68d866aa453673a9fb... commit 0674a92cffa2a68d866aa453673a9fbbd723fed6 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Oct 12 17:40:12 2016 +0200 RakNet: fix heuristic dissector RAKNET_OFFLINE_MESSAGE_DATA_ID starts with 0x0, which means NULL character. this give a string of length 0 and RakNet heuristic was wrongly catching all UDP packets. Let's do a memcmp instead of a strncmp. Change-Id: I38e98838b114037bf37a218003bade88261a2dd8 Reviewed-on: https://code.wireshark.org/review/18167 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6ae3ba02f7156bf5e7eb5e189f287fc... commit 6ae3ba02f7156bf5e7eb5e189f287fcb5027f0ff Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Oct 12 14:22:55 2016 +0200 M3AP: register dissector by name Change-Id: Idbc06c512e42674e28e84237a2fe59d0e5635d40 Reviewed-on: https://code.wireshark.org/review/18165 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d267e2e24b596ba5ff366ef737d88b8... commit d267e2e24b596ba5ff366ef737d88b86b97b72d4 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Oct 12 14:22:31 2016 +0200 M2AP: register dissector by name Change-Id: I2d734d892fa67cb5843675cb423641c0eb433cea Reviewed-on: https://code.wireshark.org/review/18164 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a62637ad8cd7ab090f89f4c6bc27518... commit a62637ad8cd7ab090f89f4c6bc27518edc2fd18f Author: Dario Lombardo <lomato@gmail.com> Date: Tue Oct 4 11:56:17 2016 +0200 quic: use ws_strtou function. Change-Id: Ibe1c9e48d2843fd8442d43f90a8e529a4c591fc8 Reviewed-on: https://code.wireshark.org/review/18061 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=84cfd3bad6625974f70934e40af4120... commit 84cfd3bad6625974f70934e40af4120c916006a9 Author: Francesco Fondelli <francesco.fondelli@gmail.com> Date: Wed Oct 12 11:19:55 2016 +0200 HL7: fix missing struct initialization spotted by Clang Static Analyzer Change-Id: Icb3e924f48b8fa00d7a39fcbdc4400ad2c4c2b89 Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/18163 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9934fff4c095b0454323f471c82219f... commit 9934fff4c095b0454323f471c82219fcbbc0ea6f Author: Marius Paliga <mareko.paliga@gmail.com> Date: Tue Oct 11 16:36:56 2016 +0200 Add support for Enhanced-Diagnostics AVP Bug: 13004 Change-Id: I20a3faec635a8c86e2d45eb17ce24e2a9db81b5e Reviewed-on: https://code.wireshark.org/review/18154 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d78c5e0ac24027ba8da9d481d39af71... commit d78c5e0ac24027ba8da9d481d39af71d52a85296 Author: Jan Spevak <jan.spevak@nokia.com> Date: Wed Oct 12 10:33:00 2016 +0200 Diameter: Upadte AVPs 1003, 1094 and 1099 Bug: 13010 Change-Id: I8a3f8ea551ec959e1e5344f825c8bba7bd4ff866 Reviewed-on: https://code.wireshark.org/review/18160 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c06189f7c6e6e428d914bfabdd96e5d... commit c06189f7c6e6e428d914bfabdd96e5de42a2400d Author: PHO <pho@cielonegro.org> Date: Mon Oct 3 09:22:35 2016 +0900 raknet, mcpe: Improve dissectors packet-raknet.c now correctly dissects the following offline messages: * ID_UNCONNECTED_PING * ID_UNCONNECTED_PING_OPEN_CONNECTIONS * ID_OPEN_CONNECTION_REQUEST_1 * ID_OPEN_CONNECTION_REPLY_1 * ID_OPEN_CONNECTION_REQUEST_2 * ID_OPEN_CONNECTION_REPLY_2 * ID_OUT_OF_BAND_INTERNAL * ID_CONNECTION_ATTEMPT_FAILED * ID_ALREADY_CONNECTED * ID_NO_FREE_INCOMING_CONNECTIONS * ID_CONNECTION_BANNED * ID_INCOMPATIBLE_PROTOCOL_VERSION * ID_IP_RECENTLY_CONNECTED * ID_UNCONNECTED_PONG packet-raknet.c now correctly dissects the following system messages: * ID_CONNECTED_PING * ID_CONNECTED_PONG * ID_CONNECTION_REQUEST * ID_CONNECTION_REQUEST_ACCEPTED * ID_NEW_INCOMING_CONNECTION packet-raknet.h exports the following functions: * raknet_add_udp_dissector() * raknet_delete_udp_dissector() * raknet_conversation_set_dissector() packet-raknet.c now dissects message flags, reliability, reliable message number and so on. It now reassembles fragmented packets, supports heuristics, supports dissecting combined packets, and gives up dissecting messages when they are encrypted. packet-raknet.c now calls subdissectors with a tvbuff buffer only having a message ID and payload. It first tries to locate a subdissector based on the port, and then tries heuristic dissectors if any. packet-mcpe.c is updated so that it uses the new raknet interface, and it now correctly dissects the following game packets: * 0x01 Login * 0x03 Server to Client Handshake * 0x06 Batch packet-mcpe.c now supports heuristics, and gives up dissecting packets in a conversation once it sees a "Server to Client Handshake" packet because everything, including packet ID, are encrypted after that. Change-Id: I92c0b3ff0f18d22d4513bb014aeb4ea6475fb06c Reviewed-on: https://code.wireshark.org/review/18044 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1cd22559a8a907263f1d032e8066482... commit 1cd22559a8a907263f1d032e8066482b22f8fbe3 Author: Peter Wu <peter@lekensteyn.nl> Date: Tue Oct 4 01:47:26 2016 +0200 Qt: convert UatDialog to model/view pattern, improve UX Fixes: - Fix crash (heap-use-after-free) on removing a record while editing. - Mark a record as invalid if any of the fields fail the validation. (Fixes crash in at least the ISAKMP dissector.) - Prevent saving of invalid UAT entries (e.g. empty UATs). - Do not close the dialog on pressing Enter/Escape while editing, close the editor instead. - Fix HTML injection in the error messages. Improvements: - Tab-navigation now works between fields. - The field editor is now closed once the focus is lost. - Fields that fail validation are marked (currently with a pink color). - The error hint selection has become smarter (see comments in UatDialog::checkForErrorHint). - Properly recognizes PT_TXTMOD_HEXBYTES formats like "aa:bb" (previously it would not expect the ":" and report a bad length). A validator prevents invalid strings from being entered. - The OK button is disabled when new/edited records are bad. Notably, existing (possibly invalid) records are skipped. (Bug 7471). Live validation (while typing in the editor) was dropped during conversion, but it can be added later if desired. Drag and drop reordering still needs to be implemented. Bug: 11714 Bug: 7471 Change-Id: Ic0b6a177f90503fbd65b5001d8a87a10e38f4d64 Reviewed-on: https://code.wireshark.org/review/17994 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9434f25275b1ff838a9976903f180de... commit 9434f25275b1ff838a9976903f180de7da4b00e4 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Oct 7 12:35:41 2016 +0200 TLS(1.3): Add Supported Versions (43) Hello extension Ping-Bug: 12779 Change-Id: Ia8dcfcb300f4da3bf270d9512fbcc85a7b1a8671 Reviewed-on: https://code.wireshark.org/review/18108 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=aa78460ef9793ea56f79ef353e9f6af... commit aa78460ef9793ea56f79ef353e9f6af3805799f8 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Oct 11 21:58:29 2016 +0200 SMPP: use mktime_utc to convert struct tm to time_t Bug: 12632 Change-Id: Ie340facff86d988b7a85f6351d85343169042ce9 Reviewed-on: https://code.wireshark.org/review/18155 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=50ddeaadf9fa300858a0b02cf451ade... commit 50ddeaadf9fa300858a0b02cf451ade5ce443d98 Author: Birol Capa <birol.capa@siemens.com> Date: Tue Sep 27 17:36:28 2016 +0300 PROFINET: Don't display expert information when implicit AR is used. According to specification: Value(UUID): 00000000-0000-0000-0000-000000000000 Meaning: Reserved Use: The value NIL indicates the usage of the implicit AR. Change-Id: Iea807f14bf6da36700b778a1383ebd970aa105a5 Reviewed-on: https://code.wireshark.org/review/17951 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=31a35aa9e6d48ea1ee179b26c1b11d7... commit 31a35aa9e6d48ea1ee179b26c1b11d7e6e8079a1 Author: Michael Mann <mmann78@netscape.net> Date: Mon Oct 10 23:36:25 2016 -0400 Cleanup from adding Decode As TCP preferences. 1. Fix bug caught by scan build (module not read) 2. Remove range preference call that should have been part of original patch. Change-Id: I24b1fb253548bffddc4c8ebfc3ede666d8fd9dcd Reviewed-on: https://code.wireshark.org/review/18143 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a1ecd5661f4c28ca38bf83519e89bfb... commit a1ecd5661f4c28ca38bf83519e89bfbb2f502671 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Oct 11 23:32:38 2016 +0200 GSM A GM: add specific filters for IPv4 / IPv6 Protocol ID Bug: 13001 Change-Id: I6bdaa5cd034b9ccf608fe0f6913d099ee920f0db Reviewed-on: https://code.wireshark.org/review/18157 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=13139a9853df2af06186ecc18c0a408... commit 13139a9853df2af06186ecc18c0a40849282378b Author: Gerald Combs <gerald@wireshark.org> Date: Tue Oct 11 14:01:20 2016 -0700 dumpabi: Fix log paths. Make sure the paths we pass to "cat" and "abi-compliance-checker -log-path" match. Change-Id: Ie68b445b9d92d85c0ed1eb508a78c0bcc960d061 Reviewed-on: https://code.wireshark.org/review/18156 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f92daa140bad09c78b4acf1fc7f76d7... commit f92daa140bad09c78b4acf1fc7f76d7bab75d74e Author: Moeller, Thies <thies.moeller@baslerweb.com> Date: Sat Oct 8 22:38:36 2016 +0200 u3v / gvsp update the PFNC pixelformat definitions according to http://www.emva.org/wp-content/uploads/GenICamPixelFormatValues.pdf Change-Id: I744248d0ca73c2ad9a90f1e662ccd6b90bcade5c Reviewed-on: https://code.wireshark.org/review/18126 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7cef0cb93cc44ed02cd68caa79d3d97... commit 7cef0cb93cc44ed02cd68caa79d3d97173b0edfe Author: Michael Mann <mmann78@netscape.net> Date: Sun Oct 9 20:01:45 2016 -0400 Add Local Service Discovery (LSD) protocol Bug: 12985 Change-Id: Iceacd3d122337091380d56bd7fa9875bf7cb4d47 Reviewed-on: https://code.wireshark.org/review/18134 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=53c20dd179ca60a9cf7bdfffe0af8c1... commit 53c20dd179ca60a9cf7bdfffe0af8c1a9b5c1f8b Author: Jonathan Muñoz <jonathan.munoz@inria.fr> Date: Thu Sep 8 09:40:09 2016 +0200 ieee802.15.4: Increments the offset for not defined/unknown Payload IEs Change-Id: If8d5fe86c6c1bedd468de437e503039428c648b0 Reviewed-on: https://code.wireshark.org/review/18150 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=082424fb70256972b3b6722a81d1ca8... commit 082424fb70256972b3b6722a81d1ca808c3b8a7e Author: Moeller, Thies <thies.moeller@baslerweb.com> Date: Tue Oct 11 14:17:35 2016 +0200 u3v fix typo in descriptor Change-Id: Ib62546216faa8d231cc004ab214a7ca4931919f2 Reviewed-on: https://code.wireshark.org/review/18153 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2ad87fab3403786490dc71339af4195... commit 2ad87fab3403786490dc71339af4195cf5e1248c Author: Juanjo Martin <juanjo@rti.com> Date: Tue Oct 11 12:09:42 2016 +0200 RTPS: Fixed octet to next header dissection when submessage is unknown Change-Id: If18d4797a8ace9f93546cac0d2d6f09bf7086cc3 Reviewed-on: https://code.wireshark.org/review/18145 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=71232b69fda6372f1853cf7c7fadd98... commit 71232b69fda6372f1853cf7c7fadd989353adc69 Author: Michael Mann <mmann78@netscape.net> Date: Mon Oct 10 23:34:41 2016 -0400 fix: break loop on failed string->number conversion Bug: 12998 Change-Id: I3e9739dd9863e615c2ca0fc91f043c8562e4203e Reviewed-on: https://code.wireshark.org/review/18142 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=203f12dca0bde081abf45cdce108082... commit 203f12dca0bde081abf45cdce108082abbfc95db Author: Francesco Fondelli <francesco.fondelli@gmail.com> Date: Fri Sep 16 09:25:47 2016 +0200 HL7 protocol support Bug: 12906 Change-Id: I0dafdd74b21b27189d0a532c679e449c536f76f0 Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/17725 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=754d03cb822c8bb8a8813cab403ef3d... commit 754d03cb822c8bb8a8813cab403ef3d4c39a7561 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Mon Oct 10 20:10:23 2016 +0100 Disable wslua GRegex unit test It's broken for recent GLib versions and there is no time frame for a fix. Ping-Bug: 12997 Change-Id: Ia687af9b0df8fc37121179ba20761c878bf57057 Reviewed-on: https://code.wireshark.org/review/18140 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=7715d4819a953d9ff3d00603a69613b... commit 7715d4819a953d9ff3d00603a69613b3ca937383 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Mon Oct 10 22:25:28 2016 +0200 LPPa: upgrade dissector to v13.1.0 Change-Id: I8afddebf9b75b992a1cd9cb75f8cf7bb5223c6f9 Reviewed-on: https://code.wireshark.org/review/18141 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9c2052796788cad58d1d356c1f23063... commit 9c2052796788cad58d1d356c1f230630a92b12a4 Author: Gerald Combs <gerald@wireshark.org> Date: Mon Oct 10 10:36:24 2016 -0700 fuzz-test: Fix an exit status check. Make sure we check the exit status of the Valgrind process, not the most recently executed command. Change-Id: I3b6bd427383e4271b9ed38a10da6db506a511dc1 Reviewed-on: https://code.wireshark.org/review/18138 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=cebf038721bd795f754df955c8cbbbb... commit cebf038721bd795f754df955c8cbbbb509e75122 Author: D. Ulis <daulis0@gmail.com> Date: Fri Oct 7 16:21:13 2016 -0400 CIP: Attribute updates 1. Combine various Attribute ID filters into a single one "cip.attribute", so that it's easier to find a certain attribute in any part of the packet. This makes sense because Attributes refer to the same property, but various types of messages can have that field in different locations. This applies to Get/Set Attribute Single, Get/Set Attribute List, Get Attributes All. 2. Connection Manager: Dissect more attributes 3. Port: Display the Port Type name 4. Get/Set Attribute Single: Show unparsed data as raw bytes. Previously, if there were extra bytes they were not displayed. 5. Get/Set Attribute List: Show remaining data for unknown attributes under the main Attribute List tree, instead of under the unknown Attribute ID tree. 6. Display Attribute ID as DEC, since the specification tables are in decimal. 7. Update Class list 8. Minor: Remove some unused variables, typos Change-Id: I1a65da5f827484a3cd0e49ec944572ea5a166db1 Reviewed-on: https://code.wireshark.org/review/18118 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e105989180aec5c432d1ac9d1c174bd... commit e105989180aec5c432d1ac9d1c174bd9534d167b Author: Dario Lombardo <lomato@gmail.com> Date: Sat Oct 8 22:16:30 2016 +0200 fix: use ws_strtoi function. Change-Id: I537a7b349ea31e02cf538a782301c94053bb82dc Reviewed-on: https://code.wireshark.org/review/18125 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e8022a9c7b36b96578a30fc8132def6... commit e8022a9c7b36b96578a30fc8132def6de8928606 Author: Michael Mann <mmann78@netscape.net> Date: Sun Oct 9 22:54:03 2016 -0400 Profinet I/O: Sanity check number of I/O objects Can prevent really long loops from fuzz testing. Bug: 12851 Change-Id: I85e00af2c4753ce4c5bcb650a7df188d7f679c9a Reviewed-on: https://code.wireshark.org/review/18136 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=347395147fe91e99d57d14f8769d11e... commit 347395147fe91e99d57d14f8769d11eecae2f450 Author: Michael Mann <mmann78@netscape.net> Date: Sun Oct 9 21:00:59 2016 -0400 HARTIP: Fix infinite loop Bug: 12967 Change-Id: Ic7a52d4ee5dea896044c1c97b7b48f13e21f2762 Reviewed-on: https://code.wireshark.org/review/18135 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=050cc468569d3d5551f56cb2ecbc7f7... commit 050cc468569d3d5551f56cb2ecbc7f7c35da21cf Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Oct 9 22:22:59 2016 +0200 M3AP: upgrade dissector to v13.2.0 Change-Id: Iaedd4d3205e44a391a12be71eea0ccdc237fe790 Reviewed-on: https://code.wireshark.org/review/18133 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=83df30ee53e9a7ec77e07e4566fd5ec... commit 83df30ee53e9a7ec77e07e4566fd5ec0f67c0cf4 Author: Gerald Combs <gerald@wireshark.org> Date: Sun Oct 9 08:12:24 2016 -0700 [Automatic update for 2016-10-09] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I84adcfee2652783d1b3b7d7e3ff9b209f8b23d96 Reviewed-on: https://code.wireshark.org/review/18130 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=a10b505b84c384fbcf70d4f0310790a... commit a10b505b84c384fbcf70d4f0310790ae8cd72466 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Oct 7 15:38:07 2016 +0200 xcsl: use ws_strou function. Change-Id: I1c054253b77b266a162d09e8da107e5ebb9eceb8 Reviewed-on: https://code.wireshark.org/review/18111 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9b2dc3e769402163e74cd0d6cf0fe1e... commit 9b2dc3e769402163e74cd0d6cf0fe1ee8f4b9419 Author: Dario Lombardo <lomato@gmail.com> Date: Sat Oct 8 19:38:29 2016 +0200 E212: use ws_strtou function. Change-Id: Ifaeaf7ceb7addba95237852529ae1aa3e8a8b46b Reviewed-on: https://code.wireshark.org/review/18124 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6c26ed90ddb3c823c8bf3bd80d0461d... commit 6c26ed90ddb3c823c8bf3bd80d0461d57da7aa5c Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Oct 7 14:58:43 2016 +0200 TLS(1.3): Add new cipher from TLS 1.3 Change-Id: I8f39ea55763e925e15896efc9c519297c1288ccf Reviewed-on: https://code.wireshark.org/review/18110 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=40e43f7a136f28215b77e189152401b... commit 40e43f7a136f28215b77e189152401b0ce58edab Author: Guy Harris <guy@alum.mit.edu> Date: Sun Oct 9 00:09:42 2016 -0700 Note the registry for the bgp_l2vpn_encaps values. Change-Id: Id8ccf81c08d84124e1d7361ce6e87080fa6b440d Reviewed-on: https://code.wireshark.org/review/18128 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=78a56f796c0120e2a974ba89dc68551... commit 78a56f796c0120e2a974ba89dc685515824f3f70 Author: Guy Harris <guy@alum.mit.edu> Date: Sat Oct 8 19:21:20 2016 -0700 Note the registry for fec_vc_types_vals values and update it. Change-Id: I0514417895ccc86f51bf239d56005245fd875809 Reviewed-on: https://code.wireshark.org/review/18127 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5fba7f368de778208b1e4f9978fcc17... commit 5fba7f368de778208b1e4f9978fcc174923c6de4 Author: Uli Heilmeier <openid@heilmeier.eu> Date: Sat Oct 8 12:10:38 2016 +0000 Revert "CMakeLists: Add man files" This reverts commit 55148a2ea470d19290d236428f3c8e725775c96a. Change-Id: If93b97933cae4d8ffd1e4cc9a635def031ab0cc6 Reviewed-on: https://code.wireshark.org/review/18123 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=61956b8bf39075c4e8e7365cdf4e410... commit 61956b8bf39075c4e8e7365cdf4e410c76e3c276 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Oct 7 15:05:15 2016 +0200 column-utils: add space to improve readability. In tshark the UTF8 arrow overlaps the ports. When pcap file has more than 999 packets the output is no more aligned. Bug: 12502 Change-Id: I07f90bbc0d2f065458bc07b7fde8f6a651951b60 Reviewed-on: https://code.wireshark.org/review/18109 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Balint Reczey <balint@balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=b682bbd6ee5b93b45727c85293edce5... commit b682bbd6ee5b93b45727c85293edce5ced9b337c Author: Francesco Fondelli <francesco.fondelli@gmail.com> Date: Fri Sep 16 15:13:44 2016 +0200 add tvb_find_guint16() utility Change-Id: I75c0165948325c2e50918706d8a821411761727b Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/17734 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=268841f3e00b7cf0f16c81dd2b3b952... commit 268841f3e00b7cf0f16c81dd2b3b952172130b8b Author: Michael Mann <mmann78@netscape.net> Date: Fri Oct 7 16:25:01 2016 -0400 Combine Decode As and port preferences for tcp.port dissector table. This patch introduces new APIs to allow dissectors to have a preference for a (TCP) port, but the underlying data is actually part of Decode As functionality. For now the APIs are intentionally separate from the regular APIs that register a dissector within a dissector table. It may be possible to eventually combine the two so that all dissectors that register with a dissector table have an opportunity to "automatically" have a preference to adjust the "table value" through the preferences dialog. The tcp.port dissector table was used as the guinea pig. This will eventually be expanded to other dissector tables as well (most notably UDP ports). Some dissectors that "shared" a TCP/UDP port preference were also converted. It also removed the need for some preference callback functions (mostly when the callback function was the proto_reg_handoff function) so there is cleanup around that. Dissectors that has a port preference whose default was 0 were switched to using the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference Also added comments for TCP ports used that aren't IANA registered. Change-Id: I99604f95d426ad345f4b494598d94178b886eb67 Reviewed-on: https://code.wireshark.org/review/17724 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=11d3224142c0531879fb8e415daf963... commit 11d3224142c0531879fb8e415daf9639a4eace66 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Oct 5 17:01:57 2016 +0200 s7comm: use ws_stroi function. Change-Id: I0d27c2aa7d896c4c6048dff963910ad7f88b07ee Reviewed-on: https://code.wireshark.org/review/18085 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=eaf6258102eaf954895a8386c5b5f6f... commit eaf6258102eaf954895a8386c5b5f6f9b4fa8cec Author: Dario Lombardo <lomato@gmail.com> Date: Fri Oct 7 15:41:37 2016 +0200 dpnss: use ws_strtou function. Change-Id: If0313f96aaca8d17c55e76dc27a643cbbbdfdcd0 Reviewed-on: https://code.wireshark.org/review/18113 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6a306f26b1fdc29ca4d88b7610db22e... commit 6a306f26b1fdc29ca4d88b7610db22e4f9b5c7a2 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Oct 7 15:38:52 2016 +0200 wlccp: fix typo. Change-Id: I893fdc3025119c69142c617bfcea65654c45ad8b Reviewed-on: https://code.wireshark.org/review/18112 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=95e927ec9399cefd14989674231d251... commit 95e927ec9399cefd14989674231d25165bd93960 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Oct 7 15:44:45 2016 +0200 iso8583: use ws_strtoi function. Change-Id: Icbf98fe1754984cde137dffd98ae6e24ca34081d Reviewed-on: https://code.wireshark.org/review/18114 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b15079bf1dce6d755352782e29f4313... commit b15079bf1dce6d755352782e29f43131f951bab7 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Oct 7 15:48:07 2016 +0200 idl2wrs: use ws_strtou function. Change-Id: I696688088ae926e32ff6c4518c020537d8fe7597 Reviewed-on: https://code.wireshark.org/review/18115 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=dd589f5c169f0d9feb55d86d4bc3fe3... commit dd589f5c169f0d9feb55d86d4bc3fe3b991ea822 Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Tue Oct 4 19:55:12 2016 +0200 Qt: valign text in RTP Stream Analysis window. The text on the left hand side of the RTP Stream Analtsis window is a (HTML) table of table headers followed by table data. For some reason the table data is center aligned in the cells of the table. This does not line up with the text in the table header cells. See http://imgur.com/a/QIQFd Also the HTML document is not compliant. Closing tags are missing, for td and html itself. Change-Id: I1cd58e8702db12433c863757141a6b68c1e2550c Reviewed-on: https://code.wireshark.org/review/18074 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=41fe95fd3e865638db955d95a2e53fd... commit 41fe95fd3e865638db955d95a2e53fd746d5f775 Author: AndersBroman <anders.broman@ericsson.com> Date: Fri Oct 7 16:46:56 2016 +0200 [MEGACO] Add long name for gm/rsb Change-Id: I72efa2210f03477d7e04b2177b751b29cf827eb0 Reviewed-on: https://code.wireshark.org/review/18116 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=22d8142ce77fce18f87b1a0242f86bd... commit 22d8142ce77fce18f87b1a0242f86bd198623d2f Author: Gerald Combs <gerald@wireshark.org> Date: Thu Oct 6 10:38:39 2016 -0700 Disable ASAN when building lemon. If ASAN is enabled, use "-fno-sanitize=all" when building lemon. This keeps us from having to set ASAN_OPTIONS=detect_leaks=0 in the environment in order to build Wireshark. Change-Id: I36f6d1a4f913ecabaf188f4c2b59216c8430d81a Reviewed-on: https://code.wireshark.org/review/18098 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=827ae0c722dc686da9980478a6ff3db... commit 827ae0c722dc686da9980478a6ff3db723993ea5 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Oct 7 11:01:37 2016 +0200 TLS: Fix typo after g989dcef3 Change-Id: I23cf7e7847aea4f48f035d567ba7d22060acb0e7 Reviewed-on: https://code.wireshark.org/review/18106 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=830e7ffd58d296ebfc156350d2e1d51... commit 830e7ffd58d296ebfc156350d2e1d510aa526594 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Oct 7 11:03:39 2016 +0200 TLS: Display extension type with decimal (like IANA) Change-Id: I33820de49a43fceaacc2172068dde83eb0be5fdc Reviewed-on: https://code.wireshark.org/review/18107 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=d58da8ec9098f249abd3fd0dfb3e00d... commit d58da8ec9098f249abd3fd0dfb3e00dee6ff47b4 Author: Roland Knall <roland.knall@br-automation.com> Date: Thu Oct 6 17:04:45 2016 +0200 Interface View/Model: Correct column ordering This orders the columns correctly in the sequence the developer has intended when adding them with setColumns. Also it allows for disabling and inverting the filtering by type, as well as query additional roles instead of only Qt::DisplayRole from the tree model. Change-Id: I90469e8e3f3caa50debb3c839590d42719a6fb10 Reviewed-on: https://code.wireshark.org/review/18096 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=a239472f303b1b482b5ec91e631a16d... commit a239472f303b1b482b5ec91e631a16d3ae3c90ce Author: Dario Lombardo <lomato@gmail.com> Date: Thu Oct 6 12:25:00 2016 +0200 rtsp: use ws_strto[u|i] functions. Change-Id: Id3fa0b4d3a99004ab74be329e13e95c47e11ab72 Reviewed-on: https://code.wireshark.org/review/18091 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=dd5a1f6c6660a9c81513eda8097e26a... commit dd5a1f6c6660a9c81513eda8097e26a9a9367ef0 Author: Dario Lombardo <lomato@gmail.com> Date: Thu Oct 6 17:10:00 2016 +0200 soupbintcp: use ws_strto[u|i] functions. Change-Id: I2bf33798843c8768f4d980a065bd2d13e9d32ed8 Reviewed-on: https://code.wireshark.org/review/18097 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bdcbc3e55f42040514528d7161e5b1a... commit bdcbc3e55f42040514528d7161e5b1a295bf1da3 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Oct 7 12:17:24 2016 +0200 tpncp: use ws_strtou function. Change-Id: Ic8e5c5abffe456ed7a48abf1de87d63665667759 Reviewed-on: https://code.wireshark.org/review/18105 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=196c2b1284464239a47bc910c0d6aba... commit 196c2b1284464239a47bc910c0d6abaac99ee007 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Oct 6 12:44:43 2016 +0200 TLS(1.3): Add Hello Retry Request (6) extension Add also special case on hello key_share extension Ping-Bug: 12779 Change-Id: Ib8e2dd060f322c2404a8afa9b8cb70de7c2c65b7 Reviewed-on: https://code.wireshark.org/review/18093 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5b3dcb671f37ff635be47f778b6985a... commit 5b3dcb671f37ff635be47f778b6985a21163e5d6 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Jul 29 12:22:49 2016 +0200 .mailmap: fix typo Change-Id: I8ee371ab99397c00293372102c73805108845738 Reviewed-on: https://code.wireshark.org/review/17979 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=66433787d0071d02e036cf04f06eb34... commit 66433787d0071d02e036cf04f06eb34accce0f67 Author: Jeff Morriss <jeff.morriss.ws@gmail.com> Date: Thu Oct 6 10:04:52 2016 -0400 M2PA: use G_STRINGIFY to show the user the default preference value. The preferences subsystem knows/stores the default values for all preferences; maybe we should use that to show the default values for all preferences. Change-Id: I562ce9f129c8dfd8378aeb425f70f21b4cf59230 Reviewed-on: https://code.wireshark.org/review/18094 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9e23ed3109393bf6aa8562975378925... commit 9e23ed3109393bf6aa85629753789256a2051e59 Author: D. Ulis <daulis0@gmail.com> Date: Thu Oct 6 13:57:55 2016 -0400 ENIP: Add Connection ID to tree 1. Add Connection ID to tree 2. Remove unused defines 3. Fix Typo Change-Id: I25b76057d5c482c73f22e45cc38d5dceb68feca6 Reviewed-on: https://code.wireshark.org/review/18099 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6529b36c548b4a9de4e5b5b9e49e236... commit 6529b36c548b4a9de4e5b5b9e49e236d885a5907 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Sep 29 10:17:07 2016 +0200 TLS(1.3): Add cookie (44) hello extension Ping-Bug: 12779 Change-Id: I94d492d126050fdff6f98608f9d68d55c19e0a50 Reviewed-on: https://code.wireshark.org/review/18092 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=40d23eb23a3e44dbf6554f3747c0123... commit 40d23eb23a3e44dbf6554f3747c012333c710dec Author: D. Ulis <daulis0@gmail.com> Date: Thu Oct 6 14:40:28 2016 -0400 CIP: More minor bug fixes 1. CIP Safety: Exception Detail Alarm and Exception Detail Warning both were not parsing their 3 parts because the offset was not increased. Fixed the offsets and combined the functions because they have the same format. 2. CIP: Forward Open Safety Response had wrong offsets so it was parsing incorrectly. This incorrectly showed as Malformed. 3. CIP Safety: Pass in tvb to proto_tree_add_subtree() instead of NULL. This was causing a Dissector bug (seems only on trunk, not 2.2). This was already done for packet-cip.c under https://code.wireshark.org/review/#/c/16748/ 4. Some minor typos Change-Id: I63e8d200cd3408c16ca0a1edbc483c3bb8298d3b Reviewed-on: https://code.wireshark.org/review/18100 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8b6de4c81eeb92c347273847318c117... commit 8b6de4c81eeb92c347273847318c117b6bd961b7 Author: Jim Young <jyoung@gsu.edu> Date: Thu Oct 6 18:03:40 2016 -0500 Add a little more info about vagrant and our Vagrantfile. Change-Id: I2f24f869e6b7b819e50e3ea5ade5dbae5272ced2 Reviewed-on: https://code.wireshark.org/review/18102 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=18883a7154f36efee5bc40ad3d23013... commit 18883a7154f36efee5bc40ad3d23013fd742514b Author: shuai xiao <iamhihi@gmail.com> Date: Thu Oct 6 14:03:05 2016 -0700 packet-ieee80211.c - fix bug in vht_compressed_beamforming_report Change-Id: I667c00a8093896984dbf75fa20bec86304706886 Reviewed-on: https://code.wireshark.org/review/18101 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5c55c42eafc899ae870c4e6bebc4a27... commit 5c55c42eafc899ae870c4e6bebc4a27a266a2b15 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sat Oct 1 19:12:14 2016 +0200 jsmn(.h): fix warning: '@param' command used in a comment that is not attached to a function declaration [-Wdocumentation] Change-Id: Ia03fc0d1d0d4af430055f2ae3c66416922b62fd1 Reviewed-on: https://code.wireshark.org/review/18009 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5a12a5e3e83f6a04ecd04bcdb9ac28d... commit 5a12a5e3e83f6a04ecd04bcdb9ac28dd853864dd Author: Andreas Urke <arurke@netwurke.com> Date: Thu Oct 6 01:24:08 2016 +0200 packet-ieee802154: Correct DISSECT_IEEE802154_OPTION_ZBOSS from 0x03 to 0x04 Bug: 12984 Change-Id: Ie7d74a99807cfc77b0c444d79e21b64e1612ac90 Reviewed-on: https://code.wireshark.org/review/18088 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=93b7eead007e8d56e8b5aa011a31298... commit 93b7eead007e8d56e8b5aa011a312980f7fd25a1 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Oct 5 21:29:57 2016 +0200 EIGRP: fix checksum computation Bug: 12982 Change-Id: Iaf816247d49b2f869dc19f64cb0a24247fb38169 Reviewed-on: https://code.wireshark.org/review/18087 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2b5020aca51cded41847374a1dc2f8f... commit 2b5020aca51cded41847374a1dc2f8fc3438c5c6 Author: Gerald Combs <gerald@wireshark.org> Date: Wed Oct 5 11:21:41 2016 -0700 randpkt-test: Fix our optstring "-a" doesn't have an argument. Change-Id: Ia178985925da6e8bf9e1f0e9626521fb93656632 Reviewed-on: https://code.wireshark.org/review/18086 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=90e30be14d82a873c892c0c945b1817... commit 90e30be14d82a873c892c0c945b1817866a46a82 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 20 12:05:10 2016 +0200 bootp: use ws_strtoi function. Change-Id: Id6e4f65d9f011c259931824235bbfb04362c0c71 Reviewed-on: https://code.wireshark.org/review/17813 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6416ae60514caf81f761539235a00ba... commit 6416ae60514caf81f761539235a00ba92b907821 Author: Joakim Karlsson <oakimk@gmail.com> Date: Tue Oct 4 23:43:54 2016 +0200 gtp: improve traffic flow template Both 29.060 and 29.274 reference to 24.008 for TFT filter. Remove redundant part and switch to common TFT encoder. Second reason: decode_gtp_tft didn't encoder all correct, missed direction and filter index. Change-Id: I9691dcb5a9d151f181a3531145ac339fcc7ba245 Reviewed-on: https://code.wireshark.org/review/18082 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=55148a2ea470d19290d236428f3c8e7... commit 55148a2ea470d19290d236428f3c8e725775c96a Author: Uli Heilmeier <uh@heilmeier.eu> Date: Mon Sep 12 14:30:44 2016 +0200 CMakeLists: Add man files Current Wireshark.app bundle on OS X doesn't include man pages. Change-Id: I4123105ae805c3f127dbfd74768b88d4da546c56 Ping-Bug: 12746 Reviewed-on: https://code.wireshark.org/review/17902 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bf424e6f8433a94921a9a4dc728621f... commit bf424e6f8433a94921a9a4dc728621f169e00216 Author: Uli Heilmeier <uh@heilmeier.eu> Date: Sun Sep 25 16:20:24 2016 +0200 macOS: extend MANPATH for Wireshark.app Modify postinstall.sh script to add file /etc/manpaths.d/Wireshark during installation. Content of the file is the current path of the Wireshark manpages. Bug: 12746 Change-Id: I1dc0dc9a2acf56c39c78c709294f1a6804c6ec5c Reviewed-on: https://code.wireshark.org/review/17916 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bff2f93c7d1f4bdba3c141441c57eff... commit bff2f93c7d1f4bdba3c141441c57eff8697dbb94 Author: Mirko Parthey <mirko.parthey@web.de> Date: Sun Sep 18 20:01:26 2016 +0200 isakmp: Add dissection of Responder Lifetime notification Derive the dissection functions from dissect_ike_attribute() and dissect_ipsec_attribute(): * Add dedicated header fields. * Remove attribute types not applicable in Responder Lifetime context. Clean up the field name "isakmp.ipsec.attr.type". Bug: 12963 Change-Id: I486380836d915255812098be2190bcc77ec13c00 Reviewed-on: https://code.wireshark.org/review/17970 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cb959510d2d25a41a142b01659d62f1... commit cb959510d2d25a41a142b01659d62f19b6b1c1ac Author: PHO <pho@cielonegro.org> Date: Mon Oct 3 08:52:08 2016 +0900 tvbuff_zlib: Check if the given offset and compressed length are indeed valid before trying to allocate memory g_malloc() may abort(3) the program when the comprlen is insanely large so use tvb_memdup() instead. Change-Id: I23fbdc2362900030c41da1c297ab0c787de7c5ca Reviewed-on: https://code.wireshark.org/review/18043 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=257abd91217c8f5512689be5cc568a5... commit 257abd91217c8f5512689be5cc568a500fda3b54 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Oct 2 21:07:24 2016 +0200 spnego: fix indent (use 2 spaces) and modelines Change-Id: I077c21eb213435e7ed0e9ac0b9a8f95aa9dd6f3d Reviewed-on: https://code.wireshark.org/review/18075 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d6635e8dc873dcf46b3808ad4c61d2c... commit d6635e8dc873dcf46b3808ad4c61d2c598e4d725 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Oct 4 18:19:06 2016 +0200 msrp: use ws_strtou function. Change-Id: I54bef4b44bcf4ad851c6f0817b1e2c645d0e409a Reviewed-on: https://code.wireshark.org/review/18068 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=23f11b755202d6ba9b7a8b80df72649... commit 23f11b755202d6ba9b7a8b80df7264992e3a41f0 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Oct 4 15:16:02 2016 +0200 Openflow (v4/v5): Add check if all length is decoded Change-Id: I7846dd04c45d0398ded8345b6a2794d6f851cb64 Ping-Bug: 12979 Reviewed-on: https://code.wireshark.org/review/18065 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=dda1ee05b3b5e439a3dd1ed6944f5e7... commit dda1ee05b3b5e439a3dd1ed6944f5e797b5ed995 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 30 10:47:21 2016 +0200 LLDP: fix indent (use tab) Change-Id: Ic9923d93d74a40da2a4009f8b27d8a5ae9803833 Reviewed-on: https://code.wireshark.org/review/18064 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=76cf240a0bbe142829083189f943dcc... commit 76cf240a0bbe142829083189f943dcc85c7f1223 Author: Michael Mann <mmann78@netscape.net> Date: Tue Oct 4 07:30:29 2016 -0400 SMPP: Make smpp.message a FT_BYTES field. As an FT_NONE field, you can't filter/use the message it contains. Bug: 12960 Change-Id: Icaa9a260195711f1bd90f5ed14797c0d0c46de9c Reviewed-on: https://code.wireshark.org/review/18063 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ca2ac990637881a708f395de8f09ab0... commit ca2ac990637881a708f395de8f09ab01c0f7a697 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Sep 26 15:13:11 2016 +0200 h248_annex_c: use ws_strtoi function. Change-Id: I0f9a1866a58ec61a8cd424ca69c1170791b5fe72 Reviewed-on: https://code.wireshark.org/review/17939 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6499a02395aea342508dae85f053afd... commit 6499a02395aea342508dae85f053afd9896dd073 Author: Gerald Combs <gerald@wireshark.org> Date: Tue Oct 4 09:05:31 2016 -0700 Color filters: Initialize a variable. Make sure temp_dfilter is initialized so that we don't end up freeing invalid memory. Change-Id: Id31969573690574846422b67c950188fd6ee4ef3 Reviewed-on: https://code.wireshark.org/review/18066 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c8143e2077832c83ee2c03302d2319d... commit c8143e2077832c83ee2c03302d2319d5be948722 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Oct 4 10:52:50 2016 +0200 Qt: add condition to compile without extcap. Change-Id: Ieabccb5dfc7884bebf9f2b68caaa16a82609bd30 Reviewed-on: https://code.wireshark.org/review/18060 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d8fdf5454a457abe0109ad5615d5d4c... commit d8fdf5454a457abe0109ad5615d5d4c4bfca4222 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Oct 3 12:02:21 2016 +0200 sshdump: add remote capture command. This new option adds the chance to use a custom capture command. It must produce a PCAP stream that will be read by Wireshark, written to STDOUT. Change-Id: I34a72465eb369194f24ecf0594df143b8ad6555f Reviewed-on: https://code.wireshark.org/review/18037 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=99367fc51303224ec9e95e29a8407cd... commit 99367fc51303224ec9e95e29a8407cd0d0b5d9f6 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Oct 3 16:19:01 2016 +0200 sshdump: use tcpdump as default capture binary. This removes the option to specify a custom capture binary due to incompatibilities between different binaries options. A following change will add the chance to use a custom capture command that will cover all the cases that the default doesn't. Bug: 12952 Change-Id: Idbde3e27f34c28f4ce622c3a860994e25ce5f92f Reviewed-on: https://code.wireshark.org/review/18040 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bdd21938ba4fa931c2e0b2d7f804489... commit bdd21938ba4fa931c2e0b2d7f804489e18da77a7 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Oct 4 07:51:39 2016 +0200 LTE RRC: upgrade dissector to v13.3.0 Change-Id: Ic2c8e9c6d3df0bffdd6a195c29aa586df29cb20a Reviewed-on: https://code.wireshark.org/review/18059 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8d08b3ed82b452419dcf485ed42a350... commit 8d08b3ed82b452419dcf485ed42a350073ccbf27 Author: PHO <pho@cielonegro.org> Date: Mon Oct 3 08:49:40 2016 +0900 help/Makefile.am: Use the python command chosen by the configure script Change-Id: I7b6e2b0c7802e214b4483990d0e7e70c58b3f96b Reviewed-on: https://code.wireshark.org/review/18042 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=fc234708a7d3837b6d705f06a0bd466... commit fc234708a7d3837b6d705f06a0bd46651a01f6a5 Author: Roland Knall <rknall@gmail.com> Date: Mon Oct 3 19:57:44 2016 +0200 Interface View/Model: Fix pcap-less build Change-Id: I88bc6c939b7ce6986299e4ebf99358437b758bd2 Reviewed-on: https://code.wireshark.org/review/18045 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=a59e64c9069aabd42a2df349e2d478e... commit a59e64c9069aabd42a2df349e2d478e6f2147ffa Author: Peter Wu <peter@lekensteyn.nl> Date: Tue Oct 4 03:05:47 2016 +0200 uat: fix PT_TXTMOD_HEXBYTES/PT_TXTMOD_ENUM comments The PT_TXTMOD_HEXBYTES comment was misleading, edit it to reflect the actual implementation in GTK+/Qt. Change-Id: I1506ad9189296dcc09cc20eafb0d65eaf291d79f Reviewed-on: https://code.wireshark.org/review/18058 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=1fdbdf7fcaf30661ac95a5d0af3c2aa... commit 1fdbdf7fcaf30661ac95a5d0af3c2aa105b6274f Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Sat Oct 1 20:43:54 2016 +0200 Qt: Have logo in the center of the about dialog Change-Id: I5dca338e7e3eda3f4b0fa827fe6f7177337f5393 Reviewed-on: https://code.wireshark.org/review/18011 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8ea52e2f4902325809d420120cebbd9... commit 8ea52e2f4902325809d420120cebbd97dc47518b Author: Gerald Combs <gerald@wireshark.org> Date: Mon Oct 3 15:18:49 2016 -0700 Man pages: Update -D flag text. Refer to "Windows" instead of "Windows 2000". Add an "ip link show" breadcrumb. Change-Id: Ie1faa1d30b0ac63de35b0385cbb1306f08828e61 Reviewed-on: https://code.wireshark.org/review/18056 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=a68dd39a01d7490383f306f2dc35fb8... commit a68dd39a01d7490383f306f2dc35fb8f079b8c69 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Mon Oct 3 23:30:02 2016 +0200 p1: Handle implicit Content The retured-content is defined as IMPLICIT Content (octet string), so ensure we handle this correctly. Bug: 12976 Change-Id: I4bcce67cea97142bf3312e1a5c2aeb169c7a69d2 Reviewed-on: https://code.wireshark.org/review/18054 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=650c0f93be4765c8a2dc2db035fe1d0... commit 650c0f93be4765c8a2dc2db035fe1d0542a047c3 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Mon Oct 3 21:09:28 2016 +0200 p1: Check for valid tvb before tvb_reported_length Move the modification of the content item (which adds the length) inside the check for a valid tvb to avoid calling tvb_reported_length() with a NULL parameter. Bug: 12976 Change-Id: I54368584b7c00f7a2937eaec772533ae73d98f80 Reviewed-on: https://code.wireshark.org/review/18050 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=1320ea4d57bf376a6a1923a7103d332... commit 1320ea4d57bf376a6a1923a7103d3321b4de8cc3 Author: Gerald Combs <gerald@wireshark.org> Date: Tue Sep 20 11:30:38 2016 -0700 Be more forgiving about invalid Coloring Rules. In ColoringRulesDialog: Only check a rule's display filter if that rule is enabled. This keeps us from disabling the OK button when we shouldn't. Adjust the "Your coloring rules file contains unknown rules" dialog text and buttons for accuracy. In color_filters.c: Don't try to compile disabled filters in color_filters_apply. Don't warn about disabled and invalid filters in read_filters_file. Bug: 12814 Change-Id: I7143bf8e7a6162d296f1e93769344b69763195c8 Reviewed-on: https://code.wireshark.org/review/17823 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d2a59db2bbf944da07710d31d4f86fe... commit d2a59db2bbf944da07710d31d4f86fe5a27490dd Author: Birol Capa <birol.capa@siemens.com> Date: Wed Sep 28 14:00:17 2016 +0300 PROFINET: Add preliminary version of the Reporting System (RS) dissection. The Reporting System (RS) ASE is composed of Observers and Event buffer queues. Bug: 12959 Change-Id: Ibce2d607bffe9c04b24e8ccd5ef502307fbba7c6 Reviewed-on: https://code.wireshark.org/review/17965 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a50bed094bdb03ce68b65c6a69696ce... commit a50bed094bdb03ce68b65c6a69696ce446f9dd3d Author: Roland Knall <roland.knall@br-automation.com> Date: Mon Oct 3 16:31:36 2016 +0200 Interface List: Allow column filtering in model This change allows for the definition of columns to be shown to the enduser if instanting the proxy model. The tree model will allways transport ALL data, and it is the job of the proxy model to determine which data is actually shown. Additionally, this removes the final definitions of the global interface array from interface_frame as well as sort_filter, so that knowledge about the inner workings of the interface list is contained to interface_tree_model Change-Id: Ib34b150066ee344ad0d18bec1d90826eb0fa28b2 Reviewed-on: https://code.wireshark.org/review/18039 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=542c3c6f3a87ba147dd85f2909270cc... commit 542c3c6f3a87ba147dd85f2909270cc2ad320e93 Author: Dario Lombardo <lomato@gmail.com> Date: Thu Sep 29 14:32:03 2016 +0200 ssl: use ws_strtou function. Change-Id: I947dc83e3b1b853873b5158f234e44ef933c3bcc Reviewed-on: https://code.wireshark.org/review/17982 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b90134f703b897811b62b7cfa89b280... commit b90134f703b897811b62b7cfa89b2800e5b8d541 Author: Michael Mann <mmann78@netscape.net> Date: Mon Oct 3 08:16:30 2016 -0400 ieee80211: (Re)Fix EOSP flag dissection for mesh case Ia8d4d74a7f0f5795790f930fc1e894a7ee202da7 didn't have proper bit comparison. Change-Id: I5b7e431745aff7ca895b6b83500bd7e8f1039fde Reviewed-on: https://code.wireshark.org/review/18038 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=aadec0f7659af0249bdba0a8718cd3b... commit aadec0f7659af0249bdba0a8718cd3bf2fd98a42 Author: AndersBroman <anders.broman@ericsson.com> Date: Mon Oct 3 09:59:52 2016 +0200 [Diameter] Use ...array_sized_new() for hf:s and ett:s Change-Id: I5d3d3779ccf1fcd8a61e6cb6342305db2bc6e2be Reviewed-on: https://code.wireshark.org/review/18036 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7849d29b24bc67ee208741decd67dd4... commit 7849d29b24bc67ee208741decd67dd43d45dff0c Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 27 09:39:07 2016 +0200 Qt: make parameter unused when SHOW_BUFFER_COLUMN is undefined. Change-Id: I87843f61d4c98fea90e49088f3d56df5aa801e58 Reviewed-on: https://code.wireshark.org/review/17946 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1fbf831a6ba8eb46757ec93ecbe95ef... commit 1fbf831a6ba8eb46757ec93ecbe95efdf9020b3a Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 30 10:51:41 2016 +0200 Qt: properly handle UAT changes on dialog close Ensure that UAT changes are always applied, not just when pressing the OK/Cancel buttons, but also when closing the dialog via the window close button or by pressing Escape. Change-Id: I0f0b97588553c6b01a24dfde78218d0ce2667e2c Reviewed-on: https://code.wireshark.org/review/17993 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=54721903166d06734acb0d985e05f25... commit 54721903166d06734acb0d985e05f25125c98016 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Oct 2 19:58:10 2016 +0200 cisco-erspan: fix no newline at end of file [-Wnewline-eof] Change-Id: I155a2293d48a62bd198aa20f0fb68f76934cdb6a Reviewed-on: https://code.wireshark.org/review/18031 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cb1c8c6243ce1e6af6171ad7bcd2881... commit cb1c8c6243ce1e6af6171ad7bcd2881ca1c39205 Author: Michael Sweet <michael.r.sweet@gmail.com> Date: Sat Aug 20 12:09:25 2016 -0400 IPP packet dissector improvements: - Support collection values - Support out-of-band values - Support unknown values - Support detail for octetString/collection values - Support symbolic enum keywords for member attributes - Update detail format to be more compact, normalize format to match IPP syntax descriptions Change-Id: I76295221901fa88250a2e9ef099eca2c53b20132 Reviewed-on: https://code.wireshark.org/review/17693 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Smith Kennedy <smith.kennedy@hp.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=310d87b556c24ad2c30e1e944a3cd59... commit 310d87b556c24ad2c30e1e944a3cd59cf1c57041 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Oct 2 22:33:03 2016 +0200 LPP: upgrade dissector to v13.2.0 Change-Id: I6ebf5efcb656534f663369b7987aa32ebd55d2dc Reviewed-on: https://code.wireshark.org/review/18033 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=57268e3c5b8baeb6228c9588f434577... commit 57268e3c5b8baeb6228c9588f434577d85b5c451 Author: Michael Mann <mmann78@netscape.net> Date: Sun Oct 2 19:21:05 2016 -0400 tshark: follow streams should start with chunk 1. Chunk 0 is not allowed, so it's discarded when outputting a stream. Ping-Bug: 12855 Change-Id: Ia7bbb0e222b6b4e714f8bfa245e910c151d82905 Reviewed-on: https://code.wireshark.org/review/18034 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=470086f059246b7f4a204def34cea13... commit 470086f059246b7f4a204def34cea130e5a3af61 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Oct 2 20:52:14 2016 +0200 X2AP: upgrade dissector to v13.5.0 Also get rid of two global variables Change-Id: I8c20decb76f5c1773f58efd24d2e1e7d1177d358 Reviewed-on: https://code.wireshark.org/review/18029 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7a6610fc996940974eaafdcf8bff192... commit 7a6610fc996940974eaafdcf8bff19298308ed72 Author: Gerald Combs <gerald@zing.org> Date: Sun Oct 2 12:03:34 2016 -0700 make-manuf: Add more sanity checks. Increase the number of minimum entries required in each IAB / OUI file to 1000. Add a minimum total entry count. Add total counts to the output. Trim whitespace so that we pass the pre-commit hook. Re-run make-manuf to fix the mass removal in g3ab0137. Change-Id: I6f924969c1b494f2e0b62570a459e99ba5c1b02f Reviewed-on: https://code.wireshark.org/review/18030 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=37f37bb6b6d18cd346b19b7fa092f44... commit 37f37bb6b6d18cd346b19b7fa092f447d085f5e9 Author: Guy Harris <guy@alum.mit.edu> Date: Sun Oct 2 11:27:18 2016 -0700 Some strings that appear in at least some .aps files. Change-Id: I335a2db8ce6ebb424081a9a6156c6eb523720029 Reviewed-on: https://code.wireshark.org/review/18028 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=53523a739c41abfdc3f61ba460f8a6d... commit 53523a739c41abfdc3f61ba460f8a6d021c02832 Author: Roland Knall <rknall@gmail.com> Date: Sun Oct 2 16:47:04 2016 +0200 Interface List: Fix build for no PCAP builds This is a fix for building without libpcap. Also, changing _U_ to Q_UNUSED for the tree_model Change-Id: I38a992731a3d3c4062ffab3cca0049cf08050794 Reviewed-on: https://code.wireshark.org/review/18019 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=fea4d585edc407b7177e3b0481bf59f... commit fea4d585edc407b7177e3b0481bf59f57942cf18 Author: Roland Knall <rknall@gmail.com> Date: Sun Oct 2 16:22:27 2016 +0200 Interface List: Hide button for only one interface If only one interface type exists, the button row is being hidden. Change-Id: Ieed9c363ab1ebc4bc15d0e09bceeb79a04d6e76e Reviewed-on: https://code.wireshark.org/review/18017 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e38d103d30f8131efd22742d6b03d7f... commit e38d103d30f8131efd22742d6b03d7f34a226936 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sun Oct 2 16:41:08 2016 +0200 Qt: Only color sequence analysis items having color filter Packets without a color filter will end up with fg_color and bg_color = 0, so avoid drawing all in black. Bug: 12065 Change-Id: I76bcabcfa3281fcece08f1b2af66274c808b80bb Reviewed-on: https://code.wireshark.org/review/18018 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=9f55eb4e954dd125e229bc94892e157... commit 9f55eb4e954dd125e229bc94892e1571abd2cd65 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Oct 2 12:20:45 2016 +0200 wslua: fix wslua file test failure Lua 5.2.4 built with -DLUA_USE_APICHECK detected a stack issue: tshark: lapi.c:175: lua_settop: Assertion `(-(idx+1) <= (L->top - (func + 1))) && "invalid new top"' failed. Function File_read always assumes that File_read_line pushes a value on the stack (which clearly did not happen). On read failure, it would then pop the stack (tripping the assertion) to push nil. The other user (File_lines) is also affected by this change, but the Lua 5.2.4 documentation says that it should also return nil on EOF, fitting this implementation. Change-Id: I9cc8a5319523b2b56f4ae4735bbdbc1196387386 Reviewed-on: https://code.wireshark.org/review/18016 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=3ab013753304b7e42faf86a5b6c6522... commit 3ab013753304b7e42faf86a5b6c6522110da0432 Author: Gerald Combs <gerald@wireshark.org> Date: Sun Oct 2 08:10:23 2016 -0700 [Automatic update for 2016-10-02] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ice97c38ca24c22c72e6bc63a4329c8131d0146f2 Reviewed-on: https://code.wireshark.org/review/18020 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=98accd21bc790747218f7b4db5ebb82... commit 98accd21bc790747218f7b4db5ebb8285634fa86 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Oct 2 09:49:05 2016 +0200 Makefile.am (epan/dissectors): fix indent align (and use always tabs) Change-Id: I874314ac736ad94bfaf15665ee7b030382e9bdf3 Reviewed-on: https://code.wireshark.org/review/18015 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1b8ccdc45d1c6e68291802021b46485... commit 1b8ccdc45d1c6e68291802021b4648594d5fcf81 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Oct 2 09:55:52 2016 +0200 gsm_osmux: fix implicit conversion shortens 64-bit value into a 32-bit value (with macOS buildbot) Change-Id: Idd919b20f9909fe3f85b6e1694738a8561f4d97f Reviewed-on: https://code.wireshark.org/review/18014 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=02640154045c35618ee155fc28e2495... commit 02640154045c35618ee155fc28e2495c87b4b296 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Oct 2 09:46:39 2016 +0200 gsm_osmux(.h): fix packet-gsm_osmux.h: No such file or directory Change-Id: I51d6aa1ff4fe7abf908872c8297a926ebebf1258 Reviewed-on: https://code.wireshark.org/review/18013 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=483c4a61d5310f91cd08114cc084656... commit 483c4a61d5310f91cd08114cc084656f40754895 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sat Oct 1 23:46:13 2016 +0200 S1AP: upgrade dissector to v13.4.0 Change-Id: I140c40a93dce2ffdf7c144701bc3886d5366f951 Reviewed-on: https://code.wireshark.org/review/18012 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0a9e74e5325037429af49303bded800... commit 0a9e74e5325037429af49303bded80091d012044 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sat Oct 1 19:08:51 2016 +0200 wsjsmn(.h): fix no newline at end of file [-Wnewline-eof] Change-Id: If99fa78b20cdc9d2180652f7e4331fe2f8aacbff Reviewed-on: https://code.wireshark.org/review/18008 Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=913564af42c86892d8a0dc20f4c0820... commit 913564af42c86892d8a0dc20f4c082080387d22a Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sat Oct 1 20:24:45 2016 +0200 NAS EPS: upgrade dissector to v13.7.0 Change-Id: Ic856255d4adbde0af795cd36798ba4a9d42b4080 Reviewed-on: https://code.wireshark.org/review/18010 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dd0d9ea4fbf4ec5e11078c89d42da21... commit dd0d9ea4fbf4ec5e11078c89d42da211ed46b4b8 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sat Oct 1 17:54:13 2016 +0200 interface_tree_model(.h): fix not a Doxygen trailing comment [-Wdocumentation] Change-Id: Ibdf59547ec116d99ff8e60fd8c69dbd2b929e887 Reviewed-on: https://code.wireshark.org/review/18007 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c33169b7b812ade98ded1c50af0ff24... commit c33169b7b812ade98ded1c50af0ff24a9e439bc5 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sat Oct 1 14:22:46 2016 +0200 3GPP NAS: upgrade dissector to v13.7.0 Change-Id: I353608057c50e2631f6bae6a026f361640ec9560 Reviewed-on: https://code.wireshark.org/review/18006 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=99097dd3c65358a525e40767cc1501c... commit 99097dd3c65358a525e40767cc1501c4116c3a4d Author: Roland Knall <rknall@gmail.com> Date: Sat Oct 1 08:54:57 2016 +0200 Interface List: Change display to view/model This changes the underlying model of the main interface tree. Because of that, we can resort to a view/model approach, enlisting the global interfaces list as only data source. The interface list works identical to the old list, but allows for filtering of the displayed interfaces by type. Only types, which are present and whose interfaces are not hidden, are being displayed for selection. Change-Id: If8475b227daa026dc0ad3d25bc7fe050d5bf2ac3 Reviewed-on: https://code.wireshark.org/review/17940 Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b6ad91520fd602710f5afe4a4eb8787... commit b6ad91520fd602710f5afe4a4eb8787a6bca22d4 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Sep 21 16:53:11 2016 +0200 rlogin: use ws_strtou function. Add expert info when conversion fails. Change-Id: Ic13cb90abddd08218a957cd771bd5a4fab5a413e Reviewed-on: https://code.wireshark.org/review/17839 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7ea363223a5a5a872d66a65570c134c... commit 7ea363223a5a5a872d66a65570c134c34aa51b49 Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 30 10:46:28 2016 +0200 uat: allow insertion of new record at arbitrary index This should make drag-and-drop support (reordering) in Qt easier. It also ensures that memcpy is used as fallback if copy_cb does not exist. Change-Id: Iefe358890c49dcda4727054f7a2cee05614a36f6 Reviewed-on: https://code.wireshark.org/review/17992 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2dfc0da22cc4c525c32baa268466664... commit 2dfc0da22cc4c525c32baa2684666643d4bf23a0 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 30 08:15:11 2016 +0200 Kerberos: remove some unused #define for avoid conflit with heimdal lib Bug:12831 Change-Id: Ic244b6b8dc4f68a0f782b88984ad7857ceb02e25 Reviewed-on: https://code.wireshark.org/review/17989 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=da8969ceefbcc1ad19f36309ccb5b20... commit da8969ceefbcc1ad19f36309ccb5b208c6324b5c Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 30 08:10:01 2016 +0200 spnego: use same name define name from krb5 and for heimdal lib add the value Bug:12831 Change-Id: Ibf04560867acfe2a430034248ce2a386ea89b668 Reviewed-on: https://code.wireshark.org/review/17988 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0f18087ca32fa897dd3dfc04202bb40... commit 0f18087ca32fa897dd3dfc04202bb40d3639364d Author: D. Ulis <daulis0@gmail.com> Date: Fri Sep 30 15:19:51 2016 -0400 CIP: Minor bug fixes 1. CIP: dissect_cip_set_attribute_list_req - Too many bytes highlighted. Could cause malformed packet 2. CIP: dissect_cip_cco_all_attribute_common - Too many bytes highlighted 3. CIP Motion: dissect_cntr_service - Wrong size passed in which tried to highlight too many bytes. Would cause malformed packet. 4. CIP: Some minor formatting/whitespace changes. Change-Id: I5899888a3e58452945c8546cf635768cdd3cf738 Reviewed-on: https://code.wireshark.org/review/18000 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cda23193bfa9f5b9b1753742ebffdad... commit cda23193bfa9f5b9b1753742ebffdaddd75a73c2 Author: Gerald Combs <gerald@wireshark.org> Date: Fri Sep 30 11:21:05 2016 -0700 NetFlow: Fix a preference description. Stringify the correct macro so that we print (default: 60) instead of (default: V9TEMPLATE_MAX_FIELDS_DEF) Change-Id: Ie2068eaf577f6024d4a9b64ef5ce761944f269a2 Reviewed-on: https://code.wireshark.org/review/17998 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=11c10244ef5168a337d88611d61c5eb... commit 11c10244ef5168a337d88611d61c5ebc88acd29e Author: Dario Lombardo <lomato@gmail.com> Date: Wed Sep 28 12:01:33 2016 +0200 wsutil: split libjsmn. The libjsmn was imported into the tree and enhanced with a new function. This change splits it into the "original" libjsmn and an addictional module wsjsmn that contains the new function. This will make easier to port within the tree future versions of the library. Change-Id: I3f1caa91bee462e0767e5e18d0b6a10f0b1cad32 Reviewed-on: https://code.wireshark.org/review/17963 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=534787e402d6aa8b349638f911a2a65... commit 534787e402d6aa8b349638f911a2a65b013c6594 Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 30 16:06:15 2016 +0200 cmake: make WERROR_COMMON_FLAGS a normal string Instead of checking for the boolean "FALSE", just set an empty string. This avoids the need to check for WERROR_COMMON_FLAGS before using it. The transformation is the same for all files, remove "if (WERROR_COMMON_FLAGS)" and "endif()", reindent and add quotes (since we have a string here and not a list). Modelines have been added where missing. Change-Id: I0ab05ae507c51fa77336d49a99a226399cc81b92 Reviewed-on: https://code.wireshark.org/review/17997 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=53c91974c7e8f77555920e137cab80b... commit 53c91974c7e8f77555920e137cab80b5418e992b Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 30 09:35:30 2016 +0200 kismet: use cast in ws_strtou. Fix the warning: packet-kismet.c: In function 'dissect_kismet': packet-kismet.c:242:58: error: passing argument 3 of 'ws_strtou64' from incompatible pointer type [-Werror] if (ws_strtou64(format_text(line, tokenlen), NULL, &t.secs)) { ^ In file included from packet-kismet.c:34:0: ../../wsutil/strtoi.h:49:24: note: expected 'guint64 *' but argument is of type 'time_t *' WS_DLL_PUBLIC gboolean ws_strtou64(const gchar* str, const gchar** endptr, guint64* cint); Change-Id: Ifd31de22db22f39f78359cc9432eb7da187f73a6 Reviewed-on: https://code.wireshark.org/review/17990 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Uli Heilmeier <openid@heilmeier.eu> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c5655dcfbfb3b392e2bc65e1c7486a5... commit c5655dcfbfb3b392e2bc65e1c7486a5839e047e4 Author: Anders Broman <a.broman58@gmail.com> Date: Fri Sep 30 11:52:26 2016 +0000 Revert "LLDP: fix indent (use tab)" This reverts commit f97372bfccf34c012b4a4a6f720ca54dae8ea5d8. Change-Id: I750b232fa710e64815875671e713533bb0f42e24 Reviewed-on: https://code.wireshark.org/review/17995 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f97372bfccf34c012b4a4a6f720ca54... commit f97372bfccf34c012b4a4a6f720ca54dae8ea5d8 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 30 10:47:21 2016 +0200 LLDP: fix indent (use tab) Change-Id: I7f9aa2733401fc99a10d5d5a83a175e923562f50 Reviewed-on: https://code.wireshark.org/review/17991 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fdbf443d27130628918ac247c682d32... commit fdbf443d27130628918ac247c682d32bcb314b49 Author: Daniel Willmann <dwillmann@sysmocom.de> Date: Tue Jul 12 14:25:35 2016 -0400 Add dissector for the osmux protocol The Osmux protocol bundles multiple AMR frames inside one UDP packet to avoid the overhead of having one IP/UDP/RTP packet per AMR frame. It is used by the osmocom project. Sponsored-by: On-Waves ehf Change-Id: I8fb21e54adec8d8bd7ac5ebd2154100a73ab71c9 Reviewed-on: https://code.wireshark.org/review/16996 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=11da041bab27f69a940a2c8113f1a81... commit 11da041bab27f69a940a2c8113f1a811534d4eaa Author: Birol Capa <birol.capa@siemens.com> Date: Tue Aug 16 13:09:28 2016 +0300 LLDP: Update column info according to PROFINET requirements Column information of LLDP frames should be updated according to PROFINET requirements without changing the default behavior of column information. Therefore, a new protocol setting is added. This setting is used to display PROFINET specialized column information: Edit-> Preferences -> Protocols -> Select LLDP Bug: 12937 Change-Id: I48b78d0a3f6b3425f6f9c1d4be20dc24b143346d Reviewed-on: https://code.wireshark.org/review/17081 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d8a2d39d429ad20707eafc05399e640... commit d8a2d39d429ad20707eafc05399e640521d66f57 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 29 21:47:29 2016 +0200 Update c-ares to 1.12.0 Change-Id: Icd70f5e4e5e1a41a6a188500874a893433ecb8ed Reviewed-on: https://code.wireshark.org/review/17985 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1f633cfc840de148e928d121a613237... commit 1f633cfc840de148e928d121a613237ea5dafb0a Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 29 11:25:52 2016 -0700 Qt: Add html_escape to qt_ui_utils. Add an html_escape convenience function, which escapes HTML metacharacters using Qt::escape on Qt4 and QString::toHtmlEscaped on Qt5. Use it where we were previously using #if QT_VERSION and calling the API-specific functions. Change-Id: Ifda3e9634a37fc00bdb46e08d5711f934692fef5 Reviewed-on: https://code.wireshark.org/review/17984 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5f69295c47a9a72ae27d8404860ab81... commit 5f69295c47a9a72ae27d8404860ab8170591cb1d Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 29 08:33:24 2016 -0700 macosx-setup: Upgrade c-ares to 1.12.0. Change the download protocol to https as well. Change-Id: Id2043141d3b89449f2a0c739c05142af0a7b46ba Reviewed-on: https://code.wireshark.org/review/17983 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d86214e86737967765238409bd26016... commit d86214e86737967765238409bd260162d313f15f Author: Dario Lombardo <lomato@gmail.com> Date: Mon Sep 12 14:18:30 2016 +0200 kismet: use ws_strtou64. Add also an expert info when the time is invalid. Change-Id: I8b3639aade41574cf1bda38f3ae1d02b09d0711c Reviewed-on: https://code.wireshark.org/review/17678 Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=85df9217f0db503cd2aff04a2e5a475... commit 85df9217f0db503cd2aff04a2e5a475f5d0203a9 Author: Benjamin Parzella <bparzella@gmail.com> Date: Fri Sep 23 15:58:34 2016 +0200 Added HSMS dissector Bug: 12942 Change-Id: I69ab22caa9938167db421ca2f0346ca086280823 Reviewed-on: https://code.wireshark.org/review/17890 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c205bce8ef2922cc0f0dc28c6593e64... commit c205bce8ef2922cc0f0dc28c6593e640ac8a49b9 Author: AndersBroman <anders.broman@ericsson.com> Date: Thu Sep 29 13:03:41 2016 +0200 proto.c use g_list_prepend when adding heuristic dissectors and plugins. Change-Id: If55938f0bad556a002fc85466c0b4f0e904991dc Reviewed-on: https://code.wireshark.org/review/17981 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b3166fd87c789ae9c42196933d89cbf... commit b3166fd87c789ae9c42196933d89cbfd70084002 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Sep 28 13:48:23 2016 +0200 TLS: Fix indent of SNI hello extension use 4 spaces Change-Id: I0cbde19997f51046e6d5f22213b994a94a2998d6 Reviewed-on: https://code.wireshark.org/review/17978 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e91af83c637adaa7a9837de65f50596... commit e91af83c637adaa7a9837de65f50596a32b08db0 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Sep 28 21:35:12 2016 -0700 Replace some seeks forward with wtap_read_bytes() with a null buffer pointer. If the seek forward is just skipping record content that's not (currently) interesting, use wtap_read_bytes() with a null buffer pointer; it catches short "reads" and requires less seeking, so it may work better when reading from a pipe. Change-Id: Ifb07d20e0391a8ed97da85149d971b4e9ef093a8 Reviewed-on: https://code.wireshark.org/review/17976 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=48b641576c53e9c7cef2e9487669460... commit 48b641576c53e9c7cef2e9487669460a975a0c0d Author: Birol Capa <birol.capa@siemens.com> Date: Wed Sep 28 08:56:22 2016 +0300 PROFINET: Fix variable may not have been initialized warning The variable may not have been initialized. To make code more readable and to avoid possible future mistakes initialize the variables. Change-Id: I0c5e78b6d625c87252a4c47e263a3d5c701f2674 Reviewed-on: https://code.wireshark.org/review/17962 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=12d55fb917dad1aaba8429b24cb1eac... commit 12d55fb917dad1aaba8429b24cb1eac49c3cd11f Author: Uli Heilmeier <uh@heilmeier.eu> Date: Thu Sep 8 16:00:29 2016 +0200 TCP: Fix next sequence number for SYN/FIN packets with payload The next sequence number is off by one when there is TCP payload in a SYN or FIN packet (e.g. when using TCP FastOpen). Bug: 12579 Bug: 12838 Change-Id: Idb68cea4b4dcba39461019c08db09367cbfc6d68 Reviewed-on: https://code.wireshark.org/review/16239 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ef2aae1d8ce4c9e4b273ec5117602d4... commit ef2aae1d8ce4c9e4b273ec5117602d42227f66c7 Author: Sergey Avseyev <sergey.avseyev@gmail.com> Date: Thu Sep 29 00:19:45 2016 +0300 packet-couchbase.c: dissect body of DCP_FAILOVER_LOG response Change-Id: Icbadcc83b5fedea4373d4c65a11700d73b3dc32e Reviewed-on: https://code.wireshark.org/review/17972 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=14be63a807a850221a83914d135329d... commit 14be63a807a850221a83914d135329dee19bc18b Author: Dirk Jagdmann <doj@cubic.org> Date: Fri Sep 23 01:46:16 2016 -0700 set PDML and PSML encoding to UTF-8. replace fputs() with fprintf() in writing PSML and PDML preambles for more consistent code formatting. Change-Id: I57dbb27cbf935dd31342639b315d1fc98bd27d77 Reviewed-on: https://code.wireshark.org/review/17895 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7aa243c0c76a0d27e6cf1bb97f25680... commit 7aa243c0c76a0d27e6cf1bb97f2568009a093039 Author: Parav Pandit <paravpandit@yahoo.com> Date: Wed Sep 28 20:54:01 2016 +0000 packet-infiniband: Fix setting rocev2 udp port number This patch sets RoCE-v2 (RRoCE) UDP port number to right value of 4791 as assigned by IANA described in below link. http://www.iana.org/assignments/service-names-port-numbers/service-names-por... Change-Id: I97b82fb53fd63d9107ee5d4c64b94840e743fc72 Tested-by: pandit.parav@gmail.com Reviewed-on: https://code.wireshark.org/review/17971 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a88b7bc1a6f4033a0b98c9847d259fb... commit a88b7bc1a6f4033a0b98c9847d259fb3d687fcf4 Author: Birol Capa <birol.capa@siemens.com> Date: Wed Sep 28 07:56:14 2016 +0300 PROFINET: Fix switch statement has no default A switch statement has no section labeled default. To make the code more readable add the default statement with a good comment. Change-Id: Iacd9b1520628e229baedc89277d07ffac2caf1b6 Reviewed-on: https://code.wireshark.org/review/17960 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=814477c32f9ac7838cf7364fcc83f36... commit 814477c32f9ac7838cf7364fcc83f36378ea2159 Author: Birol Capa <birol.capa@siemens.com> Date: Wed Sep 28 08:26:34 2016 +0300 PROFINET: Fix pointer variable 'fp' previously deallocated warning 'fp' pointer variable was freed or deleted in an earlier statement. To make code more readable and to avoid possible future mistakes make sure that developer sees this situation. Change-Id: Ib5b9c4c32000adf05a30e094ebc98fe4bc4cfa52 Reviewed-on: https://code.wireshark.org/review/17961 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=48a66835ee4f319ba7806a542bb2cf1... commit 48a66835ee4f319ba7806a542bb2cf1f16a2ac06 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Sep 28 16:45:23 2016 -0700 Use wtap_read_bytes() to skip over bytes when reading a record. Allow file_read() to take a null pointer as a buffer argument; a null argument means "do everything except copy the bytes from the file to the user buffer". That means that wtap_read_bytes() and wtap_read_bytes_or_eof() also support a null pointer as a buffer argument. Use wtap_read_bytes() with a null buffer argument rather than file_skip() to skip forward over data. This fixes some places where files were mis-identified as ERF files, as the ERF open heuristics now get a short "read" error if they try to skip over more bytes than exist in the file. Change-Id: I4f73499d877c1f582e2bcf9b045034880cb09622 Reviewed-on: https://code.wireshark.org/review/17974 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a3ce2336b2a0e684a94d1e0046556bc... commit a3ce2336b2a0e684a94d1e0046556bc0b42748f2 Author: Birol Capa <birol.capa@siemens.com> Date: Tue Sep 27 17:20:41 2016 +0300 PROFINET: Fix possibly passing a null pointer to function A NULL pointer is possibly being passed to a function identified. Change-Id: I87afb4fcd669451d94fecbcb827e7ff82d3e6740 Reviewed-on: https://code.wireshark.org/review/17950 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=f72f937623e31ae4a59555573a24de8... commit f72f937623e31ae4a59555573a24de8ad603a965 Author: Simon Zhong <szhong.jnpr@gmail.com> Date: Tue Sep 27 17:28:53 2016 -0400 pcep: Added rfc 7334 support. Updated PCEP-ERROR Object Error Types and Values base on Path Computation Element Protocol (PCEP) Numbers 2016-08-09 version Change-Id: Ife0b49119a2b634279e33ab8f699a5dc57ecb34b Reviewed-on: https://code.wireshark.org/review/17957 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1e532f2f6f8c23f13e4c930727addd5... commit 1e532f2f6f8c23f13e4c930727addd5d4679ab6b Author: Marius Paliga <mareko.paliga@gmail.com> Date: Wed Sep 28 16:15:01 2016 +0200 Diameter: Add support for DRMP AVP Bug: 12961 Change-Id: I4d9abbae3893916fdd317263a74398d2242f53de Reviewed-on: https://code.wireshark.org/review/17969 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4aca4dc3192f4cbf17af7a4fb11d8b3... commit 4aca4dc3192f4cbf17af7a4fb11d8b30f0f77eef Author: AndersBroman <anders.broman@ericsson.com> Date: Wed Sep 28 14:38:41 2016 +0200 file_access: Use g_slist_prepend. Change-Id: I6ed0f384e130ec9181e43b6262bb21d91f944dfa Reviewed-on: https://code.wireshark.org/review/17968 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c3b25e8111dc304486537d7cc60e54b... commit c3b25e8111dc304486537d7cc60e54ba27c04fa0 Author: AndersBroman <anders.broman@ericsson.com> Date: Wed Sep 28 13:31:14 2016 +0200 Use g_slist_prepend, it should be faster if there's a lot of IP addresses Change-Id: I3861c0af24523315db6889b22ec93159174ba86f Reviewed-on: https://code.wireshark.org/review/17966 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4f636d100e35865fc7156ffb2ba6746... commit 4f636d100e35865fc7156ffb2ba674605d1b404c Author: Dario Lombardo <lomato@gmail.com> Date: Wed Sep 28 13:59:52 2016 +0200 eap: check scanf return value (CID 1373396). Change-Id: I4b602110fc3959dd7214fe15e9c37e3870794c1d Reviewed-on: https://code.wireshark.org/review/17967 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=148e4f77e9d528466e51d47c64acce1... commit 148e4f77e9d528466e51d47c64acce106c5be0e7 Author: AndersBroman <anders.broman@ericsson.com> Date: Wed Sep 28 12:09:58 2016 +0200 When regestering taps, only loop trough the list of taps once when adding new taps. Change-Id: Ida5ad2375c95664ee1b911d265cb69672db2be2d Reviewed-on: https://code.wireshark.org/review/17964 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=152e245804397bfcd0fc3e4cfac22e1... commit 152e245804397bfcd0fc3e4cfac22e1d49b0b169 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Sep 27 23:57:29 2016 +0200 proto_tree_add_item_ret_(u)int/proto_tree_add_bitmask_with_flags_ret_uint64: return real value Apply mask and bit shift on the returned value. Change-Id: I00aebc854756f01a25199a259d6d5252abea4349 Reviewed-on: https://code.wireshark.org/review/17958 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f8b32e5b4edac7c4ca9932aacef64b4... commit f8b32e5b4edac7c4ca9932aacef64b48e514b577 Author: Roland Knall <rknall@gmail.com> Date: Tue Sep 27 18:55:08 2016 +0200 checkAPIs.pl: Avoid false positive in header This avoids the text index being identified as shadow variable Bug:12956 Change-Id: I5565c5807e2c7d317d6849deeba9edd63c069397 Reviewed-on: https://code.wireshark.org/review/17953 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=e302f5ef6b74b1a8a5a78e129e7db4e... commit e302f5ef6b74b1a8a5a78e129e7db4efc3eea63a Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Sep 27 22:51:01 2016 +0200 tshark.c: fix indentation Change-Id: Ie44f76a063f375df4ae85642cd0d011a0e233d60 Reviewed-on: https://code.wireshark.org/review/17956 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e9b94ae81fffa686ac160223aebcb67... commit e9b94ae81fffa686ac160223aebcb67686415b77 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Sep 27 21:39:46 2016 +0200 tshark: register extcap preferences Bug: 12949 Change-Id: I95ef8a15a2d629bbb351d34dbfc730fa5ea62cd5 Reviewed-on: https://code.wireshark.org/review/17954 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5972c3d52960a737575ae9683316bef... commit 5972c3d52960a737575ae9683316bef0890cf181 Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Sep 27 11:01:14 2016 +0200 [proto.c] proto_all_finfos(), pre-allocate array to hold all fields. Change-Id: I0d41e417e57e656ccee1c2ce6bd406af4ed23d10 Reviewed-on: https://code.wireshark.org/review/17948 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=73a0ee0e41ce9f561d4f440902dc3ae... commit 73a0ee0e41ce9f561d4f440902dc3aebce3285c8 Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 22 09:24:38 2016 -0700 Qt+macOS: Look for San Francisco Mono Make San Francisco Mono the default monospace font on macOS. Note that we should look for Ubuntu Mono on that platform. Change-Id: I6f563099ae3797a7f73ea595158a2844581fbeec Reviewed-on: https://code.wireshark.org/review/17867 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d39d272e8002ce4346d554e39bf1b50... commit d39d272e8002ce4346d554e39bf1b5053df4a27e Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Sep 22 13:46:42 2016 +0200 TLS(1.3): Add Early Data (42) Hello extension Bug:12779 Change-Id: I97470c6e6be6e3df707cf2f3634f2c1e9da26bc2 Reviewed-on: https://code.wireshark.org/review/17885 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b5eb01c1a5219f075897b1cc5bc8f18... commit b5eb01c1a5219f075897b1cc5bc8f1883262af3b Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 24 13:09:36 2016 +0200 ssl: fix crash when setting RSA key file without valid protocol If ssl_association_add is passed a NULL app_handle argument, it will trigger DISSECTOR_ASSERT which fails due to the bad wmem scope (wmem_packet_scope). Arguably DISSECTOR_ASSERT should not be used there, but its alternative is g_warning/g_assert are not much different... Fix the crash (assertion failure) by checking that the UAT-supplied protocol is really valid. Normally the post_update_cb should not be invoked if any of the fields are invalid, but that requires larger changes in the Qt UAT dialog code. Change-Id: Ie245213b650b1de9640db8dadd08f3ed2bff335f Reviewed-on: https://code.wireshark.org/review/17906 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7bca5e168817f6f665e9aaec70ca377... commit 7bca5e168817f6f665e9aaec70ca37722c7afbea Author: Simon Zhong <szhong.jnpr@gmail.com> Date: Sat Sep 24 23:18:18 2016 -0400 pcep: Added missed pieces of RFC 6006 support. Added display Object-Type number in string. Change-Id: Icbb44aae2379f308f49bef7355e8c8c901889c15 Reviewed-on: https://code.wireshark.org/review/17910 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e239f72585896f301c2a23312f94cfc... commit e239f72585896f301c2a23312f94cfc50e421aed Author: Mirko Parthey <mirko.parthey@web.de> Date: Fri Sep 23 23:52:15 2016 +0200 ISAKMP: Rename identifiers and change item labels Rename identifiers and change item labels to reflect their purpose: * ISAKMP Phase 1 = IKE * ISAKMP Phase 2 = IPsec * IKEv2 Attribute = Transform Attribute Remove "transform" and "type" where they do not apply. External users of isakmp.tf.* field names, such as display filters, have to be updated after this commit to use isakmp.ipsec.* instead. old new -------------------------------------------------------------------- dissect_transform_attribute() dissect_ipsec_attribute() dissect_transform_ike_attribute() dissect_ike_attribute() ISAKMP_ IPSEC_ hf_isakmp_tf_attr hf_isakmp_ipsec_attr isakmp.tf. isakmp.ipsec. transform_ike_attr_type ike_attr_type transform_isakmp_attr_type ipsec_attr_type transform_attr_sa_life_type attr_life_type transform_dh_group_type dh_group transform_attr_encap_type ipsec_attr_encap_mode transform_attr_auth_type ipsec_attr_auth_algo transform_attr_ecn_type ipsec_attr_ecn_tunnel transform_attr_ext_seq_nbr_type ipsec_attr_ext_seq_nbr transform_attr_addr_preservation_type ipsec_attr_addr_preservation transform_attr_sa_direction_type ipsec_attr_sa_direction transform_attr_enc_type ike_attr_enc_algo transform_attr_hash_type ike_attr_hash_algo transform_attr_authmeth_type ike_attr_authmeth transform_attr_grp_type ike_attr_grp_type Type Payload Payload Transform IKE Attribute Type IKE Attribute Transform Attribute Type IPsec Attribute Transform IKE2 Attribute Type Transform Attribute Config Attribute Type Config Attribute ISAKMP (v1) IKEv1 ISAKMP (v2) IKEv2 -------------------------------------------------------------------- Change-Id: Ib02a0bad100f932a290cae35ea4bd75b191f797b Reviewed-on: https://code.wireshark.org/review/17914 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1a384ef4161470bf4a1af18da9b0b98... commit 1a384ef4161470bf4a1af18da9b0b98cbc9c7f56 Author: AndersBroman <anders.broman@ericsson.com> Date: Mon Sep 26 15:04:34 2016 +0200 [proto.c] Add proto_find_first_finfo() to find first occurance of a field. Change-Id: I11f50d7b00851880f77067260e2496175d227e76 Reviewed-on: https://code.wireshark.org/review/17937 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0a45d13652cd0f34a9cabfbc6dbbdc8... commit 0a45d13652cd0f34a9cabfbc6dbbdc8faaaf3554 Author: Gerald Combs <gerald@wireshark.org> Date: Mon Sep 26 16:19:42 2016 -0700 WiX: Try to fix development upgrades. Try enabling the MajorUpgrade:AllowSameVersionUpgrades attribute. This should keep the .msi packages from installing side by side when only the micro version differs. Change-Id: I37e8971d965ec1909c6baacb55d6a8062b13ff70 Reviewed-on: https://code.wireshark.org/review/17945 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=b725d6c9acc403dba30c72d20cf7103... commit b725d6c9acc403dba30c72d20cf7103e4f490334 Author: Gerald Combs <gerald@wireshark.org> Date: Mon Sep 26 10:34:04 2016 -0700 Add an initial "shellcheck" target. Look for shellcheck in Autotools and CMake, and if found add a target that checks some of our shell scripts. Add a "source=" directive to targets that include test-common.sh so that shellcheck will correctly process the scripts. Note that this requires shellcheck 0.4.0 or later. To do: Fix the issues that shellcheck found and check more scripts. Change-Id: I441f9f59d8a3f8eec6718119c2370f2560b98f3c Reviewed-on: https://code.wireshark.org/review/17943 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=06352a27b1ad2f9197b6193f97fad0c... commit 06352a27b1ad2f9197b6193f97fad0c6947cc6d6 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 26 14:39:45 2016 -0700 Reorganize the source lists. For the different classes of generated dissectors, have CLEAN_xxx_DISSECTOR_SRC with the ones that compile without warnings, DIRTY_xxx_DISSECTOR_SRC for the ones that get warnings, and xxx_DISSECTOR_SRC which is the combination of the two. Add a new NCP2222_DISSECTOR_SRC for the packet-ncp2222.c dissector generated by tools/ncp2222.py. Add a new source group for it. Move register.c to DISSECTOR_SUPPORT_SRC. Get rid of DISSECTOR_GENERATED_FILES; it's kind of a "none of the above" category, and we now have an "above" for all files. Include NCP2222_DISSECTOR_SRC in DISSECTOR_FILES. Add an ALL_DISSECTOR_SRC that includes DISSECTOR_FILES and CORBA_IDL_DISSECTOR_SRC (why are those kept separate?). Use it for the list of files we use to generate register.c. Add NCP2222_DISSECTOR_SRC to CLEAN_FILES. (Hopefully this makes it less likely that we'll forget to use -Werror for clean dissector files or forget to use them to generate register.c.) Change-Id: Ib9a7d10e1b9045516ef1f014046c6ff777c42be2 Reviewed-on: https://code.wireshark.org/review/17944 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7b279d26aa646e9d561bf9a0516b9a3... commit 7b279d26aa646e9d561bf9a0516b9a39130fa864 Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Sep 26 15:54:06 2016 +0200 Register ncp2222 dissector Otherwise a lot of ncp fields are missing. Bug: 12945 Fixes: v2.1.0rc0-2918-g2e23b50 ("Add checkAPI calls to CMake.") Change-Id: Ic46dc12c9a98b38d78ef988c0ce71f38e3163549 Reviewed-on: https://code.wireshark.org/review/17941 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Reviewed-by: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6fcce373b1cdbeac0ac4098ce0f2e51... commit 6fcce373b1cdbeac0ac4098ce0f2e51fd5999c29 Author: Dario Lombardo <lomato@gmail.com> Date: Thu Sep 15 09:51:42 2016 +0200 sshdump: restyle the output write routine. Bug: 12884 Change-Id: I90733bbcbbd8fafc0421b3fb9c6f9b48f178583c Reviewed-on: https://code.wireshark.org/review/17710 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0850c1f1db31efa02ff4383fb96d33e... commit 0850c1f1db31efa02ff4383fb96d33e1193d838b Author: Peter Palúch <Peter.Paluch@fri.uniza.sk> Date: Tue Sep 13 15:07:57 2016 +0200 BGP: Support for Cost, EIGRP and OSPF extended communities Bug: 12891 Change-Id: I70ed7f8a08122c559128b8df4d65e03be8201e1a Reviewed-on: https://code.wireshark.org/review/17683 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Palúch <Peter.Paluch@fri.uniza.sk> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=91ab8cf345b01acae69675dae34c6a2... commit 91ab8cf345b01acae69675dae34c6a2e7a6cedeb Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sun Sep 25 10:29:37 2016 +0200 btle: Fix Feature support bit positions From BT spec 4.2 volume 6 part B section 4.6, Feature support. Bug: 12946 Change-Id: I065e9bc9af88bb1daf53d26ae683d7ddedbb8ebf Reviewed-on: https://code.wireshark.org/review/17911 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=37a92ddebd9217f8e1cc2a758a5155c... commit 37a92ddebd9217f8e1cc2a758a5155c6a9924782 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sun Sep 25 22:18:06 2016 +0200 btle: Show full LL_VERSION_IND SubVersNr The BT spec does not specify a bitmask for Subversion Number. Change-Id: If6f384badc4228ea1e1c30ec8156f382ca5959e0 Reviewed-on: https://code.wireshark.org/review/17936 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=156584660b0e8b133385d34a90c78e6... commit 156584660b0e8b133385d34a90c78e6b378870fe Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sun Sep 25 20:17:29 2016 +0200 btle: Add LL_LENGTH_REQ/RSP control data Change-Id: Ib09232a25c70fc319b1df90dc09a89a34cf59c3e Reviewed-on: https://code.wireshark.org/review/17932 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=aeb112fde85197d4bf665d513d333ac... commit aeb112fde85197d4bf665d513d333ace0896c4f8 Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 25 11:21:57 2016 -0700 Do GArray bounds checking. Make sure we aren't going past the end of the array of per-interface packet counts. Change-Id: I6e19a5d375ebcc2193c37dc42c8f49836a5fd2c7 Reviewed-on: https://code.wireshark.org/review/17924 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=79ae8c1d07fe777a175269ed49d2ade... commit 79ae8c1d07fe777a175269ed49d2adee9c1d575b Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 25 11:02:27 2016 -0700 Report failure to compile a filter as an error. The NCP dissector relies on those filters being compiled, and we end up doing a g_assert() anyway; use g_error() to make sure the error gets printed. Change-Id: Ibc20407c1c08f0baaa626f269e9552ae11b36083 Ping-Bug: 12945 Reviewed-on: https://code.wireshark.org/review/17921 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f3fede009945dbe06ae5d1419f78876... commit f3fede009945dbe06ae5d1419f78876b3bef75cd Author: AndersBroman <a.broman@bredband.net> Date: Sun Sep 25 19:08:25 2016 +0200 [iscsi] Add a cast "packet-iscsi.c(625): warning C4267: 'function' : conversion from 'size_t' to 'guint', possible loss of data" Change-Id: I63ddf1384acdebc176a052489891d55d7a1b21ce Reviewed-on: https://code.wireshark.org/review/17920 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fce2531169e4e239c866ffa208722cf... commit fce2531169e4e239c866ffa208722cf84de4d8c5 Author: Gerald Combs <gerald@wireshark.org> Date: Sun Sep 25 08:12:59 2016 -0700 [Automatic update for 2016-09-25] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ie3096d67f82b93b751640e063ebe231fc235f83f Reviewed-on: https://code.wireshark.org/review/17917 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=e6ea68c72e681f10c73103ff8da8895... commit e6ea68c72e681f10c73103ff8da88954ed98e65e Author: Masashi Honma <masashi.honma@gmail.com> Date: Thu Sep 8 18:44:00 2016 +0900 ieee80211: Fix EOSP flag dissection for mesh case Change-Id: Ia8d4d74a7f0f5795790f930fc1e894a7ee202da7 Signed-off-by: Masashi Honma <masashi.honma@gmail.com> Reviewed-on: https://code.wireshark.org/review/17550 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0ee1445ada61c4b21b7abb70ee50050... commit 0ee1445ada61c4b21b7abb70ee50050a34932ac6 Author: rosemountSkp <rosemountSkp@code.wireshark.org> Date: Thu Aug 25 14:19:41 2016 +0000 Improve HART dissector Fixed short command 0 short address, command 0 that has less bytes, command 9 byte count, command 48 parse first 6 bytes instead of 5 and the command may has less bytes, pass correct byte count into the dissect_parse_hart_cmds() function. Added support HART published and NAK message types and more HART commands. Bug: 12817 Change-Id: I4a9e7f9b342346ff4ecdcd06a73238c1a08d00fc Reviewed-on: https://code.wireshark.org/review/17325 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=870822b9c61b984dbca72743fe37e30... commit 870822b9c61b984dbca72743fe37e30c401ea2e5 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 23 14:31:34 2016 +0200 eap: add imsi to wlan identity dissection. Change-Id: Ic8ff4e1846e8c0a11ee19ffbc4897635388dfa62 Reviewed-on: https://code.wireshark.org/review/17888 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=31cd04e901d6c730b00ecac231d828f... commit 31cd04e901d6c730b00ecac231d828fcc8bb5577 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 20 17:49:50 2016 +0200 ssh: use ws_strtoi function. Change-Id: Iafcb721eb6081902dd6b5c3a2258ae5c2ccd95e9 Reviewed-on: https://code.wireshark.org/review/17822 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8ca846436d14da6079a51da4111a860... commit 8ca846436d14da6079a51da4111a860e0f357c36 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Sep 21 15:03:28 2016 +0200 idl2wrs: use ws_strtou function Change-Id: I90173b0defc04ac80054170153afe9389def620b Reviewed-on: https://code.wireshark.org/review/17837 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3c9fb071191a211af756faedd7647cf... commit 3c9fb071191a211af756faedd7647cf80e542639 Author: Dario Lombardo <lomato@gmail.com> Date: Thu Sep 22 14:45:52 2016 +0200 iscsi: use ws_strtou functions. Add expert info for failed conversion. Change-Id: I03d5e2db791f81d43384bb047c268d07709a6099 Reviewed-on: https://code.wireshark.org/review/17863 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=06b09eea72ecbfe937a89a5887274e4... commit 06b09eea72ecbfe937a89a5887274e445b4c1bbf Author: Andreas Leibold <andreas.leibold@harman.com> Date: Mon Sep 12 14:51:51 2016 +0200 Changes to 1722.1 / MAAP to work with 1722 draft15 The C/D control flag was integrated in the subtype field of 1722 after draft 6. These changes are now added to the 1722-1 and MAAP protocol. Change-Id: I19b2e8237fb87d42ec7bcb6f9f53e8cc8605731d Reviewed-on: https://code.wireshark.org/review/17664 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=75ae538514f55f8faa114ce31fc5a2a... commit 75ae538514f55f8faa114ce31fc5a2a1d7b7ef22 Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 24 15:11:32 2016 +0200 ssl: fix exact matching of ALPN protocol names The "name_length >= alpn_proto->proto_name_len" condition always failed to match for short names (like "h2" where the reported length is 2, but the proto_name_len would be 3). This fixes recognition of HTTP/2 traffic, without this patch it would be interpreted as http-over-tls as reported on https://ask.wireshark.org/questions/55720/how-to-install-http2-dissector-plu... Change-Id: Idc3eae0b6d593c8f3c435230ef76da90a4b1e7fc Reviewed-on: https://code.wireshark.org/review/17907 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=46aba5a3407be21db89fff8ed3be4be... commit 46aba5a3407be21db89fff8ed3be4bed4883e806 Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 24 12:16:08 2016 +0200 doc: add the -d (decode as) option to wireshark(1) Text is partially copied from the tshark manual page. Change-Id: I120e327f15394fc48fce6e4a122e7eab83e91c82 Reviewed-on: https://code.wireshark.org/review/17904 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cacb4a428715b6a77ddee50d87d5dff... commit cacb4a428715b6a77ddee50d87d5dffe1f83557c Author: Uli Heilmeier <uh@heilmeier.eu> Date: Sat Sep 24 11:17:17 2016 +0200 Editcap: Fix comparsion between signed and unsigned int secs_per_block is a unsigned integer. Therefore we can't compare a signed integer with it. Change-Id: Ic965a88e0e704e296c4af9193ca4a3504173ae36 Reviewed-on: https://code.wireshark.org/review/17901 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=17546ad88378fbeaad25e571e0fa35e... commit 17546ad88378fbeaad25e571e0fa35e7a5bfa622 Author: Gerald Combs <gerald@wireshark.org> Date: Wed Sep 21 15:38:16 2016 -0700 Check for ASAN when fuzzing. Try to determine if we passed -fsanitize=address to gcc or clang and adjust the ASAN variable fuzz-test.sh, randpkt-test.sh and test-captures.sh accordingly. Change-Id: I88a34828fb5875e1a74a3b180ffb3da37daac0bd Reviewed-on: https://code.wireshark.org/review/17848 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8b047554ee93fbbf7731da371df0779... commit 8b047554ee93fbbf7731da371df0779acc9fc87a Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 24 11:51:24 2016 +0200 ssl-utils: fix decryption of NULL ciphers A dissector bug was reported: epan/dissectors/packet-ssl-utils.c:1615: failed assertion "data" and fair enough, the MAC Key is indeed NULL because of our special handling for NULL ciphers. Just ignore the MAC key then. Change-Id: I12d2be5e84520badb44a99fc965c48c3afa89346 Fixes: v2.3.0rc0-697-gb1d36fe ("ssl-utils: remove block and key sizes from cipher suites table") Reviewed-on: https://code.wireshark.org/review/17903 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ca232b1d129f55a65c53bddb1f21520... commit ca232b1d129f55a65c53bddb1f215208a32c2ec6 Author: Uli Heilmeier <uh@heilmeier.eu> Date: Sat Sep 24 11:03:53 2016 +0200 Udpdump: Fix g_debug() for ssize_t buflen Using %lu for ssize_t throws an error. This commit change it to %zd. Change-Id: I19ae72fe0836424bcb93e912e9b1757df4ae5fb1 Reviewed-on: https://code.wireshark.org/review/17900 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=989dcef3175267c6db4f9256c6a61ce... commit 989dcef3175267c6db4f9256c6a61ce8640f132f Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 23 08:07:42 2016 +0200 TLS: Update Hello ExtensionType list use same name and display in dec from http://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-v... Change-Id: Ia4a959571204b611dbf275311c9ce58c594b6716 Reviewed-on: https://code.wireshark.org/review/17886 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=1a3f1d08fd8fad8485dac5811ba6363... commit 1a3f1d08fd8fad8485dac5811ba636370c66de7e Author: Dirk Jagdmann <doj@cubic.org> Date: Thu Sep 22 23:32:53 2016 -0700 update description of PDML file format by updating URLs to external documentation. Also mention the pdml2html.xsl file. Change-Id: I44894f52771939bf9f861abf19bcb8bc589e37eb Reviewed-on: https://code.wireshark.org/review/17894 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=575e36324c700ac89cb11ff4e70dcfe... commit 575e36324c700ac89cb11ff4e70dcfe542ad753c Author: Gerald Combs <gerald@wireshark.org> Date: Fri Sep 23 17:45:39 2016 -0700 WiX: Disable desktop icon and shortcut checkboxes. Enable and disable the Wireshark and Wireshark-gtk desktop icon and shortcut checkboxes depending on our feature selections to match the NSIS installer behavior (and make sense). Set the level of "Fe.WiresharkGTK" to 2 so that it's disabled by default. This roughly matches the behavior of the NSIS installer. Note that we can't enable or disable radio buttons. Change-Id: I1c73f901344e21bd62e67890ce544f644c0cdda6 Reviewed-on: https://code.wireshark.org/review/17898 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a1b04ad228b11994e6f3452d0a2ed11... commit a1b04ad228b11994e6f3452d0a2ed11ddefb582a Author: Gerald Combs <gerald@wireshark.org> Date: Fri Sep 23 15:51:44 2016 -0700 More WSDG layout & markup fixups. Change-Id: I7b404be25d20c28c7dca23d57f9670236a5855c2 Reviewed-on: https://code.wireshark.org/review/17897 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=2b9cb53b39979d074ab3d2f4f541ea9... commit 2b9cb53b39979d074ab3d2f4f541ea9d5edf36fd Author: Gerald Combs <gerald@wireshark.org> Date: Fri Sep 23 15:17:28 2016 -0700 WSDG: Fixup PDF layout. Change-Id: I62653e6a5934e5bd77bf6663610124cb82e95c44 Reviewed-on: https://code.wireshark.org/review/17896 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=d1b99809b52a8942609cdf54905d848... commit d1b99809b52a8942609cdf54905d848a9c6c12c3 Author: szhong <szhong.jnpr@gmail.com> Date: Sat Sep 17 23:24:30 2016 -0400 pcep: add Conveying Vendor-Specific Constraints (RFC7470) support Added capability to expand Private Enterprise Number to string. Change-Id: Id3df604a47c3067febb878caf89087aa00ecf038 Reviewed-on: https://code.wireshark.org/review/17770 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d390db98183247c4460575caac20e83... commit d390db98183247c4460575caac20e834cba2862e Author: Gerald Combs <gerald@wireshark.org> Date: Fri Sep 23 09:28:41 2016 -0700 WSUG: More layout and PDF fixes. Set variablelist.as.blocks in custom_layer_pdf.xsl so that we don't end up with list text squeezed into tiny columns on the right. Set column widths for most of our tables. Change-Id: I3fe47d945a7945618012c9de1fc0e97b788dea9e Reviewed-on: https://code.wireshark.org/review/17893 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=2e0cbb7ae72fd9d944ff9343483b6f5... commit 2e0cbb7ae72fd9d944ff9343483b6f5df0564b61 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 23 08:12:13 2016 +0200 TLS: use define value for ssl_versions value string and also move on the top and not too far from ssl_version_short value_string Change-Id: I9012d0d0839fd29da500a7f37a83ecc982f0fb5b Reviewed-on: https://code.wireshark.org/review/17887 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=cc50515e57162d2ef740aa6e725e06f... commit cc50515e57162d2ef740aa6e725e06f2b0c21293 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Fri Sep 23 08:13:28 2016 +0200 Show memory info on macOS and Linux Added support for showing memory information (amount of physical memory) in version information on macOS and Linux. Moved CPU info and memory info right after OS version info. Change-Id: I305d1b7d015d50ed137f2c80b31d698e9315d735 Reviewed-on: https://code.wireshark.org/review/17884 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2fa327ae0ca84368086922e4869e4fa... commit 2fa327ae0ca84368086922e4869e4fa739b1f1f3 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 23 10:18:14 2016 +0200 eap: fix cast warning. Change-Id: I94a4a927c91552f58ecec3d0d78efcf699bf77de Reviewed-on: https://code.wireshark.org/review/17881 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0703c7b4145f1ec23172b261356ca65... commit 0703c7b4145f1ec23172b261356ca65bb17d12dc Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Thu Sep 22 13:23:37 2016 +0200 dumpcap: Include CPU info as hardware description in SHB Add CPU info as hardware description in session header block when using pcapng. Use capture_comment from the capture_options structure when using ring buffer. Change-Id: I5e688fc2d6ab61de1f64ad9a8a96e6e39e8cf708 Reviewed-on: https://code.wireshark.org/review/17862 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=00c862e4056be43d91beb2c6b66b996... commit 00c862e4056be43d91beb2c6b66b996140e5d280 Author: Mikael Kanstrup <mikael.kanstrup@gmail.com> Date: Wed Sep 14 14:13:20 2016 +0200 capchild: Support optional 802.11 channel parameters Document the the 802.11 set channel function and its parameters. Add support for optional parameters. Bug: 12896 Change-Id: I95966f99149aa9c1502d97b5707dcc8c2f5b26e8 Reviewed-on: https://code.wireshark.org/review/17699 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b6a2915d0d5a7ab1524a49b216290f1... commit b6a2915d0d5a7ab1524a49b216290f1e33feb19b Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 18 16:19:58 2016 +0200 mate: fix Match edge cases, improve documentation Use strcmp to sort AVPs in an AVPL and for matching instead of comparing pointer addresses. Pointers can only be used for (in)equality, there is no ordering in them. Matching of attributes however requires a better ordering to know whether the operator (condition) or whether the operand (data) can be skipped. Otherwise it is possible that condition (b) randomly fails to match data (a,b). User-visible changes (mainly edge cases): - Loose (a=1, a?) on data (a=0, a=1) would previously fail to return (a=0,a=1) because the a? condition is not tried for data a=0. Now it tries all compatible conditions for a data AVP. - Any Match condition like (a=1, a^1) would previously be treated the same as (a=1) while (a^1, a=1) would still be seen as (a^1, a=1). The first case is now fixed to match (a=1, a^1). (Via a fix in insert_avp to ensure that (a=1) is not considered the same as (a^1).) - Every (a=1, a=2) on data (a=1, b=1) previously failed, but the comment "it will not create a list if there is not a match for every attribute in op" suggests that it should return (a=1). - Every (a=1) on data (a=2) previously succeeded (bug) while it would fail on (a=2, b=1). This is fixed now by checking whether any of the conditions really have matching data for the attribute. Other changes: optimize merge_avpl and new_avpl_*_match to insert in linear time instead of quadratic, rewrite and add comments in an attempt to make it easier to understand. Merge the new_avpl_every_match and new_avpl_exact_match functions and rename it to new_avpl_pairs_match to reflects its actual implemented functionality. Not addressed in this patch is the quasi-randomness of the returned data AVPL. AVPLs are unordered, so the condition Strict (a?) on data (a=1, a=2) could in theory return either (a=1) or (a=2). In practice this returns (a=1) because of alphabetical ordering, but this cannot really be relied on. It gets worse for conditions like Strict (a?, a>1), these are considered undefined behavior (without warnings for now). Ping-Bug: 12184 Change-Id: I0008448ffcb96183f106cb937c4f488e26a82f92 Reviewed-on: https://code.wireshark.org/review/17777 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=064f4d18dbc2cba6452d69bd354da2f... commit 064f4d18dbc2cba6452d69bd354da2ff234b4182 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Sep 19 14:40:11 2016 +0200 eap: dissect eap wlan identity. EAP identities can be of different kind. This change adds a sort of heuristic that dissects the wlan identity in the form of <imsi>@wlan.mnc<mnc>.mcc<mcc>.3gppnetwork.org. A general purpose dissection function, acting as a proxy, has been created to make room for other specific dissections. Bug: 12921 Change-Id: Ic48aee004fa7df5ee4dbeca091ed31616d155890 Reviewed-on: https://code.wireshark.org/review/17796 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1ec28b4a084112e6ca4971300f17354... commit 1ec28b4a084112e6ca4971300f17354e8c6cee3c Author: Stefan Metzmacher <metze@samba.org> Date: Mon Sep 19 04:35:49 2016 +0200 packet-dcerpc: let dissect_dcerpc_cn_auth() always dissect the whole auth_info As all this information belongs together I'm moving it into a subtree. Change-Id: I839a5a6294360976a78b4b43f219e30381b4f516 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/17878 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=68dbc6431f5b391c05f27641ad5c11c... commit 68dbc6431f5b391c05f27641ad5c11c378739648 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Aug 21 16:50:15 2016 +0200 ISAKMP: fix Argument with 'nonnull' attribute passed null found by Clang Analyzer Change-Id: I8d7ebc6dd46e0d6494d412653ec423b8c0fde9c8 Reviewed-on: https://code.wireshark.org/review/17203 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a2329b187b640d39d8dbd93cfe21eee... commit a2329b187b640d39d8dbd93cfe21eeeb954d82fa Author: Gerald Combs <gerald@zing.org> Date: Thu Sep 22 18:37:01 2016 -0700 WSDG: Layout and content updates. Adjust the column widths of some tables to that they render more cleanly and without FOP warnings. Move some table content to plain text instead of trying to shove it into table cells. Fix some other layout and formatting. Change-Id: I40e40fd7ca5c3cc594ea30c8b1ad233afd4cdca4 Reviewed-on: https://code.wireshark.org/review/17880 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=e0bc5b1c3e167a29d383c4f010ce91b... commit e0bc5b1c3e167a29d383c4f010ce91b57dc58a63 Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 22 15:43:37 2016 -0700 WSDG: Adjust markup and fix FOP warnings Wrap monospace text in our PDF output. Fix the formatting of a list. Fix an anchor reference. Change-Id: Id9433f3e3462569299e6702b4a4e137481ad80c4 Reviewed-on: https://code.wireshark.org/review/17877 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=eeb4361e57e01d03a655433c9e75388... commit eeb4361e57e01d03a655433c9e75388d93bb9f6f Author: Priyanka Mondal <priyanka02010@gmail.com> Date: Thu Sep 22 14:43:12 2016 +0530 Dropped packet: Add dropped packets info in netscaler trace Change-Id: I2a9806026413c5971e5ecad17cd80787130cb9ed Reviewed-on: https://code.wireshark.org/review/17803 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a156a0021d42d90130506e7e589ac47... commit a156a0021d42d90130506e7e589ac4782d31bee8 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Sep 22 09:18:21 2016 +0200 CDP: Add CDP over GRE http://www.cisco.com/c/en/us/td/docs/wireless/access_point/15-3-3-JB/configu... Bug:12934 Change-Id: If6498446c86f509a44dc28d3c2e4d86cc61cd167 Reviewed-on: https://code.wireshark.org/review/17853 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0b1fd7e8fb267c19eebe484db31a724... commit 0b1fd7e8fb267c19eebe484db31a7240781a7023 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 22 22:09:13 2016 +0200 6LowPAN: initialize interface identifier even when no data-link source is found Bug: 12939 Change-Id: Ib4e8adbff3e335e602da5e6857bfc801601fd25e Reviewed-on: https://code.wireshark.org/review/17871 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=76d97c39c9be04ff2ed599cc3d15b7f... commit 76d97c39c9be04ff2ed599cc3d15b7fddbf080f6 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 22 13:54:13 2016 -0700 Fix the "do we have Xcode?" test for older versions of Xcode. Change-Id: I35853b6cb2985bf9bc36175ec8085929e66db349 Reviewed-on: https://code.wireshark.org/review/17872 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=14fcb720ddac2bd91f5306d20452908... commit 14fcb720ddac2bd91f5306d20452908e37d168e8 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 22 21:01:52 2016 +0200 BTHCI ACL: ensure to initialize the full bthci_acl_data_t structure Change-Id: Ie1a020bf5dddde3f9476a6fdf307da9effb4bf8c Ping-Bug: 12939 Reviewed-on: https://code.wireshark.org/review/17870 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8438c1d5a6a91d1c60efdb4922f65f2... commit 8438c1d5a6a91d1c60efdb4922f65f21e48b9dbc Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 22 20:39:46 2016 +0200 LDSS: fix a memory leak caught by ASan Change-Id: I988b0ac0fbadb782c1ba499a086c29522a564618 Reviewed-on: https://code.wireshark.org/review/17869 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cf12e448b1721143d0232c5d866a973... commit cf12e448b1721143d0232c5d866a973862cab139 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 22 20:14:25 2016 +0200 proto.c: avoid dereferencing a NULL pointer Some sub protocols do not register fields Follow-up of gf4a521e Change-Id: Iec3165d6204cc6acc0ec31a7266f860012463cd0 Reviewed-on: https://code.wireshark.org/review/17868 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7477e1c3b90cedfe0d154f5b4c8eb9e... commit 7477e1c3b90cedfe0d154f5b4c8eb9e5d7e26b59 Author: Birol Capa <birol.capa@siemens.com> Date: Thu Sep 22 16:42:39 2016 +0300 Fix Profinet RPCInterfaceUUID decoding The translation of all RPCInterfaceUUID for PNIO evaluates to "PNIO". However, UUID allows distinction of - UUID_IO_DeviceInterface (IOD-IF) - UUID_IO_ControllerInterface (IOC-IF) - UUID_IO_SupervisorInterface (IOS-IF) - UUID_IO_ParameterServerInterface (PServ-IF) Bug: 12938 Change-Id: I97c27808f61abd96728421488bb0ee5fdbace566 Reviewed-on: https://code.wireshark.org/review/17865 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f4a521ee74f01063fe2738ff5a975d5... commit f4a521ee74f01063fe2738ff5a975d5a833ab85e Author: AndersBroman <anders.broman@ericsson.com> Date: Thu Sep 22 16:18:03 2016 +0200 [proto.c] As we know the size of the hf array use g_ptr_array_sized_new() to allocate the arry to hold them. This should be more efficient. Change-Id: I84b1095b6eb110fdcc1b2630949c76b51f3a47b6 Reviewed-on: https://code.wireshark.org/review/17866 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0b3d6793681fb351cd6e726d3323839... commit 0b3d6793681fb351cd6e726d3323839cb0d86e64 Author: AndersBroman <anders.broman@ericsson.com> Date: Thu Sep 22 15:25:07 2016 +0200 Don't call proto_register_field_array() or expert_register_protocol() with proto = -1 Change-Id: I60f899ad748b5d3e17f237552af7d2dbc8f27bd2 Reviewed-on: https://code.wireshark.org/review/17864 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d29b369bdcdf5bbc3f22b46e3ba0734... commit d29b369bdcdf5bbc3f22b46e3ba0734c630dd3ad Author: Michael Mann <mmann78@netscape.net> Date: Wed Sep 21 23:16:58 2016 -0400 Add range_add_value and range_remove_value. These APIs can insert or remove a single value into a range structure. Adding a value may extend an existing range or create a new one. Removing a value may remove a range item. Change-Id: Ia6995ecf7760aca1fb7fd9b4c53972298a57675f Reviewed-on: https://code.wireshark.org/review/17836 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=69dfe97251cea64ba7a1506f5ca51bf... commit 69dfe97251cea64ba7a1506f5ca51bfed2bf24b3 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Sep 22 11:14:53 2016 +0200 iwarp: Add RDMA Atomic operations (RFC 7306) Bug:12928 Change-Id: Id3f9e41a62a90e36f19e1d55226826e7f9ffa3f4 Reviewed-on: https://code.wireshark.org/review/17855 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=46595f4ad07e7bc9080497e860c969b... commit 46595f4ad07e7bc9080497e860c969b570bea676 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 22 03:11:17 2016 -0700 Point people to the Mac App Store for Xcode. Don't give a URL that doesn't work any more. Change-Id: I3d2dbef2dda4a96aff9382e687eb8eb64218d14d Reviewed-on: https://code.wireshark.org/review/17859 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4e53f5d975d184e6813d3dfb25b8c06... commit 4e53f5d975d184e6813d3dfb25b8c06fc046dbd7 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 22 02:59:53 2016 -0700 Make it detect command-line-toos-only installations. /usr/bin/xcodebuild is present, but appears not to work, if you have only the command-line tools for Xcode 8 installed, not Xcode 8 itself. Change-Id: I4a55e30f8afcc7e575e661d2b4ea944c967790ec Reviewed-on: https://code.wireshark.org/review/17856 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=dedf926540ab3b828e314f0f7b8d280... commit dedf926540ab3b828e314f0f7b8d2809a8f0d4f2 Author: Juanjo Martin <juanjo@rti.com> Date: Tue Sep 20 13:32:46 2016 +0200 RTPS: Added DTLS locator dissection Change-Id: I168d728a56479bd3eeac4baa2d7708dbc3d09bed Reviewed-on: https://code.wireshark.org/review/17814 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=48a075b10496ff77fd3f46cf79cc17b... commit 48a075b10496ff77fd3f46cf79cc17b9f61aa6b6 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Sep 22 10:05:53 2016 +0200 MACsec: Fix typo macsec/MACSEC => MACsec Change-Id: I1016396edaf3f8bf025dd9b840d0d2f588546d49 Reviewed-on: https://code.wireshark.org/review/17854 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5b4ca98a5410d9c33be2aa54490ba57... commit 5b4ca98a5410d9c33be2aa54490ba57239ae73a7 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sun Sep 18 20:10:14 2016 +0200 Qt: Optimized setColumnVisibility() usage Setting column visibility (show/hide columns) is only needed when columns has changed and when show/hide from column popup menu. Change-Id: Ia33d6fccab44443c453921fc2629bbf1d22efd01 Reviewed-on: https://code.wireshark.org/review/17781 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=b9d493f8de1cadfce591cdc20613c3e... commit b9d493f8de1cadfce591cdc20613c3ee8896c4cf Author: AndersBroman <anders.broman@ericsson.com> Date: Wed Sep 21 18:26:16 2016 +0200 [print.c] Use pinfo and frame_info to print geninfo. Change-Id: Ie77292bfb2d962b326cb4dd9273d7258586f18b5 Reviewed-on: https://code.wireshark.org/review/17841 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fe1d0060167993ea8d70710b318783b... commit fe1d0060167993ea8d70710b318783b04168b4f3 Author: AndersBroman <anders.broman@ericsson.com> Date: Wed Sep 21 17:36:23 2016 +0200 [print.c] Get timestamp directly from pinfo rather than going via field info. Change-Id: I266775b0880931bbce5ec0ed9bc9d8b0dbce7246 Reviewed-on: https://code.wireshark.org/review/17840 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bf95ccca2eb903b81f3ddd0de7e21c4... commit bf95ccca2eb903b81f3ddd0de7e21c42d687a64c Author: Guy Harris <guy@alum.mit.edu> Date: Wed Sep 21 20:48:37 2016 -0700 Don't mention a particular version of XQuartz. The version we were using is out of date and, because we don't download it in the script, we don't *need* the version, we can just point people to http://www.xquartz.org. Change-Id: I049e55c11a6877a1ad888288a157cc8527740b16 Reviewed-on: https://code.wireshark.org/review/17850 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=479323072cdddb21f950943e3a4a246... commit 479323072cdddb21f950943e3a4a2462a7027b02 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 20 17:28:01 2016 +0200 gsm_map: use ws_strtoi in template. Change-Id: I682955b3c58695d831d6d8013eaa77d347a0ec2e Reviewed-on: https://code.wireshark.org/review/17820 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f87d1ab69996753e4c40854bac9aecb... commit f87d1ab69996753e4c40854bac9aecbfd7cc0c98 Author: Gerald Combs <gerald@wireshark.org> Date: Wed Sep 21 17:25:32 2016 -0700 WiX: Fix condition logic. The condition expressions in g630b646 were incorrect. Fix them. This also lets us make the error messages more verbose, so do so. Add a hint about debugging. Change-Id: I74d4b9cfb1bc9afb23be4d61ac190f90e7048745 Reviewed-on: https://code.wireshark.org/review/17849 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f513dd35c1a3a588392c542a5331b01... commit f513dd35c1a3a588392c542a5331b0137dae3eff Author: Davide Caratti <davide.caratti@gmail.com> Date: Wed Sep 21 01:26:52 2016 +0200 ethertype: add missing value_string row for MACSEC Change-Id: Ie062054249d847e4cc430818ce2deca96b2c7d90 Reviewed-on: https://code.wireshark.org/review/17845 Reviewed-by: d. caratti <davide.caratti@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=876bca186bdce5bb2f3f5b3b5200ef0... commit 876bca186bdce5bb2f3f5b3b5200ef0a83bf5683 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Sep 21 14:43:20 2016 -0700 Add a -a flag to use if TShark was built with ASan. We mustn't set the virtual address space limit if that's the case, as ASan consumes a ton of address space. Clean up a comment while we're at it. Change-Id: I7e88135f16b21cb091a73a35de70bee757fb3876 Reviewed-on: https://code.wireshark.org/review/17847 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ec0aeb983b0efc2d2e5e24209a3a0fc... commit ec0aeb983b0efc2d2e5e24209a3a0fc198b353d2 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Sep 21 14:41:04 2016 -0700 Set the VA limit with ulimit -S, and clean up comments. Other limits are set with -S, do that with the virtual address space limit as well. Change-Id: Ie427341a4c7be56d3e8d96be6c1713c56e9bad87 Reviewed-on: https://code.wireshark.org/review/17846 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c2b7a74c149241a5fa490d9201c04a9... commit c2b7a74c149241a5fa490d9201c04a987e3d3f63 Author: Olga Kornievskaia <olga.kornievskaia@gmail.com> Date: Wed Sep 21 13:17:42 2016 -0400 nfs: Fixing OFFLOAD_STATUS reply decoding commit b5aa0ff1a4e84c15f6c159e4900e84bd563570b4 nfs: Add NFSv4.2 ops OFFLOAD_CANCEL and OFFLOAD_STATUS As coded, the reply of the OFFLOAD_STATUS decodes a stateid. However, in the spec, the reply is count and an array of statuses. I propose the following fix to match the spec for the OFFLOAD_STATUS. Change-Id: Ibaddba96446b8d9b520ca977f0b1ed66749d3388 Reviewed-on: https://code.wireshark.org/review/17805 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=eafa0a061d614541b8ad230289657aa... commit eafa0a061d614541b8ad230289657aaf185033c7 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Wed Sep 21 21:22:57 2016 +0200 dmp: Restore checksum incorrect info The "Checksum incorrect" note in COL_INFO was inadvertently broken in gad6fc87d6. Change-Id: I064c3c79aa3e1ae72d3a8167538e709d0b5fe94a Reviewed-on: https://code.wireshark.org/review/17842 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=2e4024263622ed67b0dfd1d275ddab8... commit 2e4024263622ed67b0dfd1d275ddab87549128cd Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 6 09:58:48 2016 +0200 capture_sync: use ws_strtou function. Change-Id: Ic128a7f1afd85f6b737392ff76b40d54cbdd8971 Reviewed-on: https://code.wireshark.org/review/17523 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=4528da9f0112d7107b00de48ff71877... commit 4528da9f0112d7107b00de48ff71877b9be983bc Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Sep 21 14:19:07 2016 +0200 Diameter: fix a typo in AVP TGPP 1656 Bug: 12927 Change-Id: I6a6507d7b3b0321d2d12d3d306003e480070e79e Reviewed-on: https://code.wireshark.org/review/17833 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b9d4a18ad2f10cc9216d8131d9e1ddc... commit b9d4a18ad2f10cc9216d8131d9e1ddc89bfc50ac Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Sep 20 14:14:38 2016 +0200 TLS: no extension length on padding extension also remove padding function (don't needed) Bug: 12922 Change-Id: Ie049ee21193ec82b8dc873a7dff78e9d058c7935 Reviewed-on: https://code.wireshark.org/review/17825 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=7be73201a044e8228de8e91a5f8708e... commit 7be73201a044e8228de8e91a5f8708ebcd761015 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Sep 21 11:09:43 2016 +0200 BTL2AP: compare strings with strcmp, not memcp Otherwise a string shorter than 7 characters will trigger an out of bounds access Bug: 12825 Change-Id: I54a7909d74838dcb56583374e5753f877ff74fe2 Reviewed-on: https://code.wireshark.org/review/17826 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> http://cgit.osmocom.org/wireshark/commit/?id=c2c8dc38fee6d33a2e926aa05a3e3f7... commit c2c8dc38fee6d33a2e926aa05a3e3f7ef1723db2 Author: AndersBroman <anders.broman@ericsson.com> Date: Wed Sep 21 13:15:32 2016 +0200 [Diameter AVPs] Correct 3GPP AVPs 1655. 1656 531 and 532 Bug: 12927 Change-Id: I545d5c54396431ab67f78fbc31111460d758f8b1 Reviewed-on: https://code.wireshark.org/review/17827 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=73899237f0ef8b70c05608ac57c7722... commit 73899237f0ef8b70c05608ac57c7722a7016e271 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 20 17:37:41 2016 +0200 camel: use ws_strtoi in template. Change-Id: Ida61cc61d6a6a1c34eb42ceaba31621276f93966 Reviewed-on: https://code.wireshark.org/review/17821 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=920df263e34c2c1f2015566d44c1c6b... commit 920df263e34c2c1f2015566d44c1c6bd0cedfaaf Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Sep 20 15:39:06 2016 +0200 [GTPv2] Export dissect_gtpv2_tai() Change-Id: I3ec15b0411d8e9639cc31b36aa25ce74054395da Reviewed-on: https://code.wireshark.org/review/17819 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=962c3b20c26b575168c0fc677594fe2... commit 962c3b20c26b575168c0fc677594fe203e87917d Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Sep 20 14:35:38 2016 +0200 [GTPv2] Export dissect_gtpv2_tai() Change-Id: If4daaf8d53734c00ba922ca61d21db3c09e859d1 Reviewed-on: https://code.wireshark.org/review/17818 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7933d8002be6abca18cb31c7a2a3076... commit 7933d8002be6abca18cb31c7a2a3076725cc53e1 Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Sep 20 14:31:05 2016 +0200 [Diameter 3GPP] hf_diameter_3gpp_feature_list1_sh_flags_spare_bits missing bitmask. Change-Id: I999fb71a26e90a46e11bd2907c3fcb8566e92562 Reviewed-on: https://code.wireshark.org/review/17817 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ece9c286195df796e6e42325e1664f3... commit ece9c286195df796e6e42325e1664f3336f2611d Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Sep 15 08:04:14 2016 +0200 selfm: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I758ff81bdfcb9c18810baad12554d7f7f0e7705f Reviewed-on: https://code.wireshark.org/review/17707 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=980a0a300ac14794c5d378e2b069633... commit 980a0a300ac14794c5d378e2b0696339cbe83ae7 Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Sep 20 13:43:37 2016 +0200 Add define for vendor dacom Change-Id: Ie7411d4d41e3f0a0ea98ed4a14d40c5715535c8a Reviewed-on: https://code.wireshark.org/review/17815 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b83c730ff0fac672d8623ebb5e6129d... commit b83c730ff0fac672d8623ebb5e6129de370dd1a6 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Aug 26 10:33:43 2016 +0200 TLS(1.3): Add Pre-Shared Key (41) Hello extension Bug: 12779 Change-Id: I64ef80db0a8b51ee569fed3b87099144e57eedc2 Reviewed-on: https://code.wireshark.org/review/17320 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=811bb3302bf503523f51c219226426f... commit 811bb3302bf503523f51c219226426feb63b7a18 Author: Hauke Mehrtens <hauke.mehrtens@intel.com> Date: Wed Aug 31 20:06:49 2016 +0200 netlink: make dissect_netlink_attributes() endianness aware Always give the netlink data struct to dissect_netlink_attributes() so we can extract which endianness we should use. This fixes the netlink dissector on big endian. Change-Id: Ia485a29035c947908c29a9e30d0aba8d4fc94093 Signed-off-by: Hauke Mehrtens <hauke.mehrtens@intel.com> Reviewed-on: https://code.wireshark.org/review/17636 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=b1bbfaa9f72f77c9cee48b6f078bf42... commit b1bbfaa9f72f77c9cee48b6f078bf42f9895e47b Author: Hauke Mehrtens <hauke.mehrtens@intel.com> Date: Wed Aug 31 19:44:25 2016 +0200 netlink: try to detect endianness There is no field which indicates which endianness is used for netlink data, try to guess it by checking if the length in little or big endian fits better. Change-Id: I02884763931f3f3589b7ac5bff2781797c1d0f87 Signed-off-by: Hauke Mehrtens <hauke.mehrtens@intel.com> Reviewed-on: https://code.wireshark.org/review/17635 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=927a050979fc94d8ad29f03570371ca... commit 927a050979fc94d8ad29f03570371ca1460bb804 Author: Chris Bontje <cbontje@gmail.com> Date: Wed Sep 14 11:58:47 2016 -0600 [SELFM] - Further additions to re-assembly efforts (Multiple PDUs spanning additional TCP packets) Change-Id: I35db77ee05c3c873577b4f40c41f283e5666a4e2 Reviewed-on: https://code.wireshark.org/review/17701 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e4a230aad2d23db35f6b61f2fcd3188... commit e4a230aad2d23db35f6b61f2fcd318803e2a83dd Author: Gerald Combs <gerald@wireshark.org> Date: Mon Sep 19 15:05:18 2016 -0700 Move the rest of README.qt to the WSDG. Change-Id: I8ba0dc0170141db0b96cac996e5ad5f0bd3253ea Reviewed-on: https://code.wireshark.org/review/17806 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=eb4c70616f5b1de32f8b1d963ae0bff... commit eb4c70616f5b1de32f8b1d963ae0bff5a5f20a7d Author: Stefan Metzmacher <metze@samba.org> Date: Tue Sep 20 02:41:46 2016 +0200 packet-dcerpc: dissect the auth verifier of PDU_CO_CANCEL, PDU_ORPHANED and PDU_FAULT Change-Id: I28325d655ccd5d363aac89e49e5333b3d75f68a2 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/17810 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=01d80d649f6c84692ddebf9cd5cf90c... commit 01d80d649f6c84692ddebf9cd5cf90c02a2033c6 Author: Stefan Metzmacher <metze@samba.org> Date: Sun Sep 18 20:25:52 2016 +0200 packet-dcerpc: The opnum field is generated for PDU_RESP and PDU_FAULT Change-Id: Ieeb9de0f54a22afc3adcd52d8af2c45e8b82b0ab Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/17808 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9058363ed7e99db7a36b9ab8f03ceb6... commit 9058363ed7e99db7a36b9ab8f03ceb635a6cb94e Author: Stefan Metzmacher <metze@samba.org> Date: Tue Sep 20 02:29:16 2016 +0200 packet-dcerpc: nca_s_fault_sec_pkg_error Change-Id: I951a317da795c94ac6518be73cb2c836e7afb836 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/17807 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4ed3518c052f2b17cb35bc5aaa5c819... commit 4ed3518c052f2b17cb35bc5aaa5c819dcfe9603c Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Mon Sep 19 21:12:34 2016 +0200 Qt: Added option to Remove from recent files list Change-Id: If87e1bf4796d45582bc2490720683e4072971f56 Reviewed-on: https://code.wireshark.org/review/17804 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=cdfc47d58dd52d028dee4797b9a151d... commit cdfc47d58dd52d028dee4797b9a151d4d06633fe Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Sep 19 01:15:21 2016 +0200 http: add spdy Upgrade support Not found in any specification, but it appears to be implemented by kubernetes (using "SPDY/3.1" value). Ping-Bug: 12874 Change-Id: I9fc7ad2f657a739b415f6801fe0f43f6ef75ca70 Reviewed-on: https://code.wireshark.org/review/17786 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ee47d8c8dbad10a7f55287aec1fee32... commit ee47d8c8dbad10a7f55287aec1fee3257c59cc61 Author: Binh Trinh <beango@gmail.com> Date: Sun Sep 18 15:33:44 2016 -0400 Qt: Fix bug in capture file dialog introduced by HideNameFilterDetails Restore File->Save As and File->Export Specified Packets functionalities broken by commit c711bc64573e20e343f343a53ad4d1d50add433d. Change-Id: I5d246d296979b5e509a90569094d672083b06b9b Reviewed-on: https://code.wireshark.org/review/17783 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=a8e727b636ad39e1b04145841145088... commit a8e727b636ad39e1b041458411450882ac381247 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Mon Sep 19 09:37:27 2016 +0200 Qt: reenable export packet bytes menu while capturing Change-Id: I2a3e35ec7c3233e6b32c53a2124b00bbfff8a2e1 Reviewed-on: https://code.wireshark.org/review/17793 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7a7f0202857e0c08324454a7e8ef1b3... commit 7a7f0202857e0c08324454a7e8ef1b364403c581 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Sep 18 21:54:50 2016 +0200 Qt: fix file set menus when stopping a capture or opening a capture after startup Create file_set_dialog_ window at program start so that file set menu entries are properly populated Bug: 12904 Change-Id: I597067da51808000683b15a19df646857082a867 Reviewed-on: https://code.wireshark.org/review/17785 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d7a07deb195bfe51ad13096c23876ba... commit d7a07deb195bfe51ad13096c23876babf2db5238 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Sep 18 23:00:07 2016 +0200 Qt: fix some menus activation when stopping a capture Call MainWindow::setMenusForCaptureFile() once the capture is finished While we are at it, let's deactivate Export PDU and Export Packet Bytes menus while capturing Bug: 12071 Bug: 12898 Change-Id: I8ab9d531135790b51cd630d3f548d0c47a4a60a5 Reviewed-on: https://code.wireshark.org/review/17784 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2de2ddd229ae9b2a57c3916016c3394... commit 2de2ddd229ae9b2a57c3916016c33941d5b2b1d5 Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 18 21:15:59 2016 -0700 Support bitfields for FT_CHAR. Change-Id: I3ad1ad27107c9e2c0d9da6d05f0a06609369271f Reviewed-on: https://code.wireshark.org/review/17789 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9143862cd0ae2ca9365a189e47fba73... commit 9143862cd0ae2ca9365a189e47fba7364699f35f Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Sep 16 21:05:39 2016 +0200 WiX: add SSHdump, Ciscodump and UDPdump to installer Change-Id: Iae2a222db8e9359fd8440b59f43ec90c3b7f8243 Reviewed-on: https://code.wireshark.org/review/17747 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d7fe514fc05e95e3a99fd211768de5a... commit d7fe514fc05e95e3a99fd211768de5abdc3f6486 Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 18 18:48:50 2016 -0700 Improve support for single-character fields and filter expressions. Add an FT_CHAR type, which is like FT_UINT8 except that the value is displayed as a C-style character constant. Allow use of C-style character constants in filter expressions; they can be used in comparisons with all integral types, and in "contains" operators. Use that type for some fields that appear (based on the way they're displayed, or on the use of C-style character constants in their value_string tables) to be 1-byte characters rather than 8-bit numbers. Change-Id: I39a9f0dda0bd7f4fa02a9ca8373216206f4d7135 Reviewed-on: https://code.wireshark.org/review/17787 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=630b64613567c268b2b08966707c81d... commit 630b64613567c268b2b08966707c81d3ec8661a5 Author: Gerald Combs <gerald@wireshark.org> Date: Tue Sep 13 17:07:15 2016 -0700 WiX: Add NSIS installer checks. Look for an existing NSIS installation and cancel the installation if we find one. Add a note about making this process more friendly. Change-Id: Id6ea4d511bc813a38fa834931f5e677d3d6a4319 Reviewed-on: https://code.wireshark.org/review/17702 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gilbert Ramirez <gram@alumni.rice.edu> http://cgit.osmocom.org/wireshark/commit/?id=df2f01a60bed267117c8c46dea4259d... commit df2f01a60bed267117c8c46dea4259dc7e2e995c Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 18 19:38:03 2016 -0700 Add new functions. Change-Id: I2ae30ae84cc7c65b847f8db93828affc50a40ce1 Reviewed-on: https://code.wireshark.org/review/17788 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b914ec30ce281680241de73ad3de8ad... commit b914ec30ce281680241de73ad3de8ad099dc7295 Author: Martin Kaiser <wireshark@kaiser.cx> Date: Sun Sep 18 13:41:47 2016 +0200 bootp: dissect option 82, sub-option 12 (Relay Agent Identifier) as defined in RFC6925 Bug: 12907 Change-Id: I546d243f4b188025d8c96a1eaa0798b70a847a25 Reviewed-on: https://code.wireshark.org/review/17775 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=763f7510e37c907e57c53b0dce1b607... commit 763f7510e37c907e57c53b0dce1b6072ae4a0759 Author: Niels de Vos <ndevos@redhat.com> Date: Sun Sep 18 15:41:17 2016 +0200 glusterfs: decode upcall flags for cache-invalidation Add decoding of the upcall->flags value. This mask currently used do give hints about the cache-invalidation structures. Change-Id: I4a3ab03bec6e2a2c9f8c7bbf17babb2bc93c9d7b Signed-off-by: Niels de Vos <ndevos@redhat.com> Reviewed-on: https://code.wireshark.org/review/17776 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9dad78a6fcb7c9f14c25235b95f19b2... commit 9dad78a6fcb7c9f14c25235b95f19b27701e4326 Author: Joerg Mayer <jmayer@loplof.de> Date: Wed Sep 14 06:08:00 2016 +0200 UDLD has been an informational RFC for a while Fix some whitespace Change-Id: I7438b6b394078a23eda6d77fbda789d5413e0417 Reviewed-on: https://code.wireshark.org/review/17782 Reviewed-by: Jörg Mayer <jmayer@loplof.de> http://cgit.osmocom.org/wireshark/commit/?id=f823464174785a4a329faef680cfeb9... commit f823464174785a4a329faef680cfeb97a312775c Author: Dirk Jagdmann <doj@cubic.org> Date: Sat Sep 17 02:07:52 2016 -0700 add link to Wireshark wiki to pdml2html.xsl Change-Id: Id756cc51d2f30f48994ec9ee07941b2680aa0ba9 Reviewed-on: https://code.wireshark.org/review/17772 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=baa0feee4d586f41643e38d7688feec... commit baa0feee4d586f41643e38d7688feecb67c77a40 Author: Gerald Combs <gerald@wireshark.org> Date: Sun Sep 18 08:12:43 2016 -0700 [Automatic update for 2016-09-18] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I1fb3ac4b7bd4f44dfcf7b40b28b0b2aa89ca4d3e Reviewed-on: https://code.wireshark.org/review/17778 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=553e119672a27b068ec14073dbc1456... commit 553e119672a27b068ec14073dbc1456df06d0ec3 Author: Mirko Parthey <mirko.parthey@web.de> Date: Thu Sep 8 23:00:34 2016 +0200 ISAKMP: Reduce code duplication Equalize attribute dissecting functions: * Convert all attribute type names to range_string. Add "Unassigned" and "Private use" ranges while we are at it. * Swap the order of format and type fields for config attributes. Move common code into the new function dissect_attribute_header(). Try to keep the parameter list short: * Group the hfindex values for attribute details into a struct. * Merge attribute subtree types. Add a colon in the main attribute item label for visual separation. Skip dissection of config attributes for unknown IKE versions. Change-Id: I6e6286f3d4cf16f3cd16a23aca540c4af72f3442 Reviewed-on: https://code.wireshark.org/review/17663 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=ca2a9699810ccbb6a8230c8035228a1... commit ca2a9699810ccbb6a8230c8035228a1e2ba2b3db Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 16 17:37:44 2016 +0200 Qt: allow file dialogs to mark an UAT as dirty Otherwise changes to just the the key file path in the SSL keys list dialog are not saved to disk. Bug: 12640 Change-Id: I12c66efab04a19d662b8090629b8e67aefc01984 Reviewed-on: https://code.wireshark.org/review/17738 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=7514f98f563bf480b28214e883e9e10... commit 7514f98f563bf480b28214e883e9e100d0cdcdf9 Author: Graham Bloice <graham.bloice@trihedral.com> Date: Sat Sep 17 18:54:41 2016 +0100 Make Winflex\bison the preferred option Cygwin flex\bison generate shortening warnings due to size_t on Win 64. The win flex\bison versions don't so find them first. Change-Id: Ib68c84435f859325612410b72b6cf21cf106ecc2 Reviewed-on: https://code.wireshark.org/review/17763 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> http://cgit.osmocom.org/wireshark/commit/?id=66203b4f31e69187636d2dfc0562bc0... commit 66203b4f31e69187636d2dfc0562bc0ccc5a7173 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Sep 18 09:31:01 2016 +0200 extcap: fix management of multicheck and saved non boolean arguments Launching USBPcap without going in the interface options menu exhibits 2 bugs: - we should restore a value only if it is not an empty string (otherwise USBPcap with an ampty --devices multicheck argument) - when building the argument list for a non boolean argument not using the default value, do not call g_strconcat. It will build a string concatenating the option and value (for example "--devices 1" that will be treated as a single argument). Instead option and value must be given separately to argument list. Bug: 12846 Change-Id: I5628cb264a7632089e6579e9ae7400e2c0e500e2 Reviewed-on: https://code.wireshark.org/review/17773 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a978ad7ce3022fb7930ede81f4dd72a... commit a978ad7ce3022fb7930ede81f4dd72a69bc6018a Author: BACdaBASpert <BACdaBASpert@optigo.net> Date: Fri Sep 16 16:57:50 2016 -0700 update bacapp vendor id to name mapping from BACnet Change-Id: Ibd09e3d8ec167a9270545e37365a2370ac6c2c28 Reviewed-on: https://code.wireshark.org/review/17753 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9941cc5f7dbd49b31020d61de3ccd93... commit 9941cc5f7dbd49b31020d61de3ccd93855122552 Author: Gerald Combs <gerald@wireshark.org> Date: Sat Sep 17 10:48:41 2016 -0500 Fix up coding style in ByteViewText. As WSDG 12.2.2.1 says, use trailing_underscore_ convention for member variables. Change-Id: I7d6dbcce3908aefc167cdc6ee1d054a2f5f5a072 Reviewed-on: https://code.wireshark.org/review/17756 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=205b67f7c9d2e4e3627c36380f0010e... commit 205b67f7c9d2e4e3627c36380f0010e1e85819ce Author: Guy Harris <guy@alum.mit.edu> Date: Sat Sep 17 13:44:45 2016 -0700 The full identity string was added above. Change-Id: I0945cb9cb6a9d5ccf3756b887654d73a28035a49 Reviewed-on: https://code.wireshark.org/review/17768 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=db839fc525780a5ed6b20291454a4b9... commit db839fc525780a5ed6b20291454a4b97d83d8553 Author: Guy Harris <guy@alum.mit.edu> Date: Sat Sep 17 13:25:44 2016 -0700 Update a comment. In one of the two cases where we treat the first byte of an identity as a prefix, we know it's EAP-AKA. (In the other, we do *not* know that!) Change-Id: I16625f7193eb3ab0840739ec37dbd64e2a5a0fb5 Reviewed-on: https://code.wireshark.org/review/17767 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=6bedad69b672fdf0e67b54738edb644... commit 6bedad69b672fdf0e67b54738edb64433938c8ae Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sat Sep 17 12:37:11 2016 +0200 Qt: Hide columns after setting widths In columnsChanged() the visibility must be set after setting the width to avoid that setting width overwrites visibility. This should fix hidden columns displayed during first capture. Bug: 12377 Change-Id: Idbbf36b014724970775c34b0c08803de9b006742 Reviewed-on: https://code.wireshark.org/review/17755 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=39c3ddf8615ccc5fb54ef70dfb762ea... commit 39c3ddf8615ccc5fb54ef70dfb762ea5a022b87e Author: Guy Harris <guy@alum.mit.edu> Date: Sat Sep 17 13:14:04 2016 -0700 Fix handling of EAP identity. There's no guarantee that the identity is a string whose first character is a prefix indicating the type of identity; only display it as a prefix if it's one of the known types. We really may need some other mechanism to determine how to parse the identity, perhaps based on what the protocol layers below it are. Put back the display of the full string in one case where that was inadvertently removed. Change-Id: I2e3324f964fa25ebd7065ddb0de82ffae6597509 Reviewed-on: https://code.wireshark.org/review/17764 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ede1af20ba483dd7b6b35d3bd1eabe5... commit ede1af20ba483dd7b6b35d3bd1eabe5cc463592c Author: Martin Kaiser <wireshark@kaiser.cx> Date: Sat Sep 17 18:46:26 2016 +0200 eap: make eap_identity_prefix a numeric item This used to be string item, its value was not 0-terminated. This resulted in out-of-bounds mem acceess when eap_identity_prefix was used by proto_tree_add_string_format(). ==14744== Conditional jump or move depends on uninitialised value(s) ==14744== at 0x4C294F8: strlen (mc_replace_strmem.c:390) ==14744== by 0xC19C97F: g_strdup (gstrfuncs.c:355) ==14744== by 0x739CA75: string_fvalue_set_string (ftype-string.c:51) ==14744== by 0x67136A9: proto_tree_add_string (proto.c:3515) ==14744== by 0x6713870: proto_tree_add_string_format (proto.c:3547) ==14744== by 0x69BB494: dissect_eap (packet-eap.c:838) ==14744== by 0x66FD0B4: call_dissector_work (packet.c:649) As the content is a number anyway, the simplest solution is to make eap_identity_prefix a numeric item and use proto_tree_add_uint_format_value(). Bug: 12913 Change-Id: I907b1d3555a96e9662b1d8253d17d35adfdada48 Reviewed-on: https://code.wireshark.org/review/17760 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=983a9691a9ec18e29f045300dbb6d66... commit 983a9691a9ec18e29f045300dbb6d664c9da1635 Author: Martin Kaiser <wireshark@kaiser.cx> Date: Sat Sep 17 19:10:35 2016 +0200 eap: (trivial) reformat a comment Change-Id: I2c8a8066f1591004ace6362e24be57b6cec747d1 Reviewed-on: https://code.wireshark.org/review/17762 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=3c83afa472e452e1637113bb13f61a0... commit 3c83afa472e452e1637113bb13f61a095a41642b Author: Martin Kaiser <wireshark@kaiser.cx> Date: Sat Sep 17 19:03:26 2016 +0200 eap: remove unnecessary if (tree) checks Change-Id: If42a5d610eea7c7818a0d37dd5878c84ba7f7d81 Reviewed-on: https://code.wireshark.org/review/17761 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=c82303610d0727f938ec003aeec7c2c... commit c82303610d0727f938ec003aeec7c2c7cc4693f0 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sat Sep 17 18:36:32 2016 +0200 ISUP: do not display Called Party Number twice Bug: 12911 Change-Id: I3632ffbeb85a96d9268eca6ddc0f8b38587688c4 Reviewed-on: https://code.wireshark.org/review/17758 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=22257e8cf5a497cd16dd7336a9b8dd2... commit 22257e8cf5a497cd16dd7336a9b8dd224285ee39 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Sep 16 22:15:57 2016 +0200 p_XXX_proto_data: only allow the use of pinfo and file scopes Those are the only ones meaningful. Let's convert the buggy dissectors and add an assert to avoid the misuse of the pool parameter in the future Change-Id: I65f470b757f163f11a25cd352ffe168d1f8a86d3 Reviewed-on: https://code.wireshark.org/review/17748 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2832f4e97d77324b4e46aac40dae0ce... commit 2832f4e97d77324b4e46aac40dae0ce898ae559d Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Sep 16 20:59:06 2016 +0200 NSIS: add UDPdump to installer Change-Id: Ic340d7de5de2573bf1e4ee97c8f7ef9af822d225 Reviewed-on: https://code.wireshark.org/review/17746 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2c33f74bc68c0356eb44a11918d690a... commit 2c33f74bc68c0356eb44a11918d690ac8f26ab63 Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 16 17:05:55 2016 +0200 extcap: fix heap-use-after free after saving prefs All strings passed to prefs must be valid for the lifetime of the program (before prefs_cleanup is called). Use wmem for this purpose. Fixes v2.3.0rc0-660-g26bf66f Change-Id: I94f3bbb8ac6e18ae59d6462525f6bbc46fdb0f1f Reviewed-on: https://code.wireshark.org/review/17737 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=05ae6a7560a8f39daac073d2094fdcd... commit 05ae6a7560a8f39daac073d2094fdcde6975a4ec Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 16 13:56:47 2016 +0200 Remove -Wdeclaration-after-statement This is a C99 feature which we can use now. Change-Id: I84a63d6bf282b79c9f0da0543b3b4f5a0cf0c81a Reviewed-on: https://code.wireshark.org/review/17733 Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=41567191d8c19d2b27571f9c1713fa1... commit 41567191d8c19d2b27571f9c1713fa1f9d6bd11a Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Aug 23 18:14:03 2016 +0200 TLS(1.3): Add Share Key (40) Hello extension Bug: 12779 Change-Id: I5cbc911f2c7818558c5182d2e3ccf9235be9281b Reviewed-on: https://code.wireshark.org/review/17301 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=5540df7a82a4a3ef0ce0b51536dd93d... commit 5540df7a82a4a3ef0ce0b51536dd93d296b77483 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Sep 7 23:15:44 2016 +0200 TLS: Pass directly the handshake_type to dissect_hnd_hello_ext with TLS 1.3, there is a new 'Hello' type (Hello Retry Request) Change-Id: If7a11b70a5b0a69044126c50e1d6ab4e1d443f77 Reviewed-on: https://code.wireshark.org/review/17573 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=c1d9ce47b5164dc010ff525335e9fa4... commit c1d9ce47b5164dc010ff525335e9fa48446d7023 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 22 17:55:10 2016 +0200 TLS(1.3): Add new Hello extension list * Key share (40) * Pre-Shared Key (41) * Early Data (42) * Cookie (44) Bug: 12779 Change-Id: I16e3cf691ae66e244608db233db180e24538a68d Reviewed-on: https://code.wireshark.org/review/17239 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=d32b116d408bfc64f74d7a98ad518e7... commit d32b116d408bfc64f74d7a98ad518e7cd0d4d688 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 22 11:01:59 2016 +0200 TLS(1.3): Add (experimental) extension 'Draft version TLS 1.3' Coming from https://github.com/tlswg/tls13-spec/wiki/Implementations#version-negotiation Bug: 12779 Change-Id: Ieca74eac737b5ba6c101b719e2e5e3aecf931279 Reviewed-on: https://code.wireshark.org/review/17226 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=7319887c3169adba91d0f3fd1b52013... commit 7319887c3169adba91d0f3fd1b5201354e246979 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 22 10:08:00 2016 +0200 TLS(1.3): Fix Server Hello There is no session_id and compression method with TLS 1.3 Server Hello Also no time on first bytes of random field Bug: 12779 Change-Id: Id79221c2ad50695cf6d46cd5c9255deab99e2d2c Reviewed-on: https://code.wireshark.org/review/17225 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=778f7c52cc454d97e3ff560ebf7fa96... commit 778f7c52cc454d97e3ff560ebf7fa9694da56e98 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Aug 21 09:33:39 2016 +0200 TLS(1.3): Add TLS 1.3 value for version Handshake Bug: 12779 Change-Id: I298ecf4a0537df2e88354aed6912d4298a094216 Reviewed-on: https://code.wireshark.org/review/17224 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=ee2c4da947a6e7ae638efa464d9eb09... commit ee2c4da947a6e7ae638efa464d9eb09c9082fa00 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Fri Sep 16 20:32:04 2016 +0200 Qt: Reset expert info icon when start capture failed When starting capture fails the expert info icon must be removed and the file status must be cleared. This happens more frequently when using sshdump with configuration errors. Change-Id: I9b2215c71bd16406a0978256018b1664f06c19f1 Reviewed-on: https://code.wireshark.org/review/17741 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=686d72fc7d8a71f63a51f02cee08d26... commit 686d72fc7d8a71f63a51f02cee08d269e55cdb81 Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 16 11:40:31 2016 -0700 Type and size cleanups. Use size_t for sizes. Do checks to make sure we don't overflow ints. Change-Id: Id0846cc5c6348d67a23064517ad1c432cf1cb61a Reviewed-on: https://code.wireshark.org/review/17742 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ef527fa9618eeb24824de1be9a84c21... commit ef527fa9618eeb24824de1be9a84c2126fe46290 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Sep 16 20:55:31 2016 +0200 M3AP: remove Procedure Code from info column Change-Id: I69aebed5000f6544eede69e7435fb49e4e0ce179 Reviewed-on: https://code.wireshark.org/review/17744 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=953b85c1d42c3daf73ba08dea861ae1... commit 953b85c1d42c3daf73ba08dea861ae13122e6879 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Sep 16 20:54:23 2016 +0200 M2AP: remove Procedure Code from info column Change-Id: I965cc0455f5f3ac8a676cc0e3453e8a449d76109 Reviewed-on: https://code.wireshark.org/review/17743 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=770a8737d7dd0772078d4711fce186c... commit 770a8737d7dd0772078d4711fce186c6b3915b20 Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 16 10:41:11 2016 -0700 Add ws_hexstrtou{bits} and use ws_hexstrtou32 in androiddump. Make the reply length unsigned - there's no reason for it to be signed. Change-Id: I5f4d1f027eeddee939547c052220efb89800f4b1 Reviewed-on: https://code.wireshark.org/review/17740 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1ca260bbb4126423acc2c6c8199ab28... commit 1ca260bbb4126423acc2c6c8199ab2831fad995d Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 16 16:59:51 2016 +0200 udpdump: use socket_handle_t instead of int for portability. Change-Id: Ic31302046e95d1678073a8a77812316be367e9a5 Reviewed-on: https://code.wireshark.org/review/17736 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f317a2b304f50392b360ac95de99545... commit f317a2b304f50392b360ac95de995459a24c3b7d Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 15 18:20:05 2016 -0700 Qt: Argument vector fixups. In wireshark-qt.cpp we have two "argv" variables, one that we pass to QCoreApplication (which it then corrupts irreversibly on Windows if you pass it multibyte characters), and one that we convert to UTF-8 and use normally. Name the throwaway argument vector "qt_argv". Name ours "argv", which is the traditional and less error-prone name. Bug: 12900 Change-Id: Idd80b9f779f36ffe977465afd623d320212f92b1 Reviewed-on: https://code.wireshark.org/review/17723 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=547a5c8c9e71a19fd44addec741289d... commit 547a5c8c9e71a19fd44addec741289da4febcbe3 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 16 14:07:38 2016 +0200 eap: add identity details. Change-Id: I60e017ac48d9daf52b8a40809625dc1ae09c9d8e Reviewed-on: https://code.wireshark.org/review/17735 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3120536012bc85361e2e5cd204bd4aa... commit 3120536012bc85361e2e5cd204bd4aa91fb67ff6 Author: Michael Mann <mmann78@netscape.net> Date: Sat Sep 3 22:22:50 2016 -0400 Have TPKT support a TCP port range preference instead of having "subdissectors?" register their own. There are a number of dissectors who are subdissectors of TPKT (and OSITP) that are not called by TCP dissector directly, yet can possibly register a TCP port "on the behalf" of TPKT. Just allow TPKT to support a range of ports to possibly include these protocols. Remove the preferences from these dissectors, but add backwards compatibility for the preferences by hooking into set_prefs and have the preferences just hook into Decode As functionality directly. Change-Id: Ic1b4959d39607f2b6b20fa6508da8d87d04cf098 Reviewed-on: https://code.wireshark.org/review/17476 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d67c1db3f2b16185d7cff250e098f48... commit d67c1db3f2b16185d7cff250e098f48d94883f0e Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 31 10:14:33 2016 +0200 extcap: make extcap use the ws_strtoi/u functions. Change-Id: Id75c72eba869c8a0f413ce8b5d6329ce172aed1f Reviewed-on: https://code.wireshark.org/review/17415 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2492fe41ba165738aa8667ebfe7f9e9... commit 2492fe41ba165738aa8667ebfe7f9e96f69ef350 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Sep 16 10:14:00 2016 +0200 VTP: Always display reserved/unsed fields Change-Id: Ib0b065c20e599567224c05068dad5bd24a711609 Reviewed-on: https://code.wireshark.org/review/17728 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e4aa7be94943369c7f8119d7f15135d... commit e4aa7be94943369c7f8119d7f15135d3f07b56df Author: Kenneth Soerensen <knnthsrnsn@gmail.com> Date: Thu Sep 15 20:46:37 2016 +0200 ZigBee: Fix reassembly of APS fragments. The unsigned variable num_blocks was initialized to -1. Which caused the dissector to set the total length to 4294967295 fragments when the second fragment was processed. This made the dissector unable to reassemble data made of more than two fragments. Change-Id: I120af090ed29ac73a1fa699bea2bfc91798ef92b Reviewed-on: https://code.wireshark.org/review/17712 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=663031e4a84850fdeeab52cd36f4411... commit 663031e4a84850fdeeab52cd36f44117664b285c Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 16 10:03:12 2016 +0200 ssl-utils: fix -Wshorten-64-to-32 and other warnings Fixes -Wshorten-64-to-32 from v2.3.0rc0-697-gb1d36fe ("ssl-utils: remove block and key sizes from cipher suites table"), -Wpointer-sign, -Wunreachable-code-break. Change-Id: I37ca5e9effe5d6560d49ccef53e9feb096cd2ad6 Reviewed-on: https://code.wireshark.org/review/17727 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6d13aebde939c8d3eb3f60410dbeb95... commit 6d13aebde939c8d3eb3f60410dbeb953b139a299 Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 16 03:01:49 2016 -0700 ws_strou16() now takes three arguments. Change-Id: I94a3a8707de724b1b4c2fafaa4c96d2a52b418c6 Reviewed-on: https://code.wireshark.org/review/17732 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=689ff93474c61984adcf5ad0bd3230e... commit 689ff93474c61984adcf5ad0bd3230e77dd83545 Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 16 02:59:40 2016 -0700 Squelch some compiler warnings. gcry_cipher_get_algo_keylen() returns a size_t, which is bigger than a guint on most if not all 64-bit platforms; however, if the key is bigger than 2^32 bytes, we have bigger problems, so just cast it down. Change-Id: Ia7c97d2742686daf2e42f634c6e349cb580fa9df Reviewed-on: https://code.wireshark.org/review/17731 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=47650d357e3115e89b854f195b38585... commit 47650d357e3115e89b854f195b385855c4703a21 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Feb 10 15:45:45 2016 +0100 extcap: add udpdump. Udpdump is a generic UDP receiver that exports datagram in PCAP format. Change-Id: I52620a92b12530b6f9b5449c43e692663acdfc14 Reviewed-on: https://code.wireshark.org/review/17195 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1cd3587b739c5e5aa1b5fd75c8df4ca... commit 1cd3587b739c5e5aa1b5fd75c8df4ca374f4a6ff Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 16 00:49:15 2016 +0200 ssl-utils: fix runtime memory leak Ensure that Libgcrypt and zlib memory are freed when closing a pcap. Change-Id: I420f9950911d95d59ff046fee57900ca6f7e9621 Reviewed-on: https://code.wireshark.org/review/17718 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=b1d36fe0df74266be57878f16f80790... commit b1d36fe0df74266be57878f16f80790d41dfcf6c Author: Peter Wu <peter@lekensteyn.nl> Date: Thu Sep 15 23:57:15 2016 +0200 ssl-utils: remove block and key sizes from cipher suites table There was an implicit dependency between the block size in the cipher suites table and the size expected by Libgcrypt. Just remove the block size from the table and rely on the value from Libgcrypt to avoid the risk of mismatching values (which could lead to a buffer overflow). While at it, remove the size of the key ("bits") and the size of key material ("eff_bits") too. Move the key material sizes for export ciphers away from the table and use byte quantities instead of bits. Additionally, this fixes an issue where 8 bytes of uninitialized stack memory is written to the SSL debug log for stream ciphers like RC4. The size of the Write Key is also corrected for export ciphers, now it prints the actual (restricted) number of bytes that are used. Change-Id: I71d3c83ece0f02b2e11e45455dc08c41740836be Reviewed-on: https://code.wireshark.org/review/17714 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=979df813dc60358d3f6972d6ca8f5c9... commit 979df813dc60358d3f6972d6ca8f5c97ea7b747b Author: Peter Wu <peter@lekensteyn.nl> Date: Thu Sep 15 01:41:20 2016 +0200 ssl-utils: fix buffer overrun (read) with AEAD cipher suites ssl_cipher_init should only set the IV for CBC cipher suites. NULL cipher suites will not invoke gcry_cipher_setiv and AEAD ciphers will set the nonce in a different place anyway. Fixes a buffer overrun (read) by 12 bytes for any AES-CCM and AES-GCM cipher suite because the "block size" is set to 4 bytes while the reported block size for AES is 16 bytes (128 bit). (The four bytes are the "salt" part of the nonce that is extracted from the "client/server write IV" part of the key block.) Observed with the DTLS packet capture from https://ask.wireshark.org/questions/55487/decrypt-application-data-pending-d... Change-Id: I4cc7216f2d77cbd1eac9a40dca3fdfde7e7b3680 Reviewed-on: https://code.wireshark.org/review/17713 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8def685972f0589551a88bcb41d7bb2... commit 8def685972f0589551a88bcb41d7bb2e039d5627 Author: Mikael Kanstrup <mikael.kanstrup@gmail.com> Date: Wed Sep 14 14:21:10 2016 +0200 Use valid channel parameters from wireless toolbar Both the QT and GTK wireless toolbar used "-1" to indicate unused channel parameters. This was an undocumented feature that recently stopped working. Use the now documented way (NULL) to specify that some parameters are not used. Bug: 12896 Change-Id: I4a93a15ba1d880592b355b7eca155632a4b92ea0 Reviewed-on: https://code.wireshark.org/review/17700 Reviewed-by: Gilbert Ramirez <gram@alumni.rice.edu> Petri-Dish: Gilbert Ramirez <gram@alumni.rice.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f674ef75d765a7933774b8659ca20ef... commit f674ef75d765a7933774b8659ca20ef0ef16e78d Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Thu Sep 15 09:08:18 2016 +0200 Qt: Avoid crashes in IAX2 Stream Analysis Avoid crash when opening IAX2 Stream Analysis without having any packets and when not having a selected packet. Also disable the Save Audio options if not having any IAX2 packets. Also set Close as default button. Change-Id: I1da04e3f907d9d562fa227ab9f0428aa6097131e Reviewed-on: https://code.wireshark.org/review/17708 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=1158576622d677884a3ce4aa169873d... commit 1158576622d677884a3ce4aa169873d453897c9d Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 15 18:32:21 2016 -0700 Don't pick up junk from an unset error-number variable. Keep the actual error code and pointer-to-error-string in the scanner state, rather than pointers to the variables passed in to us. Initialize them to 0 and NULL, respectively. That way, when the actual scanner routine returns, we don't check for an error by looking at the error variable pointed to by our argument, which might not have been set by the scanner and might have stack junk in it, we look at a structure member we set to 0 before the scan. Change-Id: I81a4fd6d5cf5e56f5638fae1253c48dc50c9c36d Reviewed-on: https://code.wireshark.org/review/17721 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7a7d162a494e3ccf15f58f1d710dcf6... commit 7a7d162a494e3ccf15f58f1d710dcf645cfa02b1 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 15 15:20:26 2016 -0700 Don't pick up junk from an unset error-number variable. Keep the actual error code and pointer-to-error-string in the scanner state, rather than pointers to the variables passed in to us. Initialize them to 0 and NULL, respectively. That way, when the actual scanner routine returns, we don't check for an error by looking at the error variable pointed to by our argument, which might not have been set by the scanner and might have stack junk in it, we look at a structure member we set to 0 before the scan. Bug: 12903 Change-Id: I5a382da569a226e60c3c2a47f3a1515b0490c31d Reviewed-on: https://code.wireshark.org/review/17716 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=acb68ae1c461f8608389b130c8e452b... commit acb68ae1c461f8608389b130c8e452bda04d40da Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 9 16:41:15 2016 +0200 cli: use ws_strtou function. Change-Id: Ic358c50aa21dac485348ee5f7af8947f75e4f952 Reviewed-on: https://code.wireshark.org/review/17611 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=251bc5ca13e375851c4630053693a24... commit 251bc5ca13e375851c4630053693a2460083c68a Author: AndersBroman <anders.broman@ericsson.com> Date: Thu Sep 15 16:43:35 2016 +0200 [SIP] Make it possible to call a subdisector for the VIA branch parameter. Change-Id: I7d91780f130105f04648489d6ed0bf2a320edce9 Reviewed-on: https://code.wireshark.org/review/17711 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c5a477e72aafa76331c3d13d97c3905... commit c5a477e72aafa76331c3d13d97c39059ffa99605 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 15 11:37:07 2016 +0200 S1AP: add dissection of NB-IoT transparent containers To do so, memorize whether a given eNB UE S1AP ID belongs to a NB-IoT TAI or not. Also add a preference allowing to force dissection as legacy LTE or NB-IoT if automatic mode fails. While we are at it, let's remove the global variables and introduce a S1AP private data info stored in pinfo. Change-Id: I7e30b3d59d909684e5cfe13510293ed38ad52574 Reviewed-on: https://code.wireshark.org/review/17709 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f2e79776a78ad245c3fa0e079601f5e... commit f2e79776a78ad245c3fa0e079601f5ea7b9cce2f Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Sep 14 19:45:50 2016 +0200 eap: fix EAPOL conversation tracking, fixes TLS decryption Use new heuristics based on the EAP Code field to determine whether a field originates from the client or server. This is more reliable than using "pinfo->match_uint" for two reasons: (1) the heuristics dissector does not set "match_uint" (resulting in an arbitrary match on the previous value) and (2) with EAP over EAPOL, there is no matching port number (resulting in two conversations with different addresses and port number zero). To fix TLS decryption, make sure to create a single conversation for both direction and allow the port type to be PT_NONE (to avoid reporting all packets as originating from the server). Bug: 12879 Change-Id: I7b4267a27ffcf68bf9d3f6a90d6e6e2093733f51 Reviewed-on: https://code.wireshark.org/review/17703 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e8e193694a35779eaf506120ecd2567... commit e8e193694a35779eaf506120ecd2567c98f652ac Author: Gilbert Ramirez <gram@alumni.rice.edu> Date: Tue Sep 13 22:33:54 2016 -0500 Qt: Option to copy bytes to clipboard as Escaped String Some users need to copy the bytes to a Python script for sending out through a raw socket. While they can modify a plain hex dump, having Wireshark copy directly as a Python string makes their work easier. This format also works with Bash, so it is called "Escaped String". E.g.: "\x55\xb5\xd4\x67\x03" Change-Id: I0b6a5eb2e348f686397afda76095aaa2fb85c18d Reviewed-on: https://code.wireshark.org/review/17696 Petri-Dish: Gilbert Ramirez <gram@alumni.rice.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c711bc64573e20e343f343a53ad4d1d... commit c711bc64573e20e343f343a53ad4d1d50add433d Author: Gerald Combs <gerald@wireshark.org> Date: Tue Sep 13 12:47:22 2016 -0700 Qt: Shorten capture file dialog name filters. In the capture file dialog's "Files of type" combobox separate out the wildcards we display from the ones that are applied. Set the HideNameFilterDetails option and for "All Files" and "All Capture Files" leave the option hidden. For other options print the wildcard list twice so that it's both displayed and applied. Go even further and filter out ".gz" wildcards in the displayed list since they're effectively duplicates of their uncompressed counterparts. Based on Dario's work in change 17605. Bug: 12837 Change-Id: I35de8f31492657e37b12ca4c8de5ed9e79d2e2f8 Reviewed-on: https://code.wireshark.org/review/17689 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fcc56c2b7f9c70ef14b016b1a40e132... commit fcc56c2b7f9c70ef14b016b1a40e132c9020de34 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Sep 7 15:15:57 2016 +0200 iseries: rework the read routine. Change the way a line is read in iseries. Instead of reading a string then convert it with atoi, parse it as an integer and convert it to nsecs. Change-Id: Id8e8e9866dbcef3b1612a608f9647bc490263dae Reviewed-on: https://code.wireshark.org/review/17558 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3d7524c206e7e6630c29c154b5a6684... commit 3d7524c206e7e6630c29c154b5a66844872ed889 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Sep 14 17:05:26 2016 -0700 Fix a test to work with Xcode 8. (Hopefully it still does what it's supposed to; I don't have any machine, real or virtual, that has the command-line tools installed without Xcode being installed on which to test it.) Change-Id: I0ce8ce4f8532fcc6ab121641dde238180dfa69ce Reviewed-on: https://code.wireshark.org/review/17704 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=057b6bbd2e33afea4dc00accadabe89... commit 057b6bbd2e33afea4dc00accadabe89282d7f2f5 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Tue Sep 13 13:37:11 2016 +0200 Qt: Set Close as default button Set Close as default button in some statistics dialogs. Change-Id: I82e17d27de256aabaec1633bb973c554eec907c3 Reviewed-on: https://code.wireshark.org/review/17685 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=c9abf97b58a7ed92526a6fc307424bd... commit c9abf97b58a7ed92526a6fc307424bdaca27a636 Author: Gerald Combs <gerald@wireshark.org> Date: Tue Sep 13 15:27:23 2016 -0700 NSIS: Disable a debugging MessageBox. Disable a MessageBox added in gec5f578. Change-Id: I4a1ad044836a9363b2e4d9f80df419e7c81f73dd Reviewed-on: https://code.wireshark.org/review/17694 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=0dc96da1b9dd56d811e76569782ccd1... commit 0dc96da1b9dd56d811e76569782ccd1831998fd0 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Sep 13 22:38:32 2016 +0200 X2AP: remove Procedure Code from info column Change-Id: I8d4632ef3b338063e96f4a417f0e3280489968a4 Reviewed-on: https://code.wireshark.org/review/17692 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c644651bac5769feeeb02f177646a73... commit c644651bac5769feeeb02f177646a7372cf26d81 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Sep 13 22:36:30 2016 +0200 S1AP: remove Procedure Code from info column Change-Id: I53ece74627adc038ee6ff2af2959f2dae76ab879 Reviewed-on: https://code.wireshark.org/review/17691 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=48433e98b9ac03f5e55d6d8fa277824... commit 48433e98b9ac03f5e55d6d8fa277824e9e5b0946 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Sep 13 22:23:15 2016 +0200 NAS EPS: add an option to dissect User Data Container as IP packet Change-Id: I7d1196b79c22df5abe7d399bd9bea5c3d60bff7f Reviewed-on: https://code.wireshark.org/review/17690 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ec5f5780a11ca1e2019f3d5b7bf6a9a... commit ec5f5780a11ca1e2019f3d5b7bf6a9a64aa0b144 Author: Gerald Combs <gerald@wireshark.org> Date: Fri Sep 9 09:30:54 2016 -0700 NSIS: Look for an installed WiX package. Dig through the registry and look for a WiX / Windows Installer package. Offer to uninstall it if we find one. Change-Id: I513ce4184880571c484461483a3d25e6d90a85e0 Reviewed-on: https://code.wireshark.org/review/17613 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=aa44e3b75da316bb9ee3237c401042a... commit aa44e3b75da316bb9ee3237c401042afa36db7d8 Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 8 11:24:34 2016 -0700 NSIS: Disable GTK+ by default. Disable the legacy UI by default. Associate our Programs and Features icon with Wireshark.exe. Move some GTK+-specific code to SecWiresharkGtk. Make sure the /desktopicon and /quicklaunchicon apply to Wireshark.exe. Remove unneeded parentheses in the display name. Change-Id: Ia7662d003d15afd809d81631e059e249a93d0999 Reviewed-on: https://code.wireshark.org/review/17593 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=3c163637d6890ce5782fc204186629b... commit 3c163637d6890ce5782fc204186629b789932d32 Author: Gerald Combs <gerald@wireshark.org> Date: Tue Sep 13 11:29:25 2016 -0700 WSUG: Fixup PDF images. Pass relative image directory paths to xsltproc. The DocBook documentation says you can use a URI, but trying to get that to work with CMake and Windows appears to be a path to tears and undignified wails of frustration. Add attributes for our different types of images and use them so that the PDFs don't scale our screenshots to an unusable size. Change-Id: I786d09d9ef9be3d423b2af426a8867739ae12c1a Reviewed-on: https://code.wireshark.org/review/17688 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=1e3c57b486b1d6a443cc29884337f98... commit 1e3c57b486b1d6a443cc29884337f983ca61bbfe Author: Tom Haynes <loghyr@primarydata.com> Date: Tue Sep 13 09:24:53 2016 -0700 nfs: Primary Data's NFSv4 DataSphere filehandle decoder Change-Id: I0d339f69f37fd3b6a2f7b37b1c239edb2a4cf7a5 Signed-off-by: Tom Haynes <loghyr@primarydata.com> Reviewed-on: https://code.wireshark.org/review/17676 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5e03d3183c55277aa75f7337bd8cac7... commit 5e03d3183c55277aa75f7337bd8cac76a60d51b2 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Tue Sep 13 12:49:23 2016 +0200 Qt: Fix open Flow Graph in full screen Check if initialized in SequenceDialog::resizeEvent because loadGeometry() may call resizeEvent (from showFullScreen()) before init_ is initialized. Change-Id: I1a514454f1521f68df71c3113077c68acb2f3218 Reviewed-on: https://code.wireshark.org/review/17684 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=5b03a42489eb3adfa9c1aa8971e3564... commit 5b03a42489eb3adfa9c1aa8971e35649fcfe6014 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 13 11:14:01 2016 +0200 sshdump: remove -P. This option is incompatible with other capture binaries (like tcpdump). Change-Id: If93fca69f93b7833e7f8bb28b70311373f42f3f5 Reviewed-on: https://code.wireshark.org/review/17682 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9c1e9b27f4cf549d3ed9a6d76e1469a... commit 9c1e9b27f4cf549d3ed9a6d76e1469a84e447fda Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Sep 12 21:30:26 2016 +0200 qt: fix default action in Time Shift dialog Use "Apply" as default action, not "Open Help". Change-Id: Ida9b878732e444bbc450f8e63cc8e30a76f29bdc Reviewed-on: https://code.wireshark.org/review/17672 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=8d2016da9792b494cffd7d34a395ece... commit 8d2016da9792b494cffd7d34a395ecea728b9407 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 9 17:16:10 2016 +0200 addr_resolv: use ws_strtou8 function. This change prevents to accept netmasks as /24x. The mask must be an clean integer. Change-Id: I46aeb089dd6538b5cc4bde7efd4dc317621a5245 Reviewed-on: https://code.wireshark.org/review/17612 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=3fd70302efceed9bd7aa40779cba29d... commit 3fd70302efceed9bd7aa40779cba29d818bb96fd Author: Guy Harris <guy@alum.mit.edu> Date: Tue Sep 13 01:51:07 2016 -0700 Fix indentation. Change-Id: I2b2d1cd584eb1ec56ec5cdcd33fb789843c8192c Reviewed-on: https://code.wireshark.org/review/17680 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b6165546656ae28d73fa9add25fcffd... commit b6165546656ae28d73fa9add25fcffd2876c1fb2 Author: Michal Labedzki <michal.labedzki@tieto.com> Date: Mon Nov 2 19:41:12 2015 +0100 Bluetooth: HCI vendor: Add support for some Intel commands/events This change based on BlueZ code on the same license that Wireshark is. It seems that a lot of commands/events are incomplete or unknown, however better to have them. Also rename variables (etc.) of the first dissector to contain vendor name like new one, to distinguish them. Change-Id: I2db3ed73d477699032a44bac2d3c88a9230b0095 Reviewed-on: https://code.wireshark.org/review/17657 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ad980c70bf4301f76403fca1c65cfae... commit ad980c70bf4301f76403fca1c65cfae995c146cc Author: Michal Labedzki <michal.labedzki@tieto.com> Date: Tue May 3 22:45:05 2016 +0200 Qt/Bluetooth: Implement hover for rows This improves readability, especially while presenting results to the other people. Change-Id: I1a6fc93c1b858078e171729971561321a4ddd956 Reviewed-on: https://code.wireshark.org/review/16469 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> http://cgit.osmocom.org/wireshark/commit/?id=99fff00e020748514ee80efd0cea28d... commit 99fff00e020748514ee80efd0cea28d0148f4bdd Author: Gerald Combs <gerald@wireshark.org> Date: Mon Sep 12 15:44:16 2016 -0700 WSDG: Updates for Qt 5.6. Refer to Qt 5.6 for Windows builds. Update the download URL. Change-Id: Id4de0d55679a6ac1b7aac82ddd5eb80d6b54568a Reviewed-on: https://code.wireshark.org/review/17674 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6c4b0ffe9119e9e48bbe3e3cd2fa7d0... commit 6c4b0ffe9119e9e48bbe3e3cd2fa7d0c0fb70d2e Author: Dario Lombardo <lomato@gmail.com> Date: Mon Sep 12 12:41:48 2016 +0200 telnet: get rid of atoi(). Change-Id: Id445aef1af21fcf176611122a757482c0b22f4bd Reviewed-on: https://code.wireshark.org/review/17662 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=84436438a8cbcb533839584b0eef2eb... commit 84436438a8cbcb533839584b0eef2eb43f4b5396 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 12 09:51:47 2016 -0700 Fix file name in comment. Change-Id: I2a5b6e5c0ba8e729fbfa7e9e218aca1c747d6e45 Reviewed-on: https://code.wireshark.org/review/17667 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f2d6d07498b42637134a08459458cdd... commit f2d6d07498b42637134a08459458cdda679380e0 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 12 09:45:12 2016 -0700 Remove unnecessary extcap_cleanup() declaration. That wasn't sufficient to avoid #ifdeffing calls to extcap_cleanup(), as this header wasn't even being included if HAVE_EXTCAP wasn't defined, hence change I18c855e13281013a6277c1f38eeac92e74d52b34 was necessary. It's probably best that this not be included if HAVE_EXTCAP isn't defined, so as to catch *other* references to functions etc. that aren't available without extcap. Change-Id: I5c4ad331b6df93bbbcd28ad3b9815e4cd226039a Reviewed-on: https://code.wireshark.org/review/17666 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=cea1737bd218aa84bf41637deee25bd... commit cea1737bd218aa84bf41637deee25bd199fb128d Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Sep 12 11:22:16 2016 +0200 Let strtoi with NULL endptr require no invalid characters If the caller is not interested in checking its end, then it probably wants a valid number only if the string contains a valid number. Add a shortcut for this. Change-Id: I39701bd445e29fb2606720b18ca3764c74a7255b Reviewed-on: https://code.wireshark.org/review/17658 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e3247b3a71f1bdb89c40573412ab7b2... commit e3247b3a71f1bdb89c40573412ab7b2181212a98 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Sep 12 15:07:36 2016 +0200 fix some compilation issues without extcap. Change-Id: I18c855e13281013a6277c1f38eeac92e74d52b34 Reviewed-on: https://code.wireshark.org/review/17665 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=159d4317dc5eff3a450bac44610f902... commit 159d4317dc5eff3a450bac44610f9023e96b50e5 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 11 12:00:10 2016 +0200 androiddump: fix memleaks Most of the actions (e.g. `androiddump --extcap-interfaces`) return immediately without cleaning up. Fix this by adding a common exit path. Change-Id: If02b18da49d866fb5525306e52fbf4590d98ecd2 Reviewed-on: https://code.wireshark.org/review/17634 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=26bf66f423489fa3128d406c949954b... commit 26bf66f423489fa3128d406c949954be5c39455c Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 11 14:17:14 2016 +0200 extcap: plug more memory leaks Fix leak of the preference key name which happen for every new extcap argument. Fix leak of extcap arguments and the interface names in extcap_register_preferences. Change-Id: Idd68f924baa000303043cb98b32b23ce34fddb64 Reviewed-on: https://code.wireshark.org/review/17637 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=c64762d33c3a9cbc4af4040284534b4... commit c64762d33c3a9cbc4af4040284534b440d12b210 Author: Mikael Kanstrup <mikael.kanstrup@gmail.com> Date: Thu Sep 8 14:26:58 2016 +0200 extcap: Fix misc memory leaks triggered by network interface changes Valgrind reports plenty of misc memory leaks in extcap after the network interface list has changed or is refreshed. Errors can be seen by starting Wireshark with Valgrind's memcheck tool and bringing a network interface up and down a few times with: ifconfig eth0 up ifconfig eth0 down Change-Id: I90f53847071854b7d02facb39b7a380732de79b4 Reviewed-on: https://code.wireshark.org/review/17606 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=e079862fad331cba874717ec1d0af9e... commit e079862fad331cba874717ec1d0af9e35ba438b5 Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Sep 12 10:37:03 2016 +0200 cmake: fix breakage with libnl2 I accidentally assumed that libnl2 works fine with just libnl.so, but apparently the other libraries are also necessary. Change-Id: I1636710ea3f41ed10a5ccb37106cae9e688abec9 Reviewed-on: https://code.wireshark.org/review/17654 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=3c70e6d684ff822806e0dd9d1a46c53... commit 3c70e6d684ff822806e0dd9d1a46c5350825d012 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Mon Mar 7 21:10:46 2016 +0100 dmp: Code cleanup Change-Id: I06c80ca44e8f727c9dc8ec552117ff60e44a7ef4 Reviewed-on: https://code.wireshark.org/review/17659 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=b28cd2dbd78bfeecd0209142f6dd6a8... commit b28cd2dbd78bfeecd0209142f6dd6a8e8ad8aa90 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Mon Sep 12 10:53:16 2016 +0200 Qt: Word wrap static text preferences The preferences static text may be too long for the preferences dialog width, so set word wrap for this label. Change-Id: I0828601b39a5e189de707087e317c598576fc3db Reviewed-on: https://code.wireshark.org/review/17656 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=68fafcf43f096c2db01527a2265570f... commit 68fafcf43f096c2db01527a2265570f7a1ffe373 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Mon Sep 12 10:43:16 2016 +0200 dmp: Remove obsolete structured id handling The structured id handling is not in use by anyone. Change-Id: I643fb03f642a5c1900aaec7d41e2b66dba5a2b05 Reviewed-on: https://code.wireshark.org/review/17655 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=2e42199e1177f01b5cd1789b0cbe112... commit 2e42199e1177f01b5cd1789b0cbe112d36f05fbc Author: AndersBroman <anders.broman@ericsson.com> Date: Wed Aug 24 13:14:55 2016 +0200 [SELFM] Fix reassembly, tcp_dissect_pdus() can't be used as the real length of the PDU is not known(length is exluding escape bytes). Change-Id: I762419f12ca80f6597163e232c4b853819927b65 Reviewed-on: https://code.wireshark.org/review/17302 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4fe91cf9f550bca33a79925b31e99a4... commit 4fe91cf9f550bca33a79925b31e99a42cfb010bc Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Sep 11 22:25:24 2016 +0200 S1AP: add missing messages in info column While we are at it, let's reorder them in the .cnf file to match their definition in S1AP-PDU-Contents.asn and ease review Change-Id: I4c433fa862d83053d8b01cc951e756379356fa57 Reviewed-on: https://code.wireshark.org/review/17649 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=032a6ac3be243c2bbf4b5d1010065a1... commit 032a6ac3be243c2bbf4b5d1010065a14b7784ddb Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 11 22:19:31 2016 +0200 Fix memleaks in capture file dialog Tried to poke various fields (including the capture filter field), this revealed some memleaks. Change-Id: I1eca431a09839906a4b3c902ad85e55bffc71ca8 Reviewed-on: https://code.wireshark.org/review/17648 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=71c41a0a13f9825d71e08e5bc037002... commit 71c41a0a13f9825d71e08e5bc03700275287f096 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 11 17:04:13 2016 +0200 epl: fix memleaks Fixes a memleak that occurs on (re)loading a pcap. While at it, remove some unnecessary variables. Change-Id: Ibb662e5c608881bc7dfde9d12cdb77f699ff6542 Reviewed-on: https://code.wireshark.org/review/17639 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5c505e7d439ff4d267288d4420180f6... commit 5c505e7d439ff4d267288d4420180f6b12521d06 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Sep 11 22:57:45 2016 +0200 X2AP: add dissection of X2AP-Message information element Change-Id: I2993e1a9ebad1660573bce8a61b44962af08bbb3 Reviewed-on: https://code.wireshark.org/review/17652 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8629e60922e226665832f19aa698c8a... commit 8629e60922e226665832f19aa698c8aff41eacef Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 11 13:48:35 2016 -0700 More signed vs. unsigned argument cleanups. Use the get.*guint32 routines to get unsigned values. Change-Id: I75e83b2d21bdf08c7c995e36e4deb3b1c6d6959d Reviewed-on: https://code.wireshark.org/review/17651 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4abf452b193b3be3fd32bc113d57398... commit 4abf452b193b3be3fd32bc113d573984495af232 Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 11 13:32:02 2016 -0700 Use the get.*guint32() routines to get guint32s. Change-Id: Ie3b451549a29970a5e3204b449f198aa1c82de5b Reviewed-on: https://code.wireshark.org/review/17650 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4f46d9da9cc8175c3182bdc664324aa... commit 4f46d9da9cc8175c3182bdc664324aa82f267aaa Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 11 13:23:20 2016 -0700 Allow a zero change offset in editcap. It doesn't have to be non-zero. Change-Id: If578906855abd9eb9fa07e97ee5508c139b6f61b Reviewed-on: https://code.wireshark.org/review/17646 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=11d3a0f963e5bd7426c6b29f1e65204... commit 11d3a0f963e5bd7426c6b29f1e6520420299559f Author: Guy Harris <guy@alum.mit.edu> Date: Sun Sep 11 12:08:45 2016 -0700 Add a -a flag to specify running under ASan, and don't set ulimit -v if so. You can't run ASan-built programs with a ulimit, as ASan allocates a huge amount of shadow memory. Change-Id: Ic4d3c2fae77719f65d4594774bc8aa92d2a3a035 Ping-Bug: 12797 Reviewed-on: https://code.wireshark.org/review/17645 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9360f419590831a7d7d3f6889b717ed... commit 9360f419590831a7d7d3f6889b717ed36a1e4de9 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sun Sep 11 20:27:50 2016 +0200 mqtt: Only suback has failure in QoS values Change-Id: Ib308090dfc0911a9bb7580e601cab0bfbfe58efe Reviewed-on: https://code.wireshark.org/review/17644 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=c2b858e26de89bd90c3c782c43c1bff... commit c2b858e26de89bd90c3c782c43c1bff1c0ac79f2 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sun Sep 11 20:21:10 2016 +0200 mqtt: Fix subscribe/suback QoS values Change-Id: I15424b768e6e0fe2e8268db69b82d81351146155 Reviewed-on: https://code.wireshark.org/review/17643 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=bb46efdca9c9e710a511501652e27dc... commit bb46efdca9c9e710a511501652e27dc3606c6e5f Author: Matt Lawrence <bugzilla.wireshark@erisa.co.uk> Date: Mon Aug 29 11:39:04 2016 +0100 MySQL: verify connection state before dissecting as greeting/login. Change-Id: I419fad047c91ff1d8544eb3458534c132ec23821 Bug: 12791 Reviewed-on: https://code.wireshark.org/review/17368 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c31527d406e57e9e86699b9cfe20593... commit c31527d406e57e9e86699b9cfe2059300f911cf1 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Thu Sep 8 21:26:12 2016 +0200 mqtt: Added elements from version 3.1.1 Added version 3.1.1 CONNACK session present flag and SUBACK failure indication. Adjusted SUBSCRIBE and SUBACK QoS values. Added string length values. Removed the message type subtree as it had no purpose. Put the message type in the top tree mqtt node instead. Removed unused code and fixed code layout. Change-Id: I8a9ae26ac9a2af04dc6f8d08ac46aa305c225c4f Reviewed-on: https://code.wireshark.org/review/17590 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e954569f321fedc097f65e243091d5e... commit e954569f321fedc097f65e243091d5ea12cc9406 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Sep 7 18:07:01 2016 +0200 CQL: rename code for don't only support v3 There is a v4 (and v5) with some change (patches coming !) Change-Id: I3107727e2b86f7f6c0019ba6f2638bb40b41c0fb Reviewed-on: https://code.wireshark.org/review/17626 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0332275b161693c76257159c7f5d15f... commit 0332275b161693c76257159c7f5d15f7b1008203 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 11 16:10:46 2016 +0200 qt: fix minor memory leaks on exit Change-Id: I4856b7ce7eec15abe1278e9ba8314be61845347a Reviewed-on: https://code.wireshark.org/review/17638 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=1d493ce156c4a230bc376d957c196ca... commit 1d493ce156c4a230bc376d957c196cab31388dd2 Author: Gerald Combs <gerald@wireshark.org> Date: Sun Sep 11 08:12:41 2016 -0700 [Automatic update for 2016-09-11] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I29e1c1ae96c686a2c97609e939c2c35845d2d9ee Reviewed-on: https://code.wireshark.org/review/17640 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=456312e22b06dd900ce11776f35321c... commit 456312e22b06dd900ce11776f35321c0a158ea7e Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 11 11:25:51 2016 +0200 dumpcap: fix memleak on exit Invocation of tshark -D (dumpcap -D -Z none) under ASAN fails with: tshark: Child dumpcap process died: Abort - core dumped Change-Id: Ida363089066205d579e841b019b32c2e33516f12 Reviewed-on: https://code.wireshark.org/review/17633 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=583150198b78c84d043455b0afcca58... commit 583150198b78c84d043455b0afcca58a9659eab3 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 11 01:16:24 2016 +0200 extcap: fix use-after-free for preferences In commit v2.3.0rc0-117-g485bc45 (backported to v2.2.0rc0-44-g66721ca), extcap_prefs_dynamic_vals and extcap_cleanup were added in an attempt to address dangling pointers. Unfortunately it is not sufficient: - A pointer to the preference value is stored in extcap_arg and passed to the prefs API, but this extcap_arg structure can become invalid which result in use-after-free whenever the preference is accessed. - On exit, a use-after-free occurs in prefs_cleanup when the preference value is being checked. As the preference subsystem actually manages the memory for the string value and consumers should only provide a pointer where the value can be stored, convert the char* field in extcap to char**. This has as additional benefit that values are not limited to 256 bytes anymore. extcap_cleanup is moved after epan_cleanup to ensure that prefs_cleanup does not operate on dangling pointers. Crash is reproducible under ASAN with: tshark -i randpkt Ping-Bug: 12183 Change-Id: Ibf1ba1102a5633aa085dc278a12ffc05a4f4a34b Reviewed-on: https://code.wireshark.org/review/17631 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b82695d9976ebed00f34bfc45f0358d... commit b82695d9976ebed00f34bfc45f0358db095e0670 Author: Gerald Combs <gerald@wireshark.org> Date: Wed Sep 7 14:53:10 2016 -0700 WiX: Add a warning and increase compression. Note that you should probably uninstall the NSIS package first if it's installed. Set the compression level to "high". Change-Id: I10de8df580f8410fd13cdf414db1b1812a9fcf02 Reviewed-on: https://code.wireshark.org/review/17566 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2fb9cbd9adae558276ff68d4d819566... commit 2fb9cbd9adae558276ff68d4d819566246f4e3f5 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Aug 23 13:38:27 2016 +0200 TLS: Enhance display of Hello Extension Append the length to the extension and display the contents of unknown extensions as bytes. Change-Id: Iba1204a1d5e187f28cb41c4369b10eeb86e6b43a Reviewed-on: https://code.wireshark.org/review/17265 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=193e366a3f54ba08a16322add7da0a4... commit 193e366a3f54ba08a16322add7da0a4089210897 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 9 16:33:55 2016 +0200 remove unused mkcap.c. mkcap.c is not used in any place. Change-Id: Ie29b2ed66bc304a5b6a19fc9128ead2958f8062a Reviewed-on: https://code.wireshark.org/review/17610 Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e8f1d2abda939f37d99f272f8a76a19... commit e8f1d2abda939f37d99f272f8a76a191c9a752b4 Author: Guy Harris <guy@alum.mit.edu> Date: Sat Sep 10 12:54:08 2016 -0700 Fix indentation. Change-Id: I440eac95172fe040255ab010fd17a17b21b68ae8 Reviewed-on: https://code.wireshark.org/review/17630 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8bfe20b8286d8287cf3dd7e59f4464f... commit 8bfe20b8286d8287cf3dd7e59f4464f0b4b45e8f Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 10 19:29:49 2016 +0200 debian: Update symbols file with new/missing symbols wtap_get_all_file_extensions_list was renamed in v2.3.0rc0-621-g4a6dde1 ws_strtou* functions were introduced in v2.3.0rc0-544-gba981ac get_guint32 and get_nonzero_guint32 were added in v2.3.0rc0-595-ge09b03e Change-Id: I9aea9c48f2da03590952b995fd21cddb17532af0 Reviewed-on: https://code.wireshark.org/review/17629 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=af3a0654a2f33ce9dd58b1e2626b934... commit af3a0654a2f33ce9dd58b1e2626b9348c4677416 Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 10 15:05:35 2016 +0200 extcap-base: fix memleak from help options Also correct modelines, this file really uses 4 spaces and not tabs. Change-Id: I828d0249cc7637275e5a04e9117b22e9eea6bd8c Reviewed-on: https://code.wireshark.org/review/17625 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=ac7c05f9157033169b140115636e8be... commit ac7c05f9157033169b140115636e8bec94ffb62d Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 9 14:40:01 2016 +0200 sll: add unused bytes to tree. The bytes that are not part of the address are not dissected. Added them to the tree as "unused", to have a complete dissection of the packet. Found by incomplete dissector check. Change-Id: Iafffebe8bc0f8254ac0b451d007e0a99aab91924 Reviewed-on: https://code.wireshark.org/review/17608 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f9fc92aa0164e906fc53c80b7ae727b... commit f9fc92aa0164e906fc53c80b7ae727bbf4fc52e0 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sat Sep 10 16:43:28 2016 +0200 CQL: fix indent modelines Change-Id: Ie7ad09b3141fa6f4753981bd814736ee88c817d1 Reviewed-on: https://code.wireshark.org/review/17627 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7fad354a3e379382368cd1ef67b8413... commit 7fad354a3e379382368cd1ef67b841315c29e050 Author: Michael Mann <mmann78@netscape.net> Date: Sat Jul 30 10:54:25 2016 -0400 Add Socket CANFD dissector. Bug: 12687 Change-Id: Ib489b4c6aff1e0611e9b8a086054e56284f24b84 Reviewed-on: https://code.wireshark.org/review/16787 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=7541a004d0ff0242cfb9405859428d2... commit 7541a004d0ff0242cfb9405859428d2b2ce2cafd Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 10 13:03:38 2016 +0200 reordercap: fix memleak on exit Change-Id: I328fe03ab6c72b2bb9c4ead01170a341e5bd4d1a Reviewed-on: https://code.wireshark.org/review/17624 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=e5fef1d73e687807ae1df40979ffc5a... commit e5fef1d73e687807ae1df40979ffc5a65dda03cc Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 10 01:27:28 2016 +0200 Fix version-string releated memleak for some CLI tools These programs resulted on a memleak report on exit. Change-Id: I630618f50d723b7af4cb00ba29671d4e7c6fcdc2 Reviewed-on: https://code.wireshark.org/review/17623 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=4b05159dfec9e3e4495982e70803d7d... commit 4b05159dfec9e3e4495982e70803d7d49c13f54b Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 10 01:25:55 2016 +0200 capinfos: fix memleaks Change-Id: Ib3145bb13d2a72c16f9c219fa19321e44958a30e Reviewed-on: https://code.wireshark.org/review/17622 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=d1a82132a62bbd5c20e0490c6f7d693... commit d1a82132a62bbd5c20e0490c6f7d693c318481d1 Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 10 01:20:41 2016 +0200 editcap: fix memleaks The version string stuff mirrors an earlier tshark change. Move some cleanup calls (in case no packets are selected) and add wtap_close. Change-Id: I6f282e89279a732c226824e10857be04b40841e8 Reviewed-on: https://code.wireshark.org/review/17621 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=ba2a3b3626ef9fc084ee8a9508d196e... commit ba2a3b3626ef9fc084ee8a9508d196ec890c2336 Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Sep 10 01:12:58 2016 +0200 wiretap: fix memory leak of interface_data for wtap_dumper Mirrors the behavior of wtap_close. Change-Id: I1a04878fdd0409fa74931737332f9b8a1ae77fb1 Reviewed-on: https://code.wireshark.org/review/17620 Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=d6f91a7ca421caa7787c1539bca61f9... commit d6f91a7ca421caa7787c1539bca61f943923fa9c Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Sep 9 23:37:46 2016 +0200 S1AP: prettify dissection Change-Id: I2b4339e489d11ade2751cad8874ba220d12fe3db Reviewed-on: https://code.wireshark.org/review/17615 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4a6dde12d6fe6af05b05d4c06b10056... commit 4a6dde12d6fe6af05b05d4c06b10056f6508711a Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 9 23:44:25 2016 -0700 Have "All Capture Files" match only capture files. We support reading some types of files that aren't capture files, in case we have a dissector for that file format (because, for example, it's often transported over HTTP). Don't include them in the set of files "All Capture Files" matches; you can still look for them as they have individual entries in the drop-down menu of file type patterns. Ultimately, there should be Fileshark/TFileshark programs to read those files - and other file types, and even capture files if the goal is to look at the file structure rather than at the packets - and *that's* the program that should offer the ability to load JPEGs and so on. (No, this does not reduce the "All Capture Files" list down to a level that makes the problem in bug 12837 go away. The right way to fix *that* is to arrange, somehow, that the "All Capture Files" entry not actually list all the suffixes it matches.) Change-Id: I705bff5fcd0694c6c6a11892621a195aa7cd0264 Reviewed-on: https://code.wireshark.org/review/17619 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d1cacbb1463503999981637314310a0... commit d1cacbb1463503999981637314310a0824d9f3fe Author: Gerald Combs <gerald@wireshark.org> Date: Fri Sep 9 15:04:15 2016 -0700 PortableApps: Allow multiple instances. The documentation for the [Launch]SingleAppInstance key doesn't seem to match its behavior in that its default value (true) keeps multiple portable instances from running, at least for us. Set it to false since we're happy with users running as many concurrent instances as they can stand. Set the related SinglePortableAppInstance key to false while we're here in case its default value ever changes. Change-Id: Iea1a6a80d5b204814b7569776734e0b0e254d657 Reviewed-on: https://code.wireshark.org/review/17616 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=559bb375c1542f6556b4afc260345eb... commit 559bb375c1542f6556b4afc260345eb6a988025b Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 8 14:31:03 2016 -0700 Remove name resolution from the file dialogs. A single name resolution checkbox was added to the file dialog way back in 2000 in g0f7cf64. At that time it was needed because resolution was synchronous and could drastically affect your load time. Since then we've added asynchronous name resolution and more recently made it mandatory (ge005bc8). We've also added more name resolution checkboxes and other controls. Remove the name resolution checkboxes. You can just as easily change resolution options before or after opening a file and they take up valuable real estate. Combine the size and packets in the Qt and Win32 dialogs and pretty-print the size. Combine the start and elapsed times in the Qt, Win32, and GTK+ dialogs. This lets us shrink the custom areas of the file dialogs even further. Make the default file type combo item more descriptive. Change-Id: Id770adc0f284a4c7f08ee5a7db84f8435f4bf907 Reviewed-on: https://code.wireshark.org/review/17597 Tested-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=ecd82d08a1479849cb6d4ebb93422b0... commit ecd82d08a1479849cb6d4ebb93422b0f96470704 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Sep 9 22:16:02 2016 +0200 X2AP: shorten field description Change-Id: I37828fe5611fa835050427ac0c73e979aa7a1ddf Reviewed-on: https://code.wireshark.org/review/17614 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ae7c4ad3c0975887ee320409df78ad3... commit ae7c4ad3c0975887ee320409df78ad38ccad901a Author: Michael Mann <mmann78@netscape.net> Date: Wed Sep 7 20:43:01 2016 -0400 Remove "Elasticsearch HTTP" dissector. It was just a wrapper over regular HTTP dissector, which can already pick its own ports to use. Also some other minor cleanup related to removal. Change-Id: I20dd37670c676551a06aaeb69fd657684af9685d Reviewed-on: https://code.wireshark.org/review/17567 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=82f1d14daea37bf46395dc3fdfb2766... commit 82f1d14daea37bf46395dc3fdfb27662f31870d2 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Fri Sep 9 13:31:24 2016 +0200 nordic_ble: Capitalize short name Change-Id: I2130b012f28b23342679f33e1e19a4e5e0943090 Reviewed-on: https://code.wireshark.org/review/17607 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=cb963316027b3592f81f03c3185848c... commit cb963316027b3592f81f03c3185848c22f60a341 Author: Adrien Aubry <adraub@gmail.com> Date: Thu Sep 8 15:26:25 2016 +0200 CANopen: EMCY manufacturer error field size bug fix -Manufacturer error field has 5 bytes (not 4) -corrected two descriptions Change-Id: Ic6f3e8fdf08c52f1d4f987410e1e0597a9f6aaed Reviewed-on: https://code.wireshark.org/review/17575 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f7a59da905ab7f8fb6b744017cfbc1c... commit f7a59da905ab7f8fb6b744017cfbc1cbf9f36ba8 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 4 21:30:03 2016 +0200 ssl: set protocol column to "TLS" when possible The protocol version from a SSL/TLS record contains the minimum supported SSL/TLS version and is the best guess for Client Hello handshake messages if no authorative version is available. By considering the version from the conversation for the initial col_set_str call, we can also remove some other calls down the road. Change-Id: I4be25f5c9057ffd0abcea7280d826867c135fed7 Reviewed-on: https://code.wireshark.org/review/17490 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=faa04b13186fe22afef6f659e7a26ec... commit faa04b13186fe22afef6f659e7a26ec0ef37b8a6 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Sep 7 14:39:46 2016 +0200 ipfix: use ws_strtoi function. Change-Id: Icca32f714381166e505932958b87f9ffab62aa1d Reviewed-on: https://code.wireshark.org/review/17557 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d5826f10bb2a9ebc2e990c10b5eeabd... commit d5826f10bb2a9ebc2e990c10b5eeabdcd3a32611 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Sep 7 14:18:06 2016 +0200 erf: use ws_strtoi function. Change-Id: I1d94deb547bd30076e0c171bf9e6b97aac98a545 Reviewed-on: https://code.wireshark.org/review/17556 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=fd38b0c3fbecfac5bf43d08033ea3c0... commit fd38b0c3fbecfac5bf43d08033ea3c02104cdf2f Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 9 01:34:13 2016 -0700 Fix copy-and-pasteo. Change-Id: Ifead0872053943b7cfe192e15d7099e2328ae456 Reviewed-on: https://code.wireshark.org/review/17603 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=d62d86729531eab7234cc5c3dae8444... commit d62d86729531eab7234cc5c3dae844429fea88d4 Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 9 01:31:23 2016 -0700 Get rid of trailing blank. Change-Id: I3aa2f4a6e25f610e0e9236835bbcb588eeb15c08 Reviewed-on: https://code.wireshark.org/review/17602 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=216392975dc441418b5272bce322445... commit 216392975dc441418b5272bce322445b542b2a0a Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 9 01:30:12 2016 -0700 Clean up error reporting. Have xml_get_int() handle the setting of the two error reporting values and give a better error message. Have it check to make sure that there isn't cruft after the digits. Change-Id: Id590430eb52668ef76de8aa7096a27d8fc094208 Reviewed-on: https://code.wireshark.org/review/17601 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=381be238ad93c992f19020c9d9ceb16... commit 381be238ad93c992f19020c9d9ceb16a98634317 Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 9 00:50:08 2016 -0700 Add a comment. Change-Id: Ia5bedaf8718985b325ed244a471cdc4e27f2928f Reviewed-on: https://code.wireshark.org/review/17599 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4312ec8996bce797d961192e4f0742a... commit 4312ec8996bce797d961192e4f0742a572cbe8f3 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Sep 7 14:07:51 2016 +0200 dct3trace: use ws_strtoi function. Change-Id: Iaa656dc4b939ac9649b87e88c9d27082d3e53f00 Reviewed-on: https://code.wireshark.org/review/17555 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=113c1ed24f21f4e3447b9374d109c76... commit 113c1ed24f21f4e3447b9374d109c7606e37d903 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 6 17:44:56 2016 +0200 catapult: use ws_strtou/i functions. Change-Id: I0a9d3674c0cc2d0dba8c1fbeba2d739373cf8655 Reviewed-on: https://code.wireshark.org/review/17535 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1948f7bd7553f215dc2519a35dcd62e... commit 1948f7bd7553f215dc2519a35dcd62e29e35a614 Author: Jeff Layton <jlayton@redhat.com> Date: Fri Sep 2 12:02:32 2016 -0400 nfs: add dissector for CB_NOTIFY_LOCK args Show the filehandle and lockowner for the callback. Change-Id: Id09b260d4b31f8fa35ba8452dc143095e5cc88ec Signed-off-by: Jeff Layton <jlayton@redhat.com> Reviewed-on: https://code.wireshark.org/review/17574 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6519f8e4e81d838e49bf4e4cef179f9... commit 6519f8e4e81d838e49bf4e4cef179f968378f62d Author: Makoto Shimamura <makoto.shimamura@toshiba.co.jp> Date: Tue Sep 6 20:55:10 2016 +0900 OCFS2: dissector incorrectly parses LVB data and claims malformed message Some messages related to LVB data are mistakenly treated as malformed. This patch fixes it by checking LVB flags before parsing LVB data. I found that "Convert lock" and "Unlock" use PUT_LVB flags, but "Proxy AST" uses GET_LVB flags. Ping-Bug: 12122 Change-Id: I2c62c8cc9f9bd84abaf92de9f216550101962520 Reviewed-on: https://code.wireshark.org/review/17532 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=bd45929ba6075c4f41a3df87d823cb2... commit bd45929ba6075c4f41a3df87d823cb2dac3bae55 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 8 13:43:00 2016 -0700 extcap_child_watch_cb() always uses the status argument. Change-Id: I2537f2e3babe2158796acda6855f5aebeb0b7d4d Reviewed-on: https://code.wireshark.org/review/17595 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f1a7497b5341dba1f07bac9894a7132... commit f1a7497b5341dba1f07bac9894a713263257b08f Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 8 20:41:05 2016 +0200 IRemUnknown: initialize remunk_remqueryinterface_call_t structure Bug: 12841 Change-Id: I5916c30a18029d0872e0439d3393eaa6d27964dd Reviewed-on: https://code.wireshark.org/review/17589 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fb85325d695a2c8d7b78073f5f493df... commit fb85325d695a2c8d7b78073f5f493dfbfe496956 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 8 19:57:04 2016 +0200 IPP: fix use after free error Packet memory pool is already freed when columns are printed Bug: 12840 Change-Id: If3e63586f14872aafe701612998370fffe506443 Reviewed-on: https://code.wireshark.org/review/17584 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2f0a99eab34b36bba3e5069be155b05... commit 2f0a99eab34b36bba3e5069be155b05665cc8783 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 8 17:56:19 2016 +0200 M2AP: fix a typo leading to an expert info when decoding an IPv6 address Change-Id: I10b67541427ca39a8f1d0989d680841b9d7883c9 Reviewed-on: https://code.wireshark.org/review/17581 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d0e55f0f6dd6850bdf7c082f859f8d3... commit d0e55f0f6dd6850bdf7c082f859f8d3d913fa943 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 8 20:06:37 2016 +0200 M3AP: fix dissection of IP address Change-Id: I96faed61c33f6fe14cc4196c3440d873b69d5334 Reviewed-on: https://code.wireshark.org/review/17585 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a1368ce47d155cb00437c7189285808... commit a1368ce47d155cb00437c7189285808a3271e3c9 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 8 11:40:20 2016 -0700 Use get_nonzero_guint32() to fetch guint32 values. Change-Id: I3adeb2974b1093270bec12039cd855c92f660f4d Reviewed-on: https://code.wireshark.org/review/17588 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=83eb448dfcf7804582f904a8f253718... commit 83eb448dfcf7804582f904a8f253718bbfbd5e3c Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 8 11:38:03 2016 -0700 Fix the signature of the stub version of ws80211_set_freq(). Change-Id: I5f0da4fb5d8d452f3cff3d37e0749dde8e98b600 Reviewed-on: https://code.wireshark.org/review/17587 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=fcb6fd3b6fcc6b3ed56cbd81c419b28... commit fcb6fd3b6fcc6b3ed56cbd81c419b28920f2ec70 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Sep 5 15:45:21 2016 +0200 dumpcap: change types. Change-Id: I6520971e607623dadcb3ae392ce264bf49c621bd Reviewed-on: https://code.wireshark.org/review/17499 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e09b03e9b131b3a43e4d8e43cc2c667... commit e09b03e9b131b3a43e4d8e43cc2c667bcb8d0a68 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Sep 8 11:26:45 2016 -0700 Add get_ routines to get a guint32, and use them. By analogy to get_natural_int() and get_positive_int(), add routines to get a guint32 and to get a non-zero guint32, doing all the necessary error checks, and use it. Change-Id: I65a9ac8a3d136886df3588806ae7af5bdc7b8cb6 Reviewed-on: https://code.wireshark.org/review/17586 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=132632bcd96e4ee1ad8e395926af205... commit 132632bcd96e4ee1ad8e395926af2050545878c4 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Sep 5 15:50:38 2016 +0200 editcap: use ws_strtou/i functions. Change-Id: Ib69241eb04088fe32f53ac4e87911499cf5e9e40 Reviewed-on: https://code.wireshark.org/review/17500 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=468acff2bd38227ff04421cb964fe0c... commit 468acff2bd38227ff04421cb964fe0cea0eeeccb Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 8 17:04:43 2016 +0200 PER: only display internal extension presence bit if activated in preferences Change-Id: I889b32c5e609c8c10ed2a8aa5a5e6d5b88baadc4 Reviewed-on: https://code.wireshark.org/review/17580 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6652620f272a1d408e291e2738576af... commit 6652620f272a1d408e291e2738576af1c3127333 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 8 16:49:34 2016 +0200 M2AP: display IP address in a subtree Change-Id: Ic1853e1d265797e482495b8d07aa324545a7442e Reviewed-on: https://code.wireshark.org/review/17579 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=1e83b59af8698256c11bb66fe13f912... commit 1e83b59af8698256c11bb66fe13f912f3ba75471 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 8 07:20:29 2016 +0200 U3V: ensure that gencp_transaction_t structure is fully initialized Bug: 12829 Change-Id: Iee8817fc0331af037284e5ec21b30671c6b3bd7d Reviewed-on: https://code.wireshark.org/review/17569 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b20b9c9b67266226bb2626bf5bc0966... commit b20b9c9b67266226bb2626bf5bc0966b1c8228e2 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Sep 7 15:22:01 2016 +0200 QUIC: Add FHOL (Force Head Of Line blocking) tag from Q036 Change-Id: Ieb0d1d0b2ebe2a6f325cdd18ef51677ee1a5535e Reviewed-on: https://code.wireshark.org/review/17564 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=03e4307cb2daf1f208d3653b04f6458... commit 03e4307cb2daf1f208d3653b04f64580ee6d0c38 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Sep 7 22:56:39 2016 +0200 NBT: fix Bad description for NBSS error code 0x81 Issue reported by Pavel Kankovsky https://tools.ietf.org/html/rfc1002#section-4.3.4 Bug:12835 Change-Id: Iac7e58b9fd61f1f0dfd86960ef4f306ac6ed5a9c Reviewed-on: https://code.wireshark.org/review/17565 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=35affe3be4e0695aba501f4e1aa48fc... commit 35affe3be4e0695aba501f4e1aa48fc0d28ce86f Author: Michael Sweet <michael.r.sweet@gmail.com> Date: Sat Aug 20 12:09:25 2016 -0400 Changes to the IPP dissector: - xxx-time values are not UNIX timestamps (that is a CUPS-ism - they are time since bootup in IPP itself) - Change all of the display strings to use the official IANA values (confusing otherwise) - Add support for newer value/group tags. - Add support for all enum attribute values. - Add request/response tracking so you can easily match things up. - Decode octetString, rangeOfInteger, textWithLanguage, nameWithLanguage, dateTime, and resolution values. - Don't treat integers and enums as interchangeable (they aren't). - Integers and enums are signed integers. - Put operation id or status code in info column. Change-Id: I9fb5cd89d3c386a2b3932ef4c75967ce2547bc22 Reviewed-on: https://code.wireshark.org/review/17192 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Smith Kennedy <smith.kennedy@hp.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c9a3b72f4a567e2a33ac9a84a021f05... commit c9a3b72f4a567e2a33ac9a84a021f05f8e4a2e46 Author: Gerald Combs <gerald@wireshark.org> Date: Wed Sep 7 12:53:34 2016 -0700 Note recent packaging updates. Add notes about the Windows Installer and source packages. Change-Id: Ic1aea3b547afab6dfdf0218b6ea257046a20cf00 Reviewed-on: https://code.wireshark.org/review/17562 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c7fc2802221877d939bb939f04766a5... commit c7fc2802221877d939bb939f04766a5a30cfdb9f Author: Guy Harris <guy@alum.mit.edu> Date: Wed Sep 7 10:43:15 2016 -0700 Make the ws_strto* routines more like the strto* routines. Not all uses of atoi() or various strto* routines in Wireshark expect the string to contain *only* a number, so not all uses should require that the byte after the number be a '\0'. Have the ws_strto* routines take a "pointer a pointer set to point to the character after the number" argument, and have the callers do the appropriate checks of the character after that. This fixes the VMS trace reading code so that it can read those files again. The get_ routines are handed command-line arguments, so they *do* expect the string to contain only a number; have them check to make sure the byte after the number is a '\0'. Change-Id: I46fc1bea7912b9278e385fe38491a0a2ad60d697 Reviewed-on: https://code.wireshark.org/review/17560 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a66aa4c9c90017f0c03412b02a2be2b... commit a66aa4c9c90017f0c03412b02a2be2b2cef3ac5d Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Sep 7 22:15:31 2016 +0200 Add M2AP to release notes Change-Id: Ied05b57c668d99bf386e8ced55c13bf8c17c453b Reviewed-on: https://code.wireshark.org/review/17563 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f90d436a7e1c4aee19b4b3b83263d3a... commit f90d436a7e1c4aee19b4b3b83263d3ac606ff0b7 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Tue Sep 6 20:43:17 2016 +0100 ICMP: Avoid spurious reply not found for broadcast ping Bug: 12830 Change-Id: Ie73b2b6e75c396660d0d2f2fc975c57bbb58d2eb Reviewed-on: https://code.wireshark.org/review/17541 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=693c745e36eb93fca6a06507bd1b63e... commit 693c745e36eb93fca6a06507bd1b63e3503dcb98 Author: Marius Paliga <mareko.paliga@gmail.com> Date: Wed Sep 7 11:17:25 2016 +0200 Add support for TWAN-User-Location-Info Bug: 12834 Change-Id: Ibb196a4e1e8d05b3f124409b18093623f3694af0 Reviewed-on: https://code.wireshark.org/review/17553 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ee1a4109cfc8fb314d151f59859a348... commit ee1a4109cfc8fb314d151f59859a348765ba9dbf Author: Roland Knall <roland.knall@br-automation.com> Date: Mon Sep 5 07:54:47 2016 +0200 extcap: Add tool-specified helppage Allow the tool to provide a link to a helppage, displayed by clicking on help in the configuration dialog. The URL will be opened using an URL based service, therefore local as well as remote URLs are possible. Change-Id: I58b30244e97919d5cf6892faf96536ddc30fb5a7 Reviewed-on: https://code.wireshark.org/review/17549 Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=859cf86c8d25b7ead113821ece4e9de... commit 859cf86c8d25b7ead113821ece4e9dec853e70d6 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Sep 7 10:54:08 2016 +0200 M2AP: fix dissection of procedure codes Change-Id: I6c8f01e65a16561ff78593edc263fb26d99c182b Reviewed-on: https://code.wireshark.org/review/17552 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=773c71f0bca3ae92a5fc2e7864373c7... commit 773c71f0bca3ae92a5fc2e7864373c73938b22c3 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Sep 7 10:33:03 2016 +0200 M3AP: display short protocol name in protocol column Change-Id: I7575caad67101d394c2c80d4bfd81f83389043aa Reviewed-on: https://code.wireshark.org/review/17551 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=affa9df885e44238eca06ac6eb93f2b... commit affa9df885e44238eca06ac6eb93f2bd8472d20a Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 08:16:30 2016 +0200 QUIC: Add preference to force decode all payload For debugging... Change-Id: I23eb70c89ac95371e1d7b05a52ffeed4f993a52a Reviewed-on: https://code.wireshark.org/review/17135 Reviewed-by: Lucas Pardue <lucas.pardue@bbc.co.uk> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7786a975af5492160e48a2d0168365b... commit 7786a975af5492160e48a2d0168365b57e0a0770 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Sep 6 21:47:27 2016 -0700 Further ws_strto* cleanups. Make pkt_len unsigned. Improve the error message for ws_strtou32() failure. Change-Id: I080b4fc132c8e405bc1dbd87fc717c2b337517bc Reviewed-on: https://code.wireshark.org/review/17547 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c95c536f47fbf0daac4f6f6258ed890... commit c95c536f47fbf0daac4f6f6258ed8902766a9a3c Author: Makoto Shimamura <makoto.shimamura@toshiba.co.jp> Date: Tue Sep 6 22:36:33 2016 +0900 OCFS2: dissector incorrectly takes pdu length as little endian This patch fixes incorrect endian conversion in pdu length. Actually pdu length is big endian. Ping-Bug: 12122 Change-Id: I9f8827293e684a5b4c957138f5879efdd140c500 Reviewed-on: https://code.wireshark.org/review/17533 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4c39e19ff3f2e31d1323dc95a3f2b2e... commit 4c39e19ff3f2e31d1323dc95a3f2b2e958ffa752 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 6 17:58:43 2016 +0200 vms: use ws_strtoi function. Change-Id: I30c32a6fc4200da5a150769b84f91b4d193f8f5d Reviewed-on: https://code.wireshark.org/review/17536 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a4c95ebe0309f25c9ced56e8032e5d8... commit a4c95ebe0309f25c9ced56e8032e5d8c0ba0523c Author: Makoto Shimamura <makoto.shimamura@toshiba.co.jp> Date: Mon Sep 5 21:01:54 2016 +0900 OCFS2: dissector incorrectly treats keepalive messages as unknown type Keepalive req/resp messages are shown as "Unknown type (0x00)" in info column. This patch fixes them to "Keepalive Request" and "Keepalive Response". Ping-Bug: 12122 Change-Id: If09192067736b78c7785ba1ff05ae62a05d3dc23 Reviewed-on: https://code.wireshark.org/review/17497 Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0495fc3bdd89d40fdb10108fea80f0c... commit 0495fc3bdd89d40fdb10108fea80f0cb8d9825de Author: Guy Harris <guy@alum.mit.edu> Date: Tue Sep 6 20:51:23 2016 -0700 Add some notes about XLC, HP C, and Sun/Oracle C. Change-Id: I2f65face2aa7354ec350aed308402bb719bd619f Reviewed-on: https://code.wireshark.org/review/17546 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5c388384329775538d618681f571d5f... commit 5c388384329775538d618681f571d5f052bc2ae6 Author: Gerald Combs <gerald@wireshark.org> Date: Tue Sep 6 16:57:56 2016 -0700 Place variable declarations where they're used. Fix ../../ui/io_graph_item.h:251:29: warning: will never be executed [-Wunreachable-code] guint64 t, pt; /* time in us */ ^ Change-Id: I0e861e892c2c03151d9f98e31ac68ce296baa26a Reviewed-on: https://code.wireshark.org/review/17545 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=facc9535044bf082bf958be47babba4... commit facc9535044bf082bf958be47babba4f35b9fa2e Author: Gerald Combs <gerald@wireshark.org> Date: Tue Sep 6 15:59:24 2016 -0700 Autotools: Distribute packaging/wix. …otherwise you can't compile from the tarball on Windows. Change-Id: I99c73b09d9468f0da753c05451fa54348680963f Reviewed-on: https://code.wireshark.org/review/17543 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=9fb9e9f5a9d4130a67c22d0807af0d4... commit 9fb9e9f5a9d4130a67c22d0807af0d4027ef2322 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Sep 6 22:59:45 2016 +0200 X2AP: prettify info column Change-Id: I1630199383e0b83bf14e8d9850870268d7db777c Reviewed-on: https://code.wireshark.org/review/17542 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9be89dd8e85dcbc53961abdb2bdaf7f... commit 9be89dd8e85dcbc53961abdb2bdaf7fdc1b42784 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Sep 6 21:24:13 2016 +0200 X2AP: upgrade dissector to v13.4.0 Change-Id: I97250d022a40ac888522f885968e7cd3c86e3485 Reviewed-on: https://code.wireshark.org/review/17540 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=26551ba411a41f5fc35141031f04b44... commit 26551ba411a41f5fc35141031f04b4462c039c8f Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 6 14:42:29 2016 +0200 ciscodump: fix line parsing and fix memleak. Change-Id: I4aee51d7def06317a543fdc8fa05120af0e68453 Reviewed-on: https://code.wireshark.org/review/17531 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=595610f9cc2a27f0eb495c2513499e6... commit 595610f9cc2a27f0eb495c2513499e615666cf7e Author: Guy Harris <guy@alum.mit.edu> Date: Tue Sep 6 11:00:57 2016 -0700 Always set *cint before returning. Change-Id: I333aef7d3fe4ad3bf7c2a4d7318766fcbd2e4cd2 Reviewed-on: https://code.wireshark.org/review/17539 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=295dbc609dab17d396a69e460ac9561... commit 295dbc609dab17d396a69e460ac956151d3ef32d Author: Guy Harris <guy@alum.mit.edu> Date: Tue Sep 6 10:14:12 2016 -0700 Suppress another warning if told not to report failures. That's another failure that can occur if you're trying to load a libwireshark plugin in a program that doesn't use libwireshark if, for example, references to an undefined symbol don't prevent the module from being loaded in the first place. Change-Id: I21629c0094fdca7dfbd88f39b7e6c10fb600b401 Reviewed-on: https://code.wireshark.org/review/17537 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=7a674c006b3d09735c9340ad74f0255... commit 7a674c006b3d09735c9340ad74f02556fbd91cbd Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 4 01:23:37 2016 +0200 ssl: fix TLS renegotiation, add test for this A handshake starts a new session, be sure to clear the previous state to avoid creating a decoder with wrong secrets. Renegotiations are also kind of transparant to the application layer, so be sure to re-use an existing SslFlow. This fixes the Follow SSL stream functionality which would previously ignore everything except for the first session. The capture file contains a crafted HTTP request/response over TLS 1.2, interleaved with renegotiations. The HTTP response contains the Python script used to generate the traffic. Surprise! Change-Id: I0110ce76893d4a79330845e53e47e10f1c79e47e Reviewed-on: https://code.wireshark.org/review/17480 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=36c8065cc3fbe7eb36dd8474e53aca3... commit 36c8065cc3fbe7eb36dd8474e53aca36cdca624d Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Sep 6 12:41:23 2016 +0200 strtoi(.c): fix extra ';' outside of a function [-Wextra-semi] Change-Id: I2d92678b2117da732be309c2d430d0c97c7a7eed Reviewed-on: https://code.wireshark.org/review/17528 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3fce8da341b12cf3bcb3bf8e7473e1a... commit 3fce8da341b12cf3bcb3bf8e7473e1a7efbbba3f Author: Dario Lombardo <lomato@gmail.com> Date: Tue Sep 6 13:41:46 2016 +0200 checkAPI: move atoi from deprecated to soft-deprecated list. atoi must lie in soft-deprecated list until close to complete removal. Change-Id: Ia26ada56114559637fdc598913ee93523ed9434d Reviewed-on: https://code.wireshark.org/review/17529 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=10e84a612b629341acd9cd20876517e... commit 10e84a612b629341acd9cd20876517e5bab63d37 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 4 02:06:50 2016 +0200 ssl: really fix session resumption expert info In a two-pass dissection with renegotiated sessions, the is_session_resumed flag is not updated according to the current protocol flow. Fix this by performing detection of abbreviated handshakes in all cases, do not limit it to the decryption stage (where ssl != NULL). Reset the resumption assumption after the first ChangeCipherSpec (normally from the server side, but explicitly add this in case client packets somehow arrive earlier in the capture). This should not have a functional effect on normal TLS captures with Session Tickets. Bug: 12793 Change-Id: I1eb2a8262b4e359b8c1d3d0a1e004a9e856bec8c Reviewed-on: https://code.wireshark.org/review/17483 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=c8de455f4bcab0c560ec74bc0c1d3c4... commit c8de455f4bcab0c560ec74bc0c1d3c46dad07270 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Sep 6 10:13:20 2016 +0200 zvt: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I68b4fa08a7f65b92e56a6e72a6bb113e72ee33da Reviewed-on: https://code.wireshark.org/review/17524 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=27d522dad3a052e75ea0c51c465d02c... commit 27d522dad3a052e75ea0c51c465d02cf9dcc8e96 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Sep 6 08:06:19 2016 +0200 SMB2: Always display reserved field Change-Id: Ic26603488cb020da3885f5bc97c65aae18fdf191 Reviewed-on: https://code.wireshark.org/review/17517 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3b3c515ab25829a1c556c8bd490eac2... commit 3b3c515ab25829a1c556c8bd490eac22e7964873 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Sep 6 07:52:06 2016 +0200 smb2: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I714e2ea4808213901a8be64e65a0cb37c3002372 Reviewed-on: https://code.wireshark.org/review/17516 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b6dd50f848355ccfa272c1629a35780... commit b6dd50f848355ccfa272c1629a3578052d9355f7 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 2 10:19:44 2016 +0200 caputils: add conditional unused (_U_). Change-Id: I50ccedd876bf78961397b55e5a707c98900f7b9f Reviewed-on: https://code.wireshark.org/review/17457 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9b39db04d3cda98b916b3970270b3a2... commit 9b39db04d3cda98b916b3970270b3a247143adfe Author: Roland Knall <roland.knall@br-automation.com> Date: Mon Sep 5 13:29:23 2016 +0200 extcap:Replace self-organized lists with glib ones Replace the error-prone next/prev handling with GList and GHashTable Cleanup extcap_parser to only expose necessary functions Remove token know-how from extcap Change-Id: I7cc5ea06f58ad6c7a85ac292f5d2cb3d33e59833 Reviewed-on: https://code.wireshark.org/review/17496 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4ec767588248b4b42a423c56772707a... commit 4ec767588248b4b42a423c56772707a974605875 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 19:43:48 2016 -0700 We now support C++/C99-style comments. Change-Id: I175a6b0060235c2dfc7a5b3dc4ab62843d242e94 Reviewed-on: https://code.wireshark.org/review/17514 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=232a8794293bf654fb61122adffa6a7... commit 232a8794293bf654fb61122adffa6a7aa2989cc0 Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Aug 31 15:58:20 2016 +0200 Allow a lot more C99 features Flexible array members are supported by gcc, clang and even MSVC2013. Note, so far it was only used in the Windows-specific airpcap.h. Trailing commas in enum declaration are already in use since for these dissectors (commit ID is the first occurrence): epan/dissectors/packet-gluster.h v2.1.0rc0-1070-g3b706ba epan/dissectors/packet-ipv6.c v2.1.2rc0-81-ge07b4aa epan/dissectors/packet-netlink.h v2.3.0rc0-389-gc0ab12b epan/dissectors/packet-netlink-netfilter.c v2.3.0rc0-239-g1767e08 epan/dissectors/packet-netlink-route.c v2.3.0rc0-233-g2a80b40 epan/dissectors/packet-quic.c v2.3.0rc0-457-gfa320f8 Inline functions using the "inline" keyword are supported via all glib versions we support (if it is missing, glib will define a suitable inline macro). Other c99 functions listed in the README.developer document were found to be compatible with GCC 4.4.7, Clang 3.4.2 and MSVC 2013. Change-Id: If5bab03bfd8577b15a24bedf08c03bdfbf34317a Reviewed-on: https://code.wireshark.org/review/17421 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5eb9170227a590560003dfc3b654e7b... commit 5eb9170227a590560003dfc3b654e7be1b942b9a Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 19:23:36 2016 -0700 Use ws_strtoi32() in get_natural_int(). Change-Id: I9a95239de8db18cff0f6c62cb526f3ef0cb29f01 Reviewed-on: https://code.wireshark.org/review/17513 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9ef70fce3c13d37527466ee67a47fa9... commit 9ef70fce3c13d37527466ee67a47fa9bfd65f9fa Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 19:05:11 2016 -0700 Return the maximum or minimum value for ERANGE. That way, for signed values, the caller knows whether ERANGE means "too large" or "too small"; this is analogous to what the C routines return. Change-Id: Ifc1fc4723733be606487093f8aa77ae2d89d2c40 Reviewed-on: https://code.wireshark.org/review/17512 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=97103d40e36134436f96cc5efd06bbf... commit 97103d40e36134436f96cc5efd06bbf2eccf734b Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 18:08:08 2016 -0700 Check for signs in unsigned numbers and fail if we see one. -1 is not an unsigned number. For that matter, neither is +1; "unsigned" means "without a sign", and they both have signs. ANSI C's strto{whatever} routines - even the ones that supposedly are for "unsigned" values - and the GLib routines modeled after them allow a leading sign, so we have to check ourselves. Change-Id: Ia0584bbf83394185cde88eec48efcdfa316f1c92 Reviewed-on: https://code.wireshark.org/review/17511 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4adf7f2be5b9132a0aef3e8f8f57ed5... commit 4adf7f2be5b9132a0aef3e8f8f57ed525cff2e8e Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 17:57:29 2016 -0700 Use get_positive_int() to parse signed positive arguments. Change-Id: I323b2c203b49a6921251583772bdb3c3afacd31b Reviewed-on: https://code.wireshark.org/review/17510 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c02865d3feba49bf6aaa9ce7190883c... commit c02865d3feba49bf6aaa9ce7190883c2f11e5631 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 17:51:43 2016 -0700 Return after calling cmdarg_err(). cmdarg_err() prints a message, but it doesn't exit. Change-Id: I887d96bce483f873a4375cb6b5254915d014f1b1 Reviewed-on: https://code.wireshark.org/review/17509 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c1dcaff9417ba8697d9686185002ab0... commit c1dcaff9417ba8697d9686185002ab03fee83fe5 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 17:33:20 2016 -0700 Use get_positive_int() to parse signed positive arguments. Clean up indentation while we're at it. Change-Id: Ie7223f96c758bd71d2435203635db9c2b28e2249 Reviewed-on: https://code.wireshark.org/review/17508 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=94d8250bd00b30e6b0935a0c48d78be... commit 94d8250bd00b30e6b0935a0c48d78bec0f2a9242 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 16:39:25 2016 -0700 Use get_positive_int() to parse signed positive arguments. Change-Id: Id17b56704f484abdf047a3d1b0775f7fa46eb380 Reviewed-on: https://code.wireshark.org/review/17507 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2a38dc74ede3eba69f0d73b61f1735a... commit 2a38dc74ede3eba69f0d73b61f1735a4036528c1 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 16:26:29 2016 -0700 Have scan_plugins() take an argument specify what to do on load failures. That's a less gross hack to suppress load failures due to not having libwiretap than providing a no-op failure-message routine, as it at least allows other code using a failure-message routine, such as cmdarg_err() and routines that call it, to be used. We really should put libwiretap and libwireshark plugins into separate subdirectories of the plugin directories, and avoid even looking at libwireshark plugins in programs that don't use libwireshark. Change-Id: I0a6ec01ecb4e718ed36233cfaf638a317f839a73 Reviewed-on: https://code.wireshark.org/review/17506 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ae877942ea507128d3191e17075a26b... commit ae877942ea507128d3191e17075a26b86e52615d Author: Guy Harris <guy@alum.mit.edu> Date: Mon Sep 5 13:45:35 2016 -0700 Report an error if the channel type isn't valid. Change-Id: Ie9d47da4b1758cbf475989a04847853a714e1447 Reviewed-on: https://code.wireshark.org/review/17503 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=70f3737c3e4d9402cb2bb67cdd892e0... commit 70f3737c3e4d9402cb2bb67cdd892e0e7e0ee991 Author: Mirko Parthey <mirko.parthey@web.de> Date: Mon Sep 5 16:39:45 2016 +0200 ISAKMP: Fix handling of cert requests without CA Check IKEv1 Certificate Request Payloads for an empty Certificate Authority field, which is allowed by RFC 2408. Suppress dissection of this field if it is indeed empty. Change-Id: Ifb997e460a4c12003215fde86c374cfc769c5d72 Reviewed-on: https://code.wireshark.org/review/17501 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=474199a974f89cf732c7809b68ed05d... commit 474199a974f89cf732c7809b68ed05d93741cb33 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Sep 5 17:53:42 2016 +0200 checkAPI: add deprecated atoi. Instead use ws_strtoi/u functions. atoi() doesn't make any kind of check so it should be avoided. ws_strtoi/u should be used instead of strtol & co., but they're still acceptable for some cases that deviate from the basic usage. Change-Id: I145ff4d8f893852e024c4ea8fc6a836b15bd2b0d Reviewed-on: https://code.wireshark.org/review/17502 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ba981aced8c64ff405cd42b071264e2... commit ba981aced8c64ff405cd42b071264e2d9791444a Author: Dario Lombardo <lomato@gmail.com> Date: Tue Aug 30 17:52:54 2016 +0200 wsutil: add string to integer conversion utilities. In the current code many functions have been used for convertion (strtol, atoi, g_ascii_strtoll, etc). Those utilities want to be the only, shared, way to convert integers. Change-Id: I22ba1bf54e144e73a4728612a4437de5a2d339e2 Reviewed-on: https://code.wireshark.org/review/17414 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=87519e4c06260f78ecd55defb86bb20... commit 87519e4c06260f78ecd55defb86bb20c3f4d7697 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Sep 4 22:21:42 2016 +0200 S1AP: fix dissection of TransportLayerAddress IE when it contains both IPv4 and IPv6 Change-Id: I8c257d79b4e842da6853ea3c53ae479f33a8047a Reviewed-on: https://code.wireshark.org/review/17491 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=98b5820546ffeea7700c0d74258eaf3... commit 98b5820546ffeea7700c0d74258eaf3b7b235d5c Author: Martin Kaiser <wireshark@kaiser.cx> Date: Sun Sep 4 18:58:35 2016 +0200 zvt: dissect Initialisation message It contains the same password field that appears in the Registration message. Make this field generic and reuse it here. Change-Id: I7be9a99b5da1713937ffca5624be66150ff453d1 Reviewed-on: https://code.wireshark.org/review/17489 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=397a9d0b2e6b763163d306772a0a7a2... commit 397a9d0b2e6b763163d306772a0a7a20afe4b8df Author: Martin Kaiser <wireshark@kaiser.cx> Date: Sun Sep 4 18:42:03 2016 +0200 zvt: start dissecting Intermediate Status Information Change-Id: I351621f1def5ad6da577a9b0d1b2c5ab49018564 Reviewed-on: https://code.wireshark.org/review/17488 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=6c462790a18ea66068b4f4542bc6d99... commit 6c462790a18ea66068b4f4542bc6d99bcaa7617c Author: Martin Kaiser <wireshark@kaiser.cx> Date: Sun Sep 4 18:20:41 2016 +0200 zvt: dissect the currency code bitmap add the value for euro Change-Id: Id8624e356ad4fcddcf77483a721428782c6bb0b2 Reviewed-on: https://code.wireshark.org/review/17487 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> http://cgit.osmocom.org/wireshark/commit/?id=54b2f2d95d247ecbf9fa65bece785e7... commit 54b2f2d95d247ecbf9fa65bece785e78635b70bd Author: Gerald Combs <gerald@wireshark.org> Date: Sun Sep 4 08:12:46 2016 -0700 [Automatic update for 2016-09-04] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I11d066907492642f5baaa38a79b8bcd086a579c4 Reviewed-on: https://code.wireshark.org/review/17484 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=668e6bc83157f93f20933c2668c04d8... commit 668e6bc83157f93f20933c2668c04d8143ef3dbb Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Sun Sep 4 00:32:33 2016 +0200 ANSI_A: Rationalize test expession (CID-1372216 ... 1372267) Implement the same changes in the ELEM_TLV() and ELEM_TV() macros as in packet-gsm_a_common.h, to remove superfluous code and squelch about 50 Coverity issues. Change-Id: I262dc60fdfa3482876d8525b34f6b1dbbe371257 Reviewed-on: https://code.wireshark.org/review/17478 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7c7497a77e30f8098bcaffd0a9c96be... commit 7c7497a77e30f8098bcaffd0a9c96be24855c0e8 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Sep 4 13:40:20 2016 +0200 ssl,http: rename http-over-ssl to http-over-tls This name is displayed in the SSL prototcol tree (Application Data Protocol: http-over-tls), rename to avoid possible user confusion. Modify the SSL dissector such that both "http" and "http-over-tls" invoke the same dissector function. Change-Id: I2d52890a8ec8fa88b6390b133a11df607a5ec3dc Reviewed-on: https://code.wireshark.org/review/17481 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=29a243d61cb1ae9d6eda404dad2038b... commit 29a243d61cb1ae9d6eda404dad2038b85cfdb487 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sun Sep 4 11:52:24 2016 +0200 irda: restore a line removed by mistake in ge4c059f Bug: 12821 Change-Id: If6423c7f8443eccd6ddb4b699bbc327a965d0d74 Reviewed-on: https://code.wireshark.org/review/17477 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4ec5cbe2d4583f0a09f91ea82e5ff29... commit 4ec5cbe2d4583f0a09f91ea82e5ff298460a370d Author: Uri Simchoni <urisimchoni@gmail.com> Date: Thu Sep 1 23:52:41 2016 +0300 SMB2: dissect the buffer of getinfo quota request Source: [MS-SMB2] 2.2.37.1 Change-Id: I526066700a88398366f31cd51552f9fa8bb761b8 Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-on: https://code.wireshark.org/review/17447 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3b9771a424089d9b37c9bc3cb769b26... commit 3b9771a424089d9b37c9bc3cb769b26a4681995c Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sat Sep 3 23:17:34 2016 +0200 M2AP: fix registration of extensions in proper dissector table Change-Id: If529448539f9e8d740fd20009221e9221db83b2b Reviewed-on: https://code.wireshark.org/review/17475 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4a3b320c98febdd8fae2d3bb8f017b1... commit 4a3b320c98febdd8fae2d3bb8f017b1aa46f1b75 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sat Sep 3 19:59:26 2016 +0200 S1AP: add more LTE-RRC transparent containers dissection Change-Id: I08246d3fa97ceafefd3a1ab5c36de50a5728fd19 Reviewed-on: https://code.wireshark.org/review/17474 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8f5ab27b4fd0d7cf92a85416ce26c4f... commit 8f5ab27b4fd0d7cf92a85416ce26c4f9136273e5 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sat Sep 3 16:43:44 2016 +0200 Add M2AP dissector (3GPP 36.443 v13.3.0) Change-Id: I1a5d4390e91c5a758e52feba6059407d873adf7a Reviewed-on: https://code.wireshark.org/review/17472 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7471b467682f84501d15cebd580d0b2... commit 7471b467682f84501d15cebd580d0b28abd77cf5 Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Sep 2 00:01:38 2016 +0200 cmake: fix libnl caching issue, make it more robust Dario reported that the cmake build fails after installing libnl3-devel (libnl-devel was already present). This results from a name collision for NL_LIBRARY and NL_INCLUDE_DIR variables. Initially these variables contained the values for libnl-1. When libnl3 is installed, these variables were not updated (because it was cached), but HAVE_LIBNL3 would still be set, resulting in a header and feature mismatch. Use separate variables for libnl1 and libnl3 to fix this. Other fixes: also set HAVE_LIBNL for libnl1; fallback to libnl1 if libnl3 is unusable (e.g. because libnl-route-3.0 is missing). Change-Id: Icf0a03843ea870347ddf365f69bacf4883d07f6d Reviewed-on: https://code.wireshark.org/review/17449 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=a547dfb8ded32d68073de14b5a0f8ef... commit a547dfb8ded32d68073de14b5a0f8ef773d0bbf5 Author: Uri Simchoni <urisimchoni@gmail.com> Date: Thu Sep 1 23:52:39 2016 +0300 SMB2: dissect getinfo request fixed parameters Dissect SMB2 getinfo request fix-sized parameters according to [MS-SMB2] section 2.2.37. This does not include extended attributes at the moment. Change-Id: I5281edf0c21517cdf43ef00e89b5680b8174c383 Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-on: https://code.wireshark.org/review/17444 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dae5f88339015f061428f3dbdf8936e... commit dae5f88339015f061428f3dbdf8936ee1b259e26 Author: Uri Simchoni <urisimchoni@gmail.com> Date: Thu Sep 1 23:52:40 2016 +0300 SMB: dissect FILE_GET_QUOTA_INFORMATION Add a function that dissects FILE_GET_QUOTA_INFORMATION structure ([MS-FSCC] 2.4.33.1) This structure is used to define a set of SIDs whose quota is to be fetched. Change-Id: I81f6bca98fb239935ca593bd8725cebbb2037fbe Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-on: https://code.wireshark.org/review/17445 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5846524f0ba9389e3f4f03546db2178... commit 5846524f0ba9389e3f4f03546db21782c2d22183 Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 1 13:51:13 2016 -0700 Qt: Conversation time column updates. Add a checkbox which lets you toggle between absolute and relative start times. Use the local time for now. Fixes bug 11618. Adjust our time precision based on the capture file's time precision. Fixes bug 12803. Update the User's Guide accordingly. Bug: 11618 Bug: 12803 Change-Id: I0049d6db6e4d0b6967bf35e6d056a61bfb4de10f Reviewed-on: https://code.wireshark.org/review/17448 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=df3bf9ca796dc2474c55c87f0ff8cb4... commit df3bf9ca796dc2474c55c87f0ff8cb4eab63d2f6 Author: Guy Harris <guy@alum.mit.edu> Date: Fri Sep 2 13:30:28 2016 -0700 Note that not all UN*X file systems are case-sensitive. Expand a comment to suggest what we should probably do on macOS. Change-Id: Ic18afe5d1b165dbb27b5f0f5ff3ff9a33835a0f4 Reviewed-on: https://code.wireshark.org/review/17470 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=770aaf1dde2c57687beb0ebe9a3af90... commit 770aaf1dde2c57687beb0ebe9a3af9003c3c2c14 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Fri Sep 2 14:10:31 2016 +0200 Qt: Preserve capture filter when preferences changed Avoid that the last entry from recent.capture_filter is added to the capture filter combo when editing preferences or changing profile. This bug was introduced in gb7897dde. Change-Id: I38a32386765c9e7ffaa93d006ff0ef7b78ac8252 Reviewed-on: https://code.wireshark.org/review/17453 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=893e0e96084fe0e559310d117fb953d... commit 893e0e96084fe0e559310d117fb953ddf08c0d6e Author: Gerald Combs <gerald@wireshark.org> Date: Tue Aug 30 12:12:33 2016 -0700 Qt: Add a timeline indicator to conversations. Add a timeline indicator to the Start and Duration columns in the Conversations dialog. Add tooltips to the columns that explain what's going on. Round the timeline rect corners and do the same for Prototocol Hierarchy Statistics. This should hopefully differentiate the graph bars from a text selection and IMHO it looks better. Update the PHS and Conversations images in the User's Guide. Change-Id: I61d6c25843be522cc444e01ba77cb5b1e991fa36 Reviewed-on: https://code.wireshark.org/review/17396 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2ddb46dbee7fbb06014a39bc87586b4... commit 2ddb46dbee7fbb06014a39bc87586b45453a7eaa Author: Dario Lombardo <lomato@gmail.com> Date: Thu Aug 25 10:18:11 2016 +0200 btavctp: rework the reassemble routine (CID 1355682). The CID is about the lack of check of wmem_tree_lookup32_le() return value, but the old code worths a bit of rework. Change-Id: I3adb868d2baa1c8aea3f914f7fb9fdf75f222960 Reviewed-on: https://code.wireshark.org/review/17322 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f01190ca90a52eb6da98315d16a5fb6... commit f01190ca90a52eb6da98315d16a5fb6f753f8659 Author: Peter Palúch <Peter.Paluch@fri.uniza.sk> Date: Tue Aug 30 11:37:38 2016 +0200 Reworked dissection of BGP Extended Community attributes This patch contains a partial rewrite of the BGP dissector for Extended Communities. The changes were primarily motivated by my dissatisfaction with the generally unreadable way in which the types, names and values of BGP Extended Communities were displayed in Wireshark GUI. The rewrite provides a hopefully more readable and eye-pleasing way of displaying the extended communities. I have also corrected numerous other flaws with the Extended Community dissector I stumbled across. In particular, the changes encompass the following: 1.) The Type octet of an Extended Community is now analyzed including its Authority and Transitivity bits. These were not dissected before. 2.) Dissection for EVPN Extended Community was improved. The original implementation blindly assumed that there is just a single subtype and decoded the community ignoring the actual subtype. 3.) I have removed the hf_bgp_ext_com_value_unknown16 and ..._unknown32. The current code uses a different approach to display values of unrecognized communities, and for recognized communities, there are no "unknown" subfields. 4.) Removed a couple of variables declared at the dissect_bgp_update_ext_com() level. These stored the result of a tvb_get_...() call but the value was used only once. I have replaced them with the direct use of tvb_get_...() 5.) Moved duplicate code to add the Type value into the community_tree from each branch in the switch(com_type_high_byte) out of it and placed it before the switch(). 6.) Reworked the style in which individual communities are displayed. Each community item (collapsed) is now displayed using the following label format: Community name: Values [Generic community type] Examples: Route Target: 1:1 [Transitive 2-Octet AS-Specific] Unknown subtype 0x01: 0x8081 0x0000 0x2800 [Non-Transitive Opaque] Unknown type 0x88 subtype 0x00: 0x0000 0x0000 0x0000 [Unknown community] 6.) To keep the filter names more consistent, changed names of selected filters: bgp.ext_com.type_high -> bgp.ext_com.type bgp.ext_com.type_low -> bgp.ext_com.stype_unknown In particular, I do not want to call the subtype as bgp.ext_com.type_low because that filter applied only to unrecognized subtypes even though its name would suggest to users that they can filter any community based on it. 7.) Numerous corrections in text labels, names and labels that have been incorrect or incomplete. Bug: 12794 Change-Id: I9653dbbc8a8f85d0cd2753dd12fd537f0a604cf3 Reviewed-on: https://code.wireshark.org/review/17377 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d68f62244d4aace823099199571f1b6... commit d68f62244d4aace823099199571f1b668162d939 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Sep 2 16:34:02 2016 +0200 aruba_erm: register dissector by name. Change-Id: Ifad70ed2ee2a554cdc31496ad47148728071abdb Reviewed-on: https://code.wireshark.org/review/17458 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fb7a60e611b4cea46978d4f2452fe9a... commit fb7a60e611b4cea46978d4f2452fe9ad7a1916ed Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Fri Sep 2 15:45:53 2016 +0200 Qt: Clear open files list when clear recent menu Remove all recent files from the main welcome page when clearing recent files from the menu. Change-Id: Ic410a729e63d82ee58b6bbb31f7e4a658b17d794 Reviewed-on: https://code.wireshark.org/review/17456 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=2cac0473be826dc0a042524884d9703... commit 2cac0473be826dc0a042524884d9703ec9c80230 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Fri Sep 2 15:21:46 2016 +0200 Qt: Add newly saved files to the recent files Update the recent files list when saving unsaved capture files. Change-Id: I469fa1f2ce3216c66de328c0b3558c9f9db115e0 Reviewed-on: https://code.wireshark.org/review/17454 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=12eee8420567f7bdcae50ce998e5e11... commit 12eee8420567f7bdcae50ce998e5e114f7328b25 Author: AndersBroman <anders.broman@ericsson.com> Date: Fri Sep 2 15:25:41 2016 +0200 [SIP] Call sub dissectors for Diagnostics in SIP reason texts. Change-Id: I68cbcf257b63a86ee37e1357876a90ea683a1d5a Reviewed-on: https://code.wireshark.org/review/17455 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2c5a485eefd84a2a08c375dca793ba8... commit 2c5a485eefd84a2a08c375dca793ba87f343b9a5 Author: Binh Trinh <beango@gmail.com> Date: Wed Aug 31 21:16:49 2016 -0400 GTP: continuation of patch for Target Identification, correction of PLMN in the case of non-compliance Change-Id: Id848574ea748786ccd6808d370cb480caa948cfb Reviewed-on: https://code.wireshark.org/review/17433 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e2b0aa21ea0f5ed136e802546c9861f... commit e2b0aa21ea0f5ed136e802546c9861f2e2609fd0 Author: Anthony Coddington <anthony.coddington@endace.com> Date: Tue Aug 30 11:04:23 2016 +1200 ERF: Fix dissector abort on short meta tags and typos Fix dissector abort on short tags. Fix value typo in hash mode enum. Differentiate unexpectedly short value, zero length (deliberate invalid) and off-end-of-record tags through expertinfo. Continue to use proto_tree_add_*() length mismatch warnings for unxepectedly long tags for now. Change WWN tags to FT_BYTES for now as they are 16 not 8 byte WWN. Not currently implemented outside Wireshark anyway. Ping-Bug: 12303 Change-Id: I79fe4332f0c1f2aed726c69acdbc958eb9e08816 Reviewed-on: https://code.wireshark.org/review/17382 Reviewed-by: Anthony Coddington <anthony.coddington@endace.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e0e2396bdb5b2575dd09619d36bcce9... commit e0e2396bdb5b2575dd09619d36bcce944f9c2cc6 Author: Uri Simchoni <urisimchoni@gmail.com> Date: Thu Sep 1 23:52:38 2016 +0300 SMB2: dissect class and infolevel in get quota info request (actually, in [MS-SMB2] those are called "InfoType" and "FileInfoClass", respectively) Change-Id: Id583be4574cea5ce092c374a5624a4bd17d5d4c6 Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-on: https://code.wireshark.org/review/17443 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=79b50207ba8bcb9a63d78ead35cf3ea... commit 79b50207ba8bcb9a63d78ead35cf3ea33c1b55b2 Author: Uri Simchoni <urisimchoni@gmail.com> Date: Thu Sep 1 23:52:37 2016 +0300 SMB2: dissect quota info This info appears in the request buffer of setinfo quota, or in the response buffer of getinfo quota. Change-Id: I5c8d96a05eddfa123547a7dd2577a01ac8cbd32d Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-on: https://code.wireshark.org/review/17442 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=aa2471dfd5fff5997ec0ebb7d69dd38... commit aa2471dfd5fff5997ec0ebb7d69dd380f28d3d83 Author: Uri Simchoni <urisimchoni@gmail.com> Date: Thu Sep 1 23:52:36 2016 +0300 SMB: make dissect_nt_user_quota public To be usable by SMB2 dissector Change-Id: I7f5b9a021951c2529f8058cd2fc160eff2e865c6 Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-on: https://code.wireshark.org/review/17441 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=416bd9a108cef32c870d1731efb82cf... commit 416bd9a108cef32c870d1731efb82cfffa0760b8 Author: Uri Simchoni <urisimchoni@gmail.com> Date: Thu Sep 1 23:52:33 2016 +0300 smb: parse user quota change time In SMB user quota records, parse unknown 8-byte field as quota record's last change time (source - [MS-FSCC] 2.4.33) Change-Id: I1f2839934fc0ab8e3d38105e02ef91a547256a70 Signed-off-by: Uri Simchoni <urisimchoni@gmail.com> Reviewed-on: https://code.wireshark.org/review/17440 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1ba3426f1840bd44765118671648414... commit 1ba3426f1840bd44765118671648414ff2c50c88 Author: Uli Heilmeier <uh@heilmeier.eu> Date: Mon Aug 29 21:07:28 2016 +0200 GSM MAP: Add OSM URI for locationEstimate As requested by bug 10969 add a link to OSM for locationEstimate. Bug: 10969 Change-Id: I715b3b5eae9728999d5c8f8c155bbcef3911ee93 Reviewed-on: https://code.wireshark.org/review/17375 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=abd78dc12ba9a93c0672f409f10a750... commit abd78dc12ba9a93c0672f409f10a7503e04535d2 Author: Gerald Combs <gerald@wireshark.org> Date: Thu Sep 1 15:09:12 2016 -0700 CMake: Move version declarations to the top of CMakeLists.txt. This lets me be more lazy during releases. Change-Id: Ie59e200f1f46282e9271f459c0bbf31dc74a59a7 Reviewed-on: https://code.wireshark.org/review/17450 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=80181532b62c19521c658f3bb281e49... commit 80181532b62c19521c658f3bb281e4956797a51c Author: Peter Wu <peter@lekensteyn.nl> Date: Thu Sep 1 02:04:31 2016 +0200 uat: fix memleak after parsing and on errors Memleaks could occur in these scenarios: - Two consecutive fields fail in their chk callback, overwriting the first heap-allocated error message. - After parsing one record, the internal record was never freed. - Syntax errors abort the parsing process and leaks the record and current field value. These leaks will only happen at startup, when the UAT files are read or when UAT strings are loaded (e.g. from the ssl.keys_list preference). Change-Id: I4cf7cbc8131f71493ba70916a8f60168e5d65148 Reviewed-on: https://code.wireshark.org/review/17432 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=27164ddc5bf3a9af17689732bb2562e... commit 27164ddc5bf3a9af17689732bb2562ec82a9ea73 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Sep 1 21:34:20 2016 +0200 E.212: update Chinese PLMN list Bug: 12798 Change-Id: Id9569cb0f79094d5152ea5949d398eb7384ee76f Reviewed-on: https://code.wireshark.org/review/17439 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e7cac432fb5ffeed6904a3429ffcd88... commit e7cac432fb5ffeed6904a3429ffcd885cef652c0 Author: Peter Wu <peter@lekensteyn.nl> Date: Thu Sep 1 00:30:23 2016 +0200 uat: clarify documentation No functional change, fixes typos, adds some meaningful function parameters and tries to clarify the memory management concerns. Also fix a -Wdocumentation issue in epan/proto.h Change-Id: I59d1fcd2ce96178e0a64a0709409a9a7a447c7c6 Reviewed-on: https://code.wireshark.org/review/17431 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=1bffa8ec0454911f3273b93dac84ac4... commit 1bffa8ec0454911f3273b93dac84ac49e2ef4b89 Author: Binh Trinh <beango@gmail.com> Date: Wed Aug 31 22:33:18 2016 -0400 GTP: Added dissection of UTRAN Container for Forward Rel Req/Resp Messages Change-Id: I8330e7e57d3ad09e526da0d7a0970f96fedd03a6 Reviewed-on: https://code.wireshark.org/review/17434 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=77ae30ffc598a56e71e0f57e151d0b6... commit 77ae30ffc598a56e71e0f57e151d0b6801110b03 Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Aug 29 18:38:45 2016 +0200 gtk: fix compilation with GTK+ before 2.18 Removed in v1.99.2rc0-399-g43f09e6, but some includes are still needed. Basically I looked for the functions defined in the ui/gtk/old-gtk-compat.h header file that were in files below ui/gtk/. Then I matched it against the removed part in the above commit and added the header back at its old place. In two other cases, the header was only needed for Windows. If the above commit did not reference the file, I checked which function was in use and added the header on top, removing redundant conditionals. Reported and tested by a user of GTK+ 2.12.12 on top of v2.0.5. Change-Id: I649eec1e5531070f88c99d893c4920306f56d849 Reviewed-on: https://code.wireshark.org/review/17371 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=717ca58264f1c745c3efb8d9da0050d... commit 717ca58264f1c745c3efb8d9da0050d52b51bb1f Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Aug 31 11:31:54 2016 +0200 ipv6: fix build with old 32-bit glib headers (master only) Introduced with v2.3.0rc0-112-gdcb7b71, nxt is only a guint8* which fails on 32-bit glib before 2.31.2. Change-Id: Ide1816a971fa213f5669a7fa71bc111d5b1cc921 Reviewed-on: https://code.wireshark.org/review/17418 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=71f867490d28c5b66494a81dca775f2... commit 71f867490d28c5b66494a81dca775f2a47995ecb Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Aug 31 11:32:54 2016 +0200 ipsec: fix build with old 32-bit glib headers In commit v2.3.0rc0-121-gb6d13ef, GUINT_TO_POINTER(ah_nxt) was added, but on 32-bit glib before 2.31.2 this results in a type error. Change the type of ah_nxt since all its users take a guint anyway. Change-Id: I2fb030f79011b8a7159a0b0df26d3545b0ce3c06 Reviewed-on: https://code.wireshark.org/review/17419 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=e3c3d7a4afeeb8bc0519717e6c85c03... commit e3c3d7a4afeeb8bc0519717e6c85c038fb99170a Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Aug 31 11:11:56 2016 +0200 gtk: fix 32-bit build 32-bit glib before 2.31.2 expand GUINT_TO_POINTER(x) as (gpointer)x. add explicit cast since curr_layer_num is 8 bits. Fixes v1.99.10rc0-179-g1d7bcb2. Storing a 64-bit integer into a 32-bit pointer makes the compiler complain. Add explicit cast. Fixes v1.99.1rc0-76-ged0b19b. Change-Id: I75fdf17882a0f5ddce7d3b3e74b1bf80ff6cd4ae Reviewed-on: https://code.wireshark.org/review/17417 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=717215df61f7fc4daf596c3cd07b1f4... commit 717215df61f7fc4daf596c3cd07b1f4e19b38700 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Aug 31 22:16:10 2016 +0200 E.212: update list to Operational Bulletin No. 1106 (15.VIII.2016) Also manually add PLMN 460 02 (Chian Mobile) as it is not listed by ITU yet Bug: 12622 Bug: 12798 Change-Id: I7c6fab9dcb9da90178186e94f624301ef1861421 Reviewed-on: https://code.wireshark.org/review/17428 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cb2f8fc8914b89d7455a4a7f5e99b9d... commit cb2f8fc8914b89d7455a4a7f5e99b9de64f32556 Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Wed Aug 31 21:06:34 2016 +0200 OSSP: Retrieve OUI at proper offset in packet Bug: 12801 Change-Id: Ic70f0d93bbffc99ceacf6b2963b04d7477e4914b Reviewed-on: https://code.wireshark.org/review/17425 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ce2fa7b30a741929a2d502eaf390c3f... commit ce2fa7b30a741929a2d502eaf390c3f238bbe6b9 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Aug 31 17:24:54 2016 +0200 NFS: fix indent (remove some trailing spaces) Change-Id: Ic72d264686c3b37ac15118eec07057c7bb8a2a50 Reviewed-on: https://code.wireshark.org/review/17422 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5c2d82a6c24a06da0132fb7bd493ce4... commit 5c2d82a6c24a06da0132fb7bd493ce4e58594f0d Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Aug 31 17:55:15 2016 +0200 diam_dict.l: remove use of strdup This should fix crashes on Windows, _strdup should not be mixed with g_free. This was only uncovered in v2.3.0rc0-474-ga04b6fc, before that ddict_free was never called. Change-Id: I34111385c82715de70fb42fe44b99b89e132a374 Reviewed-on: https://code.wireshark.org/review/17423 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a7dd070d55e41e76da5a3c595d3f547... commit a7dd070d55e41e76da5a3c595d3f547c8cf3837b Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Aug 31 11:48:33 2016 +0200 Win: switch back to Lua library compiled with MinGW It does not suffer anymore from bug 9957 Change-Id: I871f01db67101b09a21545ecec5473941997a5cb Reviewed-on: https://code.wireshark.org/review/17416 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bccbae58a14c2cf635f5fd3c363b2c3... commit bccbae58a14c2cf635f5fd3c363b2c355215e0f9 Author: Jonathan Brucker <jonathan.brucke@gmail.com> Date: Wed Aug 31 09:05:09 2016 +0000 rftap: add new dissector The RFtap protocol is a simple metadata header designed to provide Radio Frequency (RF) metadata about frames. For official specifications see: https://rftap.github.io/ Signed-off-by: Jonathan Brucker <jonathan.brucke@gmail.com> Change-Id: I0d008b2baadcc5cc9577113e9795eef2691b961a Reviewed-on: https://code.wireshark.org/review/17355 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6362183825cb4a12fd091b78d886196... commit 6362183825cb4a12fd091b78d88619606dec4554 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Aug 31 08:16:24 2016 +0000 Revert "Revert "diameter: fix 400kb leaked memory on exit"" This reverts commit 5fea2b5f4198f1a36f313ef38532ddffd02ac5b1. I.e., it puts back the change; the reverted version passed the tests on which the versions with this change crashed. Change-Id: Idcc0eb11588cf14e2fe666de1905ee63917b0fcf Reviewed-on: https://code.wireshark.org/review/17413 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5fea2b5f4198f1a36f313ef38532ddf... commit 5fea2b5f4198f1a36f313ef38532ddffd02ac5b1 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Aug 31 07:42:31 2016 +0000 Revert "diameter: fix 400kb leaked memory on exit" This reverts commit a04b6fcb3db901734ed948134c973996786be8b7. Temporary revert to see if this prevents the "tshark -G" crashes being seen on the 64-bit Windows buildbot. Change-Id: I561439039ca2667b72d7e2319a6f3f5f97e18d15 Reviewed-on: https://code.wireshark.org/review/17412 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c8869f68db6cd1d4a341d57600ecf22... commit c8869f68db6cd1d4a341d57600ecf22627632c9f Author: Guy Harris <guy@alum.mit.edu> Date: Wed Aug 31 00:37:27 2016 -0700 OK, it probably crashed in proto_initialize_all_prefixes(). Remove the debugging printouts. The changes that were committed between the last build that didn't crash and the first build that did were: commit 961f743d69b323aa217a6b39184485d6a0bfb2d5 Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Aug 29 01:34:22 2016 +0200 xml: fix some memleaks No more memleaks reported for the attachment in bug 12790 :-) Change-Id: I8472e442143b332edfacdf9ef3b8b893f1ec4386 Ping-Bug: 12790 Reviewed-on: https://code.wireshark.org/review/17365 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> commit a04b6fcb3db901734ed948134c973996786be8b7 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Aug 28 22:19:29 2016 +0200 diameter: fix 400kb leaked memory on exit Before: SUMMARY: AddressSanitizer: 399684 byte(s) leaked in 17208 allocation(s). After addressing to-do by calling ddict_free: SUMMARY: AddressSanitizer: 3024 byte(s) leaked in 256 allocation(s). After fixing all remaining leaks cases in the flex file for diameter: SUMMARY: AddressSanitizer: 735 byte(s) leaked in 58 allocation(s). Not bad huh :-) Ping-Bug: 12790 Change-Id: I0c730ad77ae15c69390bc6cf0a3a985395a64771 Reviewed-on: https://code.wireshark.org/review/17364 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> commit 14312835c63a3e2ec9d311ed1ffee5285141f4f9 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Aug 28 19:20:59 2016 +0200 pcapng: do not leak blocks pcapng_open and pcapng_read have 'wblock' allocated on the stack, so if they return, they do not have to set wblock.block to NULL. pcapng_read_block always sets wblock->block to NULL and may initialize it for SHB, IDB, NRB and ISB. Be sure to release the memory for IDB and ISB. It is better to have more wtap_block_free calls on a NULL value than missing them as this would be a memleak (on the other hand, do not release memory that is stored elsewhere such as SHB and NRB). Ping-Bug: 12790 Change-Id: I081f841addb36f16e3671095a919d357f4bc16c5 Reviewed-on: https://code.wireshark.org/review/17362 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> *If* one of those is the cause, my guess is that it's the Diameter one, as the crash happens before any file is read (so it's probably not the pcapng one) and thus before any dissection is done (so it's probably not the XML dissector one). Change-Id: I816c1bbd6078eab251efd02ebb7c3195f6dd1483 Reviewed-on: https://code.wireshark.org/review/17411 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1178ee68fbbea6dc096df0d69f776a2... commit 1178ee68fbbea6dc096df0d69f776a2158de630e Author: Binh Trinh <beango@gmail.com> Date: Wed Aug 31 00:18:17 2016 -0400 GTP: patch for Target identification for non-compliance workaround bug 3974 Change-Id: I2faa473c725a803056d6ffd0cb34b46d75121061 Reviewed-on: https://code.wireshark.org/review/17410 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5be39d98fb2fa07f250909989213496... commit 5be39d98fb2fa07f250909989213496873f37a74 Author: Chaitanya T K <chaitanya.mgit@gmail.com> Date: Tue Aug 30 20:59:34 2016 +0530 ieee80211: Fix the BAR Ack policy values As per 802.11-2012 table 8-15 the string should be reverse. 0 - Send Immediate Ack (False) 1 - Dont't Send Immediate Ack (True) Change-Id: Iea3b179e11781f891d2294b0bcdf92de2bdba7ba Reviewed-on: https://code.wireshark.org/review/17394 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a68fb134c78c2f800304110e5f0666f... commit a68fb134c78c2f800304110e5f0666f562f55301 Author: Tom Haynes <loghyr@primarydata.com> Date: Tue Aug 30 12:15:13 2016 -0700 nfs4: Handle CB_GETATTR Change-Id: Ifb68af443c6f13dfab99e32488d86c148621a316 Signed-off-by: Tom Haynes <loghyr@primarydata.com> Reviewed-on: https://code.wireshark.org/review/17399 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1512ee7d84cadd4c12e72f43ad4079d... commit 1512ee7d84cadd4c12e72f43ad4079df5ff345f5 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 30 20:03:42 2016 -0700 Crashing in proto_initialize_all_prefixes()? Debugging output. Change-Id: I6db711b1730b95460983ee190762753198c1959e Reviewed-on: https://code.wireshark.org/review/17409 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=18a873d57696d43a4232f95d538bfc2... commit 18a873d57696d43a4232f95d538bfc2792666637 Author: Sean O. Stalley <sean.stalley@intel.com> Date: Fri Aug 26 14:36:57 2016 -0700 MAUSB: Add Cancellation Status values defined in v1.0a Spec Change-Id: I72812fa0650da0cde37ea6cbef81a3c7a9ba333d Reviewed-on: https://code.wireshark.org/review/17373 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=33bb9bed3ec5c00a5ad4b2817ee90ae... commit 33bb9bed3ec5c00a5ad4b2817ee90ae2aabe7d15 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 30 19:23:09 2016 -0700 Debugging printouts, to see why tshark -G crashes on the Win64 buildbot. Change-Id: I16f6b7a69eed5ec66842df9d0640216fd273d3b0 Reviewed-on: https://code.wireshark.org/review/17408 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=290e23299d25722a457e58baf7a6110... commit 290e23299d25722a457e58baf7a611001cadd73d Author: Juanjo Martin <juanjo@rti.com> Date: Fri Aug 26 16:27:16 2016 +0200 RTPS: Fixed data holder dissection to match the standard The OMG standard has changed in this new version. I have fixed the implementation. Change-Id: Ie9054ed52c66580c76096af86e0fb8e34a44e9d1 Reviewed-on: https://code.wireshark.org/review/17348 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=436ed87580425d80b16c1e5ab3a60a4... commit 436ed87580425d80b16c1e5ab3a60a4e09dd3ecc Author: Tom Haynes <loghyr@primarydata.com> Date: Tue Aug 30 10:47:13 2016 -0700 nfs: Fix style in switch Change-Id: Ica9fc960946542badb64af12769e7dfa3793db82 Signed-off-by: Tom Haynes <loghyr@primarydata.com> Reviewed-on: https://code.wireshark.org/review/17397 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d78197955050f0ddf4a91379018f41b... commit d78197955050f0ddf4a91379018f41b58923c56b Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 30 17:59:59 2016 -0700 Use "ecatf" as the protocol name, to parallel everything else. The fields have names beginning with "ecatf.", the dissector is called "ecatf", and it's only the frame layer of EtherCAT anyway, so just call it "ecatf". Change-Id: I2f127363fd115c307f0525f612fe184a30d46c55 Reviewed-on: https://code.wireshark.org/review/17406 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=a4c8ebc18b71200d7a6245e386e97a9... commit a4c8ebc18b71200d7a6245e386e97a9d14c5dbdb Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 30 15:51:54 2016 -0700 Don't do any Decode As stuff for dissector tables not used with Decode As. Have all dissector tables have a "supports Decode As" flag, which defaults to FALSE, and which is set to TRUE if a register_decode_as() refers to it. When adding a dissector to a dissector table with a given key, only add it for Decode As if the dissector table supports it. For non-FT_STRING dissector tables, always check for multiple entries for the same protocol with different dissectors, and report an error if we found them. This means there's no need for the creator of a dissector table to specify whether duplicates of that sort should be allowed - we always do the check when registering something for "Decode As" (in a non-FT_STRING dissector table), and just don't bother registering anything for "Decode As" if the dissector table doesn't support "Decode As", so there's no check done for those dissector tables. Change-Id: I4a1fdea3bddc2af27a65cfbca23edc99b26c0eed Reviewed-on: https://code.wireshark.org/review/17402 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=1dbd2216edfe34e3dbb1f8967d325e7... commit 1dbd2216edfe34e3dbb1f8967d325e7fa00ecb51 Author: Juanjo Martin <juanjo@rti.com> Date: Tue Aug 30 01:57:32 2016 +0200 RTPS: Allowing duplicates in the rtps.type_name table Change-Id: Ie7a35b0bb3275a0895fad646bf9a81406eadf37c Reviewed-on: https://code.wireshark.org/review/17393 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=8b705b3753e345446553b0f36ce2b0c... commit 8b705b3753e345446553b0f36ce2b0c56046145b Author: Tom Haynes <loghyr@primarydata.com> Date: Tue Aug 30 11:00:21 2016 -0700 nfs: Standardize on FileHandle vs filehandle Change-Id: Ib945ddee4a35bf984a9411e56ed3801cde70c6c4 Signed-off-by: Tom Haynes <loghyr@primarydata.com> Reviewed-on: https://code.wireshark.org/review/17398 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=afa2605e4359509a8e188f3d7ae1182... commit afa2605e4359509a8e188f3d7ae118246e9e0ac7 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 30 13:38:03 2016 -0700 Support Decode As for {SSL,TLS}-over-TCP. We register dissectors for "Decode As" for {SSL,TLS}-over-TCP, so we should actually set up the "Decode As" stuff for it. Change-Id: I2a738667efdec1007069df74885a4fe8fc3fcbab Reviewed-on: https://code.wireshark.org/review/17400 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=68b73981193851d06d2d66d07394d84... commit 68b73981193851d06d2d66d07394d84b908fec7a Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Aug 30 14:55:54 2016 +0200 [Diameter] Improve dissection of malformed packets by continnuing dissection and display the problem more prominetly. Change-Id: Ia1a32667a18e1e5b60b5c167da9b6dd945ba3dfc Reviewed-on: https://code.wireshark.org/review/17385 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a892c90367a9f1b1d3d962cfe958174... commit a892c90367a9f1b1d3d962cfe958174b8fefcaee Author: Peter Wu <peter@lekensteyn.nl> Date: Tue Aug 30 11:12:44 2016 +0200 time_util: fix -Wshadow issue time_util.c was already fixed, but the header was missing the change, breaking the build on a very old compiler. Change-Id: I95685c9a3e25dcb7567f2551b92f20c8792a6e47 Reviewed-on: https://code.wireshark.org/review/17384 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=7c753702242dff9f73a960911907120... commit 7c753702242dff9f73a960911907120203196248 Author: Peter Wu <peter@lekensteyn.nl> Date: Tue Aug 30 00:10:50 2016 +0200 ssl: fix wrong detection of non-resumed renegotiated session If the heuristics fail to detect a resumed session, then it must mark the session as a normal session. This will also prevent from applying secrets that do not apply to this renegotiated session. Bug: 12793 Change-Id: I90f794a7bbaf7f1839e39656ac318183ecf48887 Reviewed-on: https://code.wireshark.org/review/17376 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cbd3648738de7adab294d48043d0ac5... commit cbd3648738de7adab294d48043d0ac5bc76f07bc Author: Binh Trinh <beango@gmail.com> Date: Mon Aug 29 23:22:58 2016 -0400 GTP: add new RAT Type values Change-Id: Ia3d8956197faff9366de2635a9bd29f2bfc40f0d Reviewed-on: https://code.wireshark.org/review/17381 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8e9b6f4abe06a32bb5c8e8842403c4c... commit 8e9b6f4abe06a32bb5c8e8842403c4cf8dccd765 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Aug 29 19:49:58 2016 -0700 Don't use a no-longer-extant variable. Change-Id: I41c1a37248335d983da58b0b657a28ec521be290 Reviewed-on: https://code.wireshark.org/review/17378 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=961f743d69b323aa217a6b39184485d... commit 961f743d69b323aa217a6b39184485d6a0bfb2d5 Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Aug 29 01:34:22 2016 +0200 xml: fix some memleaks No more memleaks reported for the attachment in bug 12790 :-) Change-Id: I8472e442143b332edfacdf9ef3b8b893f1ec4386 Ping-Bug: 12790 Reviewed-on: https://code.wireshark.org/review/17365 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=a04b6fcb3db901734ed948134c97399... commit a04b6fcb3db901734ed948134c973996786be8b7 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Aug 28 22:19:29 2016 +0200 diameter: fix 400kb leaked memory on exit Before: SUMMARY: AddressSanitizer: 399684 byte(s) leaked in 17208 allocation(s). After addressing to-do by calling ddict_free: SUMMARY: AddressSanitizer: 3024 byte(s) leaked in 256 allocation(s). After fixing all remaining leaks cases in the flex file for diameter: SUMMARY: AddressSanitizer: 735 byte(s) leaked in 58 allocation(s). Not bad huh :-) Ping-Bug: 12790 Change-Id: I0c730ad77ae15c69390bc6cf0a3a985395a64771 Reviewed-on: https://code.wireshark.org/review/17364 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=14312835c63a3e2ec9d311ed1ffee52... commit 14312835c63a3e2ec9d311ed1ffee5285141f4f9 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Aug 28 19:20:59 2016 +0200 pcapng: do not leak blocks pcapng_open and pcapng_read have 'wblock' allocated on the stack, so if they return, they do not have to set wblock.block to NULL. pcapng_read_block always sets wblock->block to NULL and may initialize it for SHB, IDB, NRB and ISB. Be sure to release the memory for IDB and ISB. It is better to have more wtap_block_free calls on a NULL value than missing them as this would be a memleak (on the other hand, do not release memory that is stored elsewhere such as SHB and NRB). Ping-Bug: 12790 Change-Id: I081f841addb36f16e3671095a919d357f4bc16c5 Reviewed-on: https://code.wireshark.org/review/17362 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=22ba931e15e88b758fa0d9a2287e6df... commit 22ba931e15e88b758fa0d9a2287e6df04e4e93c5 Author: Sean O. Stalley <sean.stalley@intel.com> Date: Fri Aug 26 14:40:58 2016 -0700 MAUSB: Add Status value defined in v1.0a Spec Change-Id: Ie8e77fffd54eb9b1918d90999a4419a80de8bc5e Reviewed-on: https://code.wireshark.org/review/17374 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=24fd16d86553279ca3fe8f651d85cac... commit 24fd16d86553279ca3fe8f651d85cace14edfc6c Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Mon Aug 29 11:31:11 2016 +0200 tap-iostat.c: ensure that interval is set to its maximum value when using 0 Otherwise the statistics will be wrong if the capture duration is greater than G_MAXINT32 and it the user specifies an interval of 0 Bug: 12778 Change-Id: I83a0f627ec0bb7c535446c17afa486835091ab8b Reviewed-on: https://code.wireshark.org/review/17367 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=09a6383c12bc450717df929167891c1... commit 09a6383c12bc450717df929167891c1884d541f6 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Aug 29 10:40:29 2016 +0200 telnet: remove meaningless line (CID 1372125). Change-Id: I3b9bc01a4f72e2e0de3f83426a9b8e7060d0c89a Reviewed-on: https://code.wireshark.org/review/17366 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9b272d8c8034b07f1b87347e358e83c... commit 9b272d8c8034b07f1b87347e358e83cbf1b32393 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Aug 28 19:27:52 2016 +0200 tproxy: fix memleak in is_banner_exchange_for strdup and strcmp is a recipe for leaking. Change-Id: I522c71964e39f671a4101df9b2b432433fc1c12e Reviewed-on: https://code.wireshark.org/review/17363 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0bae8424fe651ea5de1f7e160666781... commit 0bae8424fe651ea5de1f7e160666781e60ce3c86 Author: Peter Wu <peter@lekensteyn.nl> Date: Sun Aug 28 19:15:01 2016 +0200 tvbparse: fix memleak Use same wmem_epan_scope() as "w" (tvbparse_wanted_t). Change-Id: I73fdb1fb3b55a91b7bb0fc36e435024c6f0b3d73 Ping-Bug: 12790 Reviewed-on: https://code.wireshark.org/review/17361 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=16b7128d1a4b4c80d24d5a10e32a578... commit 16b7128d1a4b4c80d24d5a10e32a5787727858a9 Author: Michał Skalski <mskalski13@gmail.com> Date: Mon Aug 22 22:21:57 2016 +0200 UAT gtk-ui, Qt-ui: Fixed copying records when no cp callback is defined According to documentation of uat_copy_cb_t, if uat->copy_cb is NULL, memcpy() should be used. This affected IKEv1 and IKEv2 UAT tables (possibly others). Change-Id: I27ebdc08385d260945699f101e714d3abb288b22 Reviewed-on: https://code.wireshark.org/review/17245 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7da76916790dc85c4a5374254f17054... commit 7da76916790dc85c4a5374254f1705440b1529d7 Author: Gerald Combs <gerald@wireshark.org> Date: Sun Aug 28 08:12:43 2016 -0700 [Automatic update for 2016-08-28] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ic4d32253800cb94d52c817f1cd40179d878323cb Reviewed-on: https://code.wireshark.org/review/17358 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=294fcd11bfc2a76306e0c6ea8e8f534... commit 294fcd11bfc2a76306e0c6ea8e8f53445df940cf Author: Mirko Parthey <mirko.parthey@web.de> Date: Sun Aug 28 14:49:52 2016 +0200 ISAKMP: fix # of SPIs field name in Delete payload Fix the "Number of SPIs" field name in the Delete payload. References: RFC 2408, RFC 7296 Change-Id: I205fb830275fc011e6605fdae53c6b9141e1628b Reviewed-on: https://code.wireshark.org/review/17353 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9a935d334a462021a85b8b70962ec05... commit 9a935d334a462021a85b8b70962ec05e2167ad4c Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Fri Aug 26 11:31:03 2016 +0200 xmpp: Improve stanza reassembly. A XMPP stanza may be fragmented inside a conversation, so don't check for this only when starting a new conversation. Change-Id: I63b987184f52645e6c72c3c4155b39b7948de828 Reviewed-on: https://code.wireshark.org/review/17344 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5fe3e6af39fc55650ff9563906d016a... commit 5fe3e6af39fc55650ff9563906d016aa7becbaf1 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Sat Aug 27 11:53:29 2016 +0200 Qt: Support "Resolve Names" with multiple custom column fields Make "Resolve Names" enabled if at least one of the custom column fields can be resolved. Change-Id: I702471be5d90c91f71209923e6abcc6921dca850 Reviewed-on: https://code.wireshark.org/review/17350 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=124fb8307998151fb910df421aefcde... commit 124fb8307998151fb910df421aefcde35d8d4a1a Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 24 12:42:15 2016 +0200 extcap: improve interface print in help. Change-Id: Ife8e73b6cb1756623e937452fc042d8b31e2554f Reviewed-on: https://code.wireshark.org/review/17321 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=139170c6c6b29cf9c1eba9bbcacfbff... commit 139170c6c6b29cf9c1eba9bbcacfbffdf447e2ef Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 24 16:48:39 2016 +0200 wsutil: add enumeration of local ip addresses in Windows. Routine used by ssh-based extcaps. Change-Id: I06d8e1e1444cd03a0508dc0c7cb91d340a451c58 Reviewed-on: https://code.wireshark.org/review/17308 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d0565ad22b14eae64776fb7cf04377e... commit d0565ad22b14eae64776fb7cf04377e902380ef9 Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Fri Aug 26 08:53:33 2016 +0200 Properly end address type search by name (CID-1362742) Search address type by name iterates over an array, but fails to find its end. Therefore it may dereference invalid pointers, or NULL. Add the proper check in the for loop and make sure an end condition is always there in the array searched. Change-Id: I60ade9d438dc394340b6483b4fcb23e5ce432000 Reviewed-on: https://code.wireshark.org/review/17337 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=18e1ee7160ff4c77b1cb4dfea2c5889... commit 18e1ee7160ff4c77b1cb4dfea2c58890807cb715 Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Fri Aug 26 08:28:49 2016 +0200 SDP: Restore usability of conversation debug feature. Some type changes were not carried forwared into the conversation debugging code. These changes allow compilation again. Change-Id: I90dde7cc94496828cf8931d74225773c2cea42a1 Reviewed-on: https://code.wireshark.org/review/17336 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=e19c176f7b9120a011f1ea41bbc148a... commit e19c176f7b9120a011f1ea41bbc148a1171c64ac Author: Juanjo Martin <juanjo@rti.com> Date: Fri Aug 26 15:41:36 2016 +0200 RTPS: Added missing parameters Added the dissection of three parameters. Change-Id: I07e7b655ad7fd3462625c2fb565e41593c62f897 Reviewed-on: https://code.wireshark.org/review/17346 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=fa320f882258d1c3c56c4d2a52251b3... commit fa320f882258d1c3c56c4d2a52251b369d4ed692 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Aug 26 13:58:55 2016 +0200 QUIC: Update COL_INFO when packet is RST Stream and use rst stream code error Issue reported by Lucas Pardue Change-Id: Ic3c53fce9751a556c5f1aa30d55687a60c9c6a4d Reviewed-on: https://code.wireshark.org/review/17345 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Lucas Pardue <lucas.pardue@bbc.co.uk> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=14bd8793f766c7a3421ba6bdf8d3d22... commit 14bd8793f766c7a3421ba6bdf8d3d22ee6dc8694 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Aug 26 10:43:00 2016 +0200 QUIC: Update COL_INFO when packet is GOAWAY Issue reported by Lucas Perdue Change-Id: I4852f6bad7a4c98b345ff198b33ab560eacb5ed0 Reviewed-on: https://code.wireshark.org/review/17341 Reviewed-by: Lucas Pardue <lucas.pardue@bbc.co.uk> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=df28c8266ff9ebc404fd53408050c50... commit df28c8266ff9ebc404fd53408050c507a442ac04 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Aug 26 10:41:45 2016 +0200 QUIC: Fix some typo (copy/paste error) on GOAWAY/CONNECTION_CLOSE Frame Issue reported by Lucas Perdue Change-Id: I9c4ede6ba2fb0303aab05f1d59835e5a8b386a3e Reviewed-on: https://code.wireshark.org/review/17340 Reviewed-by: Lucas Pardue <lucas.pardue@bbc.co.uk> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=09be46361bab677842cc598405cbc7a... commit 09be46361bab677842cc598405cbc7a44b974f1f Author: Peter Wu <peter@lekensteyn.nl> Date: Thu Aug 25 18:03:35 2016 +0200 qt: fix crash on Search Packet while redissecting Before redissection, PacketList::freeze() is called which clears the model. This results in a NULL-deref when pressing Ctrl-F (Packet Search) or Ctrl-G (Go To Packet). Reproducer: in a large capture file, enter some display filter (e.g. "udp") and immediately press Ctrl-F. Thanks to Github user SNAPESNATCH for the initial report via IRC that included a helpful stack trace on Windows. Change-Id: If7334d6df4e9591fb1f2a52e3e2f837285b2959f Reviewed-on: https://code.wireshark.org/review/17326 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=17f977ec5695259ec02c7e6e4cd24e3... commit 17f977ec5695259ec02c7e6e4cd24e3e2ed263c1 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Aug 25 16:58:25 2016 -0700 Handle ETH_P_CANFD as well as ETH_P_CAN. Both of them need to have the CAN ID/flags field of the header byte-swapped as necessary to make sure it's in the *reading* host's byte order, not the *writing* host's byte order, if the two are different. Change-Id: Iac1589fdd9fe4d9ee6fbac8d821b48694d68919b Reviewed-on: https://code.wireshark.org/review/17333 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=27372ca7379b3ff5cccf1488d96a72d... commit 27372ca7379b3ff5cccf1488d96a72d06dfba0d1 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Aug 25 14:39:42 2016 -0700 One more change for the removal of LINKTYPE_SOCKETCAN_HOSTENDIAN. Change-Id: If1615e23efa30119fff5eb2935335c2cde34b89e Reviewed-on: https://code.wireshark.org/review/17330 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c8157aa6b4afdbc2f84779ffbeea4f8... commit c8157aa6b4afdbc2f84779ffbeea4f8d3bdc8666 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Aug 25 14:14:11 2016 -0700 Go back to having only one SocketCAN LINKTYPE_ value. Libpcap just backed out the "host-endian" SocketCAN LINKTYPE_ value; we don't need it any more. Change-Id: I33a7dc21207a0009e20b4abaefe1119eb649c39a Reviewed-on: https://code.wireshark.org/review/17327 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ce9a4b212ec7b75985cef3b9ab36280... commit ce9a4b212ec7b75985cef3b9ab362808e6fd25c5 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Thu Aug 25 15:39:40 2016 +0200 xmpp/xml: Store item length in xml_frame. The created XML proto_item can be faked (if not visible and not referenced), so ensure we store the correct item length to be used in XMPP. This will avoid an invalid "Malformed Packet" for some XMPP packets. Change-Id: I79d805b725dbeb93f26a38b72bdcc84187aee16f Reviewed-on: https://code.wireshark.org/review/17324 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f597234785f8e4ddf1cf9f7c5d6f5fb... commit f597234785f8e4ddf1cf9f7c5d6f5fbacd9631bf Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 24 15:10:51 2016 +0200 extcap: add binary name and version to help message. Change-Id: I8f8083c817065cf66fd006a1caeb309d26209509 Reviewed-on: https://code.wireshark.org/review/17305 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c661da414d5ddb506e0c23d3169cff4... commit c661da414d5ddb506e0c23d3169cff45b6211398 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Thu Aug 25 12:44:41 2016 +0200 xmpp: Add whitespace keepalive indication RFC 6120 section 4.6.1 defines the use of a single whitespace as "whitespace keepalive", so indicate this in the Info column. Change-Id: I685431d91be2a37fbd66f8d1cdabe53f33092e93 Reviewed-on: https://code.wireshark.org/review/17323 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> http://cgit.osmocom.org/wireshark/commit/?id=8ce301704bb191208ea2486396d83c4... commit 8ce301704bb191208ea2486396d83c4305ba3315 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Aug 24 19:23:09 2016 -0700 Expand comments. Change-Id: I4e3de542d24c567434f4554917e826ccbd64cb6c Reviewed-on: https://code.wireshark.org/review/17319 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b66fb7d3d34f1671963bc19ec9ece2e... commit b66fb7d3d34f1671963bc19ec9ece2eaecf391b5 Author: Balint Reczey <balint@balintreczey.hu> Date: Tue Aug 23 03:01:32 2016 +0200 debian: Fix libwscodecs' symbols file Change-Id: I842fd2339788c2cbe5ca88294aaf74bf9adc5ae2 Reviewed-on: https://code.wireshark.org/review/17285 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a1af188aedceb90ba0af4e1af3faa6b... commit a1af188aedceb90ba0af4e1af3faa6b36da54d40 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 24 16:54:02 2016 +0200 wsutil: fix indentation of interface.c Change-Id: Icf0c0c4ce1e3763eb385de24dc608a120e0f4af2 Reviewed-on: https://code.wireshark.org/review/17307 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=4cf9a1dca07a328d016894d7730b68e... commit 4cf9a1dca07a328d016894d7730b68e836229cde Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 24 12:00:54 2016 +0200 dtls: remove unneeded checks (CID 1158712 & 1158716). Change-Id: Id463f7746880f71f317bb52b40dc8b298965b4ec Reviewed-on: https://code.wireshark.org/review/17300 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=47a95f65359e2164ccb05dbecb6ca57... commit 47a95f65359e2164ccb05dbecb6ca57af496c2ca Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Aug 24 19:53:04 2016 +0200 HTTP2: Display PUSH_PROMISE Header in bytes and also use the name of spec for field (Header BLock Fragment Change-Id: I5a3884186258dac1f243f991a3392c875403eb97 Reviewed-on: https://code.wireshark.org/review/17310 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c7986c5b02d35eab05fbbdca4a5519d... commit c7986c5b02d35eab05fbbdca4a5519d9720d59a7 Author: Martin Kaiser <wireshark@kaiser.cx> Date: Sat Aug 6 19:57:23 2016 +0200 zbee-nwk-gp: don't THROW() an exception from a dissector show expert infos and return the number of bytes we dissected Change-Id: Ibb12372e8670380137f4fc3d012d0b0afa4cd638 Reviewed-on: https://code.wireshark.org/review/17313 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1c7a96076e8df653c353c44d51bd190... commit 1c7a96076e8df653c353c44d51bd190ffa0c794f Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 24 16:42:16 2016 +0200 extcap: remove unused #define from ssh-base. Change-Id: I52d26cb1e60452f8fa4d79f988fde2268486fc1c Reviewed-on: https://code.wireshark.org/review/17306 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7ccec07b6dc5515f3b9f7e40884205b... commit 7ccec07b6dc5515f3b9f7e40884205b61c1d43ce Author: Gerald Combs <gerald@wireshark.org> Date: Wed Aug 24 10:03:38 2016 -0700 IEEE 1722: Fixup ranges. Use RVALS + BASE_RANGE_STRING for range_strings. This should fix the "-G values" failure on the Win32 buildbot. Change-Id: I9a42b66a22b615d3de9c04b485adc7b9aa2cc154 Reviewed-on: https://code.wireshark.org/review/17309 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c2b98004df95390155d45881306224a... commit c2b98004df95390155d45881306224a1ebe1792f Author: Gerald Combs <gerald@wireshark.org> Date: Tue Aug 23 16:55:16 2016 -0700 Fuzz test: Make Valgrind error detection more verbose. When we set VG_ERR_CNT=1 print the reason. Change-Id: Icb8f2a1e7074044521873b116fc891cc4be4b204 Reviewed-on: https://code.wireshark.org/review/17287 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=88b9b750f5e00c6eb6d75c72fc107fd... commit 88b9b750f5e00c6eb6d75c72fc107fd1d7427744 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 24 11:10:10 2016 +0200 Qt: add initializer (CID 1328485). Change-Id: I1ce4ddc8bfb66522d4e472c258de2f928d5c776f Reviewed-on: https://code.wireshark.org/review/17298 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f269f56c1ab485a9f3462554eb088f6... commit f269f56c1ab485a9f3462554eb088f6895e3ccf6 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 24 10:43:11 2016 +0200 extcap: make extcaps use the version registered in config. Change-Id: I12d0d0bec06e02af0a9d0877c0f0f1d86261d752 Reviewed-on: https://code.wireshark.org/review/17296 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2095b325998f1da06a4e80efeb186ec... commit 2095b325998f1da06a4e80efeb186ec99d6e39ed Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Aug 23 22:10:08 2016 +0200 call_heur_dissector_direct: do not trigger an assert if heuristic dissector rejects packet This can happen for example is the heuristics changed between the Wireshark version used to export PDUs, and the one used to open the file. Instead, call data dissector. Change-Id: I29f7754f883fd710c3557a610583ef988ca13e43 Reviewed-on: https://code.wireshark.org/review/17280 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=20908f55f6c93fb79fbd39e60affa2d... commit 20908f55f6c93fb79fbd39e60affa2d4428b4951 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Aug 23 19:41:46 2016 +0200 SCSI: Mode Sense 10: Wrong block descriptor length Issue reported by Sharon Samuel Enoch Bug:12780 Change-Id: I94ad5355cdfa4d8cd3915c9e261931ff56dc765b Reviewed-on: https://code.wireshark.org/review/17272 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5213496250aceff086404c568e3718e... commit 5213496250aceff086404c568e3718ebc0060934 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Wed Aug 24 08:10:27 2016 +0200 IPMI: do not use col_set_str with non const strings Bug: 12782 Change-Id: Ia082ccf5355d7f8dd6073861c59c804fecc96266 Reviewed-on: https://code.wireshark.org/review/17289 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8915bb2a4eb20392b78bb6210b2caa4... commit 8915bb2a4eb20392b78bb6210b2caa4e147bf697 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Aug 23 23:37:12 2016 +0200 ISAKMP: remove useless callback isakmp_cleanup_protocol() and isakmp_init_protocol() are already registered as cleanup and init routines Change-Id: I4fd2348dc507c8bc933aebd5abfb2522b57da0b4 Reviewed-on: https://code.wireshark.org/review/17284 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0fcca6f0c8392b16ebfefdc69086d02... commit 0fcca6f0c8392b16ebfefdc69086d02e1dba2c7e Author: Mirko Parthey <mirko.parthey@web.de> Date: Tue Aug 23 16:29:57 2016 +0200 ISAKMP: fix DOI field read size Read 4 bytes from the packet instead of 1 because that is the correct size of the DOI field. Reference: RFC 2408 Change-Id: I5745363811bb46af307a925d688ec36cfb29984b Reviewed-on: https://code.wireshark.org/review/17271 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=640382c74364f61da36bdc5b1272e8c... commit 640382c74364f61da36bdc5b1272e8cda28f1d8f Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Tue Aug 16 22:21:59 2016 +0100 CMake: Allow setting per target compiler warnings Setting our compiler warning flags in CMAKE_C_FLAGS does not allow using different flags per target. Allow for that possibility by setting the internal WS_WARNINGS_{C,CXX}_FLAGS and using the COMPILE_OPTIONS property to set them. This change is just setting mechanism and there should be no difference in generated warnings. The check_X_compiler_flag cmake test is changed to test each flag individually. We need a list, not a space separated string, and the aggregate test is not significant. Change-Id: I59fc5cd7e130c7a5e001c598e3df3e13f83a6a25 Reviewed-on: https://code.wireshark.org/review/17150 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=505bcefd20501ae0811f6074f2113b5... commit 505bcefd20501ae0811f6074f2113b52788d78c5 Author: Michał Skalski <mskalski13@gmail.com> Date: Tue Aug 23 01:12:59 2016 +0200 isakmp Fix IKEv2 modification UAT crash Problem is that not all fields of UAT are updated on change (only those defined in UAT definition with ikev2_uat_flds, specifically pointers to encr_spec and auth_spec in ike2_decr_data_t were set to NULL. Fixed by re-setting pointers after update table callback was called. Also fixed memory leaks after UAT modification. Bug was partially resolved with change Ibdab979b5959eb561635cbcb446e17138baca87b https://code.wireshark.org/review/17078 which eliminated crash, but decryption still didn't work after UAT modification (DISSECTOR BUG was displayed). Bug: 12748 Change-Id: I8209edd8e214d62e34b641fdd2e046b9ff4c95eb Reviewed-on: https://code.wireshark.org/review/17249 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e11d4a891373c0f47062dd526a1f5ff... commit e11d4a891373c0f47062dd526a1f5ff6baa09ba6 Author: Chris Bontje <cbontje@gmail.com> Date: Tue Aug 23 08:42:59 2016 -0600 [lg8979] - Fix dissection of 'Analog Group Change Report' Responses (FC2) They follow the same dissection as normal 'Analog Change Report' Responses (FC0) Change-Id: I854084f43fd0cc52ba02b6f1e760a63033ab48dd Reviewed-on: https://code.wireshark.org/review/17270 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> http://cgit.osmocom.org/wireshark/commit/?id=f4ad204745e6ccbb0ae420561b8e159... commit f4ad204745e6ccbb0ae420561b8e159dc4a3a824 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 23 11:50:51 2016 -0700 Remove now-redundant check. We now check much earlier for an invalid message length; remove the check done afterwards. Also, note that dissect_netlink_error() should also check the message length, to make sure it doesn't run past the end of the message, and indicate why we are assuming an "integer" is 4 bytes (it's because the RFC is vague here). Change-Id: Ie0b5074acc852cdeaa008fee1125130a6c8771a1 Reviewed-on: https://code.wireshark.org/review/17279 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3479406d6f9841bcf5d70b0c3b84354... commit 3479406d6f9841bcf5d70b0c3b84354dcbf3742d Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 23 11:41:24 2016 -0700 Get rid of trailing tabs. Change-Id: I0c26f02a63a12acc900637cd6a106d26e386a7a8 Reviewed-on: https://code.wireshark.org/review/17278 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=111358e51b2e3c34621e4883206813f... commit 111358e51b2e3c34621e4883206813f422cdc1fd Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 23 11:39:56 2016 -0700 Catch too-short netlink message lengths. 0 would cause an infinite loop. and any value < 16 is clearly wrong, so if we see such a packet, just show the header's length field and stop dissecting. Bug: 12776 Change-Id: Iefc56b26b83ff5424968d065bdb9fa84a7a65481 Reviewed-on: https://code.wireshark.org/review/17277 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=12cae9dc80a09ba0ed75b421d328143... commit 12cae9dc80a09ba0ed75b421d328143ac98a298b Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Aug 23 19:41:48 2016 +0200 MAC LTE: fix dissection of CE Mode A RAR message The Msg3 PUSCH narrowband index parameter depends on the UL bandwidth Change-Id: Ib57c85ffbd4c108e9c8f3d14fa53a48f0df1b0e6 Reviewed-on: https://code.wireshark.org/review/17274 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=40ac3c86825d4a15e585035fbae6e9a... commit 40ac3c86825d4a15e585035fbae6e9a86424ee4e Author: Balint Reczey <balint@balintreczey.hu> Date: Tue Aug 23 13:53:23 2016 +0200 Documentation with unset license is under project's license (GPL-2+) doc/idl2deb.pod is licensed explicitly under GPL-2+ it is just not recognized by the check. Change-Id: Iabc7ee6bd6fe9080d6cdd28a29bb4c5f97b0ece9 Reviewed-on: https://code.wireshark.org/review/17268 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Petri-Dish: Balint Reczey <balint@balintreczey.hu> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=c7ca0e88df468989647fc272a798bcd... commit c7ca0e88df468989647fc272a798bcd038084d99 Author: Michał Skalski <mskalski13@gmail.com> Date: Sun Aug 21 22:00:44 2016 +0200 dissector ISAKMP IKEv2: fixed bug with libgcrypt-1.6.x and AEAD ciphers IKEv2: Fixed bug with AEAD ciphers with 8- and 12-byte length ICVs and libgcrypt 1.6.x - gcry_cipher_checktag() returned INVALID_LENGTH. Fixed for merged changeset https://code.wireshark.org/review/17078 Added support for verification of encrypted data with HMAC_MD5_128 [RFC4595] and HMAC_SHA1_160 [RFC4595] integrity algorithms Added IKEv2 decryption suite for few combinations of encryption and integrity algorithms: 3DES-CBC/SHA1_160, AES-128-CCM-12, AES-128-CCM-12 (using CTR mode), AES-192-CTR/SHA2-512, AES-256-CBC/SHA2-256, AES-256-CCM-16, AES-256-GCM-16, AES-256-GCM-8 Change-Id: Ic564b25f1fd41e913c605322b7b8aa030cf90ddf Reviewed-on: https://code.wireshark.org/review/17213 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8d7aba1060ef1823223e52c06d613fa... commit 8d7aba1060ef1823223e52c06d613fa3fe3828b0 Author: Jonathan Muñoz <jonathan.munoz@inria.fr> Date: Tue Jul 5 17:13:14 2016 +0200 IEEE 802.15.4:dissecting header & payload information elements used by 6tisch. This patch shows the Information Elements (IE) defined by the IEEE802.15.4. It dissects the information of those IE which are used by the IETF WG 6tisch and announces the others. Here the list of the fully dissected ones: - For the header IEs: - Time Correction. - Header Termination 1. - Header Termination 2. - For the payload IEs: - MLME: - Nested Shorts: - TSCH Synchronization IE. - TSCH Timeslot IE. - TSCH Slotframe and Link IE. - Nested Longs: - Channel Hopping IE. - Payload Termination IE. For the rest of the IEs defined in the standart, this patch shows them but does not analyze their inner fields. References: https://datatracker.ietf.org/doc/draft-ietf-6tisch-minimal/ IEEE Standard for Low-Rate Wireless Personal Area Networks (WPANs). Change-Id: I45292315fa532f08be6a218eb5756284a22eeee4 Reviewed-on: https://code.wireshark.org/review/16671 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=52910f4e3fa7d771a671cd30bd5320d... commit 52910f4e3fa7d771a671cd30bd5320d70aee3eec Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Aug 22 22:29:21 2016 +0200 isakmp: fix type confusion Caught by ASAN with WIRESHARK_DEBUG_WMEM_OVERRIDE=simple set. Manually inspection of all type casts to decrypt_data_t and ikev2_decrypt_data_t showed no other users that do not check isakmp_version first. Change-Id: If889afff85a20e31222d33cbea8db3a91a77f389 Reviewed-on: https://code.wireshark.org/review/17246 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michał Skalski <mskalski13@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bee0cd776219fc3cd6ac6a932a1d25b... commit bee0cd776219fc3cd6ac6a932a1d25b944c299a0 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Aug 22 20:36:24 2016 -0700 See if *this* convinces the compiler that valuelen and value will be set. Change-Id: I2a7715ac3255502f244a0d0a7e588b3a44c34f11 Reviewed-on: https://code.wireshark.org/review/17258 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=9edb7afa84cc694eddc563e794492f8... commit 9edb7afa84cc694eddc563e794492f8dd1fe61ca Author: Guy Harris <guy@alum.mit.edu> Date: Mon Aug 22 19:57:22 2016 -0700 More fields, more pre-allocated memory for fields. Change-Id: I8362e64354c4ca985dbabc190cfb75d2bd31a5ad Reviewed-on: https://code.wireshark.org/review/17257 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=ff00166a96d887e03899577caae3a35... commit ff00166a96d887e03899577caae3a355c26b0837 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Aug 22 19:28:24 2016 -0700 Fix handling of parameters with no value. Return a value length of 0 if there's no parameter value. (And don't return anything if the pointers through which we return them are null.) If no value is present, return NULL from ws_find_media_type_parameter(). Change-Id: I32b57623d7651bcf065af5b81f2390a600988b21 Reviewed-on: https://code.wireshark.org/review/17255 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=4458c48cf4b94da8626361499a044d7... commit 4458c48cf4b94da8626361499a044d7c8c096538 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Aug 22 18:25:33 2016 -0700 Add cast to squelch "building with a C++ compiler" warnings. Change-Id: Ia95c40096018479aec99fafd93d7b95d31ba4723 Reviewed-on: https://code.wireshark.org/review/17253 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=0b3a96222b39ea4df1fdc899a950c50... commit 0b3a96222b39ea4df1fdc899a950c50ec56a1077 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Aug 22 17:53:10 2016 -0700 Handle quoted-pairs in quoted-strings correctly. Backslash, in a quoted-string, escapes quotes (and any other characters, although the only ones that *need* escaping are a double-quote and a backslash). This means that the value of a parameter isn't just the raw characters from the parameters string; for a quoted string, it needs to be un-escaped, and for a *non*-quoted string, it has to stop at the first non-token character (you can put comments in). So ws_find_media_type_parameter() must return an allocated string with the actual value. Get rid of index_of_char(); it doesn't do anything that strchr() does. Change-Id: I36328ea71c28fe6ac4918a8e73c281a25f6be844 Reviewed-on: https://code.wireshark.org/review/17251 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=943a9ede85962f07fc75b64e2ed12bd... commit 943a9ede85962f07fc75b64e2ed12bdc54a911bb Author: Gerald Combs <gerald@wireshark.org> Date: Mon Aug 22 15:10:24 2016 -0700 Update docbook/README.txt Update to reflect current reality. Still needs a lot of work. Change-Id: Id6bb12f5e8ca42bbadc237f148bb388b54a321e2 Reviewed-on: https://code.wireshark.org/review/17247 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=9c80ff0617a67d9f024f11d0dbd7943... commit 9c80ff0617a67d9f024f11d0dbd7943a76f69bc6 Author: Mirko Parthey <mirko.parthey@web.de> Date: Mon Aug 22 13:25:33 2016 +0200 IKEv2: Add D-H Transform IDs for Brainpool Curves Add Diffie-Hellman Group Transform IDs for the ECC Brainpool Curves. References: RFC 6932, RFC 6954 Change-Id: I1ca0da8e5e06abbd1c53a591d01c1f05aa60c35a Reviewed-on: https://code.wireshark.org/review/17231 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ee0f94aaaec4cc35b463a94df601a83... commit ee0f94aaaec4cc35b463a94df601a83a23f7967e Author: Balint Reczey <balint@balintreczey.hu> Date: Mon Aug 22 13:26:14 2016 +0200 Make index_of_char() static again Change-Id: I1c0d344c50ee5d78dd8247ccfe795ce0cd94aaa2 Reviewed-on: https://code.wireshark.org/review/17230 Reviewed-by: Balint Reczey <balint@balintreczey.hu> http://cgit.osmocom.org/wireshark/commit/?id=e129aec55870af97224b37ecc7f0541... commit e129aec55870af97224b37ecc7f05416b6b215dd Author: Balint Reczey <balint@balintreczey.hu> Date: Mon Aug 22 14:11:32 2016 +0200 debian: Update symbols file with new symbols Some symbols are marked as appearing in 2.2 intentionally, because they are cherry-picked to master-2.2. Change-Id: Ia7807b3bddab0a069812f56c1be2eca8bf7d1cd4 Reviewed-on: https://code.wireshark.org/review/17232 Reviewed-by: Balint Reczey <balint@balintreczey.hu> Petri-Dish: Balint Reczey <balint@balintreczey.hu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c43b8b5ef95b7b2dc865d8b0df89222... commit c43b8b5ef95b7b2dc865d8b0df89222b224059ce Author: Balint Reczey <balint@balintreczey.hu> Date: Mon Aug 22 12:59:01 2016 +0200 Rename find_parameter() to ws_find_media_type_parameter() The symbols exported from libs should use less generic. preferably prefixed names to avoid name collisions with other shared library symbols. Change-Id: I8323b3e194a7ee4d61baec0c007342fab6cbde84 Reviewed-on: https://code.wireshark.org/review/17229 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=22e421f7d390e7558b998dc458bfb53... commit 22e421f7d390e7558b998dc458bfb536cfaf460b Author: Andreas Leibold <andreas.leibold@harman.com> Date: Mon Aug 22 12:51:05 2016 +0200 Fixed a bug which might have caused a division by 0. Variable "channels_per_frame" could have caused a division by 0. This is now changed, by stopping dissection in this case. A warning is shown for this case. Change-Id: I6d4dcb91b833a7d7f0759e28f56950b94ab1ed7e Reviewed-on: https://code.wireshark.org/review/17228 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=b9e70e9b4cb0d85b6fcbbcfa387a5be... commit b9e70e9b4cb0d85b6fcbbcfa387a5bea80046665 Author: Binh Trinh <beango@gmail.com> Date: Sun Aug 14 23:41:48 2016 -0400 RANAP: Add an heuristic to decode the HO-to-UTRAN Command embedded in the RRC Container within the TargetRNC-to-SourceRNC Transparent Container Change-Id: Iea7c8d24f52cf8bd11e13a53853e11ec1ecdcd36 Reviewed-on: https://code.wireshark.org/review/17058 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=3f4ef54776cc9216ad1d633723e8984... commit 3f4ef54776cc9216ad1d633723e8984018b4deba Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 22 11:55:52 2016 +0200 ipp: fix typo indent Change-Id: Ibc44ab1e009f2dc07258b702f0e08aced38a66e2 Reviewed-on: https://code.wireshark.org/review/17223 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e8ba606348ab2cea260b9ddb31ee215... commit e8ba606348ab2cea260b9ddb31ee21568f1ed3f9 Author: AndersBroman <anders.broman@ericsson.com> Date: Mon Aug 22 12:33:08 2016 +0200 [Diameter] Add Command codes 8388718 - 8388722. Bug: 12774 Change-Id: I413ba4a195ee1bd3d7de66399d1be714ef77d7e2 Reviewed-on: https://code.wireshark.org/review/17227 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e83bdc67cc413c25321ae75792a2c92... commit e83bdc67cc413c25321ae75792a2c92d55b6e544 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Aug 22 00:37:42 2016 -0700 wmem_array_index() returns a *pointer* to the array element. The array is an array of guint8 *'s that point to strings; wmem_array_index() doesn't return a pointer to the string, it returns a pointer to a pointer to the string, and you have to dereference the result of the wmem_array_index() call to get a pointer to the string. Change-Id: I8c7b3320f0979b01383ad255419c21cdeb7df4c7 Reviewed-on: https://code.wireshark.org/review/17221 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=c00ea6f26e3c83e1db144d9d858cf9c... commit c00ea6f26e3c83e1db144d9d858cf9c4662d7e19 Author: Guy Harris <guy@alum.mit.edu> Date: Sun Aug 21 23:43:38 2016 -0700 Look up the XML dissector the right way. Looking up "text/xml" in the "media_type" dissector is somewhat of a long-way-around way of finding the XML dissector; just look for it by name. Change-Id: Ifafeabc563bf7bfa529bc44ba31bf6ae376a09c8 Reviewed-on: https://code.wireshark.org/review/17219 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=e1f11c97349dad879c3d3a875c289a1... commit e1f11c97349dad879c3d3a875c289a195a8ba52c Author: Guy Harris <guy@alum.mit.edu> Date: Sun Aug 21 23:36:54 2016 -0700 Get rid of trailing blank line. Change-Id: I409a843b48983355c242708f6c9972bd8f337bf6 Reviewed-on: https://code.wireshark.org/review/17218 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=5825f59ddccb8af2b4a06356f61195d... commit 5825f59ddccb8af2b4a06356f61195dd26c977d7 Author: Guy Harris <guy@alum.mit.edu> Date: Sun Aug 21 23:33:23 2016 -0700 Pass an HTTP message type to all HTTP subdissectors. This gets complicated, because those subdissectors might be called by other dissectors as well. We need a better way of passing that sort of out-of-bound information. Pull some routines used for processing Content-Type parameters into common code; we can't guarantee that the media parameters passed in would be writable (passing it as *the* data hid that; passing a structure with that *and* the HTTP message type revealed it), so don't convert it to lower-case in place. Use that information, if available, to determine whether an IPP message is a requet or a response. Change-Id: I4bccc9f05cd0b14ad445be7ab37b3d884d841325 Reviewed-on: https://code.wireshark.org/review/17216 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=efdcb25360621e5ac14f276b37964f2... commit efdcb25360621e5ac14f276b37964f27f4ce0ba4 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed Aug 17 10:39:54 2016 +0200 ISUP: Enhance display of unknown (opt) parameter Ping-Bug:12674 Change-Id: If67920246a9122dc693a71a4afcea212fb7f84ab Reviewed-on: https://code.wireshark.org/review/17108 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f06234154079afe61671471dfe97d59... commit f06234154079afe61671471dfe97d59b282f8e21 Author: Gerald Combs <gerald@zing.org> Date: Sun Aug 21 11:23:20 2016 -0700 Merge the CaveBear list into manuf.tmpl. If the following lines at the top of "Ethernet.txt" are anything to go by ---- $Revision: 2.83 $ $Date: 1999/03/09 11:36:19 $ $Author: map $ $Id: Ethernet.txt,v 2.83 1999/03/09 11:36:19 map Exp $ ---- we've been fetching the same list over and over for quite some time. Go ahead and merge the CaveBear list with manuf.tmpl and stop fetching it remotely. Fixup the way we split the lines we get from the IEEE while we're here, otherwise we log carriage returns in the middle of lines. The following CaveBear lines were skipped during the merge: Change-Id: I2110a7480a01a1bc5cbb6adf858acd9b5f75204c 00:00:10 - Skipping CaveBear "Hughes LAN Systems (formerly Sytek)" in favor of "Hughes" 00:00:11 - Skipping CaveBear "Tektronix" in favor of "Tektrnix" 00:00:1A - Skipping CaveBear "AMD (?)" in favor of "AMD" 00:00:20 - Skipping CaveBear "DIAB (Data Intdustrier AB)" in favor of "DIAB" 00:00:21 - Skipping CaveBear "SC&C (PAM Soft&Hardware also reported)" in favor of "SC&C" 00:00:24 - Skipping CaveBear "Olicom" in favor of "Olicom" 00:00:3D - Skipping CaveBear "AT&T" in favor of "AT&T" 00:00:46 - Skipping CaveBear "ISC-Bunker Ramo, An Olivetti Company" in favor of "ISC-BR" 00:00:4B - Skipping CaveBear "APT -ICL also reported" in favor of "APT" 00:00:55 - Skipping CaveBear "AT&T" in favor of "AT&T" 00:00:5A - Skipping CaveBear "Xerox 806 (unregistered)" in favor of "SkSchnei # SK (Schneider & Koch in Europe and Syskonnect outside of Europe)" 00:00:62 - Skipping CaveBear "Honeywell" in favor of "Hneywell # Honeywell" 00:00:63 - Skipping CaveBear "Hewlett-Packard LanProbe" in favor of "HP" 00:00:69 - Skipping CaveBear "Concord Communications, Inc (although someone said Silicon Graphics)" in favor of "SGI" 00:00:6B - Skipping CaveBear "MIPS" in favor of "MIPS" 00:00:7A - Skipping CaveBear "Ardent" in favor of "Ardent" 00:00:7D - Skipping CaveBear "Cray Research Superservers,Inc [Also Harris (3M) (old)]" in favor of "Cray" 00:00:A3 - Skipping CaveBear "Network Application Technology (NAT)" in favor of "NAT" 00:00:A5 - Skipping CaveBear "Compatible Systems Corporation" in favor of "CSC" 00:00:A7 - Skipping CaveBear "Network Computing Devices (NCD) X-terminals" in favor of "NCD" 00:00:A9 - Skipping CaveBear "Network Systems" in favor of "NetSys # Network Systems" 00:00:DD - Skipping CaveBear "Gould" in favor of "Gould" 00:00:DE - Skipping CaveBear "Unigraph" in favor of "Unigraph" 00:00:E1 - Skipping CaveBear "Hitachi (laptop built-in)" in favor of "Hitachi" 00:00:F6 - Skipping CaveBear "A.M.C. (Applied Microsystems Corp.)" in favor of "Madge" 00:01:FA - Skipping CaveBear "Compaq (PageMarq printers)" in favor of "Compaq" 00:02:04 - Skipping CaveBear "Novell NE3200" in favor of "Novell" 00:07:01 - Skipping CaveBear "Racal-Datacom" in favor of "Cisco # RACAL-DATACOM" 00:20:85 - Skipping CaveBear "3COM SuperStack II UPS management module" in favor of "3Com" 00:40:0B - Skipping CaveBear "Crescendo (now owned by Cisco)" in favor of "Cresc" 00:40:96 - Skipping CaveBear "Telesystems SLW Inc" in favor of "Aironet # Cisco Systems, Inc." 00:60:B0 - Skipping CaveBear "Hewlett-Packard" in favor of "HP" 00:80:0F - Skipping CaveBear "SMC (Standard Microsystem Corp.)" in favor of "SMC" 00:80:1C - Skipping CaveBear "Cisco" in favor of "Cisco # NEWPORT SYSTEMS SOLUTIONS" 00:80:96 - Skipping CaveBear "HDS (Human Designed Systems) X terminals" in favor of "HDS" 00:80:AD - Skipping CaveBear "CNet Technology Used by Telebit (among others)" in favor of "Telebit" 00:90:B1 - Skipping CaveBear "Cisco" in favor of "Cisco" 00:E0:98 - Skipping CaveBear "Linksys PCMCIA card" in favor of "Trend" 02:07:01 - Skipping CaveBear "Racal-Datacom" in favor of "Interlan # Interlan [now Racal-InterLAN] DEC (UNIBUS or QBUS), Apollo, Cisco" 02:CF:1F - Skipping CaveBear "CMC Masscomp; Silicon Graphics; Prime EXL" in favor of "CMC" 08:00:02 - Skipping CaveBear "3Com (formerly Bridge)" in favor of "3Com" 08:00:03 - Skipping CaveBear "ACC (Advanced Computer Communications)" in favor of "ACC" 08:00:08 - Skipping CaveBear "BBN (Bolt Beranek and Newman, Inc.)" in favor of "BBN" 08:00:09 - Skipping CaveBear "Hewlett-Packard" in favor of "HP" 08:00:1A - Skipping CaveBear "Tiara? (used to have Data General)" in favor of "DataGenl # Data General" 08:00:38 - Skipping CaveBear "Bull" in favor of "Bull" 08:00:3E - Skipping CaveBear "Motorola VME bus processor modules" in favor of "Motorola" 08:00:69 - Skipping CaveBear "Silicon Graphics" in favor of "SGI" 08:00:79 - Skipping CaveBear "Silicon Graphics" in favor of "SGI" 08:00:90 - Skipping CaveBear "Retix, Inc. Bridges" in favor of "Retix" 09:00:6A - Skipping CaveBear "AT&T" in favor of "AT&T" 10:00:90 - Skipping CaveBear "Hewlett-Packard Advisor products" in favor of "HP" 10:00:D4 - Skipping CaveBear "DEC" in favor of "DEC" 3C:00:00 - Skipping CaveBear "3Com dual function (V.34 modem + Ethernet) card" in favor of "3Com" 44:45:53 - Skipping CaveBear "Microsoft (Windows95 internal "adapters")" in favor of "Microsoft" Reviewed-on: https://code.wireshark.org/review/17212 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6a7d5df1ae5bf0d0d5e1bf33e6da2d6... commit 6a7d5df1ae5bf0d0d5e1bf33e6da2d6973046acd Author: Michael Mann <mmann78@netscape.net> Date: Sun Aug 21 18:04:42 2016 -0400 Add "Modbus/TCP over UDP" There already is "ModbusRTU over UDP", this is the Modbus/TCP format over UDP. Bug: 12768 Change-Id: I883aa8e88f8a1640459115434be84354e22bb361 Reviewed-on: https://code.wireshark.org/review/17215 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3aac4b154947f6b73a623e1f23b0718... commit 3aac4b154947f6b73a623e1f23b0718a54fe56c9 Author: Tom <tom916@qq.com> Date: Sun Aug 21 10:29:11 2016 -0400 Loosen HTTP token sting requirements so HTTP 1.0 can be included. Bug: 12770 Change-Id: I5f71072231a752ce6cdedf6f22ce8931a61c39c7 Reviewed-on: https://code.wireshark.org/review/17214 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=928e90790609938cb90419244a86316... commit 928e90790609938cb90419244a86316f4abf6a8d Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Aug 20 18:33:27 2016 +0200 nflog: add fields for interface indices Allows me to see the interface indices in a column. Change-Id: I0dd31d7ec06eb860e7c80a4273779ec9034ee42d Reviewed-on: https://code.wireshark.org/review/17193 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=767e1a26b8e8deaecc5130e381ee4a4... commit 767e1a26b8e8deaecc5130e381ee4a4b6b642757 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Aug 21 15:54:43 2016 +0200 RANAP: fix indent (use 2 spaces) and modelines Change-Id: I84e3157a9303572dcd3d9ff5df6802c42553e62f Reviewed-on: https://code.wireshark.org/review/17197 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=cfa11ed37d5dc646cb092d030c0f7fb... commit cfa11ed37d5dc646cb092d030c0f7fb4d8870cf6 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Aug 19 11:03:17 2016 +0200 mongo: add support for new mongodb 3.2 wire protocol opcodes Add OP_COMMAND (2010) and OP_COMMANDREPLY (2011) Bug:12723 Change-Id: Ib66e7136c7a6589286bbea11db2cff76d689db35 Reviewed-on: https://code.wireshark.org/review/17166 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=565dbf44ff21b90de29f4c829f517b4... commit 565dbf44ff21b90de29f4c829f517b429b931220 Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Aug 20 15:10:21 2016 +0200 nflog: support NFLOG bridge (ebtables) dissection See net/netfilter/nfnetlink_log.c, that is the only place that sets NFULA_PACKET_HDR to struct nfulnl_msg_packet_hdr. Tested with nflog-ebtables.pcapng from SampleCaptures wiki. Change-Id: I7e21f8f584f3911b3aa7d0d027ff9624886bef73 Reviewed-on: https://code.wireshark.org/review/17191 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=dc42aadcac2636df4c15f8650b66850... commit dc42aadcac2636df4c15f8650b668503911e3017 Author: Uli Heilmeier <uh@heilmeier.eu> Date: Sun Aug 21 17:27:39 2016 +0200 CDP: Don't read outside payload for Port ID Check if tvb remaining length is greater than expected length. Bug: 12767 Change-Id: Ia04b559432af417db519cfcfbec06e6010b496bf Reviewed-on: https://code.wireshark.org/review/17208 Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3509b072a6e3e3df50390860e657ccb... commit 3509b072a6e3e3df50390860e657ccb468a6fee1 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Aug 21 16:54:13 2016 +0200 LLC/STP (Cisco): Add Cisco Root Link Query PDU (STP) Cisco RLQ BPDUs, request (PID 0x0108) and response (PID 0x0109) used to support Cisco's extension (Backbone Fast [1]) to original 802.1D spanning-tree protocol. The format of the BPDUs is same as original STP configuration BPDUs [1] http://www.cisco.com/c/en/us/support/docs/lan-switching/spanning-tree-protoc... [2] http://www.cisco.com/c/en/us/support/docs/lan-switching/spanning-tree-protoc... Issue reported by Garri Bug:12772 Change-Id: I0ffd169bf252ae11817c7a44ca3a67dfd4e221eb Reviewed-on: https://code.wireshark.org/review/17204 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=a792a3b9048ebe56d7a39a26f810c88... commit a792a3b9048ebe56d7a39a26f810c885c0b9f4d8 Author: Gerald Combs <gerald@wireshark.org> Date: Sun Aug 21 08:05:53 2016 -0700 [Automatic update for 2016-08-21] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I92e3eefcb4670994fcab0d089c184ba5da2ab788 Reviewed-on: https://code.wireshark.org/review/17205 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=7804be057e882345c0e1fba28fde01c... commit 7804be057e882345c0e1fba28fde01c977123abb Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Aug 21 16:21:40 2016 +0200 ieee1722: fix Division by Zero found by Clang Analyzer and Coverity (CID 1371610) Change-Id: Iac0ef122062f8dc3160e112d76c35a256f8d8c2a Reviewed-on: https://code.wireshark.org/review/17201 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=07611921bea711baa8b460c3b2f1a91... commit 07611921bea711baa8b460c3b2f1a91b1279a799 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sun Aug 21 16:24:45 2016 +0200 nstrace: fix Control flow issues (UNREACHABLE) found by Coverity (CID 1371612) Change-Id: I76b3956d5b346412af5ff3aa5e0f6263dcb525a4 Reviewed-on: https://code.wireshark.org/review/17202 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c0ab12b23e5ca3a48d5f42600d1162a... commit c0ab12b23e5ca3a48d5f42600d1162a57dfdeca2 Author: Peter Wu <peter@lekensteyn.nl> Date: Sat Aug 20 13:22:30 2016 +0200 netlink-netfilter,nflog: use NFPROTO_xxx instead of AF_xxx These constants are mostly overlapping, except for NFPROTO_ARP. A manual study of the Linux v4.7 code shows which fields to use and also reveal that nflog.family can never be NFPROTO_ARP because (1) bridge traffic use NFPROTO_BRIDGE and (2) arptables has no ULOG/NFLOG target. This patch affects how some family fields are displayed but do not affect subdissector calls. Change-Id: I7cc73a8dcf73fe68c7ccaaa0f3b329fe484c8bfe Reviewed-on: https://code.wireshark.org/review/17190 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=9902117f1a2eb47bb5bd1a0323a3d38... commit 9902117f1a2eb47bb5bd1a0323a3d3891ef17d5b Author: Guillaume Autran <gautran@clearpath.ai> Date: Tue Jan 12 14:48:57 2016 -0500 TCPROS - Protocol dissector improvements - Added specific dissector for ROS Clock messages - Added dissector heuristics - Improve ROS traffic detection Problems to resolve: - Some topics are mistaken for Clock messages. These includes the wheel encoder topic. - ROS Services are not detected. - Ideally, the TF topic should be dissected as it is a very common topic Bug: 12749 Change-Id: I14255cbb42ae36b7e39f64dc1a5c6efffe19c8b1 Reviewed-on: https://code.wireshark.org/review/17086/ Reviewed-on: https://code.wireshark.org/review/17086 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=0a9e84264947c75bbe96d0b67cb2dbe... commit 0a9e84264947c75bbe96d0b67cb2dbe0f521f3b8 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Sat Aug 20 21:03:02 2016 +0200 COAP: ensure that key_token is always initialized Even when the token length is 0. Bug: 12771 Change-Id: I0d77f0411fe90a6702d1f23ba9cd4b61433a5995 Reviewed-on: https://code.wireshark.org/review/17194 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8f98f7ce67d23fbeb17a4a3fd75cb37... commit 8f98f7ce67d23fbeb17a4a3fd75cb376a705300f Author: Uli Heilmeier <uh@heilmeier.eu> Date: Fri Aug 19 21:21:29 2016 +0200 BOOTP: Catch undefined Client Identifier (Option 61) [1] stats "A hardware type of 0 (zero) should be used when the value field contains an identifier other than a hardware address (e.g. a fully qualified domain name)." This commit displays these other identifier. [1] https://tools.ietf.org/html/rfc2132#section-9.14 Bug: 12766 Change-Id: I3d991164641b41fb95891b2f78411d2e98a22e0d Reviewed-on: https://code.wireshark.org/review/17180 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=68a9ea61897d65d2b8970eba7f9b058... commit 68a9ea61897d65d2b8970eba7f9b05851e5e575d Author: Yasuyuki Tanaka <yatch@isl.rdc.toshiba.co.jp> Date: Wed Aug 17 18:48:24 2016 +0200 ICMPv6: Add support for MPL Control Message (RFC 7731) Bug: 12757 Change-Id: I454c8a9a85c703a746e5152157817b1d8a48accf Reviewed-on: https://code.wireshark.org/review/17115 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=302660bf575fcb7b8423b9cfbdf32e5... commit 302660bf575fcb7b8423b9cfbdf32e58e3a14e94 Author: Mirko Parthey <mirko.parthey@web.de> Date: Sun Aug 14 23:50:25 2016 +0200 ISAKMP: Add regression tests Add regression tests for bugs 12610 and 12620 Bug: 12610 Bug: 12620 Change-Id: I6325a3ccb3e27fd4d3be52190e8763737b99fe73 Reviewed-on: https://code.wireshark.org/review/17083 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6eebf9491cede3aa021e63a65ce1a28... commit 6eebf9491cede3aa021e63a65ce1a28fc93f5572 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 08:09:53 2016 +0200 QUIC: Enhance dissection of STREAM stream_id = 1 is reserved for QUIC handshake/crypto... stream_id = 3 is reserved for H2 HEADERS (PUSH_PROMISE..) (and call H2 dissector for dissection) Thanks for Lucas for pcap Change-Id: I563c44af88c3e72476f8637d8b7c5ba4d8a4a995 Reviewed-on: https://code.wireshark.org/review/17134 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=bb999e211984450f93040affb8cbe52... commit bb999e211984450f93040affb8cbe5281dd2ddcc Author: Andreas Leibold <andreas.leibold@harman.com> Date: Fri Aug 19 10:29:51 2016 +0200 1722 extensions: code clean up, warning removed code clean up dissector bugfixing 1722 / 61883 subtype: packet inspection enhanced regarding warnings 1722 / 61883-6 subtype: more detailed packet dissection Change-Id: I0d762f37402ca27ad33e0d22da50c184297bed57 Reviewed-on: https://code.wireshark.org/review/17110 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c06da45f3cea0263cfe2a02ee4294b7... commit c06da45f3cea0263cfe2a02ee4294b754e5657df Author: Guy Harris <guy@alum.mit.edu> Date: Fri Aug 19 16:18:43 2016 -0700 Add a preference to byte-swap the CAN ID field. This can be useful when dealing with 1) captures from versions of libpcap without the bug fix to use DLT_CAN_SOCKETCAN_HOSTENDIAN when appropriate and 2) DLT_CAN_SOCKETCAN_HOSTENDIAN captures if processed by a machine with a different byte order from the capturing machine with software that doesn't properly put the field into host byte order when reading and writing. Change-Id: Ia206e5c51aecccf2508cca01cff65a4feb379ac8 Reviewed-on: https://code.wireshark.org/review/17187 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=22a4f8e43ff2e5f6bbd4dfec68db679... commit 22a4f8e43ff2e5f6bbd4dfec68db67939746a6df Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Aug 19 13:37:59 2016 +0200 LCSAP: fix indent (use 2 spaces) and modelines Change-Id: I688c71a94703cecbf62b0e29f1e389551cedbeb9 Reviewed-on: https://code.wireshark.org/review/17171 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9bfbea94392195e9079ad78db4f874f... commit 9bfbea94392195e9079ad78db4f874f491b6144e Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Aug 19 18:02:58 2016 +0200 NAS EPS: generate the consecutive TAC values when using the TAI list format 1 Change-Id: I79442a95c52c0ac334ad27b83b78af78d0d23dcc Reviewed-on: https://code.wireshark.org/review/17179 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9a0a7e50cf2f832d1f140e8d7db65ef... commit 9a0a7e50cf2f832d1f140e8d7db65efd18c6c0b0 Author: Guy Harris <guy@alum.mit.edu> Date: Fri Aug 19 13:19:06 2016 -0700 Do all data fetching in the appropriate byte order. Change-Id: I481288b566c2b9888b3f068d2dbae1240fa2930e Reviewed-on: https://code.wireshark.org/review/17181 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3646cbb5db56dd794f743f3a0157558... commit 3646cbb5db56dd794f743f3a01575585624d23bb Author: AndersBroman <anders.broman@ericsson.com> Date: Fri Aug 19 15:10:06 2016 +0200 [Diameter] Add subdissection of AVP 1242 location estimate and AVP 2516 EUTRAN-Positioning-Data. Change-Id: I8eebd94ab82889cff5ef3a209c485e8d2769a71d Reviewed-on: https://code.wireshark.org/review/17177 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=6cfb20da0dd5617c620e7f48f95e931... commit 6cfb20da0dd5617c620e7f48f95e931c19a0dac4 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Aug 19 18:00:36 2016 +0200 NLM: fix dissection of NLM_FREE_ALL message The second parameter is the state, not the status as seen in C702 doc, page 159 Bug: 12764 Change-Id: I0a91a0e586c7663ace7c4c6b1044cafc1c0975ac Reviewed-on: https://code.wireshark.org/review/17178 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7cfb8b81f9a93c521f84a6f04c8e6e4... commit 7cfb8b81f9a93c521f84a6f04c8e6e4f2b5db909 Author: Gerald Combs <gerald@wireshark.org> Date: Fri Aug 19 13:59:49 2016 -0700 Answer a locale question in a comment. Change-Id: If2c287ed8d2a3b518ceff891f1e6d995d7a7daad Reviewed-on: https://code.wireshark.org/review/17182 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f52ce404593575cbc57903b46811007... commit f52ce404593575cbc57903b46811007cbf89618a Author: AndersBroman <anders.broman@ericsson.com> Date: Fri Aug 19 15:06:51 2016 +0200 [Diameter] Add stray AVP "Pseudonym-Indicator" code="2519" Change-Id: I050c27b7118fb98fea20fec697279dc68820763d Reviewed-on: https://code.wireshark.org/review/17176 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8bca5f6602cb655754dde64d42886d9... commit 8bca5f6602cb655754dde64d42886d9f03c4be0c Author: AndersBroman <anders.broman@ericsson.com> Date: Fri Aug 19 13:02:34 2016 +0200 [LCS-AP] Add decoding of Civic-Address, add expert info if wrongly encoded. Change-Id: I2631fe5ae7f8e73f8f4067c73197ae4cd386b633 Reviewed-on: https://code.wireshark.org/review/17169 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3a7e3057e6aeade67d7fc3bbc89614f... commit 3a7e3057e6aeade67d7fc3bbc89614f5a26e93d1 Author: Dario Lombardo <lomato@gmail.com> Date: Mon Aug 8 22:10:48 2016 +0200 codecs/speex: add check in speex_resampler_init_frac/set_rate_frac (CID 1355648). Add checks to avoid den_rate and num_rate to be set to 0. Change-Id: Ia4880521e7ab73d0fdc44377f4badadb09365471 Reviewed-on: https://code.wireshark.org/review/16963 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c3a8a0ce8ad391bda135fe39f304cc2... commit c3a8a0ce8ad391bda135fe39f304cc23e3025101 Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Aug 17 21:14:57 2016 +0200 netlink: fix flags dissection Flags are not in network byte order, use given encoding instead. Show both flags fields for GET and NEW requests since the netlink dissector cannot yet determine whether a request is for GET, NEW or something else. This has no effect for the sockdiag dissector but it will influence the route and netfilter netlink subdissectors. Change-Id: I472ff9e0498debbbceef657a14408c4e6a9df75b Reviewed-on: https://code.wireshark.org/review/17118 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d2ee571df2b31079f4b4f0e1915edc7... commit d2ee571df2b31079f4b4f0e1915edc76f9a5dcff Author: Michał Skalski <mskalski13@gmail.com> Date: Tue Aug 16 03:21:09 2016 +0200 dissector ISAKMP: Added decryption using AES-GCM, AES-CCM and AES-CTR Added support for decryption of IKEv2 packets encrypted with PAED or CTR cipher mode. Verification of integrity requires libgcrypt 1.6.0 or later. If it is not the case, only decryption is performed Can easily be extended to other ciphers supported by libgcrypt. NOTE: There is long-term bug in handling UAT for IKEv2 - any change resulting in change count of IKEv2 UAT entries causes crash when matching key from UAT is found. Crash does not occur when UAT is read from user prefs file. I observed this bug also on stock 1.10.6 version from Ubuntu 14.04 LTS I have no knowledge, how to fix it. Change-Id: Ibdab979b5959eb561635cbcb446e17138baca87b Reviewed-on: https://code.wireshark.org/review/17078 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5b57c799d3555c683b79a2a94c7dffc... commit 5b57c799d3555c683b79a2a94c7dffce65a30907 Author: Juanjo Martin <juanjo@rti.com> Date: Thu Aug 18 13:39:10 2016 +0200 RTPS: Added locator information to the parameter tree. This makes the user avoid to click twice in order to see the info. Change-Id: Ib983c78634b1309f12ab29d673abc1195088f55c Reviewed-on: https://code.wireshark.org/review/17146 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=72a8e95a43a8a0562f3fd87f176cb44... commit 72a8e95a43a8a0562f3fd87f176cb44d3ce34971 Author: Francois-Xavier Le Bail <fx.lebail@yahoo.com> Date: Fri Aug 19 09:15:31 2016 +0200 bfd: Fix a comment on Control packet version 1 Bug:12761 Change-Id: I5877878f19be4907b9fc0c00f19601a3c7a67005 Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-on: https://code.wireshark.org/review/17163 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2557f033f5124ad5d777c0f8a93c80b... commit 2557f033f5124ad5d777c0f8a93c80b2722a80bb Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Fri Aug 19 11:10:50 2016 +0200 mongo: set on subtree when Empty Document Change-Id: I2b6b7cf771ab7bc2f6dbc0aac5eddda2a9d2fb53 Reviewed-on: https://code.wireshark.org/review/17167 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7f173c0458dcc40ad3e60e26a0797f7... commit 7f173c0458dcc40ad3e60e26a0797f7d714312dd Author: AndersBroman <anders.broman@ericsson.com> Date: Fri Aug 19 12:34:53 2016 +0200 [LCS-AP] id-E-UTRAN-Cell-Identifier is sued also as an extension value. Change-Id: I86c7ff51a16801c2995161c45cb3d8e6800f54c4 Reviewed-on: https://code.wireshark.org/review/17168 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a837263f5748b9e3ced04e179d808ee... commit a837263f5748b9e3ced04e179d808eeebac21c60 Author: AndersBroman <anders.broman@ericsson.com> Date: Fri Aug 19 10:18:44 2016 +0200 [Diameter] Ad dissetion of Access-Restriction-Data bitfield. Change-Id: I3e751f07c540b056b55fc98fb9c26d23718bd8fc Reviewed-on: https://code.wireshark.org/review/17164 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d1c763c3f68c764ed7da85c79c4b000... commit d1c763c3f68c764ed7da85c79c4b000e5dad7ffb Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Thu Aug 18 21:15:52 2016 +0200 NAS EPS: fix dissection of multiple partial tracking area identity list As reported on https://ask.wireshark.org/questions/54955/nas-tracking-area-identity-list-de... Change-Id: I8c4ed1982e1d72136558fb381d2d15b15c9e376c Reviewed-on: https://code.wireshark.org/review/17151 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8963303df76537d9520a3e9c431cb42... commit 8963303df76537d9520a3e9c431cb420fdcd7707 Author: Guy Harris <guy@alum.mit.edu> Date: Thu Aug 18 19:48:35 2016 -0700 Adjust to the split of the SocketCAN encapsulation. Change-Id: Ibbe97f15854163163ad2bdf3b425c63d4cbfed50 Reviewed-on: https://code.wireshark.org/review/17158 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=b420d4fb448b141f9d12469c775b3b0... commit b420d4fb448b141f9d12469c775b3b09c094f041 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Sat Jul 16 08:30:06 2016 +0200 Add tools for setup macos dev environnement using brew Will be reused for Travis osx Change-Id: Ida905768efc4e48be9936b3113704dcb651d4ca0 Reviewed-on: https://code.wireshark.org/review/16495 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=95c4c432c43a07d8a43eae335916161... commit 95c4c432c43a07d8a43eae33591616145cabc57a Author: Guy Harris <guy@alum.mit.edu> Date: Thu Aug 18 18:39:43 2016 -0700 Handle the new LINKTYPE_CAN_SOCKETCAN_HOSTENDIAN. Unfortunately, only one libpcap code path puts the CAN ID in the SocketCAN header in network byte order; the others leave it in host byte order. Therefore, a new LINKTYPE_/DLT_ value was introduced, and libpcap was changed to use that for the cases where the CAN ID is in host byte order. Support them both. This means we need to, when reading pcap and pcapng files, fix up the CAN ID if the host that wrote the file has a different byte order from ours (as libpcap also now does). This includes Linux "cooked" captures, which can include CAN packets. Change-Id: I75ff2d68d1fbdb42753ce85d18f04166f21736dd Reviewed-on: https://code.wireshark.org/review/17155 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=2a4d6f1b3caccc015a1d18ea3267233... commit 2a4d6f1b3caccc015a1d18ea3267233a5503c703 Author: Chris Brandson <chris.brandson@gmail.com> Date: Thu Aug 18 11:05:55 2016 -0700 fix endianess of rejoin source address Change-Id: I71e6e2f569524642a24778ceef81c03fdc0f54c5 Reviewed-on: https://code.wireshark.org/review/17149 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=8accce861479c8d4f9d37a167c835c0... commit 8accce861479c8d4f9d37a167c835c047c620b89 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Thu Aug 18 19:15:53 2016 +0200 etypes: Add ETHERTYPE_LINK_CTL The definition was found in the Linux kernel source code. Change-Id: I41d1435497042bc5905efc7e1af3941b9e8808e2 Ping-Bug: 12759 Reviewed-on: https://code.wireshark.org/review/17148 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=ea024e245e3db5f65a99479be54414b... commit ea024e245e3db5f65a99479be54414ba5f2413fc Author: Chris Bontje <cbontje@gmail.com> Date: Thu Aug 18 11:07:13 2016 -0600 SEL Protocol - Fix 'Fast Meter Config' sub-tree addition typo & 'if (tree)' usage - The proto_tree_add_subtree call was previously using the length of the full tvb, instead of len-2 like all other calls. This typo did not previously cause an issue, but in newer versions of Wireshark it causes an assert. - When I created the selfm dissector 4-5 years ago, I used packet-synphasor.c as a template and there was an 'if (tree)' wrapper around several initial GUI calls including col_*** info column clear/set functions. It looks like in recent years this layout has been removed (for example, https://code.wireshark.org/review/#/c/6725/ ). I'm not sure of the exact reasoning behind this, but in Wireshark 2.x (QT), there are several conditions where in the SEL protocol dissector the info column will be cleared and not repopulate - I can only assume because col_clear has been called with no col_add's. Removal of this 'if' condition does correct the issue with no immediate ill effects.. Change-Id: I4c619cb320cd2152e1d4d1b76c809b1498dfda61 Reviewed-on: https://code.wireshark.org/review/17147 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fce1871df40a34cadb881e6dd105bbb... commit fce1871df40a34cadb881e6dd105bbb1b9ee026c Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 15 19:26:50 2016 +0200 QUIC: Add detection of server port Some debug tools don't use the standard 443 Change-Id: I5826de69afe343e4c112ecb78ffa1e26bd35b242 Reviewed-on: https://code.wireshark.org/review/17069 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=65c885ffc76ab2d0d7afa8e08ffe9cf... commit 65c885ffc76ab2d0d7afa8e08ffe9cfcae0a3151 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 13:16:12 2016 +0200 TCP: fix no previous prototype for 'exp_pdu_tcp_dissector_data_size/exp_pdu_tcp_dissector_data_populate_data' [-Wmissing-prototypes] Change-Id: I259f457868f4b8cde7e188d88d3d55f97070ee3b Reviewed-on: https://code.wireshark.org/review/17145 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2a4c11592f5966676098927490680f0... commit 2a4c11592f5966676098927490680f0f6e854c04 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 13:17:21 2016 +0200 logcat (text): fix no previous prototype for 'logcat_text_init/logcat_text_cleanup' [-Wmissing-prototypes] Change-Id: I1c8462064e7c07ee7f626fb26ad6bb744a7fc5b3 Reviewed-on: https://code.wireshark.org/review/17144 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=26464b028baac61102fea77b7ae6f19... commit 26464b028baac61102fea77b7ae6f19755c2359e Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 13:23:11 2016 +0200 ERF: fix no previous prototype for 'erf_ts_to_nstime/dissect_relative_time/dissect_ptp_timeinterval' [-Wmissing-prototypes] Change-Id: I21ee4f8850f63de3a7fa91ed9e8a426c82a9d62e Reviewed-on: https://code.wireshark.org/review/17143 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=6d023626c9defa8d8cdc1a5e3aa5a6a... commit 6d023626c9defa8d8cdc1a5e3aa5a6ac631cd1e0 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 09:28:24 2016 +0200 btatt: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I4c8d2fc74a84e4fe4a85efeb75f666f5402c6030 Reviewed-on: https://code.wireshark.org/review/17137 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3771bc73cc0b4d069a280e61a5c86e2... commit 3771bc73cc0b4d069a280e61a5c86e25ff82c5ca Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 13:14:47 2016 +0200 UDS: fix fix no previous prototype for 'proto_register_uds/proto_reg_handoff_uds' [-Wmissing-prototypes] Change-Id: I14567ea0142555aedb859e52eb4d92f89da8d695 Reviewed-on: https://code.wireshark.org/review/17142 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c996629ac04405e0c14ae93b9d6bf2e... commit c996629ac04405e0c14ae93b9d6bf2e21e52c8b1 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 13:18:53 2016 +0200 iso15765: fix no previous prototype for 'proto_register_iso15765/proto_reg_handoff_iso15765' [-Wmissing-prototypes] Change-Id: Id563eb5c44a988a7ea5149e312f4033cd4ca31e9 Reviewed-on: https://code.wireshark.org/review/17141 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e4a37b92ec8e9c961701a7474c661c1... commit e4a37b92ec8e9c961701a7474c661c127c40c0fe Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 13:22:05 2016 +0200 gsm abis tfp: fix no previous prototype for 'proto_register_abis_tfp/proto_reg_handoff_abis_tfp' [-Wmissing-prototypes] Change-Id: I86d397e0fb37ff12e58c923a63fbb201934d0e66 Reviewed-on: https://code.wireshark.org/review/17140 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=81fe1cada61a4cd0dc541663bb3e624... commit 81fe1cada61a4cd0dc541663bb3e624f6299141d Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 13:20:53 2016 +0200 gsm abis pgsql: fix no previous prototype for 'proto_register_abis_pgsl/proto_reg_handoff_abis_pgsl' [-Wmissing-prototypes] Change-Id: I6138ca727e6802bc2066bc1ecb8549365b588da2 Reviewed-on: https://code.wireshark.org/review/17139 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b2a6bb18aa84a084f1662eaf4faaf26... commit b2a6bb18aa84a084f1662eaf4faaf26c764ef629 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 13:02:53 2016 +0200 QUIC: fix typo about stream offset it is only Offset not Offset Length Issue reported by Lucas Change-Id: I3129d62a0601b896fd0d44d5ce4d32864afdd96e Reviewed-on: https://code.wireshark.org/review/17138 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5bc19feb86114518f988762a242c60e... commit 5bc19feb86114518f988762a242c60e21487f6dc Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Thu Aug 18 08:07:00 2016 +0200 HTTP2: export dissect_http2_pdu for used on another dissector... Change-Id: I7c27517ee26ee9f9384e22a83e547550863093d8 Reviewed-on: https://code.wireshark.org/review/17133 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=13de8ab67643d1e9b88d5ef2c4c5140... commit 13de8ab67643d1e9b88d5ef2c4c51402757006d2 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Aug 16 19:52:19 2016 +0200 QUIC: Fix some minor typo Change-Id: I541cbfd133695e4856175eb8281f30d4c2dcaea1 Reviewed-on: https://code.wireshark.org/review/17132 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4ae62f1815feeeff04ac29a49ad24b9... commit 4ae62f1815feeeff04ac29a49ad24b949c3f7127 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Wed May 25 08:22:43 2016 +0200 PAPI: Add Port (src/dest) description Change-Id: Iac6c550398f737200470505b4ed2dcffb24fa5fa Reviewed-on: https://code.wireshark.org/review/15573 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0a609d419527b3f0cd15b2a66f9be5d... commit 0a609d419527b3f0cd15b2a66f9be5df3718c3a8 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Thu Aug 18 08:47:49 2016 +0100 pre-commit: Ignore missing pre-commit-ignore.py Print error message to stderr and return non-zero exit status from child process. Change-Id: Icd433d79c5a7bf8b6ddd8e94e26695b353e34d1f Reviewed-on: https://code.wireshark.org/review/17116 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=b366d6e4dd5f14cfea820d132ee16b4... commit b366d6e4dd5f14cfea820d132ee16b45b18bd869 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Aug 12 23:12:18 2016 +0200 xbxml: restore removed line. This makes CID 1317251 obsolete. Change-Id: Id342b996268ac0734a52e93c02ae368960ee2294 Reviewed-on: https://code.wireshark.org/review/17027 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b6f73f2567854b1ea417957d7ea5de3... commit b6f73f2567854b1ea417957d7ea5de32b1989aa3 Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Aug 17 13:03:27 2016 +0200 Qt: fix crash on clearing dfilter after capture restart Since v2.1.2rc0-1-gaf5daa6 ("Qt: Replace a QMap with a QVector."), the following error could be observed: ASSERT failure in QVector<T>::operator[]: "index out of range", file /usr/include/qt/QtCore/qvector.h, line 433 Aborted (core dumped) It happens when a capture filter is present and a live capture is restarted. Then the number_to_row_ structure would be truncated which results in an invalid access. Fix this by always checking the length before inserting a new mapping. Do it inside the loop to prevent an unlikely race condition where more than 10000 packets are received before the next iteration. Store "row number + 1" to avoid having to initialize the new elements from resize() with -1, the default value is 0 which is good now. Change-Id: I88ce955a3551508e773eeadddc6f89bbb583acaf Reviewed-on: https://code.wireshark.org/review/17111 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3c8f657e01f1548fbf9cc5740374552... commit 3c8f657e01f1548fbf9cc5740374552aa8c6fdc6 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Mon Aug 15 18:55:45 2016 +0200 ISAKMP: Fix Result of operation is garbage or undefined found by Clang Analyzer Change-Id: I47233968dfc87494b3c959896622db5cd31244a7 Reviewed-on: https://code.wireshark.org/review/17065 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Mirko Parthey <mirko.parthey@web.de> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=635f0a5c2cea2f8156281953f49568e... commit 635f0a5c2cea2f8156281953f49568e1129debf1 Author: Gerald Combs <gerald@wireshark.org> Date: Thu Aug 11 09:10:48 2016 -0700 Update the README. The formatting was mostly AsciiDoc-compliant. Take it the rest of the way. Update the list of supported operating sytems, along with other info. Use HTTPS URLs. Remove README.tru64 while we're here. Change-Id: Ibd9cac5d9f3cdcc7de9c9d7052c14e851e108cbe Reviewed-on: https://code.wireshark.org/review/17014 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=38a38abc17bc726bbec6b85bafb3db8... commit 38a38abc17bc726bbec6b85bafb3db88dde5e5a5 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Aug 16 19:41:24 2016 +0200 QUIC: Update error code Also update link to source code Change-Id: I9afb72e477d11e3427cb43d574b2949bb8d777f9 Reviewed-on: https://code.wireshark.org/review/17091 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=01d1a4a392893a181f5878cadcba7e9... commit 01d1a4a392893a181f5878cadcba7e93c88a4fa7 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Aug 16 19:42:08 2016 +0200 QUIC: Fix encoding arg from MIDS Tag Change-Id: Ia1468c5f64b41452f373800af36c4c1fb4c58dbe Reviewed-on: https://code.wireshark.org/review/17092 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d0e4e5259fe13e4f7a2397127c5f294... commit d0e4e5259fe13e4f7a2397127c5f294e821236b4 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Tue Aug 16 09:56:25 2016 +0200 BGP: Add no supported AFI/SAFI (Cisco) Open Message Error Bug:12601 Change-Id: I555ee8097ea81e1afa8f2f5b2aba8fce60742016 Reviewed-on: https://code.wireshark.org/review/17107 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=322276d4b20c5d7e13c43ef723aacd9... commit 322276d4b20c5d7e13c43ef723aacd908321938a Author: Chris Bontje <cbontje@gmail.com> Date: Wed Aug 17 12:11:14 2016 -0600 SEL Protocol - Correct dissection for 'SOE Present State Response' function code Change-Id: I53691344f22f7313242f31e0abce9af5a5dbf8be Reviewed-on: https://code.wireshark.org/review/17117 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=45a8861b1ed6d394de786e276db8998... commit 45a8861b1ed6d394de786e276db8998ea0ea0efc Author: Guy Harris <guy@alum.mit.edu> Date: Wed Aug 17 19:03:11 2016 -0700 Don't distinguish between PARSED_NONRECORD and PARSE_FAILED. If we got no bytes of data from a putative packet, the file isn't a valid Ascend file, regardless of whether the parser failed or not. Just have parse_ascend() return a Boolean, TRUE if we got a packet and FALSE if not, and, in the case where we got no data but the parser didn't fail, provide "no data returned by parse" as the error string. (We weren't actually distinguishing between them when we called parse_ascend() - we were treating all non-PARSED_RECORD returns as an error.) Change-Id: I85a3e318015258f6a62c8d23ac2f906e28789982 Reviewed-on: https://code.wireshark.org/review/17130 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=85ebd88083e134304c76af52aa57306... commit 85ebd88083e134304c76af52aa573064e73df19f Author: Guy Harris <guy@alum.mit.edu> Date: Wed Aug 17 18:41:36 2016 -0700 Make it a little clearer what ascend_open() is doing. Expand comments, and merge two separate if checks. Change-Id: If339ce632ccc91c425ba6db4a32296c3038253ac Reviewed-on: https://code.wireshark.org/review/17128 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=3ba8a28f50ac695233c711c392aed33... commit 3ba8a28f50ac695233c711c392aed33d9dd398bf Author: Guy Harris <guy@alum.mit.edu> Date: Wed Aug 17 18:34:33 2016 -0700 Just return the value of yyparse() from run_ascend_parser(). That's what we're doing already, but get rid of the variable to which we assigned the return value. Change-Id: I55e31664bc26bbfffe4a4ca764c917eefbb9a8f1 Reviewed-on: https://code.wireshark.org/review/17126 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=f17ba6b21c892d4e74e2f75e766d6da... commit f17ba6b21c892d4e74e2f75e766d6daacb8d5d52 Author: Jeff Morriss <jeff.morriss.ws@gmail.com> Date: Wed Aug 17 19:47:42 2016 -0400 Add a script to validate the Diameter dictionary XML. I wrote this during Sharkfest to get the Diameter dictionary into (mostly) valid XML. There's some room for improvement in the script but it works. Change-Id: Ic8548c4f321831397951bf1d76779c263a832682 Reviewed-on: https://code.wireshark.org/review/17124 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=cdd3f45c6455012ea573c8324009838... commit cdd3f45c6455012ea573c8324009838db2570286 Author: Jeff Morriss <jeff.morriss.ws@gmail.com> Date: Wed Aug 17 10:26:48 2016 -0400 RPM: distribute the wireshark.pc file. It's been installed since Idb60157a51ea1dd0afd6cfac695bfa5760485241. Change-Id: I2171f2a0bc9b05059b8ecf4451715f7f6d9506e3 Reviewed-on: https://code.wireshark.org/review/17113 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9cbcdee7538b8b22eb27e68d0697c3a... commit 9cbcdee7538b8b22eb27e68d0697c3a15635960f Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Thu Aug 18 00:05:05 2016 +0100 pre-commit: Make version check work with git-worktree By disabling it outside the main working tree this time. Change-Id: I2075b07370e3cc1395c6de9695e40b0a952e3eab Reviewed-on: https://code.wireshark.org/review/17122 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=e3daf4a66d5f14148494c28649fb781... commit e3daf4a66d5f14148494c28649fb78136807e417 Author: Gerald Combs <gerald@wireshark.org> Date: Tue Aug 16 16:23:30 2016 -0700 Start recommending Python 3 on Windows. Works fine here, including git-review. Change-Id: I8580a6b266fba09c711be8984a9f17e02a9f789f Reviewed-on: https://code.wireshark.org/review/17097 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=72a3195c8649c315c301942da68e4ee... commit 72a3195c8649c315c301942da68e4ee31af17445 Author: Guy Harris <guy@alum.mit.edu> Date: Wed Aug 17 15:48:38 2016 -0700 The caplen for a packet is always "number of bytes seen". Set wirelen to the length from the header, but don't set caplen; start caplen out as 0 and count it up whenever we add a byte. Bug: 12754 Change-Id: Ib4e45e947df6077f97a423157c152dac9f57734a Reviewed-on: https://code.wireshark.org/review/17120 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=517058060ac7002d4c1d499a7db7dc5... commit 517058060ac7002d4c1d499a7db7dc5de807e233 Author: Jeff Morriss <jeff.morriss.ws@gmail.com> Date: Tue Aug 16 10:50:37 2016 -0400 Clean up release notes for 2.4. Specifically, remove all the stuff that was listed as new in the 2.2 release notes. Comment out some empty sections. (Note that the "Encrypted UDP based FTP with multicast" protocol is removed because that dissector was backported to master-2.2.) Change-Id: I6663b1f4456b3d4f401696af764a275dfa39ad99 Reviewed-on: https://code.wireshark.org/review/17087 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=74e8b539a22043869186ca1af46ba79... commit 74e8b539a22043869186ca1af46ba796a5378225 Author: Gerald Combs <gerald@wireshark.org> Date: Tue Aug 16 12:25:55 2016 -0700 Fix a comparison in win-setup.ps1 "if ($SomeVariable > 0)" is valid PowerShell syntax, but it writes the value of $SomeVariable to a file named "0". Use the "-gt" operator instead. Change-Id: I17e0f7033008ead3b24fed8c0c91869747ff81f1 Reviewed-on: https://code.wireshark.org/review/17093 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=f92f16916a8d84758c52fc014dbbc3c... commit f92f16916a8d84758c52fc014dbbc3cf36a59d44 Author: AndersBroman <anders.broman@ericsson.com> Date: Wed Aug 17 15:51:23 2016 +0200 [Diameter] Add a couple of AVP:s Change-Id: If7b6a1ba5e81ccb5395df33b7bbcb24a616727c9 Reviewed-on: https://code.wireshark.org/review/17112 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dd15a6d505c08078377e2a69079fdb8... commit dd15a6d505c08078377e2a69079fdb8ae3247db7 Author: Peter Wu <peter@lekensteyn.nl> Date: Fri Aug 12 17:24:54 2016 +0200 netlink-netfilter: add partial ipset support Based on Linux 4.7 headers, this decodes many interesting fields like the setname, IP address and more. Many attributes are not fully dissected, but at least the attribute names are visible now. Tested with netlink-ipset.pcap, posted on the SampleCaptures wiki. Change-Id: Ibd430e9d0f177d5f21753ac1206541b4e50329f2 Reviewed-on: https://code.wireshark.org/review/17031 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> http://cgit.osmocom.org/wireshark/commit/?id=2e37b271c473e1cbd01d62ebe1f3b01... commit 2e37b271c473e1cbd01d62ebe1f3b011fc9fe638 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Aug 16 23:52:03 2016 +0200 DCT2000: fix a buffer overflow in case of malformed packet Bug: 12750 Change-Id: Iff20efa46e000ab4ae77b2edbcb0b9af4634508c Reviewed-on: https://code.wireshark.org/review/17096 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3b97fbddc23c065727b0147aab52a27... commit 3b97fbddc23c065727b0147aab52a27c4aadffe7 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Aug 16 23:40:25 2016 +0200 DCT2000: prevent a stack buffer overflow Bug: 12752 Change-Id: I2007082909cea07314ac40d6db32ee9c2804ecdf Reviewed-on: https://code.wireshark.org/review/17095 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dd1ef75f99960a91d8b035c25999574... commit dd1ef75f99960a91d8b035c2599957456b8b2fa7 Author: Chris Brandson <chris.brandson@gmail.com> Date: Tue Aug 16 10:10:36 2016 -0700 zbee (nwk): fix typo in Rejoin IE name Change-Id: I80184c66928b6704365e1538cf47c6036d4b053f Reviewed-on: https://code.wireshark.org/review/17090 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c92ff165a290d482aa1e6b3d0434930... commit c92ff165a290d482aa1e6b3d0434930cd37d3466 Author: Binh Trinh <beango@gmail.com> Date: Tue Aug 16 23:31:29 2016 -0400 S1AP: Initialise handovertype for procedure HOReqAck Change-Id: I4d90bebc94d7e3ead1f2263668c6a3344d02bc0f Reviewed-on: https://code.wireshark.org/review/17098 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b23587f6d5ff009500a24ee275a2ca8... commit b23587f6d5ff009500a24ee275a2ca8a4bb5af23 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 16 23:59:03 2016 -0700 Show millisecond values as both raw and "(N msec)". Do as we do with other Bluetooth fields that, when multiplied by 1.25, give time amounts in milliseconds. Change-Id: I89c599e68f91c134b216c495dabdbf77db10def3 Reviewed-on: https://code.wireshark.org/review/17099 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=315bba7c645b75af24215c6303d187b... commit 315bba7c645b75af24215c6303d187b188610bba Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Aug 16 23:11:12 2016 +0200 FP: ensure that mac and rlc structures are always allocated Rather han checking everywhere that the RLC and MAC info are present in pinfo, allocate a temporary structure that will be dropped once packet dissection is over. Bug: 12751 Change-Id: I890430dd0c0b56d641777c15eedbf07fef082904 Reviewed-on: https://code.wireshark.org/review/17094 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5716cc6d7caae0700910758c1feea5d... commit 5716cc6d7caae0700910758c1feea5dbb67cfab4 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Tue Aug 16 16:20:58 2016 +0100 Add licensecheck.pl to the tarball checklicenses.py now needs it. Change-Id: I1a8c6e21fb35386dcaa44c72f9c196445a378a04 Reviewed-on: https://code.wireshark.org/review/17088 Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=858f11c1f0928391bb7980d73a7d91e... commit 858f11c1f0928391bb7980d73a7d91ea903fb226 Author: Juanjo Martin <juanjo@rti.com> Date: Tue Aug 16 18:12:13 2016 +0200 RTPS: Added improvement for SHMEM locator Change-Id: I2d7abf3606aad939901e70f94054a49b1b15a20d Reviewed-on: https://code.wireshark.org/review/17089 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=445d0f6f78817a2403e2aae30b55417... commit 445d0f6f78817a2403e2aae30b554172ba295969 Author: Jeff Morriss <jeff.morriss.ws@gmail.com> Date: Tue Aug 16 10:40:38 2016 -0400 Document the new Windows Cluster Management API dissector. It was added in I86efa0c725667083cb252e5df3bfc69118df3059. Change-Id: Ie7a80cac232bc2f763a5526bb3049fccbdc96e22 Reviewed-on: https://code.wireshark.org/review/17085 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4a2e89bff20c37f5d8863d1e57d495d... commit 4a2e89bff20c37f5d8863d1e57d495df14f75598 Author: Michal Labedzki <michal.labedzki@tieto.com> Date: Tue Sep 8 19:06:30 2015 +0200 Bluetooth: ATT: Implement attribute Regulatory Certification Data List It is described in Personal Health Devices Transcoding White Paper v1.6 at Bluetooth.org. It is not detailed implementation, because white paper is not specification for this, but it is really "giant leap for mankind". Change-Id: I476b242a67c7c0b24e450ad347216c708cc12879 Reviewed-on: https://code.wireshark.org/review/17079 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=dfbfdc411c11a5c49307a3125810f65... commit dfbfdc411c11a5c49307a3125810f65a099bdd85 Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Aug 16 12:42:20 2016 +0200 [H248] Fix Warn Dissector bug, protocol H248, in packet 1: tvbuff.c:532: failed assertion "tvb && tvb->initialized" gcp_analyze_msg() is called with a NULL tvb, remove h248_tvb and use tvb instead. Change-Id: I2cb4c3577817bbaa4ec50b2a5ef0ef296059e683 Reviewed-on: https://code.wireshark.org/review/17082 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=13d0d1038f44a95ecb4bc7a944410f1... commit 13d0d1038f44a95ecb4bc7a944410f1d1dc8758e Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 15 21:04:54 2016 +0200 QUIC: Add MIDS (Max incoming dynamic streams) Tag Also update link to source code Change-Id: I6512920927de76226137eb7451cceceb37230aa5 Reviewed-on: https://code.wireshark.org/review/17070 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=26650355f2f4480dd48d5009c4291ae... commit 26650355f2f4480dd48d5009c4291ae9f3dba9fa Author: chrisbontje <cbontje@gmail.com> Date: Mon Aug 15 15:28:48 2016 -0600 L&G 8979 Dissector - Add new function codes - Added in support for Analog Group Change & Assignment codes (FC 2 and 35) - Modified RTU Configuration function code to support multiple chassis responses Change-Id: I64f14fa3c9b1bdfa3d815eb8756de80fb4c716b4 Reviewed-on: https://code.wireshark.org/review/17076 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=5ebfbf4fec09b0c316d97a339733af7... commit 5ebfbf4fec09b0c316d97a339733af7379c73398 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 15 19:25:15 2016 +0200 extcap: Fix Dereference of null pointer Change-Id: I03098de9bd8684953a4fe024a3e6b604eeecf03f Reviewed-on: https://code.wireshark.org/review/17066 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=4b403b0b5472333fb3751b695632e21... commit 4b403b0b5472333fb3751b695632e219c364f4d5 Author: Gerald Combs <gerald@zing.org> Date: Sun Aug 14 13:49:19 2016 -0700 Fix UAT escape widths. Pass unsigned values to the %x format specifier so that naming an IO graph 你好 TCP Segments doesn't end up saving "\xffffffe4\xffffffbd\xffffffa0\xffffffe5\xffffffa5\xffffffbd TCP Segments" to io_graphs. Fixes https://ask.wireshark.org/questions/54781/statistic-io-graph-add-a-new-graph... Change-Id: I5bcae05ef9b3e17532edbb293f323586c9aeb471 Reviewed-on: https://code.wireshark.org/review/17053 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=777061b196c39c8ddb64ce19b593778... commit 777061b196c39c8ddb64ce19b59377886994dd72 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 15 18:54:41 2016 +0200 LLDP: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I1d98c3ae79e98349f7d759cce4b93e6a94144743 Reviewed-on: https://code.wireshark.org/review/17064 Reviewed-by: Uli Heilmeier <openid@heilmeier.eu> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7aef32ac0829839996a228a2c79d213... commit 7aef32ac0829839996a228a2c79d2133ced12575 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 15 19:30:35 2016 +0200 SCTE35: Add to Makefile (for autofoo) Change-Id: I9eb3cde61ee3a23239211daa9a08730e4f22bade Ping-Bug: 12521 Reviewed-on: https://code.wireshark.org/review/17067 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=fab5a740744b20f1d71b0535ddd08a3... commit fab5a740744b20f1d71b0535ddd08a394923db54 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Mon Aug 15 19:12:11 2016 +0200 Exported PDU: dump payload before calling sub dissector This way, the payload is displayed even if the sub dissector triggers an exception Change-Id: Ife062f59035776c4eb9e550eb202a5e40afc4b60 Reviewed-on: https://code.wireshark.org/review/17063 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ede140a46a2af7febaaade67453c4c8... commit ede140a46a2af7febaaade67453c4c8f1d6c946d Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Mon Aug 15 18:36:12 2016 +0200 Exported PDU: fix a typo While we are at it, let's remove dead code Change-Id: I3a001f07b9becc885d544551a1fa578642517d08 Reviewed-on: https://code.wireshark.org/review/17061 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a216e6b945009e73202cf06f0819ef0... commit a216e6b945009e73202cf06f0819ef07c360d1c4 Author: Binh Trinh <beango@gmail.com> Date: Sun Aug 14 16:31:11 2016 -0400 GTPv2: Proper decoding of transparent containers for SRVCC PS to CS Request and Response Change-Id: Icc84f8e431b440ac0b0364b9f068905d7a7cbf6b Reviewed-on: https://code.wireshark.org/review/17052 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3119e2fc23ec2b1d533a37db29fa3c5... commit 3119e2fc23ec2b1d533a37db29fa3c512429d27e Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Sun Aug 14 14:23:07 2016 +0100 pre-commit: Fix version check to work with git-worktree Change-Id: Ie895ca194738a022cc211ae50afbff0a561156a3 Reviewed-on: https://code.wireshark.org/review/17047 Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=47fbdc297ad37bd8a7b5106cdc518d1... commit 47fbdc297ad37bd8a7b5106cdc518d1f82b63d9e Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Sat Aug 13 17:45:34 2016 +0100 Fix unit test location for out of tree autotools build Make it find test programs under the build tree. Change-Id: Ie7ff547417e8f248bb58f6c96896977ca4e710d1 Reviewed-on: https://code.wireshark.org/review/17048 Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=ba820319761dd2c4589ed76fc8aac3f... commit ba820319761dd2c4589ed76fc8aac3f8c9ff2fc8 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Mon Aug 15 11:30:56 2016 +0200 ISIS LSP: fix checksum verification Regression introduced in gad6fc87 Bug: 12745 Change-Id: I46f8364651c5774544007d9e74ce479904a52e05 Reviewed-on: https://code.wireshark.org/review/17059 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=0ebaffe0a8b319a2a9b1072d0121483... commit 0ebaffe0a8b319a2a9b1072d01214834286dff05 Author: Ben Stewart <bst@google.com> Date: Wed May 25 14:36:51 2016 -0700 Implement support for SCTE-35 switching messages. This module implements a dissector for the main table in a SCTE-35 message, a splice_info_section. This payload is carried in a MPEG Section Table with a table ID of 0xFC. PIDs carrying this sort of table are also noted in the PMT with a stream type of 0x86, and a registration descriptor with fourcc 'CUEI'. The various splice command types are implemented in separate modules, and are linked to this dissector through the field scte35.splice_command_type. Field names follow the conventions documented in the SCTE35 specification. This dissector does not support encrypted SCTE35 messages, other than indication through the scte35.encrypted_packet flag. The SCTE-35 protocol is described by the Society of Cable Telecommunications Engineers at <https://www.scte.org/documents/pdf/Standards/Top%20Ten/ANSI_SCTE%2035%202013.pdf>. Bug: 12521 Change-Id: I3113e6e61a4e7f1a4a932a0128ca2846c7ce6e6f Reviewed-on: https://code.wireshark.org/review/15562 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a5166affc47a9954c5177994c9b83f3... commit a5166affc47a9954c5177994c9b83f34313c7eb4 Author: Holger Pfrommer <hpfrommer@hilscher.com> Date: Fri Jul 22 14:27:15 2016 +0200 netanalyzer: add dissection of new header version 2 fields Change-Id: I552d8be0fdf3f0949d469e66c27be37ec82c5ccf Reviewed-on: https://code.wireshark.org/review/16584 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e3009b0b1c78b25337c915fb6623231... commit e3009b0b1c78b25337c915fb66232314f769688c Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Mon Aug 8 16:48:14 2016 +0100 checklicenses: Fix a FIXME We do not whitelist GPLv2 only code because of the incompatibility with GPLv3. Move the path exception to its proper place. These files are dual-licensed in the sense of "choose one or the other", not "both licenses are in use". If the exception becomes unnecessary later it can be removed, but let's get rid of the FIXME until then. Change-Id: Ia040284b72c2ff6588b0544896cc37ae19a61613 Reviewed-on: https://code.wireshark.org/review/16957 Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=b1cbeee4a6c45ff25784f76c55673cb... commit b1cbeee4a6c45ff25784f76c55673cb7c3ab5931 Author: Gerald Combs <gerald@wireshark.org> Date: Sun Aug 14 08:10:25 2016 -0700 [Automatic update for 2016-08-14] Update manuf, services enterprise-numbers, translations, and other items. Change-Id: If8420fce59c29f34d667fde83513030703600aba Reviewed-on: https://code.wireshark.org/review/17049 Reviewed-by: Gerald Combs <gerald@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=94c4329b8a0f64805e432af9ae89b7d... commit 94c4329b8a0f64805e432af9ae89b7d624437a08 Author: Peter Wu <peter@lekensteyn.nl> Date: Wed Aug 10 23:41:37 2016 +0200 make-version.pl: make it work with git worktrees When using git worktrees, the .git file is a regular file pointing to the original git repository. Accept this case too. Also ignore the fact that the original repo could be a git-svn repo, that is very unlikely. Example workflow (requires git 2.5): # Assume work in progress in current tree. Goal is to quickly do a # fix in another branch and publish the changes without interfering # with the WIP and without marking all files out of date (which # slows down re-compilation). git worktree add /tmp/wireshark-2.2 master-2.2 pushd /tmp/wireshark-2.2 # go to temporary tree git cherry-pick -x COMMIT # backport the fix git review # submit for review popd # go back to original tree rm -rf /tmp/wireshark-2.2 && git worktree prune # cleanup # now continue working where you left work Change-Id: Iba3c723142d9cbd8b07e76647594b5699ecafc67 Reviewed-on: https://code.wireshark.org/review/17002 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=f1dc6cb42ce6f90f4554647ac0e201c... commit f1dc6cb42ce6f90f4554647ac0e201c9c8edbb24 Author: Priyanka Mondal <priyanka02010@gmail.com> Date: Thu Aug 11 17:07:35 2016 +0530 nstrace: Modified the nstrace dissector to dissect the tcp debug2, tcp cc, httpinfo and trcdbg records. bug: 12685 Change-Id: I5e224c38c52d7b6635fba1334d9e310ce1eaea23 Reviewed-on: https://code.wireshark.org/review/16338 Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=2a73658c5c4fe510f601b98f15b8400... commit 2a73658c5c4fe510f601b98f15b84003f38bf591 Author: Binh Trinh <beango@gmail.com> Date: Sun Aug 14 00:16:50 2016 -0400 RANAP: fix TargetRNC-ToSourceRNC-TransparentContainer decode Change-Id: Iadf712b6bad75faeade00ebd1f6bb2cb2013065b Reviewed-on: https://code.wireshark.org/review/17044 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=7c66a6b8dc8f32c9dd571884ac59bb0... commit 7c66a6b8dc8f32c9dd571884ac59bb0db7ee64b6 Author: Michael Mann <mmann78@netscape.net> Date: Sat Aug 13 20:41:55 2016 -0400 dcerpc: Check dissect_ndr_ucvarray_core when looping over elements that we're incrementing offset. Bug: 12720 Change-Id: Ib9c9eb2e60c35b23b4c6b4898b036bcdc442fc84 Reviewed-on: https://code.wireshark.org/review/17041 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c0f24bdf6c255068d3de386b00c1d0d... commit c0f24bdf6c255068d3de386b00c1d0db3041a98f Author: Guy Harris <guy@alum.mit.edu> Date: Sat Aug 13 16:41:54 2016 -0700 Allocate all the wmem maps with epan scope. That doesn't seem to affect the performance negatively (or positively...) to any noticeable degree with my simple "run tshark under the time command with an empty file" tests, and it does appear to reduce the amount of memory that valgrind thinks is leaked. All the other maps were already allocated with epan scope, so do that with these as well. Change-Id: Ib5ee85c8cf025e53455564a67cd1adbf28b47f78 Ping-Bug: 12656 Reviewed-on: https://code.wireshark.org/review/17040 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=631139b1eb48fdb171c28141e15d2a1... commit 631139b1eb48fdb171c28141e15d2a18854bef15 Author: Uli Heilmeier <uh@heilmeier.eu> Date: Sat Aug 13 21:53:53 2016 +0200 LLDP: Add Avaya IP Phone OUI Subtypes Used https://downloads.avaya.com/elmodocs2/one-X_Deskphone_Edition/R1.5/output/16... as reference for the subtypes. Bug: 12740 Change-Id: Ia9084bca3ab07e484c1d074a2cdf6072b8a3dfa0 Reviewed-on: https://code.wireshark.org/review/17039 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=c7e45607fc70eae886f5cee4b580811... commit c7e45607fc70eae886f5cee4b5808112193fe339 Author: Martin Kaiser <wireshark@kaiser.cx> Date: Wed Aug 10 22:54:58 2016 +0200 asciidoc.conf, sort-and-group: remove "and" if we have only one element --sort-and-group-- One --sort-and-group-- used to be converted into and One Remove the leading and in this case. Change-Id: I3332b316c4fcce164c94e36c3c7b4480947bdf68 Reviewed-on: https://code.wireshark.org/review/17003 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=854793d48ed1d1645e44c42a9c1cdfe... commit 854793d48ed1d1645e44c42a9c1cdfea38f90bf5 Author: Dario Lombardo <lomato@gmail.com> Date: Fri Aug 12 12:29:28 2016 +0200 jxta: remove dead code (CID 1159018). Check already present in line 1226. Change-Id: I2b3cd15a1d35b334a690afd3ce1a9b8b1f32e188 Reviewed-on: https://code.wireshark.org/review/17029 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=620f5721b176ab4cd0cd87ec618925c... commit 620f5721b176ab4cd0cd87ec618925c91664f2ee Author: Peter Wu <peter@lekensteyn.nl> Date: Thu Aug 11 23:30:06 2016 +0200 netlink: fully dissect NLA Type, add length restriction NLA types consist of a type and two flags, add new fields for this. Add a new parameter to restrict the data consumed by the dissect_netlink_attributes function, this is needed when implementing nested attributes using another call to this function. This also avoids adding padding to the payload and matches the comment in include/uapi/linux/netlink.h (Linux 4.7). Change-Id: I34dbfa466081b6c6c4580941aff568bd120b4210 Reviewed-on: https://code.wireshark.org/review/17030 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=5ae7076b3ead0d3c7ae3ad4d9d05d9a... commit 5ae7076b3ead0d3c7ae3ad4d9d05d9a89930d848 Author: Uli Heilmeier <uh@heilmeier.eu> Date: Sat Aug 13 13:41:06 2016 +0200 OUI: Add 0x000142 Cisco to oui_vals The LLDP dissector is using oui_vals to resolve OUIs for hf_org_spc_oui. Therefore it currently shows "Unknown" for OUI 0x000142. Change-Id: Ie5f926a183dc42a957fb05c5a38d677a2064ff28 Reviewed-on: https://code.wireshark.org/review/17036 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=cf6aa84810e4f9edf95d82af683790b... commit cf6aa84810e4f9edf95d82af683790be150feeda Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Fri Aug 12 08:37:58 2016 +0200 IEEE 802.11: fix dissection of PLMN Information IE According to 3GPP 24.302 annex H, it uses little endian encoding Change-Id: Ia764e0bb16f8bb197214109e40b1f4c5079ec654 Reviewed-on: https://code.wireshark.org/review/17026 Reviewed-by: Adrian Granados <adrian@adriangranados.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=f0befede8bfd83d10fc3b9d0a02717d... commit f0befede8bfd83d10fc3b9d0a02717da92b8ec83 Author: Dario Lombardo <lomato@gmail.com> Date: Thu Aug 11 17:48:57 2016 +0200 bgp: remove dead code (CID 1228878). afi can take only one of the 2 above values, according to the check at the beginning of the function. Change-Id: I6652a5c64b4fbc8d2e907afb3b4f66d187ff9745 Reviewed-on: https://code.wireshark.org/review/17011 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=667a4fc1186d4a5a6b7199bd5568a98... commit 667a4fc1186d4a5a6b7199bd5568a98e5edbfd3d Author: Dario Lombardo <lomato@gmail.com> Date: Fri Aug 12 12:08:10 2016 +0200 ssh: remove unneded check (CID 1215243). Change-Id: I92d5dcf0fb50324d5adfcf0759be694b4037b8e3 Reviewed-on: https://code.wireshark.org/review/17028 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=d0fad45910c6cf2e5ad9154de29a9d3... commit d0fad45910c6cf2e5ad9154de29a9d30a057a8b7 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Thu Aug 11 17:57:25 2016 +0200 btle: Improved packet header display Show elements in correct order. Show TxAdd and RxAdd values as "Random" or "Public". Change-Id: Ie75716d05d2aadf3d573a9dc078f32e6f981a691 Reviewed-on: https://code.wireshark.org/review/17012 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=00f631fce4db82fe1185abb0de1d01d... commit 00f631fce4db82fe1185abb0de1d01def60e4f33 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Thu Aug 11 18:02:08 2016 +0200 btle: No expert info for correct CRC We don't usually use expert info when checksum is correct. Change-Id: Ifc0e020ea86d69330df8cdb625672fbc9b4269ae Reviewed-on: https://code.wireshark.org/review/17013 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=259a17498889b5471ff6d75aabe86cb... commit 259a17498889b5471ff6d75aabe86cbc54a72eee Author: AndersBroman <anders.broman@ericsson.com> Date: Thu Aug 11 16:00:54 2016 +0200 [S1AP] Fix copy-paste error. Change-Id: Id75d95c8d9cfdc5982bccefb9d4ece77cee871e3 Reviewed-on: https://code.wireshark.org/review/17010 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=8260ec1ca7060b0859a76398cd3b1b1... commit 8260ec1ca7060b0859a76398cd3b1b1ee5afb3da Author: Michael Tuexen <tuexen@wireshark.org> Date: Thu Aug 11 15:32:21 2016 +0200 Fix sa_len detection on FreeBSD. FreeBSD requires socket.h to be included when testing if struct sockaddr contains sa_len. Change-Id: Ibe18a88ce19a4e8487bb00d7fa822a380ec8c98d Reviewed-on: https://code.wireshark.org/review/17008 Reviewed-by: Michael Tüxen <tuexen@wireshark.org> http://cgit.osmocom.org/wireshark/commit/?id=1dfa478b9e239cf4632179c4f637873... commit 1dfa478b9e239cf4632179c4f637873f18666070 Author: AndersBroman <anders.broman@ericsson.com> Date: Thu Aug 11 15:30:46 2016 +0200 [Diameter] Add two LCS AVPs Change-Id: Ia649a3c88116745b77ae2ffeb243730d3dd13146 Reviewed-on: https://code.wireshark.org/review/17007 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b7515b352ac8fe74203581676ac9be4... commit b7515b352ac8fe74203581676ac9be4044c3dcc1 Author: Dario Lombardo <lomato@gmail.com> Date: Tue Aug 9 15:40:58 2016 +0200 androiddump: use socklen_t (32bit) instead of gssize (64bit) (CID 1293384). Change-Id: Ia5b7bc190eb8af509a880bb23bc0879a2dcfd39c Reviewed-on: https://code.wireshark.org/review/16972 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1d7688c6c548727a6e59c7b0fcf5cc0... commit 1d7688c6c548727a6e59c7b0fcf5cc08933e96d4 Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Aug 9 15:10:38 2016 +0200 [S1AP] Update S1AP to Release 13.3.0 Change-Id: I0992f429de7812ea82809e0b63f534b44e7b6aee Reviewed-on: https://code.wireshark.org/review/17006 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=77b1e4eba0462d1c6fbbefd59520929... commit 77b1e4eba0462d1c6fbbefd595209299140b696b Author: AndersBroman <anders.broman@ericsson.com> Date: Thu Aug 11 12:41:36 2016 +0200 [LCS-AP] Update to Release V13.2.0 (2016-03) Change-Id: I4f955d2d80b987d76fec48ee8722b2822e958b29 Reviewed-on: https://code.wireshark.org/review/17005 Tested-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=561a2f056bd76bfcb4f89a05542ffce... commit 561a2f056bd76bfcb4f89a05542ffce32eed5049 Author: Mirko Parthey <mirko.parthey@web.de> Date: Tue Jul 19 00:43:19 2016 +0200 Fix IKEv1 decryption and initialization vectors Generate initialization vectors during Wireshark's first pass, in order to improve reliability and efficiency. (bug #12699) Remove a dissection shortcut in first pass to allow early analysis of the transform payloads, which is needed to find out the crypto algorithms. Introduce a hash table to store an IV per message ID. (bug #12610) Fix handling of the initial phase 1 IV. (bug #12620) Cache IVs as per-packet data instead of a list. Use the wmem allocator to avoid memory leaks. Ensure libgcrypt resource cleanup on error paths. Rely only on IKE attributes to find the decryption algorithm, do not consider the length of the user-configured secret at this point. Split code into small functions. Ping-Bug: 12610 Ping-Bug: 12620 Ping-Bug: 12699 Change-Id: I7137943da42d54816808312cd1716a7e05478cbb Reviewed-on: https://code.wireshark.org/review/16846 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=d13f1b0d920c8e079cb7ded8d41e4a5... commit d13f1b0d920c8e079cb7ded8d41e4a530275148d Author: Devin Heitmueller <dheitmueller@kernellabs.com> Date: Mon Jul 25 23:41:55 2016 -0400 Add support for PMT parsing of ATSC A/52 Audio stream type and AC-3 descriptor The ATSC A/52 specification introduces a new PMT stream type, as well as a new descriptor if the A/52 stream contains AC-3 audio. Add dissection for both. Change-Id: I859c76cc4fc6550c72711f00582e6bfa12607fa2 Reviewed-on: https://code.wireshark.org/review/16679 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e2b2d986cc3b86ef98ebd92d2e8b5fa... commit e2b2d986cc3b86ef98ebd92d2e8b5fabb5666a35 Author: Jaap Keuter <jaap.keuter@xs4all.nl> Date: Wed Aug 3 23:59:48 2016 +0200 UFTP: Add dissector for Encrypted UDP based FTP with multicast See http://uftp-multicast.sourceforge.net/ for the original publication of these dissectors. Both v3 and v4 protocols are dissected. Bug: 12718 Change-Id: If691a573b9440c7cbe3b35711231b628cf3c8604 Reviewed-on: https://code.wireshark.org/review/16936 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba71ac07ccfdaa141c9cbbc31fcfb58... commit ba71ac07ccfdaa141c9cbbc31fcfb589198224bc Author: Piotr Pawłowski <ppiotru@gmail.com> Date: Wed Aug 10 20:31:05 2016 +0200 Enhance Bluetooth LE commands parsing This patch adds parsing to some missing LE commands Change-Id: Ia22197a7855505e96021536a333b401a45480145 Reviewed-on: https://code.wireshark.org/review/16995 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=91abbb3dd84f3a3e8d664a37bdc1f67... commit 91abbb3dd84f3a3e8d664a37bdc1f67643bc9508 Author: Dario Lombardo <lomato@gmail.com> Date: Wed Aug 10 09:53:46 2016 +0200 ethercat: fix check for SdoControl (CID 1256520). Change-Id: I6a24974b41f9abee32e3a170b607062bf80f3368 Reviewed-on: https://code.wireshark.org/review/16990 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=1396f6ad555178f6b81cc1a65f9cb37... commit 1396f6ad555178f6b81cc1a65f9cb37b2d99aebf Author: Peter Wu <peter@lekensteyn.nl> Date: Mon Aug 8 23:43:24 2016 +0200 qnet6: fix display of MAC addresses and avoid overflow The MAC address is binary data, do not use tvb_get_string_enc since it substituted some bytes by a Unicode replacement character. Use FT_ETHER instead of FT_STRING to fix the display. Bug: 11850 Change-Id: I3f02cfa13e8fccc18a199e4e293580c183eeddd1 Reviewed-on: https://code.wireshark.org/review/16965 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=a7685ddae78d5aa21d0131c9333400b... commit a7685ddae78d5aa21d0131c9333400bb487a8402 Author: Dario Lombardo <lomato@gmail.com> Date: Sat Aug 6 14:36:18 2016 +0200 docbook: add tip about recommended Qt version. Change-Id: I25d3e914c9210ca79313f6ea8b82bc7280d5c095 Reviewed-on: https://code.wireshark.org/review/16924 Reviewed-by: Dario Lombardo <lomato@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=89fc02b669049bdb3e675cd319beea4... commit 89fc02b669049bdb3e675cd319beea4cb1dc51e5 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 9 22:11:12 2016 -0700 Remove unneeded include. Change-Id: Ica3f97d276332f7c54b192157c26995481508818 Reviewed-on: https://code.wireshark.org/review/16988 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=03214b767d3365be3383eda4a25fbe2... commit 03214b767d3365be3383eda4a25fbe2ad3296de0 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 9 22:02:08 2016 -0700 Remove unneeded include. Change-Id: I9c55152ca43cd2c25916fe0ed4e41dee9d2377a8 Reviewed-on: https://code.wireshark.org/review/16987 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=02674faf8a7b8272c08cbeb2eb1cd32... commit 02674faf8a7b8272c08cbeb2eb1cd32da5a20949 Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 8 20:12:01 2016 +0200 QUIC: Fix dissection of ACK frame with Q034 The ACK Frame is different after Q034 Change-Id: Ib7a14ea20c37743c5af029b2bc38abc2377cc0e7 Ping-Bug:12590 Reviewed-on: https://code.wireshark.org/review/16960 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> http://cgit.osmocom.org/wireshark/commit/?id=896355d98ded671bfd5b9208841e540... commit 896355d98ded671bfd5b9208841e5401a831c83c Author: Dario Lombardo <lomato@gmail.com> Date: Tue Aug 9 15:54:58 2016 +0200 ansi_a: remove unneeded check (CID 1158564). Upper bits are masked, making check always true. Change-Id: I5860d549aedce9b2399145ebbed690178acf1446 Reviewed-on: https://code.wireshark.org/review/16973 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=3b557f6825cd6df329a69591fbb123f... commit 3b557f6825cd6df329a69591fbb123fc5b37d91f Author: Dario Lombardo <lomato@gmail.com> Date: Tue Aug 9 17:16:48 2016 +0200 wccp: fix bitwise operations (CID 1312144 & 1312145). Change-Id: I62cdb1eb7c62ab09bd43d0e0760bdedb4b1725c8 Reviewed-on: https://code.wireshark.org/review/16976 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9ac3aada49ea489bbb8de99bcfd3768... commit 9ac3aada49ea489bbb8de99bcfd3768be2c62025 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Tue Aug 9 21:59:30 2016 +0200 nordic_ble: Add a subtree for flags Change-Id: Ifb829280ca02a20a4466e7059a76a5bf3cbe4107 Reviewed-on: https://code.wireshark.org/review/16985 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b66a85e308dbd80fd9ae03b5898b375... commit b66a85e308dbd80fd9ae03b5898b37520666bfe3 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Tue Aug 9 21:55:15 2016 +0200 btle: Renamed Message fragments to L2CAP fragments The already used terminology is L2CAP fragments. Change-Id: I900f5fed479e53c3a23154caa3b8a569c58dbb20 Reviewed-on: https://code.wireshark.org/review/16984 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=c7942b4bcb96409065ea234d928bbc6... commit c7942b4bcb96409065ea234d928bbc697a4cbfd1 Author: Stig Bjørlykke <stig@bjorlykke.org> Date: Tue Aug 9 21:51:16 2016 +0200 btl2cap: Renamed Message fragments to SDU fragments The payload in L2CAP is called SDU (Service Data Unit). Change-Id: Ie18c6ef4a68f44a4099db518c50f6f9774470476 Reviewed-on: https://code.wireshark.org/review/16983 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=2227c26cb696eb264cd8ecddc48398c... commit 2227c26cb696eb264cd8ecddc48398c6c5afd57b Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Aug 9 21:35:38 2016 +0200 Windows: upgrade Lua library to 5.2.4 Change-Id: Ib0a4afc9b6143cf5ff78f72f0808f9f804549dd9 Reviewed-on: https://code.wireshark.org/review/16979 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e812c0e384ff7e8ae17c9ec681f3aba... commit e812c0e384ff7e8ae17c9ec681f3aba0416b3615 Author: Guy Harris <guy@alum.mit.edu> Date: Tue Aug 9 12:48:49 2016 -0700 Update to Lua 5.2.4. Change-Id: Icadf4001799a58c5bc686caff4ffa99289bf08a8 Reviewed-on: https://code.wireshark.org/review/16980 Reviewed-by: Guy Harris <guy@alum.mit.edu> http://cgit.osmocom.org/wireshark/commit/?id=80af5edbfec14978c65e9aabefd427b... commit 80af5edbfec14978c65e9aabefd427b41ca8ccd1 Author: Pascal Quantin <pascal.quantin@gmail.com> Date: Tue Aug 9 18:29:00 2016 +0200 Display Lua release version in about dialog It allows to have more info on the version used (for ex 5.2.4 instead of 5.2) Change-Id: I24a5b83f0a7a72fbb131e9ddc3e735ffea689ee6 Reviewed-on: https://code.wireshark.org/review/16977 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=e53ec249ad17a2a1f223e13a46fef08... commit e53ec249ad17a2a1f223e13a46fef086d766b1d0 Author: Daniel Willmann <dwillmann@sysmocom.de> Date: Tue Jul 12 20:25:34 2016 +0200 packet-rsl: Track RTP pt and codec for rsl Save the RTP payload type and codec and add a dynamic payload. This allows AMR streams to be correctly analyzed. Together with the AMR codec support you can listen to the AMR stream as well. Sponsored-by: On-Waves ehf Change-Id: If859fd3707b5aa1c9743830f903abe8e1f12ff95 Reviewed-on: https://code.wireshark.org/review/16352 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=38949edbd1f19068a5296fbc2e10e3c... commit 38949edbd1f19068a5296fbc2e10e3ccf63a3de6 Author: AndersBroman <anders.broman@ericsson.com> Date: Tue Aug 9 16:02:54 2016 +0200 [BTL2CAP] Reassemble LE messages. Change-Id: Ie11f43741086d015e52d977d4ffc31a3cd5a731a Reviewed-on: https://code.wireshark.org/review/16974 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=b669ca75c435d741920110a5d5e7822... commit b669ca75c435d741920110a5d5e7822f55f899b0 Author: Dario Lombardo <lomato@gmail.com> Date: Sun Aug 7 19:09:17 2016 +0200 androiddump: fix bug in socket retry (CID 1293391). Change-Id: I61914d208e984d202506cdc885493e841e929990 Reviewed-on: https://code.wireshark.org/review/16948 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> http://cgit.osmocom.org/wireshark/commit/?id=7596268b9b34e24404e358f73190829... commit 7596268b9b34e24404e358f73190829e366add3b Author: Alexis La Goutte <alexis.lagoutte@gmail.com> Date: Mon Aug 8 23:11:04 2016 +0200 QUIC: Fix typo on diversification nonce display field name Change-Id: I11455fba1ebc981e3f3865469a6cb537b3cdc11f Reviewed-on: https://code.wireshark.org/review/16964 Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=9f72f9e9a30b3e2fffb744a8e4a5e4b... commit 9f72f9e9a30b3e2fffb744a8e4a5e4b1b8054a67 Author: Günther Deschner <gd@samba.org> Date: Sat Aug 6 10:14:24 2016 -0400 add clusapi (Windows Cluster Management API) from Samba git tree. We avoid compiling clusapi_PROPERTY_LIST using pidl. This struct contains inline arrays and is not strictly needed by clusapi therefor disable it. Change-Id: I86efa0c725667083cb252e5df3bfc69118df3059 Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16719 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> http://cgit.osmocom.org/wireshark/commit/?id=ba70b88419c0282dd61b23842398744... commit ba70b88419c0282dd61b2384239874440f2594bc Author: João Valverde <joao.valverde@tecnico.ulisboa.pt> Date: Mon Aug 8 22:37:55 2016 +0100 checklicenses: Remove whitelisted licenses not being used Removed a few licenses we shouldn't use (Apache v2, BSD 4-clause) and removed many others not currently being used. (Add on a need-to basis). Added GPLv3+ with Bison exception to licensecheck.pl. Also removed some crud to work around bugs for older licensecheck.pl versions. The original list came from the chromium project, which has a BSD-like license, and many more licenses in use, not all of them vetted for GPLv2+ compatibility. Change-Id: I67f334f21cd94904cf8a0e5d9beb659c82437df4 Reviewed-on: https://code.wireshark.org/review/16966 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt> http://cgit.osmocom.org/wireshark/commit/?id=8a141febc849c36dc40d4da2a39318f... commit 8a141febc849c36dc40d4da2a39318f8f8856091 Author: Guy Harris <guy@alum.mit.edu> Date: Mon Aug 8 19:13:11 2016 -0700 Use -r rather than -i for the "via stdin" tests. TShark, at least when running in one-pass mode, now supports reading from the standard input if the file format is one that *can* be read purely sequentially; both pcap and pcapng can be read purely sequentially (unlike, for example, Microsoft Network Monitor format, where you have to read the frame table, at the end of the file, before you can read the frames, meaning you have to seek backwards, which you can't do on a pipe). Using -r 1) tests the "read from standard input" path, which we should do in versions that support it, and 2) means we can check whether, for the crashes we're seeing on 32-bit Windows 8.1, it's a problem with reading from the standard input in general, or just a problem with *capturing* from the standard input. Change-Id: I67da34de43f47dd8c63fa2f2072be41148cfe5a7 Reviewed-on: https://code.wireshark.org/review/16968 Reviewed-by: Guy Harris <guy@alum.mit.edu> ----------------------------------------------------------------------- hooks/post-receive -- wireshark with Osmocom specific dissectors
participants (1)
-
gitosis＠osmocom.org