This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, master has been updated via b3a17d6074b2575a599863766b9826a7bd3369b9 (commit) from a4f570fe7a9e511d04ba3aade4a144b4cb74deb8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=b3a17d6074b2575a599863766b9826a… commit b3a17d6074b2575a599863766b9826a7bd3369b9 Author: Max <msuraev(a)sysmocom.de> Date: Thu Dec 21 12:11:33 2017 +0100 cosmetic: clarify coding scheme and puncturing * use appropriate types for coding scheme parameters * add comment regarding possible number of RLCMAC blocks The code in create_dl_acked_block() has underlying assumption that rlc.num_data_blocks can never be more than 2, which is true and is enforced by appropriate asserts but is not obvious when looking at the function code alone. It's equally hard for Coverity which leads to false positives in scan. Lets' make this assumption explicit by putting it into for(;;) condition alongside with corresponding comment. Fixes: CID143070 Change-Id: If599a6c8a6ef56d847604fcf41bb71decccd8a78 ----------------------------------------------------------------------- Summary of changes: src/gprs_coding_scheme.cpp | 44 ++++++++++++++++++++++---------------------- src/gprs_coding_scheme.h | 32 ++++++++++++++++---------------- src/rlc.cpp | 2 +- src/rlc.h | 4 ++-- src/tbf_dl.cpp | 8 ++++---- 5 files changed, 45 insertions(+), 45 deletions(-) hooks/post-receive -- UNNAMED PROJECT