This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via e95ad79d6c236489069f769c6b9c3cfc1aca595a (commit) via 8c1d15764377eb6a11aa432661d5afe60c2e8a9c (commit) via 1f80e9815f3bb98ddfabe5aaa9e69c0a47b84269 (commit) via 9a57c7bed4c096ccff4f9fc78b7ef789eeb18360 (commit) from 63948b033d41982b5e986a9c8a15fcfcd364eb25 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=e95ad79d6c236489069f769c6b9c3cf… commit e95ad79d6c236489069f769c6b9c3cfc1aca595a Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Wed Jan 17 13:45:40 2018 +0100 bts-trx: Detect duplicated responses for retransmitted commands It was detected that under some conditions, osmo-trx (with limesdr) may take a long time to answer to CMDs, which means trx_ctrl_timer will trigger re-transmitting the last sent but yet unacked CMD. Due to the high latency in osmo-trx, the original AND the rentrasnmited CMD are handled after a while and RSP messages are sent for both. When osmo-bts-trx receives the first RSP, it was marking the CMD as acked and carried on with next one. Then, when the RSP from the retransmited CMD arrives, it already lost state and doesn't know where does that come from. As a result, osmo-bts-trx shutdowns. The issue can be seen in the following truncated log from osmo-bts-trx with TRX category enabled: 20180117135228175 Enqueuing TRX control command 'CMD RXTUNE 1782000' 20180117135228175 Enqueuing TRX control command 'CMD TXTUNE 1877000' 20180117135228175 Enqueuing TRX control command 'CMD SETTSC 7' 20180117135228175 Enqueuing TRX control command 'CMD POWERON' 20180117135228175 Enqueuing TRX control command 'CMD SETRXGAIN 1' 20180117135228175 Enqueuing TRX control command 'CMD SETPOWER 20' 20180117135228175 Enqueuing TRX control command 'CMD SETSLOT 0 5' ... 20180117135249829 Response message: 'RSP POWEROFF 0' 20180117135249855 Response message: 'RSP RXTUNE 0 1782000' 20180117135249876 Response message: 'RSP TXTUNE 0 1877000' 20180117135249876 Response message: 'RSP SETTSC 0 7' 20180117135250648 Response message: 'RSP POWERON 0' 20180117135251150 Response message: 'RSP SETRXGAIN 0 0' 20180117135253151 No response from transceiver for phy0.0 (CMD SETPOWER 20) 20180117135253777 Response message: 'RSP SETPOWER 0 20' 20180117135254535 Clock indication: fn=2018878 20180117135255777 No response from transceiver for phy0.0 (CMD SETSLOT 0 5) ... 20180117135256858 Response message: 'RSP SETPOWER 0 20' 20180117135256858 Discarding duplicated RSP from old CMD 'RSP SETPOWER 0 20' 20180117135256858 Response message: 'RSP SETSLOT 0 0 5' 20180117135256858 Response message: 'RSP SETSLOT 0 0 5' 20180117135256858 Discarding duplicated RSP from old CMD 'RSP SETSLOT 0 0 5' Change-Id: I3633cba212edde878f83ed36aef922aaca6f503a http://cgit.osmocom.org/osmo-bts/commit/?id=8c1d15764377eb6a11aa432661d5afe… commit 8c1d15764377eb6a11aa432661d5afe60c2e8a9c Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Tue Jan 16 18:42:03 2018 +0100 bts-trx: trx_if.c: Improve parsing of received RSP messages from TRX First the cached CMD sent (struct trx_ctrl_msg) is reworked to have the cmdname and the params in different buffers for easier comparison with RSP later. For the receive path (trx_ctrl_read_cb), new function helpers are added to parse the buffer into cmdname+params+code (parse_rsp) and to compare if a given RSP matches the current CMD we sent (cmd_matches_rsp). The reasoning behind this patch is that a way to check for parameters when receiving a RSP will be needed in future work, as before this patch checking of parameters is ignored. This commit is a preparation for commit to check for duplicated responses. Change-Id: I2474cbc3e4457cf04f78e1c168768295e1132034 http://cgit.osmocom.org/osmo-bts/commit/?id=1f80e9815f3bb98ddfabe5aaa9e69c0… commit 1f80e9815f3bb98ddfabe5aaa9e69c0a47b84269 Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Tue Jan 16 18:45:46 2018 +0100 bts-trx: trx_if.c: trx_ctrl_read_cb: Move error handling to end of func The move includes a small logic change: If there's a mismatch between the rsp and the cmd, now we bts_shutdown instead of blindly skipping expected RSP and continuing with sending the next CMD in the queue. The change is specially not a problem since next patches are improving the logic furthermore to account for duplicates, different parameters, etc. Change-Id: I7018ded23fe51f364f248ade111aaa80ef46187e http://cgit.osmocom.org/osmo-bts/commit/?id=9a57c7bed4c096ccff4f9fc78b7ef78… commit 9a57c7bed4c096ccff4f9fc78b7ef789eeb18360 Author: Pau Espin Pedrol <pespin(a)sysmocom.de> Date: Tue Jan 16 19:16:53 2018 +0100 bts-trx: trx_if.c: Log timedout+retransmitted CMD Change-Id: Ib573c86a1640640c2a61e80fe1f1412b30342b1a ----------------------------------------------------------------------- Summary of changes: src/osmo-bts-trx/l1_if.h | 3 + src/osmo-bts-trx/trx_if.c | 222 +++++++++++++++++++++++++++++++--------------- src/osmo-bts-trx/trx_if.h | 4 +- 3 files changed, 156 insertions(+), 73 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)