This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, resf/for/master has been created at 3617fd1cb6eb3e22a1f1482e05a8d1d8cb9016f1 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-bts/commit/?id=3617fd1cb6eb3e22a1f1482e05a8d1d… commit 3617fd1cb6eb3e22a1f1482e05a8d1d8cb9016f1 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sat Jul 15 22:32:52 2017 +0200 Ensure we don't send dummy UI frames on BCCH for TC=5 When no SI 2bis, nor 2ter, nor 2quater is in use, then the code in bts_sysinfo_get() will return null, causing the transmission of a dummy frame (0303012B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B2B) instead of a system information message. This is - at least - very odd and might not be backed by the specification. We should simply send any other system information message instead of sending a frame that does not have a valid SI header. While 030301 might be a valid, empty UI frame on a DCCH, it is not a valid frame for the BCCH, where the header is structured differently. In fact, bts_sysinfo_get() should never return NULL and always return a valid BCCH message. This bug was found while developing http://git.osmocom.org/osmo-ttcn3-hacks/tree/sysinfo/Test.ttcn Change-Id: Ifeaed27d1d7ba9994fb8ce67d660648bcc8efece Closes: OS#2365 ----------------------------------------------------------------------- hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)