This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Osmocom BTS-side code (Abis, scheduling, ...)".
The branch, master has been updated
via 7a18906cfafc4d73b1c9eb9e527139af6ad938dd (commit)
from d15dc832c9da401d35300bf4c6d59235ee770bc5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-bts/commit/?id=7a18906cfafc4d73b1c9eb9e527139a…
commit 7a18906cfafc4d73b1c9eb9e527139af6ad938dd
Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Date: Tue Feb 7 14:37:21 2017 +0100
all models: fix vty write: bts_model_config_write_phy
The vty write for phy/inst is broken, leading to a written-out config being
unparsable; fix all of these:
- in common/vty.c, actually call bts_model_config_write_phy_inst().
- in sysmo and lc15 write the phy instance elements in
bts_model_config_write_phy_inst() and not in bts_model_config_write_phy(),
which lead to writing the members above their parent 'instance'.
- sysmo, lc15 and oct omit the bts_model_config_write_phy_inst()
implementation. This did not cause a compilation problem because it
was in fact never called.
- sysmo writes 'clock-source None' when clk_src is zero, leading to
unparsable
config (related: OS#1944). Instead omit the 'clock-source' when zero.
- osmo-bts-trx seems to be the only part that lacks nothing, yet it
also didn't work properly because bts_model_config_write_phy_inst()
was never called.
This problem existed since commit d784e50747b8cf0ce505489e1451f75be5ccbd4b
"Introduce new phy_link and phy_instance abstraction"
Change-Id: Icc54fa70045c8fa58e78cf9f788c21a437edfbd4
-----------------------------------------------------------------------
Summary of changes:
src/common/vty.c | 1 +
src/osmo-bts-litecell15/lc15bts_vty.c | 14 +++++---------
src/osmo-bts-octphy/octphy_vty.c | 4 ++++
src/osmo-bts-sysmo/sysmobts_vty.c | 21 +++++++++------------
4 files changed, 19 insertions(+), 21 deletions(-)
hooks/post-receive
--
Osmocom BTS-side code (Abis, scheduling, ...)