This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, sysmocom/revert_WAIT_ASSIGN has been updated discards 73f117861453745a83b229bd8f710ce51474a014 (commit) via 24d6976432c7baef013d9483472568420ea69c22 (commit) via 6348aea6a2cdc753021e5324a0dd2aecf8791f10 (commit) via da66f71ffeee47575d0fc0c3c2c6fb304d50e3cc (commit) via da933e0ff8a63943a1f738c7172a9c7ede972849 (commit) via fd9e16ce97603d2dbc692ebc6e6f27b966ceca25 (commit) via 465f5bbb6f9352ce02ba7d8cfbbc5d2b0cab4c9a (commit) via 628dcfbc971d6d0542064d7ff83ba17fffb93632 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (73f117861453745a83b229bd8f710ce51474a014) \ N -- N -- N (24d6976432c7baef013d9483472568420ea69c22) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=24d6976432c7baef013d948347256842... commit 24d6976432c7baef013d9483472568420ea69c22 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Wed Jun 8 15:27:40 2016 +0200 Revert "tbf: Add state WAIT_ASSIGN" This reverts commit f1a7b8fc6651f92a8b7f3f27b7ca05d07f4e44e0. Conflicts: tests/tbf/TbfTest.err The commit broke GPRS service at least for osmo-bts-sysmo on a SysmoBTS 1002 with current master of osmo-bts (ef30f50d5d6d5f863fc147d05ccdceb89284934e). The error observed is the following log output (was viewing both osmo-bts-sysmo and osmo-pcu logs interleaved): <0002> tbf.cpp:874 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=WAIT ASSIGN) T3169 timeout during transsmission <0002> tbf.cpp:893 - Assignment was on CCCH <0002> tbf.cpp:899 - No uplink data received yet <0007> l1sap.c:904 RACH for packet access <0001> pcu_l1_if.cpp:311 RACH request received: sapi=1 qta=0, ra=121, fn=13653 [repeat] When removing this single commit from current osmo-pcu master, GPRS service works well on SysmoBTS, with current osmo-bts master. The TbfTest.err expected output needed adjustment after the revert. Disclaimer: I am not aware of adverse effects this commit may have. I have no idea what the WAIT_ASSIGN state is used for -- further review is required. Change-Id: I1532f8e93194368cdc1e3846f82afa6d68cd5fbd ----------------------------------------------------------------------- Summary of changes: configure.ac | 13 ++++++++ src/bts.cpp | 95 +++++++++++++++++++++++++++++++++++++++++++++++++------- src/bts.h | 2 ++ src/encoding.cpp | 85 ++++++++++++++++++++++++++++++++++++++++++++------ src/encoding.h | 10 ++++-- src/pcu_main.cpp | 3 +- 6 files changed, 184 insertions(+), 24 deletions(-) hooks/post-receive -- UNNAMED PROJECT