7 Jan
2017
7 Jan
'17
10:04 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "wireshark with Osmocom specific dissectors".
The branch, laforge/qcdiag has been created
at ad287ca926540bb5a9c7a6e9e695290f36fd0553 (commit)
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/wireshark/commit/?id=ad287ca926540bb5a9c7a6e9e69529…
commit ad287ca926540bb5a9c7a6e9e695290f36fd0553
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jan 7 18:08:21 2017 +0100
WIP: Qualcomm DIAG Protocol support
Change-Id: I0bd06c46e00570005a1148860954a77c8f5445a8
http://cgit.osmocom.org/wireshark/commit/?id=91857f3ac4814804cf350a2c9f18c4…
commit 91857f3ac4814804cf350a2c9f18c4a806a304e9
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 2 16:44:20 2016 +0100
WIP: RSL Ericsson support
Change-Id: I1e9b3c08848f4feb60361e629d7225b6d2e1dcbd
http://cgit.osmocom.org/wireshark/commit/?id=b11ee92a30c92f00663225d8e3e586…
commit b11ee92a30c92f00663225d8e3e5867fe7ffeeeb
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Oct 26 22:38:20 2016 +0200
HACK: Hand GPRS RLC payload to GPRS LLC dissector
this is an ugly hack, as there is no code for packet re-assembly
in betwween, i.e. we only get proper dissection if the LLC message
was fitting entirely into one RLC block. Nevertheless, sufficient to
see things like RAU, ATTACH, IDENTITY procedures.
Change-Id: I1fc488aa58353e5f4264b940f9f4c18987148a7d
http://cgit.osmocom.org/wireshark/commit/?id=270c4e66fee78aa1a79f6b3ff4dc44…
commit 270c4e66fee78aa1a79f6b3ff4dc445a2521e6dd
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Wed Oct 26 20:09:31 2016 +0200
WIP: Jacob's EGPRS patch
... with add_new_data_source() to visualize the re-aligned bits
Change-Id: I1604dceaf3d91228e87712e099c8a209ff812f4a
http://cgit.osmocom.org/wireshark/commit/?id=2ca1a84b3cab61b2c205de412214f2…
commit 2ca1a84b3cab61b2c205de412214f2181664f899
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sun Jul 17 16:22:19 2016 +0200
l2tp: Introduce preference for default pseudowire
In some cases, the establishment of the L2TP session is not captured in
the pcap file, and thus wireshark cannot determine the l2tp pseudowire
to be used for decode.
So rather than using a ocmpile-time hard-coded default of cisco hdlc,
let's introduce a prference where the user can select the default
pseudowire in such cases.
Change-Id: I44a6373d4812c9ab5a919514273a41a2ab57142c
http://cgit.osmocom.org/wireshark/commit/?id=8dde9224b808caf813c8749b82f891…
commit 8dde9224b808caf813c8749b82f8919c9a12b779
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Sat Jul 16 15:39:17 2016 +0200
L2TP: Add preference to select Ericsson HDLC flavor
At some point over the wireshark last years, the connection between the
L2TP dissector and the Ericsson HDLC dissector (packet-ehdlc.c) got
broken. I cannot poinpoint the exact change when it broke. However,
traces with Ericsson L2TP that used to display correctly no longer do
so.
The problem with Ericsson L2TP is that they simply re-use the HDLC
pseudowire (0x0006), but then have frames completely different than
what's specified in the RFCs for that.
To address this, let's add a protocol preference to allow the user to
choose.
Change-Id: Idce022ef0f233c01ecffc67dca7f428bde31ef6b
http://cgit.osmocom.org/wireshark/commit/?id=fb9ac503c16e88408a53e808f17f19…
commit fb9ac503c16e88408a53e808f17f19f63787f2de
Author: MustBeArt <paul(a)mustbeart.com>
Date: Sun Jan 1 08:47:40 2017 -0800
DVB-S2 BB: Fix BB header CRC checks
Fix problem with baseband header CRC check that caused almost all
baseband frames to show a spurious CRC error, introduced with
proto_tree_add_checksum.
Change-Id: I6b2f9680507eeb79e59b825f3ac9e4cee1033976
Reviewed-on: https://code.wireshark.org/review/19567
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=0dcbfab4265b4f494a7b162d2c34c9…
commit 0dcbfab4265b4f494a7b162d2c34c99ed7994541
Author: Noel Power <noel.power(a)suse.com>
Date: Fri Jan 6 16:23:18 2017 +0000
Make column size sanity check more sensible.
The existing sanity check on column_size makes incorrect assumptions
about the size of the CTableColumn structure (which is an internal
dissector structure that contains optional data). The sanity check
test *always* fails. This change uses the minimum size of CTableColumn
structure instead which should prevent excessive allocation during fuzz
testing.
Bug: 13299
Change-Id: Id9fcbc15a4df4c74bb7576c6fdca1000890947fd
Signed-off-by: Noel Power <noel.power(a)suse.com>
Reviewed-on: https://code.wireshark.org/review/19566
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ae5dbe1b63b5660e46d0fbd5c1bb0b…
commit ae5dbe1b63b5660e46d0fbd5c1bb0b6e8fa8f45f
Author: Jeff Morriss <jeff.morriss.ws(a)gmail.com>
Date: Fri Jan 6 10:10:27 2017 -0500
Add support for RROCE(v2) over IPv4 (without UDP).
This isn't standard but has been seen in the wild, see:
https://ask.wireshark.org/questions/58521/cannot-decode-rocev2-traffic
With this change users can Decode-As an IP Protocol as RROCE (by selecting
Infiniband (IB) as the protocol).
Change-Id: Iec865478d056f687f2f66124d6e936f67707d2c4
Reviewed-on: https://code.wireshark.org/review/19572
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ea7440481e2d6c28f54c83bc190a1a…
commit ea7440481e2d6c28f54c83bc190a1aef206ab937
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Fri Jan 6 11:14:15 2017 -0500
packet-nvme: Dissect read/write cmd and SGL
1. Added support to dissect read and write commands.
2. Added support to dissect SGL fields addr, len, key.
3. Changed long reserved fields to decimal presentation.
4. Fixed typo for cqe reserved field.
Change-Id: I63c674c68143c9c61610bada0410b49a134361d4
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/19565
Petri-Dish: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4dc983d648b49c7364fec069d36c09…
commit 4dc983d648b49c7364fec069d36c09f802ec763c
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Jan 7 00:39:17 2017 +0100
packet: fix memleak of "short_name" for heuristics dissectors
Change-Id: I3b954e3623473899b6039f0ff572eb56defe14cc
Fixes: v2.3.0rc0-1841-ga8b68205a4 ("packet: duplicate short_name to fix UAF in
wslua")
Reviewed-on: https://code.wireshark.org/review/19571
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6a6d7ea34f43515dfe3f52aa96b943…
commit 6a6d7ea34f43515dfe3f52aa96b943c272c925a7
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Dec 22 15:12:27 2016 -0500
Convert range API to always use wmem memory.
This is mostly to address memory leaks in range preferences (the biggest
user of range functionality) on shutdown.
Now range preferences must use epan scoped memory when referencing
internal preference structures to keep consistency.
Change-Id: Idc644f59b5b42fa1d46891542b53ff13ea754157
Reviewed-on: https://code.wireshark.org/review/19387
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=29a7fce2720288c86e474f68880a0e…
commit 29a7fce2720288c86e474f68880a0e61e517027b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jan 5 22:26:59 2017 +0100
802.11(ad): Enhance dissection of Beacon Interval Control (BIC)
You can now use bitmap on 64bits (or 48bits)
and also add a reserved field
Ping-Bug: 13244
Change-Id: I2ec9412f6cfebd3a8ca5c082af5e8481e2646eaf
Reviewed-on: https://code.wireshark.org/review/19561
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=79fc411936fee077a3c9dc90b6c23c…
commit 79fc411936fee077a3c9dc90b6c23c960a662069
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Jan 1 00:22:01 2017 -0500
Convert some easily identifiable pinos.
grepping for "Decode As" comments reveals exactly was pinos were
created for - distinguishing multiple dissection functions in a
single dissection table.
Change-Id: Iaa9294045e9d0633563e7d763cb585c0e6dc598f
Reviewed-on: https://code.wireshark.org/review/19490
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f0b1099f819ecae61cf0ad3304ec5c…
commit f0b1099f819ecae61cf0ad3304ec5cf5e25bdfec
Author: John A. Thacker <johnthacker(a)gmail.com>
Date: Wed Jan 4 16:10:49 2017 -0500
VLAN: Support IEEE 802.1Q-2005 and -2011 changes
Supports the recommended meanings of the priority field as
changed by 802.1Q-2005, and the change from the CFI to DEI
in 802.1Q-2011. A preference is added to use the older
(non-compatible) spec version. Note that 802.1Q-2011 is
consistent with 802.1ad and ah, which got rolled up in 802.1Q,
but ends up removing support for bridging Token Ring and FDDI
over Ethernet.
Bug: 13294
Change-Id: Ieeadb0f6dda2758750f9e6649f1390609d78c50e
Reviewed-on: https://code.wireshark.org/review/19548
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cea1063af1aaa66f430d3441025269…
commit cea1063af1aaa66f430d34410252693b19c364d3
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jan 5 21:28:58 2017 +0100
802.11(ad): add reserved fields for Beam Forming
Change-Id: I486c883b27059eb55e9fe11fcc372fc31c1e56ca
Ping-Bug: 13244
Reviewed-on: https://code.wireshark.org/review/19560
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3871df544a7ad16a6e418153e893f0…
commit 3871df544a7ad16a6e418153e893f0caeb91f142
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jan 5 19:54:06 2017 +0100
802.11(ad): align length of Beam Forming
use UINT16
Change-Id: I7f7c4e847ed6ccb6ced446d493aa27f76cc8db61
Reviewed-on: https://code.wireshark.org/review/19559
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b4176fdaa55d7ffb5cfd7c6b289279…
commit b4176fdaa55d7ffb5cfd7c6b28927949ea985161
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Jan 5 19:40:34 2017 +0100
802.11(ad): fix typo
Wrong field name for Dynamic Allocation
Issue reported by Hany ASSASA
Bug: 13244
Change-Id: Idec2cb48c5b3d22d75880325d2aec0083d89ca95
Reviewed-on: https://code.wireshark.org/review/19558
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a8d4051e694b1773fd5338363dfee6…
commit a8d4051e694b1773fd5338363dfee617c776e7d7
Author: Jeff Morriss <jeff.morriss.ws(a)gmail.com>
Date: Thu Jan 5 09:04:59 2017 -0500
Update the preference help text to indicate the correct default RROCE port.
I97b82fb53fd63d9107ee5d4c64b94840e743fc72 changed the default but not the
help text.
Change-Id: I05375c44c01703e36686d0a16a094cb8d6b3dcd2
Reviewed-on: https://code.wireshark.org/review/19557
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ee5ade8fc5032b4343e4b37f874668…
commit ee5ade8fc5032b4343e4b37f874668fbdc7432ac
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Jan 5 12:26:36 2017 +0100
NAS EPS: NAS message container in Control Plane Service Request can be ciphered
Change-Id: I026fc63e09c54807604c5d5a112c36dd41759c00
Reviewed-on: https://code.wireshark.org/review/19556
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3979bbe340ef3d3645ff075089e2d6…
commit 3979bbe340ef3d3645ff075089e2d628e1dc62fa
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Jan 4 17:20:19 2017 +0100
Add g_log entries to measure startup time, protected by #ifdef
Change-Id: Ic32f89dc824a6da838643445a30335a8c73af1ee
Reviewed-on: https://code.wireshark.org/review/19540
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0782a7a15b4114bbcaa766fcd11ea8…
commit 0782a7a15b4114bbcaa766fcd11ea827bb9107bc
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Wed Jan 4 08:28:51 2017 -0800
More make-version.pl fixups.
Don't add extra \n's. Change ".*([\r\n]+)$" matches to
".*?([\r\n]+)$"
so that we don't greedily match the wrong line ending.
Change-Id: I916ee49207eaac17e1e4c4f677558f7be13a099a
Reviewed-on: https://code.wireshark.org/review/19541
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=29aa8893ea8fe2efbdb5b9015c840d…
commit 29aa8893ea8fe2efbdb5b9015c840d0982dbaba6
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 20:03:35 2017 -0800
Do RA_DISSECTORS in the Qt UI.
It looks as if a fair bit of work is done under RA_DISSECTORS before we
register any individual items, so add it to the splash screen update
with the Qt UI - it's used in the GTK+ UI.
Update a comment to explicitly indicate what action transactions are
being counted (other than the individual-item ones, where we have to
call routines that give us a count of items).
Change-Id: I3ec5e5fbfdcf523d693bcf1b0f0ffbe0d05d61ae
Reviewed-on: https://code.wireshark.org/review/19553
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=31c903724e250500e4a2c3dbff4254…
commit 31c903724e250500e4a2c3dbff42548495567703
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 18:51:36 2017 -0800
Fix comment.
Change-Id: I5c18130dc22220ddd85109235383fcf61e543d89
Reviewed-on: https://code.wireshark.org/review/19552
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=229f573846af147a73662e0ec68fec…
commit 229f573846af147a73662e0ec68fec322c2f3b13
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 18:45:21 2017 -0800
Remove RA_CONFIGURATION.
It's not used at all in the Qt UI, and the point at which it's used in
the GTK+ UI doesn't involve reading configuration files - between it and
RA_INTERFACES, some mostly quick command-line argument processing is
done.
Change-Id: Ib4de97c8b6dba658a6e9d8f596b551f7c45739d2
Reviewed-on: https://code.wireshark.org/review/19551
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3f176f94e7b3939dbcc4f319542734…
commit 3f176f94e7b3939dbcc4f3195427345a077cbfb1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Jan 4 21:06:06 2017 +0100
QUIC: fix typo on ACK num revived field description
Found in
https://ask.wireshark.org/questions/58396/some-question-about-quic-decode-r…
Change-Id: Ic7fc2c2318186eabb5047f816987d2553a6fd449
Reviewed-on: https://code.wireshark.org/review/19547
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c1f7cbfcefb3efda898f28530b027b…
commit c1f7cbfcefb3efda898f28530b027b639b98e58e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 14:14:21 2017 -0800
Clean up indentation.
Change-Id: Ie5a2cc5650840a40fe3a84c04598e1f35dc47f4a
Reviewed-on: https://code.wireshark.org/review/19550
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=26430ff647eff817aebdf7425f866f…
commit 26430ff647eff817aebdf7425f866f6d7f0f9860
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 14:10:16 2017 -0800
Include extcap binaries in the count of things to point out during startup.
The GTK+ version, at least, crashes if there are more "doing XXX..."
items put up than the calculated count, so, now that we're putting up
items for extcap binaries, we need to count the extcap binaries.
Clean up some stuff we found doing this (indentation, a _U_ on something
that's used).
Change-Id: I1f88042b64ce4b9ae352de37689677c694e3770b
Reviewed-on: https://code.wireshark.org/review/19549
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f7124f64a8bafe70cb52cfeb225265…
commit f7124f64a8bafe70cb52cfeb225265d229befa66
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Dec 19 11:04:09 2016 -0800
Escape opening curly braces in gen-bugnote.
Curly braces are used for attribute replacement in AsciiDoc.
Change-Id: I1461ee26543dd20a9f799084a01710faef78f2d0
Reviewed-on: https://code.wireshark.org/review/19517
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=9e7e30e6743e9336f310c281b3a54c…
commit 9e7e30e6743e9336f310c281b3a54c923e73a54f
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Wed Jan 4 10:53:29 2017 +0100
Add a startup message for Initializing extcap.
Change-Id: I06262e98bb4a55ee1eacd7a36b938b45eaffaf76
Reviewed-on: https://code.wireshark.org/review/19535
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=79d1ac994f495ab364f4d1285897a6…
commit 79d1ac994f495ab364f4d1285897a629dc002268
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 11:11:18 2017 +0000
Revert "Another change required for that."
This reverts commit 3cfa4f760276bf995aca2479166a2128451fd402.
Nope, *not* needed, and not wanted, either.
Change-Id: I71ac174a9b9b19980d0a6f44088d0a66f71ef99b
Reviewed-on: https://code.wireshark.org/review/19538
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3cfa4f760276bf995aca2479166a21…
commit 3cfa4f760276bf995aca2479166a2128451fd402
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 03:08:07 2017 -0800
Another change required for that.
Bug: 13270
Change-Id: I86e779c8f7b89ca928556d8b1acc1015b96f9100
Reviewed-on: https://code.wireshark.org/review/19537
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2cc215c7d0b07c2be3d5d5908664f5…
commit 2cc215c7d0b07c2be3d5d5908664f5e9b9bdc0de
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 03:05:14 2017 -0800
Running Wireshark through a symlink doesn't work.
We can't just symbolically link to the executables, as that means that
the executable won't be in Contents/MacOS, which means that all
@executable_path-relative references will go to the wrong place if we
run the executables using the symlink, which means that the executables
could fail (they *do* fail to find the Cocoa Qt plugin, for example).
So, instead, we go back to the old version of the utility launcher, and
put that in Contents/Resources/bin as well as, if the user requests the
CLI utilities, /usr/local/bin. Maybe PackageMaker will find that
acceptable and include them in the installer package.
Bug: 13270
Change-Id: I4016b58c9ce0df05d78525d35e53431750c2b4d9
Reviewed-on: https://code.wireshark.org/review/19536
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=0aba97a938832f7b9ffe6ec6531cc4…
commit 0aba97a938832f7b9ffe6ec6531cc41b2d96f998
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 01:29:41 2017 -0800
Oops, source and target are the other way around.
Bug: 13270
Change-Id: Ibeddb435acca298c90f2d6b9c0228e8a9a747b38
Reviewed-on: https://code.wireshark.org/review/19534
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=880580c252f722c993585670ce003d…
commit 880580c252f722c993585670ce003dd8a1f95757
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Jan 4 00:07:46 2017 -0800
Create the Content/Resources/bin directory if necessary.
Bug: 13270
Change-Id: Idc4223a24d6d2037d13a85331ce63e5a24168d3a
Reviewed-on: https://code.wireshark.org/review/19533
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3fae1366d1041c3591a919ce91aed2…
commit 3fae1366d1041c3591a919ce91aed27f983715a9
Author: Kevin Hogan <kwabena(a)google.com>
Date: Thu Dec 22 13:03:03 2016 -0800
Qt: add SACK graphs to tcptrace graph
Primarily, this adds visual indication of SACK blocks to tcptrace.
In addition:
- cleaned up focus behavior for graph selector and spinboxes
- added time-delay update to streamNumber spinBox
(similar to behavior of maWindow spinBox)
- changed ACK selection to select only SACKed responses
(rather than all ACKs - SACKs seemed more useful to look at)
Change-Id: I47d9e98d54f14e4955008ecea791b77f805c8ba9
Reviewed-on: https://code.wireshark.org/review/19388
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=15ad25ecb52ed02d293062be0fa6f0…
commit 15ad25ecb52ed02d293062be0fa6f08743f461ad
Author: Juanjo Martin <juanjo(a)rti.com>
Date: Thu Dec 29 15:24:28 2016 +0100
RTPS: Added dissection for Parametrized user data
Before we were showing an expert warning saying that it was not
supported. Now we show the parametrized data dissected in the form
sequence of (id, length, value)
Added also filters so it is possible to filter on the ids (useful
in RTPS)
Bug: 13278
Change-Id: I8569830305bc303febe6f3460221e7a52867a34d
Reviewed-on: https://code.wireshark.org/review/19458
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=66098013576b846120cd9d037b92e2…
commit 66098013576b846120cd9d037b92e281b054e2ee
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Jan 3 23:01:39 2017 +0100
RRC: upgrade dissector to v13.5.0
Change-Id: I95323ed8aabff7a20442c848fa0dc39854297584
Reviewed-on: https://code.wireshark.org/review/19527
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7b17883df5228ddb9e0cb26c155a60…
commit 7b17883df5228ddb9e0cb26c155a60a6bb51db4d
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 3 20:43:54 2017 -0800
Remove trailing whitespace.
Change-Id: Ifdea8516ccce7a72c88470913ce36b9226dfcb54
Reviewed-on: https://code.wireshark.org/review/19532
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=2cc2c2f883b4ce4ca8420877816332…
commit 2cc2c2f883b4ce4ca8420877816332086e096940
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 3 20:42:12 2017 -0800
Put symlinks to the executables in Contents/Resources/bin.
PackageMaker appears not to put them into the installer package, so
construct them in the Wireshark post-install script.
Bug: 13270
Change-Id: Idfa10d4d123d2c0e2f7b3ad65888e075fbfd27a7
Reviewed-on: https://code.wireshark.org/review/19531
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a2d6fb94fcefb10d5ef4650c1582d8…
commit a2d6fb94fcefb10d5ef4650c1582d8c06a278bd5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Jan 3 18:09:49 2017 -0800
No reason not to use etype_vals for an Ethertype field.
Maybe there was an issue on Windows back in the old days, when 1) we
didn't have a shared libwireshark library from which to import functions
and data variables and thus you couldn't get variables such as
etype_vals in a plugin and 2) the Infiniband dissector was a plugin, but
neither of those are the case any more.
Change-Id: Id8b82886317bd36a32ad1e1591673623696d4808
Reviewed-on: https://code.wireshark.org/review/19530
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=ab286246dc22d446b7d149f23c231b…
commit ab286246dc22d446b7d149f23c231ba8dbd6b640
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Tue Jan 3 14:23:13 2017 -0800
Ensure that tcp.reassembled_in is added to the tree for first segment.
Bug: 3264
Change-Id: I9fa8cfaf1e21a8a984941ee40e2e404ae21e55c9
Reviewed-on: https://code.wireshark.org/review/19528
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=564051df5e818cf4c9ad6447adebe4…
commit 564051df5e818cf4c9ad6447adebe466da03ae61
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Jan 3 14:36:56 2017 +0100
infiniband: remove offset variable.
Change-Id: Ie86c2aece05ebbc35eb15a54d8c3f2c455ff53cf
Reviewed-on: https://code.wireshark.org/review/19516
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8c86f3b0a386b6d13f56d3fbf6d907…
commit 8c86f3b0a386b6d13f56d3fbf6d9076bfa0419d2
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Jan 3 12:07:58 2017 +0100
infiniband: fix error for clobbered variable.
Given by gcc-4.9.2 on arm:
epan/dissectors/packet-infiniband.c:2708:9: error: variable ‘offset’ might be
clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
int offset = 0;
^
cc1: all warnings being treated as errors
Change-Id: I12066031093c1fa638792ff8be8f3f5457e3feda
Reviewed-on: https://code.wireshark.org/review/19515
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=13851f331c89006417c4910d20ab9d…
commit 13851f331c89006417c4910d20ab9d277523954d
Author: Mirko Parthey <mirko.parthey(a)web.de>
Date: Mon Jan 2 22:39:13 2017 +0100
ISAKMP: add Reserved fields
Add Reserved fields as defined by:
* RFC 7296 for IKEv2
* RFC 2408 for IKEv1
* draft-ietf-ipsec-isakmp-mode-cfg-05 for the IKEv1 Attributes Payload
Change-Id: I0c25de6e543aa5461650fb4cd2c103a6a3a8c392
Reviewed-on: https://code.wireshark.org/review/19480
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=ab075d356342b1f652ec56cf178104…
commit ab075d356342b1f652ec56cf178104e16f68f4dd
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Jan 2 16:24:41 2017 -0500
Use g_slist_find_custom instead of g_slist_nth when just looking for item in list.
Change-Id: Ida3c5d5826f0ca01a25052a67f1460ff4686008f
Reviewed-on: https://code.wireshark.org/review/19513
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c950ebdd0fe3938c4e8087ef1bce6d…
commit c950ebdd0fe3938c4e8087ef1bce6d365d9de1f6
Author: Gerald Combs <gerald(a)zing.org>
Date: Mon Jan 2 09:21:37 2017 -0800
make-version.pl: Fixup library version updates.
When updating {epan,wiretap}/{Makefile.am,CMakeLists.txt} make sure we
use an absolute path to each file and that we preserve the file's line
ending style.
Change-Id: Iee62a3ef8e89ca1ddae2569df62025805ee9a238
Reviewed-on: https://code.wireshark.org/review/19508
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=6f9c4c807e97332b370a012c3b3c28…
commit 6f9c4c807e97332b370a012c3b3c286c2b98c6aa
Author: Mirko Parthey <mirko.parthey(a)web.de>
Date: Mon Jan 2 15:14:07 2017 +0100
ISAKMP: Fix size of ID in IKEv1 Attributes Payload
Fix the size of the Identifier field in the IKEv1 Attributes Payload.
Reference: draft-ietf-ipsec-isakmp-mode-cfg-05, section 3.2
Change-Id: I30bfde9caa6750b342f7dfbad39e63341614a45b
Reviewed-on: https://code.wireshark.org/review/19502
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter(a)xs4all.nl>
http://cgit.osmocom.org/wireshark/commit/?id=6af7425ceebb698c53368fa90e1be5…
commit 6af7425ceebb698c53368fa90e1be52338bdf333
Author: Mirko Parthey <mirko.parthey(a)web.de>
Date: Mon Jan 2 13:45:24 2017 +0100
ISAKMP: fix dissection of IKEv2 ID Payload
Fix dissection of the IKEv2 Identification Payload.
Unlike IKEv1, it does not have Protocol and Port fields.
References:
* RFC 2407, section 4.6.2
* RFC 7296, section 3.5
Change-Id: I968e378abd49363785dd7308a4f27908c1c05a8a
Reviewed-on: https://code.wireshark.org/review/19497
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b358b870b3df572d3d8b0f3d16f1b5…
commit b358b870b3df572d3d8b0f3d16f1b5188cc549c3
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Sun Jan 1 04:35:57 2017 -0800
Snort: without explicit disable, expand preference to switch off
Change-Id: I5fd3b0cc6f19c4c873aaaae8c9e257a8b53a8419
Reviewed-on: https://code.wireshark.org/review/19489
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b380013051720c7060cd7df6e924ec…
commit b380013051720c7060cd7df6e924ec077984aefc
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Jan 1 08:10:23 2017 -0800
[Automatic update for 2017-01-01]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I397e20ffbc5227cb22d838c9eec68fae0e216162
Reviewed-on: https://code.wireshark.org/review/19492
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=4b7c2781fb3f94d49974f7616f8b74…
commit 4b7c2781fb3f94d49974f7616f8b74393af60ebd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Thu Dec 29 16:02:49 2016 +0100
OpenFlow (v4/1.3): Add complete dissection of error messages
Bug: 13221
Change-Id: Ide3e734fca280a294a993afade2503cd751d78a2
Reviewed-on: https://code.wireshark.org/review/19459
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d7ac90bfab4f52fedecf6d00f84d6d…
commit d7ac90bfab4f52fedecf6d00f84d6d196a71d40b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Jan 1 00:00:01 2017 +0100
Happy new Year 2017 !
Change-Id: I8ae8a1fdc8d0df0779ef119c527f41dac9e0dbdb
Reviewed-on: https://code.wireshark.org/review/19476
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4e5408cda9fa3d0a0d23fd6d94fafa…
commit 4e5408cda9fa3d0a0d23fd6d94fafa9c1e07cd86
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Dec 31 21:45:51 2016 -0800
Fix backwards #if defined.
Left over from some stuff I was fiddling with.
Bug: 11785
Change-Id: Ifb06e8b65db65037b336c46e5e180012ae5b7a59
Reviewed-on: https://code.wireshark.org/review/19487
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a6ce00feb3b233ed20b2b14f123811…
commit a6ce00feb3b233ed20b2b14f1238114a249f666a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Dec 31 21:43:43 2016 -0800
Squelch a compiler warning from Xcode 8 clang.
Unless I'm missing something, that code can't be reached, so local_proto
should always be set.
Change-Id: Idf765552d66cce684eb0de8dc8da57382aaf8444
Reviewed-on: https://code.wireshark.org/review/19486
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8909dff72139d2f0514a7bb83c6bf5…
commit 8909dff72139d2f0514a7bb83c6bf5c2959c4101
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Dec 31 18:45:00 2016 -0800
Always use the Windows time zone code on Windows.
We *have* to use the Windows code on Windows for the reasons given in
the comment. However, some versions of Visual Studio have a time.h that
CMake thinks defines tzname[] (which the header will do under some
circumstances), so HAVE_TZNAME gets defined on Windows. We check for
Windows *before* checking for HAVE_TZNAME - or HAVE_STRUCT_TM_TM_ZONE.
Bug: 11785
Change-Id: I61360daf08203dbd9d109a87c05727b4dbecea66
Reviewed-on: https://code.wireshark.org/review/19483
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f30b1e3b3bc4cec85296c280cdae88…
commit f30b1e3b3bc4cec85296c280cdae88d3d17fae04
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Dec 29 13:31:44 2016 -0500
Make TCP options into a dissector table.
This provides external access for dissectors and plugins to provide their
own implementation of TCP options.
Bug: 13141
Bug: 4452
Change-Id: I2fa6290616a4d8a8b421dd6daf98a23ce55479b9
Reviewed-on: https://code.wireshark.org/review/19461
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a0be5ad6f1b964db0cc7fc948d1deb…
commit a0be5ad6f1b964db0cc7fc948d1deb9ac89971b8
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Dec 29 19:41:33 2016 -0500
Add interface for "pinos" (Protocols in name only)
This is for dissectors that need distinguishing names either for registering
multiple dissection functions in a single dissector table or for "internal"
dissectors whose just need a name associated with the dissection function.
Features like enable/disable are handled by the "parent" protocol.
This avoids clutter in the "official" protocol list.
Change-Id: I69e7d27d332ae85286f254e95e8d79920da7a9e2
Reviewed-on: https://code.wireshark.org/review/19464
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6a5fcc5a38936d940e4fa50294be06…
commit 6a5fcc5a38936d940e4fa50294be0648a3ab6ea9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Nov 12 17:04:14 2016 +0100
TLS(1.3): Add PSK Key Exchanges Modes (45) hello extension
Ping-Bug: 12779
Change-Id: Ie797a437240e5530d74e3039f12a60a6f0395d0a
Reviewed-on: https://code.wireshark.org/review/18916
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f4b0abc7296bbb431e64e31f85b24c…
commit f4b0abc7296bbb431e64e31f85b24c29196c2ae4
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Dec 16 20:06:11 2016 -0500
Dissectors don't need a journey of self discovery.
They already know who they are when they register themselves. Saving the
handle then to avoid finding it later.
Not sure if this will increase unnecessary register_dissector functions
(instead of using create_dissector_handle in proto_reg_handoff function)
when other dissectors copy/paste, but it should make startup time
a few microseconds better.
Change-Id: I3839be791b32b84887ac51a6a65fb5733e9f1f43
Reviewed-on: https://code.wireshark.org/review/19481
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=13964595ad09e5d1115f6c5cb604cd…
commit 13964595ad09e5d1115f6c5cb604cded27f9f55d
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Dec 30 12:26:34 2016 -0500
Add BASE_NO_DISPLAY_VALUE to allow field value to not be shown.
There are times when byte arrays don't want to show their value
in the packet tree or there is a field that is the "header" of
a subtree where showing the field value distracts from the tree
display. For these cases, BASE_NO_DISPLAY_VALUE can be used
to not display the value.
Change-Id: I8c9f1f57cd2e663dbee07e2289e7f5e1f22d1e32
Reviewed-on: https://code.wireshark.org/review/19479
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2d8615948e06e70eef915085258660…
commit 2d8615948e06e70eef915085258660c23a5bd771
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Dec 30 16:01:16 2016 +0100
ENC: fix parsing of header broken by gee242bd
From the code before change, it appears that only SPI field is in network byte order.
Bug: 13279
Change-Id: Ia157b43a9da30d61dc9cb7607c66d44c8f607498
Reviewed-on: https://code.wireshark.org/review/19477
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0acd5034ac07c5e6cbaf56b8975ab3…
commit 0acd5034ac07c5e6cbaf56b8975ab3779b410d8d
Author: Paul Williamson <paul(a)mustbeart.com>
Date: Wed Dec 28 23:41:22 2016 +0000
Revert "Support all MA modes, fix BB CRC and frag edge cases"
Supporting all MA modes this way makes the dissector useless as a heuristic dissector;
it always matches. I just didn't understand about heuristic dissectors, and will look
for a better solution.
The fragmentation edge cases were also misunderstood. On closer reading of the spec,
these are not valid edge cases to be handled smoothly, but packet formatting errors to be
diagnosed.
The BB CRC fix is valid AFAIK, and will be resubmitted separately.
This reverts commit 2563503301aa4321a9a7a1ed392c9cbbe147fd2f.
Change-Id: I842f4eca59193b24f41a67ce7d081c681b70f449
Reviewed-on: https://code.wireshark.org/review/19449
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2f096100f5bcf5284111e62b51af23…
commit 2f096100f5bcf5284111e62b51af23a9cbf4149b
Author: Роман Донченко <dpb(a)corrigendum.ru>
Date: Wed Dec 28 22:59:50 2016 +0300
cms: don't assert if eContent fails to be dissected
If eContent is not an octet string, content_tvb will be null, and
attempting to use it will trigger an assertion. Besides ill-formed
files, this can also occur in old-style PKCS #7 files, since in PKCS #7
the corresponding field has the ANY type, rather than OCTET STRING.
Change-Id: I9a5bce983aa82107a9602317737c183461cac7f3
Reviewed-on: https://code.wireshark.org/review/19448
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e7a4c82b85d2149eeb54ff55b6a52b…
commit e7a4c82b85d2149eeb54ff55b6a52ba11f79fd0f
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Dec 30 10:00:02 2016 +0100
QUIC: Add SMHL (Support Max Header List Size) tag
Change-Id: I093f71d3ca409e048211fedf671551721b94d535
Reviewed-on: https://code.wireshark.org/review/19474
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f1fb896e581a83e9e5adb03274c7c2…
commit f1fb896e581a83e9e5adb03274c7c2421464969c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Dec 30 09:54:17 2016 +0100
QUIC: fix link to error code
Change-Id: If5a0e547c1fb952584f7e661ae5ad1abfdf4bec3
Reviewed-on: https://code.wireshark.org/review/19473
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5c356aaa836f5df60a96d49c8fe1a8…
commit 5c356aaa836f5df60a96d49c8fe1a8dda592436c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Dec 30 09:48:25 2016 +0100
enc (openBSD): Add reserved/unused field for flags
and fix also bitmap (32 bits)
Change-Id: I04b7cb64bf7d593648131c09d05eb8e9b1eca8ca
Reviewed-on: https://code.wireshark.org/review/19471
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b4afbb24a5e094dc1eb1c10ac81a38…
commit b4afbb24a5e094dc1eb1c10ac81a383c42bf3e93
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Dec 30 09:16:13 2016 +0100
enc (openBSD): fix flags field description
Change-Id: I5b17d4bfea82770458b002aacfca0fc941639899
Reviewed-on: https://code.wireshark.org/review/19470
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3761ef378537f6a9e0424f7cbded7e…
commit 3761ef378537f6a9e0424f7cbded7e7403ba425c
Author: Baruch Siach <baruch(a)tkos.co.il>
Date: Thu Dec 29 20:16:53 2016 +0200
androiddump: add missing sys/time.h header
struct timeval requires sys/time.h. Fixes the following musl libc build error:
androiddump.c: In function 'useSndTimeout':
androiddump.c:262:18: error: variable 'socket_timeout' has initializer but
incomplete type
const struct timeval socket_timeout = {
^
Change-Id: I52e204f32a012aabea2e54877e564576c072fe08
Reviewed-on: https://code.wireshark.org/review/19460
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=931253800adff149f34cc6d2ed0828…
commit 931253800adff149f34cc6d2ed082801edc2d3c8
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Thu Dec 29 22:59:13 2016 +0100
UDLD: Use correct flag bits
Assigned flag bits are the least significant bits of the flags field,
not at the most significant end.
Bug: 13280
Change-Id: Ie568df6ca137c491fedb32cf2316a0240270b3d6
Reviewed-on: https://code.wireshark.org/review/19463
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bd9d8b79b77b23bffdf1ad52388b18…
commit bd9d8b79b77b23bffdf1ad52388b187f09fe9760
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Dec 29 20:15:48 2016 -0800
Three count 'em three different names for the OS.
Change-Id: Icb53c200e95a55b648297bbf5237662c3adaeb84
Reviewed-on: https://code.wireshark.org/review/19465
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=a76c6cfa429b4dd204b14999d27187…
commit a76c6cfa429b4dd204b14999d27187faa61d0541
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Dec 28 16:15:02 2016 +0100
lemon: Fix Dereference of null pointer found by Clang analyzer
lemon.c:877:10: warning: Access to field 'lhs' results in a dereference of a
null pointer (loaded from field 'startRule')
lemon.c:1141:22: warning: Access to field 'lhs' results in a dereference of a
null pointer (loaded from field 'startRule')
it is false positve lem.nrule==0 implies lem.rule==NULL
Change-Id: Id63086990762fbf5195bce34a28f25aeb7a246f7
Reviewed-on: https://code.wireshark.org/review/19445
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=255722c01ce7ffe42c4e8ff892f949…
commit 255722c01ce7ffe42c4e8ff892f9493077a92229
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Thu Dec 29 10:20:01 2016 +0100
Fix Interface Selection List
Fixes issue introduced with Ib82519362454094f64abf1cbe6d7bc917990d7ac
Change-Id: I9fbf376c03f2ead1575ca30e8ff89dc36d99109f
Reviewed-on: https://code.wireshark.org/review/19450
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7f576aab364cd17bbfc4694aada88a…
commit 7f576aab364cd17bbfc4694aada88a7c6ea34ca0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Dec 28 16:22:54 2016 +0100
zvt: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I0f7a620e5fbdab4a4c6b62b1b7bc884073bc0f45
Reviewed-on: https://code.wireshark.org/review/19447
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=763d7f3012743091678e2120018347…
commit 763d7f3012743091678e21200183472c2000119a
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat Dec 24 14:01:16 2016 +0100
zvt: mark some functions as inline
Change-Id: I2637fc18b1eeda5e567ee62c8ed53c6757c259bd
Reviewed-on: https://code.wireshark.org/review/19457
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=d05be43a8993f8cbbb19a29c39e3e5…
commit d05be43a8993f8cbbb19a29c39e3e556e27125e9
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Dec 16 17:47:02 2016 -0500
zvt: dissect card type and result code bitmaps
Change-Id: I26a7821642224c707dc4542a35b2b5b5aee159d5
Reviewed-on: https://code.wireshark.org/review/19456
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=4eb5836a2cf529f56e6d819c338bd3…
commit 4eb5836a2cf529f56e6d819c338bd3726d56ed45
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Wed Dec 14 12:50:58 2016 -0500
zvt: dissect the text lines TLV data object
Change-Id: I3d54b4568b883b95294e29347bde0736b78157e1
Reviewed-on: https://code.wireshark.org/review/19455
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=af1a148065f2d06f978a914563da37…
commit af1a148065f2d06f978a914563da373adcf89753
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Tue Dec 13 18:28:43 2016 -0500
zvt: dissect the status apdu, add some more bitmaps
Change-Id: If74221dd55d61c5794f570daf38c88771f4a2f38
Reviewed-on: https://code.wireshark.org/review/19454
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=8f28a528124448e5cb7fb7fc28d67b…
commit 8f28a528124448e5cb7fb7fc28d67bc667891629
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Dec 2 20:13:25 2016 +0100
zvt: add some more tag names
Change-Id: If181a22f2794fb9fe812719593f8a7eb642bce42
Reviewed-on: https://code.wireshark.org/review/19453
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=9658c0dcbd101791ddfb636b823baa…
commit 9658c0dcbd101791ddfb636b823baa1d2316378a
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Dec 2 19:13:10 2016 +0100
zvt: print the tag name in the tree header
Change-Id: Iac0744f830020a54790a39820abab9fb756ffa9f
Reviewed-on: https://code.wireshark.org/review/19452
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=9bcf111b7dcd9bc570919b525a5cdf…
commit 9bcf111b7dcd9bc570919b525a5cdfdc5ed38bb3
Author: Mirko Parthey <mirko.parthey(a)web.de>
Date: Wed Dec 28 14:56:52 2016 +0100
ISAKMP: add Reserved fields for Fibre Channel
Add Reserved fields for Fibre Channel Traffic Selectors.
Reference: RFC 4595, section 4.4
Change-Id: Iba0b3d9a4d3d96918971a9a597fa313b022b5ca2
Reviewed-on: https://code.wireshark.org/review/19444
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=31872655ad257cadbf8805d0e94c0b…
commit 31872655ad257cadbf8805d0e94c0bae9696a746
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sat Dec 17 23:12:11 2016 +0100
CMake,autotools: enable -Werror=implicit by default
The -Wimplicit error covers two warnings, trying to catch these cases:
Setting a global variable without declaring its type (-Wimplicit-int):
undeclared_type = 1;
More importantly, -Wimplicit-function-declaration catches the case where
a function is not declared (missing header, programming error, etc.).
Turn these warnings into errors, most likely it will be a programming
error that results in a link failure anyway. See also
https://fedoraproject.org/wiki/Changes/Fedora26CFlags
Also fix autotools checks not to trigger -Wimplicit-int and
-Wimplicit-function-declaration (in krb5 check due to missing include).
Tested on Ubuntu 16.04 (autotools & cmake) and Arch Linux (cmake),
configure/cmake output and config.h are identical.
Change-Id: I137284263f3b1223df6e6a893111c3640802631f
Reviewed-on: https://code.wireshark.org/review/19331
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=52d38a18fdfc8f2b0903721e007b8f…
commit 52d38a18fdfc8f2b0903721e007b8f62d53e5759
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Dec 28 11:11:36 2016 +0100
Qt: Remove "Extcap" from window title.
An average user does not need to know that an interface is of type extcap.
Remove "Extcap" from the "Extcap Interface Options" dialog.
Change-Id: Iafadf2d312a4ffd5530deeac63194151571fc7d3
Reviewed-on: https://code.wireshark.org/review/19443
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=f3df81bf590a1c020155a485d77a2a…
commit f3df81bf590a1c020155a485d77a2ab506270959
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Dec 28 10:55:32 2016 +0100
Qt: Fix open extcap help URL.
The return value from QString::compare() is equal to zero when the
strings are equal. Fix the code for checking and opening the extcap
help URL if not matching "file".
This bug was introduced in g46caff30.
Ping-Bug: 13218
Change-Id: I2a84e61f0191b57269f8ce829ff82200bf19a7ac
Reviewed-on: https://code.wireshark.org/review/19442
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=40c618eac5034ebf53da664dfe5cea…
commit 40c618eac5034ebf53da664dfe5cea9b319a0f68
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 27 23:16:19 2016 -0500
Infiniband: Use base of packet tree (top_tree) for
"infiniband.mad.cm.private" heuristic dissector.
The "infiniband.payload" heuristic dissector was converted to use the base
of the packet tree so that subdissectors could show their protocol as the
base layer. Since many of the subdissectors use the same dissection function
for both "infiniband.payload" and "infiniband.mad.cm.private",
ensure that
both use the same "tree level", but still pass in the "payload
tree" as part
of the dissector data in case a subdissector wants to use it (currently used
by InfinibandSDP)
Ping-Bug: 13259
Change-Id: I899e8348f6b23d8eee9e74764d8ca32d7bf6e625
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/19441
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Parav Pandit <paravpandit(a)yahoo.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0e3841c3dd5702cb399eafda8deafa…
commit 0e3841c3dd5702cb399eafda8deafa3818c1b461
Author: Mirko Parthey <mirko.parthey(a)web.de>
Date: Wed Dec 21 21:28:39 2016 +0100
ISAKMP: add traffic selector subtree
Create a new subtree for each traffic selector.
Use the length field to find the next traffic selector
rather than accumulating the individual TS field sizes.
Split dissect_ts() to introduce separate offset variables.
After adding the final field, do not advance offset again
to avoid unused variable warnings.
Change-Id: I9951662c1bb3958994162b25b70b43ec1da103a7
Reviewed-on: https://code.wireshark.org/review/19440
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c27ff1d2c74107eb95a496b2d29f61…
commit c27ff1d2c74107eb95a496b2d29f617485c158c0
Author: Jim Young <jyoung(a)gsu.edu>
Date: Mon Dec 26 12:29:45 2016 -0500
macosx: Update Read me first.rtf with some additional install/deinstall notes
Report that files /etc/paths.d/Wireshark and /etc/manpaths.d/Wireshark
are added and should be removed.
Change-Id: I2f9d3aea0dd4f86cb9a86065108a3948e28d3001
Reviewed-on: https://code.wireshark.org/review/19436
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=dd7349754beb739592f1e513506c6f…
commit dd7349754beb739592f1e513506c6fc25eb4b22e
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Mon Dec 26 00:47:57 2016 -0500
Added basic support for NVM Express over Fabrics for RDMA.
NVM Express is high speed interface for accessing solid state drives.
NVM Express specifications are maintained by NVM Express industry
association at http://www.nvmexpress.org.
Bug: 13201
Change-Id: Id40edaf72838eea9f4087c8ddba9518a9374efab
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/19063
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Parav Pandit <paravpandit(a)yahoo.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e5a39920f9883133945b088c85c8fb…
commit e5a39920f9883133945b088c85c8fbf4737a6ecd
Author: Роман Донченко <dpb(a)corrigendum.ru>
Date: Sun Dec 18 00:55:14 2016 +0300
Move DigestInfo from pkcs12 to cms
This type is originally from PKCS #7, the predecessor of CMS, so it makes
more sense for it to be there.
Change-Id: I3a146f1d000a3bcbcd0d8f1cfe2fc27ed80cc69d
Reviewed-on: https://code.wireshark.org/review/19335
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9d47bf993932c064c60ea79592a06f…
commit 9d47bf993932c064c60ea79592a06f0ffd383fd6
Author: Roland Knall <roland.knall(a)br-automation.com>
Date: Tue Dec 27 10:14:32 2016 +0100
InterfaceList: Add check for remote interface
Add a check, to allow the filtering of remote only interfaces. Also
add the necessary options to the type menu.
Change-Id: Ib82519362454094f64abf1cbe6d7bc917990d7ac
Reviewed-on: https://code.wireshark.org/review/19438
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8e6953a64b0b785918d4a234e1eb09…
commit 8e6953a64b0b785918d4a234e1eb09de21cfb5b8
Author: Jaap Keuter <jaap.keuter(a)xs4all.nl>
Date: Mon Dec 26 14:40:14 2016 +0100
Replace assignment with structure assignment (CID 1397183)
Replace the individual field assignment with struct assignement to
- Reduce code (only single line, but he),
- (Hopefully) show Coverity this is as intended.
Change-Id: I9400b6e38f86acf57018ee7993e66d5b06d1c39c
Reviewed-on: https://code.wireshark.org/review/19434
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fc29f28cb0c72dc93398ef3cae2f90…
commit fc29f28cb0c72dc93398ef3cae2f9091c2205bec
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Dec 26 09:34:13 2016 -0500
Merge AIM files into single dissector file.
These are probably obsolete dissectors anyway, but they are a
bunch of very small files causing unnecessary file pollution.
Change-Id: I03976484996b4bf987d6743ed379534456809c2c
Reviewed-on: https://code.wireshark.org/review/19437
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6427edb18d84a812cd3f9de95f6579…
commit 6427edb18d84a812cd3f9de95f657953f4026589
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Dec 23 19:06:24 2016 +0100
zvt: dissect the TLV container's payload
add a function to dissect the sequence of TLV elements
use a hash table for payload functions like we do for the bitmaps
add two tags whose payload is another TLV sequence
Change-Id: Ibb19fd7af2f58e201174d07d410557dc315c652a
Reviewed-on: https://code.wireshark.org/review/19435
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=e41201cde4dcf28c8e22433bd363bf…
commit e41201cde4dcf28c8e22433bd363bf1133f31aa1
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Dec 26 08:04:12 2016 -0500
Don't claim packet as MATE if there is no MATE configuration
This prevents MATE from (falsely) being included in the list of
protocols for any given frame.
Change-Id: I9ffdfb52cf31dfda89b674a41bcc0992e17de5e8
Reviewed-on: https://code.wireshark.org/review/19432
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=730b2ed14ce4e1acb9b9f37f96ff1a…
commit 730b2ed14ce4e1acb9b9f37f96ff1a2c08328c83
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Dec 25 08:34:52 2016 -0800
[Automatic update for 2016-12-25]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I8fd8115fdfd4623bdf94602b6fd55a724e09cec3
Reviewed-on: https://code.wireshark.org/review/19429
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=96d15102f56900acdac587b6407eb4…
commit 96d15102f56900acdac587b6407eb4c6545721de
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Dec 24 21:00:36 2016 -0500
Remove individual post-dissect enable preferences.
Use Analyze -> Enabled Protocol dialog interface. Added support
for backwards compatibility of preference.
Change-Id: I32b3fce9d18083d9324197e3fd7ddc7eb888d1fb
Reviewed-on: https://code.wireshark.org/review/19422
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4270b48b19439cfed0f480f9ce29a3…
commit 4270b48b19439cfed0f480f9ce29a34003e45e97
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Dec 23 00:20:13 2016 +0100
DVB-CI: simplify dissection of the resource id
Now that proto_tree_add_bitmask_value_with_flags() works for tvb==NULL,
we can use it to simplify the dissection of DVB-CI's resource id.
Change-Id: Ia09d5668bf0a61161ecd0cb412680838a67d7a7a
Reviewed-on: https://code.wireshark.org/review/19409
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=68fc3e0babe145c936599adc283cd7…
commit 68fc3e0babe145c936599adc283cd76129e3e91c
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 25 01:39:34 2016 -0800
Wireshark doesn't require X11 any more.
Change-Id: Ib5ba38e5103f31f115608b92dd32f3ce1e5eec67
Reviewed-on: https://code.wireshark.org/review/19424
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=14603ea3764ccdfbe4bc2586d0cd70…
commit 14603ea3764ccdfbe4bc2586d0cd70feea8412e2
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 25 00:22:31 2016 -0800
Fix some narrowing warnings.
Don't narrow values until it's necessary, and then put in explicit casts
to indicate that the narrowing is intentional.
Change-Id: I8afc2a457822febbed33cee573953993013a7185
Reviewed-on: https://code.wireshark.org/review/19423
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=45553db9d1fd72e6d5b79b6c9fd4bd…
commit 45553db9d1fd72e6d5b79b6c9fd4bdf5d733344c
Author: Francois Schneider <francois.schneider(a)airbus.com>
Date: Wed Feb 17 21:34:52 2016 +0100
packetbb: Add decoding for TLV with single value
Bug: 4118
Change-Id: I282fb8da657701c5b855dafe1568a5f226d3c12b
Signed-off-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-on: https://code.wireshark.org/review/13985
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3a55ec3f44baf7cf454ed3cb2cd1a1…
commit 3a55ec3f44baf7cf454ed3cb2cd1a192daa71072
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 15:43:29 2016 +0100
rtp_analysis_dialog (Qt): Fix Dead Store (Dead assignement/Dead increment) Warning
found by Clang
Change-Id: I48dd8af83c97301b6bd314801ca36ac13c790eaa
Reviewed-on: https://code.wireshark.org/review/19413
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=78d56e5dd74ca22bbfbbf94ba8a74b…
commit 78d56e5dd74ca22bbfbbf94ba8a74becc15b23d3
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Dec 24 17:54:36 2016 -0500
Cleanup transum post-dissector.
1. Enable/disable preference not needed - just use Enabled Protocol
dialog interface. Added support for backwards compatibility of preference.
2. Add value_string for calculation values
3. Create an structured array of "hfs of interest" so they can more easily
be extended.
4. Convert a bunch of arrays into hash tables and lists. For the amount
of wasted space they were taking up, we can live with the very slight
performance degrade. Also puts less limits on number of things to process.
Change-Id: I7399789d62432b507062ed9cdc20ad974b9dde1b
Reviewed-on: https://code.wireshark.org/review/19406
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2563503301aa4321a9a7a1ed392c9c…
commit 2563503301aa4321a9a7a1ed392c9cbbe147fd2f
Author: MustBeArt <paul(a)mustbeart.com>
Date: Mon Dec 19 09:59:26 2016 -0800
Support all MA modes, fix BB CRC and frag edge cases
Support all four mode adaptation interface formats. Add a user preference to
specify which format is in use, or to request that the format be guessed.
Guessing is improved, but can never be reliable.
Fix problem with baseband header CRC check that caused almost all packets to
show a spurious CRC error, introduced with proto_tree_add_checksum.
Fix problem with GSE PDU fragmentation CRC beginning in one fragment and
ending in another. Any GSE frames following the fragment containing the
end of the CRC would be parsed at the wrong offset.
Fix problem with IPv4 or IPv6 starting exactly on a fragmentation boundary,
so that one baseband frame contains the complete GSE header but zero bytes
of the IP payload. Trying to further dissect the zero-length payload led to
a "malformed packet" display.
Standardize spelling per governing document: adaption -> adaptation
Change-Id: I69e64e74e4b4f02515411471e1d76b0eeb02fef1
Reviewed-on: https://code.wireshark.org/review/19421
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=802362ee1a44d4a6494092f40e6115…
commit 802362ee1a44d4a6494092f40e61155569ee5a6a
Author: Mikael Kanstrup <mikael.kanstrup(a)gmail.com>
Date: Sat Mar 19 09:36:57 2016 +0100
Avoid recursive scan_local_interfaces operation
When the local networks interfaces changes quickly or when refreshing the
list of network interfaces there's a risk of recursive calls into
scan_local_interfaces. The recursive calls are a result of calling
update_cb to process UI events during function operation which in turn
again discover a network interface change. This results in strange
duplicate entries of network interfaces and crashes.
To avoid recursive calls a check is added to stop running the function while
already updating. This patch is really just a workaround for the problem.
Ideally some asynchronous operation should be implemented instead to avoid
the UI update_cb callback alltogether.
Bug: 11553
Bug: 12263
Change-Id: I3b74d8f196677e0e261a395aff558dd9f685b538
Reviewed-on: https://code.wireshark.org/review/14492
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=194433a503bf1f90f1037e6c1e1e97…
commit 194433a503bf1f90f1037e6c1e1e97303f6c3ffa
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Dec 22 14:19:30 2016 +0100
udpdump: remove libwireshark dependancy.
Export pdu routines have been rewritten here on purpose.
Change-Id: If4879de4c98b6f20a75df158cae0cf9a80ffae57
Reviewed-on: https://code.wireshark.org/review/19384
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b58c98b269fcc69683e163a1a09e63…
commit b58c98b269fcc69683e163a1a09e63dadf2e7d96
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 19:19:53 2016 +0100
802.11(ad): split Sector Sweep Feedback in 2
one from ISS and other to ISS
Add also reserved field
Issue reported by Hany ASSASA
Bug:13244
Change-Id: Ib20cf6ae455664b87ea3470ebb6d5386a97b0f48
Reviewed-on: https://code.wireshark.org/review/19420
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4515a7eb8a20eed3d6ff8e1ba9ed17…
commit 4515a7eb8a20eed3d6ff8e1ba9ed17069a2feec0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 18:09:39 2016 +0100
802.11(ad): fix typo
Acknoledgment => Acknowledgment
Ping-Bug: 13244
Change-Id: Ia2e8eedec05c39ed0ebc38235cc52d43488e00d4
Reviewed-on: https://code.wireshark.org/review/19419
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=62a54cb773f1bf3f08c197c51117ba…
commit 62a54cb773f1bf3f08c197c51117ba5e03e6297c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 16:53:49 2016 +0100
802.11(ad): Enhance dissection of Beam Refinement
You can now use bitmap on 64bits (or 40bits)
and also add a reserved field
Change-Id: Ibc68b56477e76c2b13624920eb7a9a49f8f887f3
Ping-Bug: 13244
Reviewed-on: https://code.wireshark.org/review/19418
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=bdc88443b5329b2465dfaf7e2e3dd8…
commit bdc88443b5329b2465dfaf7e2e3dd85b75eee58c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 16:11:37 2016 +0100
802.11(ad): Add reserved field for BRP Request
Change-Id: Iee6012e841007b731dc16545a1d9bf6f17377580
Ping-Bug: 13244
Reviewed-on: https://code.wireshark.org/review/19417
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=1bd6288a25d62d386ecacfbf4b95d6…
commit 1bd6288a25d62d386ecacfbf4b95d65a3f7e3454
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 15:58:39 2016 +0100
802.11(ad): fix wrong bitmask for BRP TX Antenna
Missing a zero
Change-Id: I43097bc62fb66dea849c5ed7882d01a6de768c82
Ping-Bug: 13244
Reviewed-on: https://code.wireshark.org/review/19416
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=60551ea55a295910d9ab7b54ef2c2a…
commit 60551ea55a295910d9ab7b54ef2c2abde20da4d9
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Jun 18 00:20:54 2016 +0200
Lemon: resync with upstream
lemon: Tue Aug 16 16:46:40 2016
lempar: Tue Dec 6 17:59:05 2016 +0000
a copy of all Wireshark changes are available
https://github.com/alagoutte/sqlite/tree/wireshark
Change-Id: I144d0f983e4ac960b5a7a2fd8cd379f6282579f8
Reviewed-on: https://code.wireshark.org/review/15987
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d98a3cbf2f0f62efa57393c962f8ca…
commit d98a3cbf2f0f62efa57393c962f8cabf34f95a9e
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 18:07:44 2016 +0100
AFP: fix indent (use tabs)
Change-Id: I3d1078ddff6ec7b9c7efc5cda9a1821ef52b46ce
Reviewed-on: https://code.wireshark.org/review/19415
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d82b9f6c8a953de50f7ff217e7db77…
commit d82b9f6c8a953de50f7ff217e7db772d88ad2bd1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 15:35:41 2016 +0100
ppi-vector: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I44ae8a9cc6b09ad205b9c90e7d9595768fcac71b
Reviewed-on: https://code.wireshark.org/review/19412
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5aac1e77769865be43602392b2308b…
commit 5aac1e77769865be43602392b2308b693b87f7c4
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 15:34:44 2016 +0100
bthci_evt: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: Ic9962a1824b9f9d137177c81cb15d7ef4bc7bfc2
Reviewed-on: https://code.wireshark.org/review/19411
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2d25e4f70fb045fd1405d0dab221f9…
commit 2d25e4f70fb045fd1405d0dab221f914b1a5fc1c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 24 17:54:58 2016 +0100
disabled_protos: fix no previous prototype for function 'read_protos_list'
[-Wmissing-prototypes]
Change-Id: I5bfa11213ca27308204a1d8b6073661161c9151e
Reviewed-on: https://code.wireshark.org/review/19414
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=0c4d074f2835711c10b41ca72c507c…
commit 0c4d074f2835711c10b41ca72c507c03b4c9cc55
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sat Dec 24 13:16:38 2016 +0100
extcap_options_dialog: fix compilation with Qt4
Qt4's QFileInfo::exist() can only be used with an existing QFileInfo
object. The version that accepts the file name as paramter was
introduced in Qt5.
Create a temporary QFileInfo object and call exists() on this object.
Change-Id: I162cc22ecba61b2c2f16f9f0916b0db7969abb51
Reviewed-on: https://code.wireshark.org/review/19408
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=55549f5ac823e3081ee7a05d0156e7…
commit 55549f5ac823e3081ee7a05d0156e7f848872ebd
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Sun Nov 27 15:30:48 2016 +0100
zvt: len is used in dissect_zvt_int_status()
Change-Id: I8937dc605abf0414159acfc75ee05ccac89658fb
Reviewed-on: https://code.wireshark.org/review/19410
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=ad7caed698ff554f760e0fce994c38…
commit ad7caed698ff554f760e0fce994c386be5b18653
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Dec 23 22:24:05 2016 -0500
[TRANSUM] smb2.msg_id is now a FT_UINT64.
Per bug 12915, SMB2 message ID should be treated as a unsigned 64bit value.
Have transum logic match that as it was assuming SMB2 message ID was a
signed 64bit value
Change-Id: Ide0c12b505d1eef2aeb89d165a3ea59058e6be34
Reviewed-on: https://code.wireshark.org/review/19407
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c302812566373c5ac7383b825bea83…
commit c302812566373c5ac7383b825bea830b716778a5
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Dec 23 15:20:31 2016 -0500
Add enabled protocol list for dissectors who are disabled by default
We save a list of dissectors that are disabled through the Enabled Protocols
dialog. This is because we assume dissectors are enabled by default.
For dissectors that are disabled by default, we have no way to keep them
enabled through the Enabled Protocols dialog. A dissector that defaults
to being disabled has to be reset to enabled each time Wireshark is launched.
Add a list similar to the disabled list for enabling dissectors that are
disabled by default.
This mostly applies to post-dissectors.
Change-Id: I31a8d97a9fdbc472fe2a8666384e0f8786bb8e9f
Reviewed-on: https://code.wireshark.org/review/19405
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fb9a4d7413e7cf10cfce432e0d19e6…
commit fb9a4d7413e7cf10cfce432e0d19e60c2f3acfe5
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Dec 23 09:06:44 2016 -0500
Set BCP BPDU to size of bytes used by the protocol, not whole packet.
Bug: 13188
Change-Id: I29b2712d4d6ae57e4b0ea4bc0ec126cb80172779
Reviewed-on: https://code.wireshark.org/review/19400
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ec54234e732c600f5a30824277e9f4…
commit ec54234e732c600f5a30824277e9f456462f047c
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Fri Dec 23 13:16:20 2016 +0100
bthci_cmd: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
Change-Id: I84472632e715a6f13e2fa5b58ae95f9dc9d16776
Reviewed-on: https://code.wireshark.org/review/19399
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a1ecbc92b028203bd08db185854710…
commit a1ecbc92b028203bd08db18585471050baf712f4
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Fri Dec 23 00:20:56 2016 +0100
make proto_tree_add_bitmask_value_with_flags() work for tvb==NULL
proto_tree_add_bitmask_value_with_flags() eventually calls
proto_tree_add_XXX() for the main hf and for the field elements.
These functions work for tvb==NULL if the length is also set to 0.
Otherwise, we'll end up in proto_tree_add_pi(), get_hfi_length() and
run into the DISSECTOR_ASSERT() there.
proto_tree_add_bitmask_value...() are meant for cases where the data is
passed directly and not read from a tvb. If tvb==NULL, set our length to
0 instead of using the field length from the main hf.
Change-Id: Ia55b068e9842ba4a1ae8be8692320a8e93ea8631
Reviewed-on: https://code.wireshark.org/review/19394
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=46caff30c8234d011bdde44d051e40…
commit 46caff30c8234d011bdde44d051e405971cfa9d9
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Dec 9 15:01:54 2016 +0100
Qt: add local file existence check for extcap help.
The extcap help pages point to local manpages. Check the existence
of local file before attempting to open them, and if it fails, give
the user an error.
Ping-Bug: 13218
Change-Id: I0e0ff1e66e439d3ff8c992dbb42652782c047bb5
Reviewed-on: https://code.wireshark.org/review/19180
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f15b3a0f73568ca928827ee7467924…
commit f15b3a0f73568ca928827ee746792478c907845a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Dec 23 01:00:44 2016 -0800
Make sure we know that a RNG_RSP_DL_FREQ_OVERRIDE item is present.
Set a variable that we were supposed to be setting.
Also, note some items that should probably be expert info items instead
of, or in addition to, additional text at the end of protocol tree items.
Addresses CID 1397702.
Change-Id: I2ff0c2549f229546035964efa6af19b77646f7d2
Reviewed-on: https://code.wireshark.org/review/19397
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=933a73177736171214c2ae853fa381…
commit 933a73177736171214c2ae853fa3819fc09016bc
Author: Martin Kaiser <wireshark(a)kaiser.cx>
Date: Thu Dec 22 22:16:43 2016 +0100
DVB-CI: don't call proto_tree_add_subtree_format() with tvb==NULL
When I first implemented this, proto_tree_add_subtree_format() worked
for tvb==NULL if len was also 0. The bounds check added in
56706427f53cc64793870bf072c2c06248ae88f3 breaks this use case and makes
DVB-CI spill out dissector asserts.
Warn Dissector bug, protocol DVB-CI, in packet 625:
../epan/tvbuff.c:532: failed assertion "tvb && tvb->initialized"
Create a proto_item first and link the subtree to this item. This will
work as long as proto_tree_add_uint() accepts tvb==NULL.
Thanks to Kay Katzorke for reporting this bug.
Change-Id: I25a071c21925f7d362c92852fd5a8136e4d361c8
Reviewed-on: https://code.wireshark.org/review/19389
Petri-Dish: Martin Kaiser <wireshark(a)kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Kaiser <wireshark(a)kaiser.cx>
http://cgit.osmocom.org/wireshark/commit/?id=abe78e915e6d4aaa82b623865cadb9…
commit abe78e915e6d4aaa82b623865cadb95cc6402851
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Dec 23 09:44:38 2016 +0100
GSM A GM: align protocol / container id filter format with displayed one
Change-Id: If5dcee6a2a9dd6de304e78f84456903c932ad452
Reviewed-on: https://code.wireshark.org/review/19393
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c1e1f62cb811ad2e7fa68bbe0d337b…
commit c1e1f62cb811ad2e7fa68bbe0d337bd305eb79f4
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Dec 23 09:34:42 2016 +0100
GSM A GM: use same spelling as the 3GPP specification
Change-Id: I706b64bb3875a15d8be0e486a03784e19ab5af23
Reviewed-on: https://code.wireshark.org/review/19392
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b013d5c4d98dfc31d8e43d6cb63cc8…
commit b013d5c4d98dfc31d8e43d6cb63cc88ff6222cc7
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Dec 22 19:29:46 2016 -0800
Initialize the dissection options along with the other command-line options.
Change-Id: I35ff8f36d12831d408666c3422444371a2ac0c25
Reviewed-on: https://code.wireshark.org/review/19391
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5c1b898a4398c994f59d47db875f84…
commit 5c1b898a4398c994f59d47db875f8476a52d9652
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Thu Dec 22 11:37:19 2016 +0100
packet-rtp.c: Fix of decoding RTP over TCP
During patch modification in https://code.wireshark.org/review/#/c/19293/ we made
mistake :-(
Change-Id: I2ff65170dbcf3b5c4d27d6d7c629092d5080ed28
Reviewed-on: https://code.wireshark.org/review/19382
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b97af3af2c45f39a1005d4a3786d11…
commit b97af3af2c45f39a1005d4a3786d115800cdb1b0
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Dec 22 11:43:05 2016 +0100
udpdump: set default value for payload
Change-Id: Iad8624cbb9102611f806cdcce152b8ed14ce4474
Reviewed-on: https://code.wireshark.org/review/19383
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8c70558d1651df0502e57f0b3bd56e…
commit 8c70558d1651df0502e57f0b3bd56e1f70bc522b
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Dec 22 15:14:47 2016 +0100
RPC: fix crash when using "Dissect unknown RPC program numbers" option
When using this option, rpc_prog_info_value structure is not fully initialized.
Depending on the memory allocator used, this can lead to a NULL pointer
dereference or an access to a random memory block.
Ensure that the structure if fully initialized and test pointer before
dereferencing it.
Bug: 13266
Change-Id: Ifdc54b31c8dd3b2b6220dbe9ee27272758ff60ca
Reviewed-on: https://code.wireshark.org/review/19385
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=541beaad6e99c8efc8a57a8e87fd5e…
commit 541beaad6e99c8efc8a57a8e87fd5e8c3d56056a
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Dec 22 09:36:18 2016 +0100
Qt: use references on tap_rtp_stat_t private members (CID 1397703 and 1397704)
This should solve the "passing parameter statinfo of type
"tap_rtp_stat_t"
(size 5040 bytes) by value" warnings reported by Coverity.
Change-Id: I327906f7925ab21a914b8a98ff8481a0af9f7a2f
Reviewed-on: https://code.wireshark.org/review/19380
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=61d2c8f4a4fdca8f6d9055400a29f8…
commit 61d2c8f4a4fdca8f6d9055400a29f8c74580c313
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Thu Dec 22 09:49:56 2016 +0100
RTP: fix a possible NULL pointer dereference (CID 1397705 & 1397706)
As those dissectors are registered by name, let's not make the assumption
that rtp_info is always present.
Change-Id: I959b8c71485471b3be4cd2e71a6d96c2d4b278ff
Reviewed-on: https://code.wireshark.org/review/19381
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b3b23ff134adc3e997ba809f2a2e8d…
commit b3b23ff134adc3e997ba809f2a2e8dbb22266528
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Dec 22 09:28:05 2016 +0100
Gtk: add initializers.
As per coverity multiple CIDs.
Change-Id: I30b5a5e45de2fc9b3c563c56151bd33483c754cd
Reviewed-on: https://code.wireshark.org/review/19379
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Petri-Dish: Roland Knall <rknall(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=1a38cdeef7a8ae4435896606eeca85…
commit 1a38cdeef7a8ae4435896606eeca85897d0d5829
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Wed Dec 14 22:55:05 2016 +0100
RTSP dissector: Decode RTP/AVP/TCP and configure RTP session for it
rtsp_create_conversation was modified significantly:
- ignore non response calls => process only the complete information
- distinguish between UDP, TCP and RTSP interlaced media
- supports ED137 recording with RTP/UDP or RTP/TCP
It was tested on many samples from bugzilla and from my library.
Tests noted in bug 13257
Bug: 13257
Change-Id: I054505bcb9334c3abfff6d61c18c9cb6d2a6d56e
Reviewed-on: https://code.wireshark.org/review/19341
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=32a31c5a9cc53768e34b0773fedafc…
commit 32a31c5a9cc53768e34b0773fedafcadb4ffe04c
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Dec 21 22:26:37 2016 +0100
GTK: fix Export Objects sub menu warning
Change-Id: I513fd643a8c4849462ee6c4b296d86d04517b3db
Reviewed-on: https://code.wireshark.org/review/19378
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5a3d31b37729dad9a74ca889ab11b6…
commit 5a3d31b37729dad9a74ca889ab11b6db18a125d2
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Dec 21 21:46:02 2016 +0100
NAS EPS: upgrade dissector to v13.8.0
Change-Id: Ifad1fbd22984ad777278c7cc90622b205405cf1f
Reviewed-on: https://code.wireshark.org/review/19377
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=41951f98fb01726575c559d5d015b2…
commit 41951f98fb01726575c559d5d015b24879cbfb7d
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Dec 20 13:22:15 2016 +0100
[rpm-build] Add an option to exclude extcap.
Change-Id: Ibe16ad31986818fcd6e1bfbcfdd38ecc7663dd39
Reviewed-on: https://code.wireshark.org/review/19360
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Jeff Morriss <jeff.morriss.ws(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d70d32edb9f3425cb3e93dd6ff4b3d…
commit d70d32edb9f3425cb3e93dd6ff4b3d676b1b8858
Author: D. Ulis <daulis0(a)gmail.com>
Date: Wed Dec 21 10:13:53 2016 -0500
CIP: More attribute updates
1. CIP Safety: SERCOS Safety Network Number attribute should be 6 bytes. Don't
just use all remaining bytes
2. Remove cip_byte_array type. The last remaining usage was #1 above and it really
shouldn't be used in the future. Any attribute that would eat up all remaining bytes
would have issues with Get Attribute List responses and Set Attribute List requests.
3. Optional Attribute List: Display the attribute name if known.
4. Port: Display Port Number name
5. Port: Associated Communication Objects attribute
Change-Id: I94d99bb1f07aa4b8c44949b2ffb5d75e72483459
Reviewed-on: https://code.wireshark.org/review/19374
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5b1b136a29383a70875048e6474e69…
commit 5b1b136a29383a70875048e6474e69b486ecb97c
Author: Chuck Lever <chuck.lever(a)oracle.com>
Date: Mon Dec 19 14:59:39 2016 -0500
packet-rpcrdma: Fix Reply chunk selection size
When a Reply chunk is not present, selecting the "Reply chunk" in
the protocol tree should also select the four bytes of zeroes in
the header. This should work the same way as for the Read list and
Write list.
Change-Id: I0a9b7f927cad21e39189cfc1f2b619537ba26a30
Signed-off-by: Chuck Lever <chuck.lever(a)oracle.com>
Reviewed-on: https://code.wireshark.org/review/19376
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a5f1afe2b701fcd451645176fca543…
commit a5f1afe2b701fcd451645176fca5430429a08ea6
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Dec 21 13:56:45 2016 +0100
decoders(transum): fix redundant redeclaration of 'add_detected_tcp_svc’
[-Wredundant-decls]
Change-Id: I70ccf182160086a4c04467eec214857a461a2869
Reviewed-on: https://code.wireshark.org/review/19373
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c7a46477d37b5aa1de57187d1a54c9…
commit c7a46477d37b5aa1de57187d1a54c95a571e4802
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Dec 21 13:51:29 2016 +0100
transum: fix no previous prototype for ‘proto_register_transum’
[-Wmissing-prototypes]
the last one
Change-Id: I8b279d11b61645a19b0b356d52cf66eed0180700
Reviewed-on: https://code.wireshark.org/review/19372
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=fcae13f0f65c79d82cf6226752bb75…
commit fcae13f0f65c79d82cf6226752bb759c6e1ff8a4
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Dec 21 12:46:15 2016 +0100
Lua: Fix some typos.
Change-Id: I4d1cf878245b03665207a500fb7593be1435c3d3
Reviewed-on: https://code.wireshark.org/review/19371
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=031db50c64995d0879b77570f562c0…
commit 031db50c64995d0879b77570f562c0eb98d52e4a
Author: chinarulezzz <s.alex08(a)mail.ru>
Date: Wed Dec 21 06:20:55 2016 +0200
packet-tns.c: add Version and Services parsing for SNS messages.
Tested with pcaps from SampleCaptures wiki.
Change-Id: I13656ec484f276024160c8994a6750704058b2db
Reviewed-on: https://code.wireshark.org/review/19367
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=56cf6998bbe66ddc614bf04915847d…
commit 56cf6998bbe66ddc614bf04915847dc047218b39
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Dec 21 08:05:12 2016 +0100
transum: fix no previous prototype for '...’ [-Wmissing-prototypes]
Part 2...
Change-Id: Id219bd2b04de2003b5bfa4a33893d0310856275d
Reviewed-on: https://code.wireshark.org/review/19368
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=2ff7f36d707528e5689e84873f2ed0…
commit 2ff7f36d707528e5689e84873f2ed0062a20a84e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Wed Dec 21 10:39:41 2016 +0100
gsm_abis_om2000: restore offset increment removed by g1643e37
Change-Id: I34666a74f8769c63ecc982bd034b2563ba0298ff
Reviewed-on: https://code.wireshark.org/review/19370
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8cc9fd68e15c00c5ccf187678e4e8f…
commit 8cc9fd68e15c00c5ccf187678e4e8f57ad636675
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Dec 21 08:07:29 2016 +0100
gsmtap_log: fix no previous prototype for function
'proto_register_/reg_handoff_gsmtap_log' [-Wmissing-prototypes]
Change-Id: I5fbd79f056cff330dafbe57ea350768acd820b65
Reviewed-on: https://code.wireshark.org/review/19369
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a8b68205a448688c5ad9d29379eab5…
commit a8b68205a448688c5ad9d29379eab55065fcffd1
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Wed Dec 21 02:23:35 2016 +0100
packet: duplicate short_name to fix UAF in wslua
The "short_name" parameter of heur_dissector_add is defined as const
(and was assumed to be a string literal). This was no longer the case
though since a change in Lua where "short_name" is a dynamically
allocated string.
This "simple" fix clones the memory for internal use to avoid a
heap-use-after-free when heur_dissector_delete tries to access
"short_name".
An alternative option is to make Proto_register_heuristic track the
memory, but since there are multiple possible heuristics lists for a
protocol, the Proto (struct _wslua_field_t) structure is not
appropriate. A possible working alternative is to store the string into
lua_heur_dissectors_table_ref (replacing the value (function) by a tuple
{function,short_name}).
Change-Id: I6c6b393f4d304dd847e864da6ad17b54c8cd80e2
Fixes: v2.3.0rc0-1474-g7f2a838922 ("lua: Allow proto:register_heuristic to be
used on multiple list names")
Reviewed-on: https://code.wireshark.org/review/19365
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Franklin Mathieu <snaipe(a)diacritic.io>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=92cd2c3ccb93ff67127d5a64fafa19…
commit 92cd2c3ccb93ff67127d5a64fafa19b82ff7c624
Author: Etienne Dechamps <etienne(a)edechamps.fr>
Date: Sun Oct 23 11:32:29 2016 +0100
X-Rite i1 Display Pro USB protocol dissector.
This commit introduces a new dissector aimed at decoding the USB
protocol used by X-Rite i1 Display Pro (and derivatives) colorimeter. It
is based on reverse engineering work by Graeme Gill from the ArgyllCMS
project.
Change-Id: Icdfd0c3f75499d0df4360c6eb6856078de30ba56
Reviewed-on: https://code.wireshark.org/review/18901
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=4c50e4b5c4d794de3944c05bd8ce3e…
commit 4c50e4b5c4d794de3944c05bd8ce3ed778a13443
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 20 08:58:49 2016 -0500
Improve Infiniband heuristic subdissection.
Add preference in Infiniband dissector to distinguish between
heuristic and non-heuristic dissection (that uses Decode As).
Remove all of the preferences in the Infiniband subdissectors that
tried to put in "manual" heuristics and direct users to just use
Decode As. Most subdissectors still kept some basic heuristics in
their heuristic functions, but now also register with the Infiniband
dissector table for "manually" forcing dissection with Decode As.
Ping-Bug: 13259
Change-Id: I20d56eee38887664b439e52ec5f5b8f962c45ef1
Reviewed-on: https://code.wireshark.org/review/19362
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=caadaaf62317a88f99373d9095b827…
commit caadaaf62317a88f99373d9095b827102999e4e3
Author: Ethan Young <imfargo(a)gmail.com>
Date: Sun Dec 18 15:37:56 2016 -0500
Make EAPOL packet types into a dissector table.
This decouples EAPOL from the few dissectors it needs to call based
on packet type and moves registration to the dissectors themselves.
Change-Id: Ia8412fe33370f4aeece52c2c80cda7f140a950cf
Reviewed-on: https://code.wireshark.org/review/19328
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b7ee557d88841bc77f65c1fdc8b70e…
commit b7ee557d88841bc77f65c1fdc8b70ee4751624d6
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Dec 9 17:03:45 2016 -0500
Add HomePNA dissector
Ping-Bug: 12759
Change-Id: Ic4d47155168978541fb8c3670fcabaf3c35f8aad
Reviewed-on: https://code.wireshark.org/review/19187
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=56729299bd2898be0a4ce8ca4d351e…
commit 56729299bd2898be0a4ce8ca4d351e36a73851e0
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Dec 20 20:07:08 2016 +0100
ICMP: fix typo
Change-Id: Iffa10a3a14ec2ff32e51d92a1936d7e110a76bd4
Reviewed-on: https://code.wireshark.org/review/19364
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=c01d8b7da1d69c71115c378d58041c…
commit c01d8b7da1d69c71115c378d58041cb2fc53ef89
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Dec 20 20:06:53 2016 +0100
ICMP: fix indent (use always tab)
Change-Id: I939bf83ef6f6385dbad642aeef38673862c04bf0
Reviewed-on: https://code.wireshark.org/review/19363
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=98d350aeddfd85a1479dae133a2912…
commit 98d350aeddfd85a1479dae133a2912e0b2313184
Author: Your Name <you(a)example.com>
Date: Mon Dec 19 22:05:36 2016 -0500
Cast larger types to time_t
Resolves truncation warnings on the x86 clang build
Change-Id: I14ebbe39b8235bd1b909c488c0402b77deb6dde1
Reviewed-on: https://code.wireshark.org/review/19354
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=795f4eb106d877ba6f2bd30524cc87…
commit 795f4eb106d877ba6f2bd30524cc871404e9e42a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Tue Dec 13 10:33:02 2016 -0800
Qt+Win32: Make software updates more friendly.
Add WinSparkle can_shutdown and shutdown_request callbacks which are
called prior to running the installer. Reject updates when we have
unsaved information. Add notes about possible improvements.
Ping-Bug: 9687
Ping-Bug: 12989
Change-Id: Ia126244b311417aa3105ea8136f186adc2745445
Reviewed-on: https://code.wireshark.org/review/19244
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0de990e022a74aab7b6b1c9bf35849…
commit 0de990e022a74aab7b6b1c9bf35849a035327b92
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Tue Dec 20 12:04:05 2016 +0100
packet-rtp.c: Fixed problem - when ED137 header was decoded with tshark, no ED137
headers were shown.
Change-Id: Ic072212497ff084778f74d19be294a5b8ff8cbd5
Reviewed-on: https://code.wireshark.org/review/19359
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e9b4153f29100d6eb046fe5d112605…
commit e9b4153f29100d6eb046fe5d112605393b6a5697
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Dec 18 19:03:44 2016 +0100
Lua: Add string types and byte seperators support.
Add handling of STR_ASCII and STR_UNICODE as base types for string
and stringz. Add handling of SEP_DOT, SEP_DASH, SEP_COLON and
SEP_SPACE for bytes and uint_bytes. Add SEP_NONE for completeness.
Change-Id: Ida46c215fee7ec7132ec91ab5dd6cb3de4628920
Reviewed-on: https://code.wireshark.org/review/19337
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=d5fdbef7f4f103f3cd57524bc68b9a…
commit d5fdbef7f4f103f3cd57524bc68b9a1385c61363
Author: Peter Wu <peter(a)lekensteyn.nl>
Date: Sun Dec 18 16:49:24 2016 +0100
cmake,wslua,wsutil: load files from run/ instead of source tree
Fixes Lua on macOS, tested with an out-of-tree build:
WS_BIN_PATH=$PWD/run ../wireshark/test/test.sh -s wslua
Previously programs that were ran from the build directory would load
data files (radius/, diameter/, init.lua) from the source directory.
Then in the case of Lua, files were loaded from the program directory
($BUILDDIR/run/init.lua on Linux) or source directory
(sSOURCEDIR/epan/wslua/console.lua).
On macOS, this does not work for Lua since files are installed into
$BUILDDIR/run/Wireshark.app/Contents/Resources/share/wireshark/init.lua
instead. Since CMake always copies data files (radius, console.lua,
etc.) into the build directory, make get_datafile_dir() return this
"run" directory instead.
Change-Id: If97d2f5686271caf9ad4d4e4fc58e902dc592a98
Reviewed-on: https://code.wireshark.org/review/19330
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=bd0fa39c7b013486e680c701406c4f…
commit bd0fa39c7b013486e680c701406c4f75daec0a5a
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 20 13:32:53 2016 +0100
Lua: Remove an obsolete comment.
Change-Id: I6a946eb44f4a574d6d9add3604b2dac924c33a9f
Reviewed-on: https://code.wireshark.org/review/19361
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=24ecc1cf27ea15ba0f80ae28f47d5f…
commit 24ecc1cf27ea15ba0f80ae28f47d5f87e9732c5b
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Dec 20 09:41:20 2016 +0100
Gtk: don't use GTimeZone/GDateTime
Use struct tm instead.
Change-Id: I678797b93062305849875b33867faa52379c3dcb
Reviewed-on: https://code.wireshark.org/review/19356
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=d4eeeaf6d463f930c89e9026b68233…
commit d4eeeaf6d463f930c89e9026b682339e1e114b34
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Dec 17 10:08:54 2016 +0100
Lua: Add unit names support.
Add support for using unit names in ProtoField integer types by
using base.UNIT_STRING.
Add unit name table argument in ProtoField.float() and
ProtoField.double() (and made backward compatibility).
The use of base.UNIT_STRING is not really the best API for adding
unit names in Lua, but is the simples solution without adding new
arguments to ProtoField.
Change-Id: Ib5d064480cffd970a41db1764440642f6c593bb2
Reviewed-on: https://code.wireshark.org/review/19313
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=d9cc2b52260dac9830ac60239c4d80…
commit d9cc2b52260dac9830ac60239c4d80721df59b96
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Tue Dec 20 00:44:31 2016 -0800
Update comments and messages for the new name for Apple's OS for Macs.
Change-Id: I96be861220f6052cb1bc61f5f4e74e76821ff565
Reviewed-on: https://code.wireshark.org/review/19358
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=e5596b74bd41fe416a947f882a1a06…
commit e5596b74bd41fe416a947f882a1a0609b5c0892b
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Dec 9 11:52:42 2016 +0100
extcap: set help page for all extcaps.
They've been set to the manpage of the local filesystem.
Ping-Bug: 13218
Change-Id: Iacd5d2ba7ae39ee1718b59747c245d1c07785e8f
Reviewed-on: https://code.wireshark.org/review/19179
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=87a9a2989bf5f004473fb415625fe4…
commit 87a9a2989bf5f004473fb415625fe465f2d4eaad
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Mon Dec 19 15:40:59 2016 +0100
btle: Add a convenience btle.length field
Add a convenience btle.length field for easier filtering of BTLE
packets without data and with specific length ranges.
Change-Id: If56eac9c86ccf40741a6ceb50d13a1733132f448
Reviewed-on: https://code.wireshark.org/review/19348
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=1656261b955503b8d246029d3c6aa0…
commit 1656261b955503b8d246029d3c6aa0f42fe204bf
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Dec 19 21:29:27 2016 -0800
Use -bbigtoc for libwireshark on AIX (if we're using GCC or Clang).
This will have to be done differently with xlc if it's necessary.
While we're at it, fix the spelling of "Cygwin" (no InterCaps).
Bug: 13262
Change-Id: If3084cfb58f4abd9048afafecdd24c13645c2776
Reviewed-on: https://code.wireshark.org/review/19355
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=23d80b00122984535e47e5e2af8cbd…
commit 23d80b00122984535e47e5e2af8cbd4deb9b8a9e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Dec 19 10:54:50 2016 -0800
Don't use PCAP_ERROR if it's not known to be defined.
The introduction of pcap_list_datalinks() predates the introduction of
PCAP_ERROR, so the presence of pcap_list_datalinks() doesn't guarantee
that PCAP_ERROR is defined. Change the use of PCAP_ERROR when checking
the result of pcap_list_datalinks() to just check for -1.
Change-Id: Id8229b7aebd02eaf3701983f9343503397af4fb3
Reviewed-on: https://code.wireshark.org/review/19351
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=d7ce60bb080eb22808ccf304ebc400…
commit d7ce60bb080eb22808ccf304ebc400da866bae0b
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Dec 18 19:00:52 2016 +0100
Lua: Include all BASE_PT_* to base table.
Also added a note above field_display_e enum to indicate that this
values are parsed in make-init-lua.pl to build init.lua.
Change-Id: Ibd125684f9a68e1b8116fae0ccbc72147825d75d
Reviewed-on: https://code.wireshark.org/review/19336
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=a942468e0771686ea168d19c0e59fe…
commit a942468e0771686ea168d19c0e59fe443c644b88
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sat Dec 17 11:20:38 2016 -0500
Make more infiniband subdissectors heuristic.
1. Convert the Mellanox encapsulation header into a heuristic dissector.
2. Convert EtherType header dissection into a heuristic dissector.
3. Convert "heuristic preferences" to use deprecated_heur_dissector_pref.
Ping-Bug: 5061
Ping-Bug: 2672
Change-Id: Iabcac1af8e07f3f6f25f825ed56b2036c3285783
Reviewed-on: https://code.wireshark.org/review/19317
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=cf0f6ae0ae2c3d4661060655494528…
commit cf0f6ae0ae2c3d4661060655494528e8eaec2e89
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Dec 19 08:54:11 2016 +0100
transum: add Modelines info
Change-Id: I9d9ffdb7d32a940dbe155e82946d59f649cafe09
Reviewed-on: https://code.wireshark.org/review/19345
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=562954bbe6a1d1e78edb86f644385c…
commit 562954bbe6a1d1e78edb86f644385cea54e6f987
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Mon Dec 19 08:51:13 2016 +0100
transum: fix no previous prototype for '...’ [-Wmissing-prototypes]
Comment set_pkt_rrpd (not used)
Change-Id: I8d571f3cd45c51b07969132718a43244003c0f59
Reviewed-on: https://code.wireshark.org/review/19344
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dd143ca7681e2e3150904b764027e0…
commit dd143ca7681e2e3150904b764027e041927dcbf2
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Dec 18 23:38:53 2016 -0500
[SMTP] Bugfix BDAT command handling
BDAT handling takes the whole packet to add to its count of necessary
bytes, but wasn't updating the offset, so if a BDAT "data packet" had
multiple CRLF segments in it, the BDAT byte counter became inaccurate.
Bug: 13030
Change-Id: Idd44ccb95a8f4710db4546a918661c63a343260c
Reviewed-on: https://code.wireshark.org/review/19343
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=36ec6240a8bc2cc8c30a2a1a1dc217…
commit 36ec6240a8bc2cc8c30a2a1a1dc217c19fca0f4b
Author: Jan Spevak <jan.spevak(a)nokia.com>
Date: Mon Dec 12 10:48:37 2016 +0100
Added decoding of RAN/NAS cause IE/AVP
Change-Id: I889820405528be5e17edf85e52291d642a98cce6
Reviewed-on: https://code.wireshark.org/review/19216
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=047023d44371c0abcfeea3cee77793…
commit 047023d44371c0abcfeea3cee7779363d4e12974
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Sun Dec 4 23:30:46 2016 +0100
tools: add rpm-setup.sh.
This script mimics tools/debian-setup.sh for RPM based systems.
It installs all the required and optional packages to compile
Wireshark. Tested on Centos 7, Fedora 25, openSUSE Leap 42.1.
Change-Id: Ifc55f45608e5f5a74188d4fb5612bedb6437fcb1
Reviewed-on: https://code.wireshark.org/review/19088
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=3a6c5f07176d0c8f5367e092d328eb…
commit 3a6c5f07176d0c8f5367e092d328eb5f6ebf3b6b
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Dec 13 11:39:16 2016 +0100
tap-rtp-common.c: set STAT_FLAG_WRONG_TIMESTAMP when timestamp sequence is wrong
Set STAT_FLAG_WRONG_TIMESTAMP for RTP sequence when newer packet has lower timestamp
than previous one.
Change-Id: Ib18830eea33ddb3dbbdf3beba279131c0fc5a948
Reviewed-on: https://code.wireshark.org/review/19292
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0e6333cfb45d6caa33f72c208978f8…
commit 0e6333cfb45d6caa33f72c208978f8f6684a3ff5
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Sun Dec 18 21:08:16 2016 +0100
RTP analyzis dialog/Qt: fix - when dialog is called from RTP stream dialog, G (select
packet) signal is not passed to parent dialog
Problem is in 2.0 and master. It is probably in 2.2 too.
Change-Id: Iaa8adea788dcd5da7cff32d56d483a1e7d52d226
Reviewed-on: https://code.wireshark.org/review/19340
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=5f6732d74eb731f26d389f378567d2…
commit 5f6732d74eb731f26d389f378567d2dfa532f24c
Author: Kevin Hogan <kwabena(a)google.com>
Date: Mon Dec 5 23:50:45 2016 -0800
Qt: minor updates to TCP stream dialog and throughput moving average
The time-based moving average code should use a constant window size
as the denominator when calculating throughput.
Added QDoubleSpinbox widget to choose the time-based moving average size.
Also added (optional) ability to select ACK (reverse) packets as well as data
packets when clicking on the base graph.
(useful, for example, when examining SACK or DSACK packets)
Added CheckBox widget (with tooltip) for user to choose ACK selection
Change-Id: Ib3ba4f9be9e30aa8f3088b0b2d48b4ca214f7cc3
Reviewed-on: https://code.wireshark.org/review/19108
Petri-Dish: Peter Wu <peter(a)lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=05b3c067ce65149fdb837907716509…
commit 05b3c067ce65149fdb83790771650946aa948808
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Sun Dec 18 23:45:06 2016 +0100
RTSP: Decode XML data in ED-137 messages
Based on EUROCAE ED-137B specification: ED-137B, Part 4: RADIO, INTEROPERABILITY
STANDARDS FOR VOIP ATM COMPONENTS
https://boutique.eurocae.net/eshop/catalog/index.php
Can be verified with sample from Bug 13257, #18, #58, #64, #100
Change-Id: I91b7ec84b8cee8797306be1d1c0bd2af8f7b8f45
Reviewed-on: https://code.wireshark.org/review/19342
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8e19794b5ee44e2f850d7857c69537…
commit 8e19794b5ee44e2f850d7857c6953762304bc1bd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Dec 18 19:57:32 2016 +0100
decoders(transum): fix no previous prototype for ‘decode_*’ [-Wmissing-prototypes]
Change-Id: I93b24285443d99799f83c40f61f413c2d106c85f
Reviewed-on: https://code.wireshark.org/review/19338
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2612f23ad2664690c62b6e17db4659…
commit 2612f23ad2664690c62b6e17db465945b51b938c
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Dec 17 23:19:10 2016 +0100
Lua: Fix some memory leaks in error paths.
Because luaL_argerror() does a longjmp all memory free must be done
before calling this.
Also rewrote true_false_string_from_table() to be a bit simpler
and to give argument error when too many strings in the table.
Change-Id: Ied0fa468f1274155c746fe2e086dacf1a8582b08
Reviewed-on: https://code.wireshark.org/review/19325
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7d1b8dee925373da07c258bc26298f…
commit 7d1b8dee925373da07c258bc26298fc73a7bfe4a
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Sat Dec 17 17:45:40 2016 +0100
Call Flow: Fix - Duration of segment of RTP flow is wrong in call flow.
But is observed in 2.0 and later branches.
Change-Id: I46fcbb33824d30bac1999e1b61d9c249972d17f0
Reviewed-on: https://code.wireshark.org/review/19316
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4b613a174e42e78031276a1e230497…
commit 4b613a174e42e78031276a1e230497e993b1d534
Author: Jakub Pawlowski <jpawlowski(a)google.com>
Date: Tue Dec 13 17:03:55 2016 -0800
Bluetooth: BTLE: Add new commands parsing
Add "LE Set Extended Advertising Data",
"LE Set Extended Scan Response Data", and
"LE Set Extended Advertising Enable" command parser.
Change-Id: I3027dc9c213c15f503fa5495829726db3a207300
Reviewed-on: https://code.wireshark.org/review/19251
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=527eefa5132b47c431255b0681559a…
commit 527eefa5132b47c431255b0681559a9496d45eb4
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Dec 18 08:13:10 2016 -0800
[Automatic update for 2016-12-18]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I3c720c31d7ddfbef001bda47eca49ab4804e8e74
Reviewed-on: https://code.wireshark.org/review/19332
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=81fc27f5d7b7fa293faf7eca4bf36a…
commit 81fc27f5d7b7fa293faf7eca4bf36af72502c421
Author: AdrianSimionov <daniel.simionov(a)gmail.com>
Date: Sun Dec 18 13:00:17 2016 +1100
[docsis->type2ucd] Fix issue with decoding
Burst 4 and Burst 5 values are now properly decoded.
Change-Id: I6232a19eb849a419825be69435069e4be721cbc1
Reviewed-on: https://code.wireshark.org/review/19327
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=92c725cafb37067291022d3e9d05b9…
commit 92c725cafb37067291022d3e9d05b9cbf4624b6e
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Fri Dec 16 11:49:56 2016 +0100
SIP/SDP, RTP: Dissectors shows information about ED-137 related states of radio in
info column/VoIP call flow
Based on EUROCAE ED-137B specification:
ED-137B, Part 1: RADIO, INTEROPERABILITY STANDARDS FOR VOIP ATM COMPONENTS
https://boutique.eurocae.net/eshop/catalog/index.php
Bug: 13252
Change-Id: Ifab1aaf47e3405fcd46309167237f11ce2d7e2ff
Reviewed-on: https://code.wireshark.org/review/19302
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b4ea3c50f5f966896d47e7b4742668…
commit b4ea3c50f5f966896d47e7b47426682d7db3e077
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 17 22:34:29 2016 +0100
S1AP: use unit strings
Change-Id: I53a639b210592b36fc3f5aaf45db3932a469b49f
Reviewed-on: https://code.wireshark.org/review/19321
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=7eee48ad5588bc2debec0e564b3526…
commit 7eee48ad5588bc2debec0e564b3526c97a0eb125
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Wed Dec 14 22:55:05 2016 +0100
RTP: RTP dissector is able to decode RTP over TCP (RFC 4571)
Bug: 13251
Change-Id: I56a01e779f7f0eadc8a078f88543269a91148f00
Reviewed-on: https://code.wireshark.org/review/19293
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=5696b842b14c75f48021f2cc562887…
commit 5696b842b14c75f48021f2cc562887bc991a729d
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 17 22:49:29 2016 +0100
X2AP: use unit strings
Change-Id: Icac054fda0b1e1b8d79c33fc967345a7497e812b
Reviewed-on: https://code.wireshark.org/review/19322
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=667b700c220b7dd8ccffe7d997861a…
commit 667b700c220b7dd8ccffe7d997861aec8dc0487f
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 17 22:51:43 2016 +0100
M2AP: use unit strings
Change-Id: Id9aa6a48faaf749a439f0f61b5ad8d2920c56ac7
Reviewed-on: https://code.wireshark.org/review/19323
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=6292d14148e27bbf59a523b085cd2d…
commit 6292d14148e27bbf59a523b085cd2d447f1c6697
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 17 22:55:59 2016 +0100
M3AP: use unit strings
Change-Id: I433b6357914063ba7dbbe119771770e98e019091
Reviewed-on: https://code.wireshark.org/review/19324
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=934f255c07623c8ed3da7933fe2465…
commit 934f255c07623c8ed3da7933fe2465400dcf3452
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 17 21:40:49 2016 +0100
LTE RRC: use unit strings
Change-Id: Ib18301246f051f1362ba93621c533044a118189f
Reviewed-on: https://code.wireshark.org/review/19320
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=ced54aeb067065e29a621be2b6a119…
commit ced54aeb067065e29a621be2b6a1192e25a6e1bf
Author: Dmitry Lazurkin <dilaz03(a)gmail.com>
Date: Sat Dec 10 16:45:10 2016 +0300
kafka: add expert info about unsupported api key and version
Change-Id: I622e6f06529377e089cbeeb83d926135f983d3f3
Reviewed-on: https://code.wireshark.org/review/19194
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a5374d8955a0cc22005cee761c995c…
commit a5374d8955a0cc22005cee761c995cc72b638b15
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 17 23:23:32 2016 +0100
NBIFOM: upgrade dissector to v13.3.0
Change-Id: I95166c355bccc74705812f495066b55eedccedb0
Reviewed-on: https://code.wireshark.org/review/19326
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1613ee77b98335ec452ed09dab8ddf…
commit 1613ee77b98335ec452ed09dab8ddf44a38f3927
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 17 15:53:40 2016 +0100
LPP: use unit strings
Change-Id: Ic7767b9b47e200b0b0cae70e9781b417cf7d2a3b
Reviewed-on: https://code.wireshark.org/review/19315
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=93543464ff62937fd1850b343e8588…
commit 93543464ff62937fd1850b343e8588dc0d7e57e3
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Sat Dec 17 14:06:33 2016 +0100
ULP: follow-up of gda5cad4
Uniformize unit display
Change-Id: Ie89ad77be81232692ee7f4f220157d2d0cab21ea
Reviewed-on: https://code.wireshark.org/review/19314
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=01c328f0f66078f246a69cad34406d…
commit 01c328f0f66078f246a69cad34406d07a29b5602
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Wed Dec 30 21:31:10 2015 +0100
bootp: Update DHCP Message Type 53 Values
Add RFC6926 and RFC7724
Change-Id: I2e10c337f3fe3043e5c36f501eb3e29b16bfcecc
Reviewed-on: https://code.wireshark.org/review/19312
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=69dc69a5a76a9e2aa78b3d781ea0d9…
commit 69dc69a5a76a9e2aa78b3d781ea0d94bb3e8c4fd
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sat Dec 17 10:34:16 2016 +0100
bootp: fix indent (use tabs)
Change-Id: I0c16bf29631e9376b9f3b701627bd5f8fb133397
Reviewed-on: https://code.wireshark.org/review/19311
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e520d79c8af96e2ca7fa5024f595c4…
commit e520d79c8af96e2ca7fa5024f595c4b36101c6cf
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Sat Dec 17 07:23:31 2016 +0000
IPsec: Revert g232cb9a2dd
Change-Id: I9e353215c17c9a868b1cbbcd18a5707e023d86bb
Reviewed-on: https://code.wireshark.org/review/19310
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=da5cad4d68c72996d97a9923df9205…
commit da5cad4d68c72996d97a9923df9205cbf633e55e
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Fri Dec 16 23:33:49 2016 +0100
ULP: use unit strings
Change-Id: Id6cca5fa5b7547a43488e0bd83bb150ef008f48e
Reviewed-on: https://code.wireshark.org/review/19309
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=166e129e7ee7e026b44ed587d18595…
commit 166e129e7ee7e026b44ed587d185957cf45cc6c4
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Dec 16 20:35:13 2016 +0000
Improve some unit strings with unicode characters
Change-Id: Ic6812fd266832743962e020cfc8f0af2d4742fdf
Reviewed-on: https://code.wireshark.org/review/19308
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=2892cc6603820db170cefe0b593963…
commit 2892cc6603820db170cefe0b5939635bc95445d1
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Dec 16 19:57:54 2016 +0000
IPv6: Fix IPv6 fragment header offset unit display
Fragment offset unit is 8-octet, not bytes.
Reverts regression introduced in 232cb9a2dd87ea9cc9c88d4c32bfb7b452705130.
Change-Id: Id015209b45e15cd630f42ed2c3bbf342094b8ba6
Reviewed-on: https://code.wireshark.org/review/19307
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=bd494c326e81c85705cd073119efb5…
commit bd494c326e81c85705cd073119efb50446eb4bd9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Fri Dec 16 11:13:02 2016 -0800
Sort opttype_vals by the option value.
Otherwise, we get complaints when generating the value_string_ext from
it.
Change-Id: I2b4fc4c57b1f0c47706fe73187192c155593da84
Reviewed-on: https://code.wireshark.org/review/19306
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=3649993ded921c521dc2ecb57bddc0…
commit 3649993ded921c521dc2ecb57bddc09bb1f4f8c8
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Dec 16 01:42:16 2016 +0000
6LoWPAN: Make UDP NHC port endianness code cleaner
Change-Id: I7abb29a8368a91d113038bc878aaf47ed58360bb
Reviewed-on: https://code.wireshark.org/review/19298
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=f923009c77f7416d20d60d6dae60d1…
commit f923009c77f7416d20d60d6dae60d1a2bbd04245
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Dec 15 23:48:25 2016 +0000
6LoWPAN: Display UDP NHC port encoding field as 2-bit
Reference: RFC 6282 Section 4.3.3
Change-Id: I8ff46452d80b1aba4545967bc05310c341f6e174
Reviewed-on: https://code.wireshark.org/review/19297
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=1a57d810423a70563c7d1fae5c9563…
commit 1a57d810423a70563c7d1fae5c956317c242d55c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Fri Dec 16 09:35:01 2016 -0500
Rename packet-range.[ch] to packet_range.[ch]
The check*.pl scripts presume that files with the prefix "packet-"
are dissector files and therefore have different rules than other
files. Rather than trying to clarify that more with additional
directory information, just make any non-dissector file with
"packet-" filename prefix conform if it fails a "dissector
specific"
check from the scripts.
Change-Id: I7cb52e1fad4ea62320492bb690904260f958aeb4
Reviewed-on: https://code.wireshark.org/review/19304
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=70c4a0347ca02f5b8f7ed82d33e340…
commit 70c4a0347ca02f5b8f7ed82d33e340e86d0bd533
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 2 22:29:36 2016 +0100
Add GSMTAP logging sub-dissector
Applications can also use GSMTAP framing to convey log messages
which would traditionally be printed on stderr or on log files. This
allows the ordered/interspersed display of protocol messages with log
lines from the applications that send or received those messages.
The osmocom logging framework (part of libosmocore) implements this in
libosmocore.git Change-Id I9a7e72b8c9c6f6f2d76d1ea2332dcdee12394625
Change-Id: I0de723445e5b5ce0199a4081808111240a9ed047
Reviewed-on: https://code.wireshark.org/review/19183
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=0572fbb3cf2b7faff75f3d095565af…
commit 0572fbb3cf2b7faff75f3d095565af947d7ef41a
Author: Yasuyuki Tanaka <yatch(a)isl.rdc.toshiba.co.jp>
Date: Sun Dec 11 15:35:30 2016 +0100
6LoWPAN: bugfix in extracting in-line UDP checksum of IPHC
Bug: 13233
Change-Id: Ie697d5a2d8a604bf3348f690d78ada4f9f0b1b89
Reviewed-on: https://code.wireshark.org/review/19208
Petri-Dish: João Valverde <j(a)v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=41a9a1f9bf44c5b92eff49fecd5719…
commit 41a9a1f9bf44c5b92eff49fecd57194ff2dc116c
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Fri Nov 25 09:41:37 2016 +0000
autotools: Add tag glob pattern for distribution VCS version
Avoid leaking private tags and prefer vX.X.X over wireshark-X.X.X.
Ping-Bug: 12901
Change-Id: I7a4e2de283b87047e435a0b0abe72bc18819a985
Reviewed-on: https://code.wireshark.org/review/18951
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=8a0e86301b39039912a44cacbc786a…
commit 8a0e86301b39039912a44cacbc786a0c2f041d29
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Fri Dec 16 15:13:31 2016 +0100
[S1AP] Handle the case where the TransparentContainer is empty.
Change-Id: I6b2333c32119149b32beacc660b48970e0ddbae6
Reviewed-on: https://code.wireshark.org/review/19303
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=53f2b3710e9b661410dbee248fd449…
commit 53f2b3710e9b661410dbee248fd4494741d18574
Author: D. Ulis <daulis0(a)gmail.com>
Date: Wed Dec 14 10:40:44 2016 -0500
CIP: Always handle extra data
1. Generically handle/display all unparsed data. Any unparsed data can be found with
cip.data
2. This now shows at least some unparsed data that was not previously displayed.
Previously, extra data sent with Get Attribute List requests was not displayed. It was
difficult to tell why devices were returning errors, without knowing there was extra
data.
3. Make most functions return the number of bytes processed to support the above
points.
Change-Id: I290c09d76e74c18facaef99c8903e7937fbdd710
Reviewed-on: https://code.wireshark.org/review/19263
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=12fd99fcda388982944947afc4934d…
commit 12fd99fcda388982944947afc4934dcfbd39448f
Author: Eliot Lear <lear(a)cisco.com>
Date: Thu Dec 15 10:21:06 2016 -0500
[BOOTP/DHCPv6] Add new manufacturer usage description (MUD) DHCP option, which
presents a URL.
Change-Id: I152a388db2f3b8c035c80bd06dfbb9a18f10c031
Reviewed-on: https://code.wireshark.org/review/19284
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=93dec736c7f86c4958ec081fd4dd40…
commit 93dec736c7f86c4958ec081fd4dd402b3e35be76
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Thu Dec 15 23:15:51 2016 +0100
packet-rtp.c: Fix of variable names to test
Variables are removed
Change-Id: I54bb00a74255625c7ce487cfd31794fcdb9fa979
Reviewed-on: https://code.wireshark.org/review/19295
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=daf7c840fd7888dd64a70a626ddc1b…
commit daf7c840fd7888dd64a70a626ddc1b4fe3eae475
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Fri Dec 16 08:54:56 2016 +0100
Fix typo in unit_name_string units_decibels name.
Change-Id: Ib17ca3a613648667d0f99fa7412d074a205840a9
Reviewed-on: https://code.wireshark.org/review/19300
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=232cb9a2dd87ea9cc9c88d4c32bfb7…
commit 232cb9a2dd87ea9cc9c88d4c32bfb7b452705130
Author: Michael Mann <mmann78(a)netscape.net>
Date: Thu Dec 15 13:01:27 2016 -0500
Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.
Many proto_item_append_text calls were just adding a unit string to a field.
There's a better way to do that now.
Change-Id: Id18d5ac1ea4d8ecdc4cbe7ebaec07fbd2eab6e78
Reviewed-on: https://code.wireshark.org/review/19289
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8efb7fece1ffefd26dacd79f5ec872…
commit 8efb7fece1ffefd26dacd79f5ec8722c4e01e827
Author: Michael Mann <mmann78(a)netscape.net>
Date: Wed Dec 14 17:34:56 2016 -0500
Adjust proto_tree_add_xxx_format_value calls to use unit string
proto_tree_add_uint_format_value had the most use of unit strings, this
patch handles all of the other proto_tree_add_xxx_format_value calls that
could be better served using BASE_UNIT_STRING with a "unit string" in hf_
field.
Added more "common" unit string values to unit_strings.[ch]
Change-Id: I0fb680be781e10037eb7bd40dd21a9ee20c1fb1c
Reviewed-on: https://code.wireshark.org/review/19288
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d706f9c221e85992f7011baed53f5b…
commit d706f9c221e85992f7011baed53f5b31b7109493
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Dec 15 17:48:59 2016 -0800
Add symlinks to Wireshark binaries in Resources/bin, and point there.
That way, $PATH points to .../Wireshark.app/Contents/Resources/bin, so
the man command will look in
.../Wireshark.app/Contents/Resources/share/man.
This also may obviate the need to install the wrapper scripts in
/usr/local/bin, although those scripts obviate the need to re-set PATH
after installing Wireshark.
Change-Id: I7202b5a0fe5d2b90c956dc0db2af073f6c08b00d
Reviewed-on: https://code.wireshark.org/review/19296
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=8234de535022a699f6c2ac5f870cad…
commit 8234de535022a699f6c2ac5f870cad6cd7439060
Author: Graham Bloice <graham.bloice(a)trihedral.com>
Date: Thu Dec 15 19:54:01 2016 +0000
Fix release-notes.html generation
The ASCIIDOC_CONF_FILES setting for asciidoc was only generated
if any of the guides were being built.
Clean up a dup setting and some and blank lines in FindASCIIDOC
Change-Id: Ie8ab97db09e18cdb8d7e2a7bd4dcf8c288dd036f
Reviewed-on: https://code.wireshark.org/review/19291
Petri-Dish: Graham Bloice <graham.bloice(a)trihedral.com>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice(a)trihedral.com>
http://cgit.osmocom.org/wireshark/commit/?id=2c20ffa871d39457ef3e10bef3e380…
commit 2c20ffa871d39457ef3e10bef3e380e1c86e9661
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Dec 15 11:42:50 2016 -0800
Update tools/commit-msg.
Update tools/commit-msg to version 2.12.7 by running
curl -Lo tools/commit-msg
https://code.wireshark.org/review/tools/hooks/commit-msg
Change-Id: Ie70a8e869968b5237c9e21c0624f1f8af696d83b
Reviewed-on: https://code.wireshark.org/review/19290
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=08a6925ced4fbf97ab679dcd4795d9…
commit 08a6925ced4fbf97ab679dcd4795d95fc78c19b3
Author: João Valverde <joao.valverde(a)tecnico.ulisboa.pt>
Date: Thu Dec 15 18:15:09 2016 +0000
UDP: Add missing space to string
Change-Id: I0b5a60d426b2d06441323d74aa973e1b700d4f03
Reviewed-on: https://code.wireshark.org/review/19286
Reviewed-by: João Valverde <j(a)v6e.pt>
http://cgit.osmocom.org/wireshark/commit/?id=0d3fd95733dcc75c8967892e852814…
commit 0d3fd95733dcc75c8967892e85281436c23748a6
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Dec 15 09:32:53 2016 -0800
Update the release notes.
Change-Id: Id26548a1c262a91e4fe0a4c44dcb578b5b4e5c11
Reviewed-on: https://code.wireshark.org/review/19285
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=c8b96ef1a9b34faf5bb869b40a4c1e…
commit c8b96ef1a9b34faf5bb869b40a4c1e2c71590cd7
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Thu Dec 15 14:49:31 2016 +0100
[GTPv2] Fix dissection of MM Context fpr EPS
Change-Id: I1ee7f4caa23834ac8bcbd56731c116a785b67d6b
Reviewed-on: https://code.wireshark.org/review/19283
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e7ba5d78ea49abd28a34696f631271…
commit e7ba5d78ea49abd28a34696f631271d5b3338471
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Dec 13 12:40:47 2016 +0100
packet.c: add initializer.
As per glib manual, GSLists need to be NULL initialized.
Change-Id: If78904b900f6ddd7a0afaf3a1c480ec7626f2027
Reviewed-on: https://code.wireshark.org/review/19281
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=c65e5851b2eef0ef99e4cb9388eb78…
commit c65e5851b2eef0ef99e4cb9388eb780cd6a87aa7
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Thu Dec 15 00:29:38 2016 -0800
Make some items that don't need to be size_t guint.
Those sizes are limited by the packet sizes we support, and we only
support a maximum packet size of 2^32.
This squelches some compiler warnings.
Remove some casts that this renders unnecessary.
Change-Id: Id9a7bcf8c2ce30bbed7be6c0e28deb9cf38002e0
Reviewed-on: https://code.wireshark.org/review/19279
Petri-Dish: Guy Harris <guy(a)alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e6a9877c7177978ff655d6f61d7540…
commit e6a9877c7177978ff655d6f61d7540fb835ea165
Author: Nora Sandler <nsandler(a)securityinnovation.com>
Date: Thu Dec 8 16:54:37 2016 -0800
Improved parsing of sniffed homeplug-av data
This patch modifies the homeplug-av dissector to better decode sniffer data according
to the IEEE 1901-2010 standard.
The dissector now decodes MPDU variant fields correctly based on delimiter type, and
decodes beacon MPDU payloads.
There are some variable-length fields it doesn't handle yet.
This patch should have no effect on how non-sniffer-data packets are decoded.
These changes are based on Andrew Margolis' pull request to faifa at
https://github.com/ffainelli/faifa/pull/11
Change-Id: Ia60ac7affa99a68b38f04ab66373ac715c761328
Reviewed-on: https://code.wireshark.org/review/19156
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e1e6195cdd40fe36c1c62ee40fcf7b…
commit e1e6195cdd40fe36c1c62ee40fcf7bcc746ab2fc
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Dec 13 21:02:21 2016 +0100
802.11(ad): fix wrong dissection of Grant Frame
See 8.4a.2 from 802.11ad-2012(.pdf)
Issue reported by Hany ASSASA
Ping-Bug: 13244
Change-Id: I6e22de3009b722e61b30ce2dd93596c4f51bb2fe
Reviewed-on: https://code.wireshark.org/review/19243
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=85266a0f720bae8b527dc6f130e069…
commit 85266a0f720bae8b527dc6f130e0697d61622d52
Author: Роман Донченко <dpb(a)corrigendum.ru>
Date: Wed Dec 14 23:55:31 2016 +0300
pkixtsp: add support for dissecting CMS signature time-stamps
As per RFC 3161 Appendix A. The ASN.1 elements it defines are not
officially part of any module, so just stick them into PKIXTSP.
Change-Id: I728505cb305b924465b62eb442288edea7f916a7
Reviewed-on: https://code.wireshark.org/review/19272
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=104b1029486e3a656c9abefa733bc0…
commit 104b1029486e3a656c9abefa733bc038563afa43
Author: chinarulezzz <s.alex08(a)mail.ru>
Date: Wed Dec 14 18:43:07 2016 +0200
packet-tns.c: Oracle 12c packet length fix.
In some messages (observed in Oracle 12c) packet length has 4 bytes
instead of 2.
Tested with oracle12-example.pcapng from SampleCaptures wiki.
Also small datatype fix.
Change-Id: I35490ade8cf0dee6392f4fa1b51d8dc7cff85400
Reviewed-on: https://code.wireshark.org/review/19264
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=bdd166f4a76e0990ad08027e541c3d…
commit bdd166f4a76e0990ad08027e541c3db24f7ca273
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Wed Dec 14 19:37:04 2016 +0100
VoIP Calls/Flow Sequence: Fix of showing nodes from previous call
When VoIP Calls/Flow Sequence generates list of nodes to show (nodes above flow), it
do not clear the list from last call. As consequence of it, when second call is between
hosts than first call, you see nodes which are not involved in call.
Change-Id: I80f9acb09e6aa71b3a32bb6eacaeb5b4bb13b332
Reviewed-on: https://code.wireshark.org/review/19267
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9090afbfe9a4f9a422409c3f9d410b…
commit 9090afbfe9a4f9a422409c3f9d410bc3c14fc741
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Tue Dec 13 13:28:30 2016 +0100
Save RTP audio to file: RTP Stream Analysis dialog allows save audio for non G.711
codecs and mixed codecs
- spaghetti code for save was split into separate functions
- code saves G.711 only, all other codecs are saved as silence with correct duration
- code is ready to include other codecs
- code supports 8000 Hz sampling rate only, other rates are rejected with warning
- bidirectional stream (forward and reverse) creates stereo .au file
- output is based on timestamps in RTP streams
- save operation is slower than before because it is set of seek() - one per each
codec sample
- code allows align of save audio:
- as it is - each stream is saved from its beginning, no aling
- to start of each other - later stream is prepended with silence
- align saved audio to beginning of capture file - each stream is prepended with
silence
- save to raw works correctly now - only payload is saved
- old code was inserting G.711 silence time to time to raw data
Bug: 13242
Change-Id: I74d02a1cc1c75acf9ffe930d078c00a0555cbfb6
Reviewed-on: https://code.wireshark.org/review/19245
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1afbab69956c32b341001dd20ff667…
commit 1afbab69956c32b341001dd20ff667036fe1f8f5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Dec 14 15:02:33 2016 -0800
Just use strncmp() to check the prefix of the file's first line.
Bug: 13246
Change-Id: I9df35596aa8dcb937f6a03cf60b5d0fbe9dce1ec
Reviewed-on: https://code.wireshark.org/review/19276
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=5fdbb7a5ac8a0a68b42264bde094b9…
commit 5fdbb7a5ac8a0a68b42264bde094b90d455350e5
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Wed Dec 14 14:42:54 2016 -0800
Don't assume we've read a line long enough to contain a magic number.
Check the length of the line first.
Bug: 13246
Change-Id: I906bb652594898061afb4b2cd4edb916af354161
Reviewed-on: https://code.wireshark.org/review/19273
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=f78b60dce827522195e0c5317a46aa…
commit f78b60dce827522195e0c5317a46aadeff76ef86
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Dec 14 20:27:54 2016 +0100
nordic_ble: Add legacy version support
Added back legacy version (<= 0.9.7) support after restructuring
for dissector completeness.
Change-Id: I5355bf8faa1b9fd8ee9056254048fe5c314b6efb
Reviewed-on: https://code.wireshark.org/review/19271
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=41f28901104931cb4131f1359e62dd…
commit 41f28901104931cb4131f1359e62dd586fb4f991
Author: Michal Labedzki <michal.labedzki(a)tieto.com>
Date: Sun Nov 3 18:57:17 2013 +0100
Bluetooth profile: configure columns and layout for Bluetooth
Change-Id: Iab8e33b5a7b62eea9c1365e0e5fec84f0ccd23fe
Reviewed-on: https://code.wireshark.org/review/17080
Petri-Dish: Michal Labedzki <michal.tomasz.labedzki(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=3032e800510c46b26567346b9e900a…
commit 3032e800510c46b26567346b9e900ae5e202367f
Author: Роман Донченко <dpb(a)corrigendum.ru>
Date: Wed Dec 14 21:35:00 2016 +0300
cms: remove trivial differences between the ASN.1 code and RFC 5652
This clears up the diff between the local copy of the CMS module and
upstream, making it easier to determine what modifications were made.
Change-Id: I466cb97e6505ea8075d01663e1ede95b85468898
Reviewed-on: https://code.wireshark.org/review/19269
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1c8223dbdff2aeb08848f4fae28b45…
commit 1c8223dbdff2aeb08848f4fae28b457b14f593b2
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Fri Dec 9 11:44:11 2016 +0100
extcap: add info to extcap manpage (taken from README.extcap).
Ping-Bug: 13218
Change-Id: Ib43dc2ce8ae7991468b866aec3f03f6a5709f8b2
Reviewed-on: https://code.wireshark.org/review/19177
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=07ffcf90426b05082e95b71268181f…
commit 07ffcf90426b05082e95b71268181f108fc7403b
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Dec 14 13:43:27 2016 +0100
extcap: Avoid double free of help.
Avoid double free of help when having multiple extcap interfaces.
Ping-Bug: 13218
Change-Id: I6a0d6afd645787f9814c02e84079b4e8763d05f1
Reviewed-on: https://code.wireshark.org/review/19261
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Dario Lombardo <lomato(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=978a30bd23d37b580afa642ce1b262…
commit 978a30bd23d37b580afa642ce1b262b3dbd2e899
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Wed Dec 14 10:17:42 2016 +0100
nordic_ble: Improved dissector code
- Added header fields in a new subtree.
- Restructured to use fewer functions and to use offset
counting instead of offset defines.
- Removed support for legacy version 0.9.7.
- Removed unused code.
Change-Id: I9eb6c8b3b450ddb95fb0f4bdd9f9717dafa687b0
Reviewed-on: https://code.wireshark.org/review/19260
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=fc8f787565a485b2b932bd4f58069c…
commit fc8f787565a485b2b932bd4f58069cfbe59edc1d
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Tue Dec 13 19:28:29 2016 +0100
Skip loading the Nordic BLE Sniffer dll on WIN32
The dissector for the Nordic BLE Sniffer was added as internal in
g7844a118, so ensure we don’t load this third party dll on WIN32.
Change-Id: I74c200d42793f3c1e764bc9f6c3a9a795d38a5a7
Reviewed-on: https://code.wireshark.org/review/19259
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=1c2d224647f7223a6f26e16fda5edb…
commit 1c2d224647f7223a6f26e16fda5edba99b33d4bb
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Thu Dec 8 17:56:22 2016 +0100
extcap: set help for interfaces.
The help statement is in the first sentence, while interfaces are
in others. We need to keep state of it.
Ping-Bug: 13218
Change-Id: Iad1d403d5e8bc34e2489daaa3b14d469d5ee5b5b
Reviewed-on: https://code.wireshark.org/review/19148
Petri-Dish: Dario Lombardo <lomato(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=39050d3e2f981e7ee432edd0715a5e…
commit 39050d3e2f981e7ee432edd0715a5e3eb04f6e1f
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Mon Dec 5 12:33:02 2016 +0100
README.extcap: impagination improvement.
Change-Id: I1cc0dc6496bea8e42c199dff116530ccec6fb591
Reviewed-on: https://code.wireshark.org/review/19089
Reviewed-by: Roland Knall <rknall(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=da06f7c8b5e49d288114db619c7e36…
commit da06f7c8b5e49d288114db619c7e365cf1a7a649
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Mon Dec 12 21:13:34 2016 +0100
RTP Stream Analysis: save Audio allows any filename extension
Format of file selected by user is derived from save dialog format selection, not from
filename as before.
Bug: 13240
Change-Id: Id6e159d97e4f26c25b3d2d98d43041d8617cc737
Reviewed-on: https://code.wireshark.org/review/19240
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=e6dcb061b57f081e4803b804f221d3…
commit e6dcb061b57f081e4803b804f221d328914eee56
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Mon Dec 12 20:57:40 2016 +0100
RTP Stream Analysis dialog: dialog shows when forward/reverse stream starts
Dialog shows time (relative to capture start) and packet number when forward and
reverse stream starts. It shows difference in such values on bottom of dialog too.
Bug: 13239
Change-Id: If807b8a56723df17ed131b1aac053cf8f985bb7b
Reviewed-on: https://code.wireshark.org/review/19239
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b1ed5284a3166d0dc169c3f9ae5cf9…
commit b1ed5284a3166d0dc169c3f9ae5cf9da14b37fea
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 21:06:49 2016 -0500
Remove add_item_text
It's a manual attempt at what proto_tree_add_bitmask can do anyway.
Change-Id: If551e8afa346a33b8e15dc441aae75ba0752ab46
Reviewed-on: https://code.wireshark.org/review/19257
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=8156e138481a16e577399f9950430f…
commit 8156e138481a16e577399f9950430fb56a1dabdb
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 19:40:45 2016 -0500
packet-lsc.c: Use proto_tree_add_item instead of manually fetching field values.
Change-Id: I60740615de02bc5047eaca618973064513ac7b56
Reviewed-on: https://code.wireshark.org/review/19256
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=d346d8a7222ac6d1b60e94a8ec5645…
commit d346d8a7222ac6d1b60e94a8ec5645ace46c5735
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 19:28:32 2016 -0500
packet-kerberos4.c: Use encodings instead of boolean little vs big endian.
Also use proto_tree_add_item_ret_length for string handling.
Change-Id: Id1eae2e51460a3b7f4c3385b9b1fd7f12398a227
Reviewed-on: https://code.wireshark.org/review/19255
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a8d06c7008bc2e82711e063641c4c2…
commit a8d06c7008bc2e82711e063641c4c2ba731cb08c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 19:08:40 2016 -0500
packet-nbt.c: General cleanup
1. Remove functionality that was replaced by a proto_tree_add_bitmask
2. Remove use of nbdgm_header structure which is just a useless placeholder
3. Remove some if (tree) over single fields.
Change-Id: I0879043685686eb5b861cf77ec38bbf25ed6044e
Reviewed-on: https://code.wireshark.org/review/19254
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b585c7275bb0d9e5dafb4e3ae2f057…
commit b585c7275bb0d9e5dafb4e3ae2f057ce6d333d5c
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 18:11:02 2016 -0500
file-jpeg.c - Pacify pre-commit hooks by removing macro
IMG_JFIF was trying to be a macro for all display and expert info filters.
This messed with the pre-commit scripts ability to ensure protocol
filter name was being used as the prefix for display and expert info
filters. So replaced IMG_JFIF with the proper prefix - "image-jfif"
Change-Id: I1fe3dc8797529c9d17f75c511bc279824e7e69b0
Reviewed-on: https://code.wireshark.org/review/19253
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=f41e3bfd358bcf3a0e060cee72b4fc…
commit f41e3bfd358bcf3a0e060cee72b4fc1464fe2d78
Author: Dario Lombardo <lomato(a)gmail.com>
Date: Tue Dec 13 12:27:04 2016 +0100
cmake: add semicolon to file list.
The file list contains semicolon-separated list of files to check.
When merging the lists we need to separate them properly.
Error:
No such file: "packet-ncp2222.cpacket-coseventcomm.c" at
wireshark/tools/checkAPIs.pl line 2050.
Change-Id: I19702ab85408caf69ed922732fce74c3058be640
Reviewed-on: https://code.wireshark.org/review/19237
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=b7f4e250599d7ea0452711d388c161…
commit b7f4e250599d7ea0452711d388c161fd4ef61c60
Author: Michael Mann <mmann78(a)netscape.net>
Date: Tue Dec 13 14:26:27 2016 -0500
Adjust proto_tree_add_uint_format_value calls to use unit string
Several calls to proto_tree_add_uint_format_value could be better served
using BASE_UNIT_STRING with a "unit string" in hf_ field. There also
a few cases where proto_tree_add_uint_format_value could just be
proto_tree_add_uint.
Added a few more "common" unit string values to unit_strings.[ch]
Change-Id: Iaedff82c515269c9c31ab9100dff19f5563c932d
Reviewed-on: https://code.wireshark.org/review/19242
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=a869ec6f55160622a90bc437517dee…
commit a869ec6f55160622a90bc437517dee91d57f85d5
Author: Michael Mann <mmann78(a)netscape.net>
Date: Mon Dec 12 13:22:05 2016 -0500
Adjust proto_tree_add_[float|double]_format_value calls to use unit string
Several calls to proto_tree_add_[float|double]_xxx could be better served
using BASE_UNIT_STRING with a "unit string" in hf_ field.
Added a few more "common" unit string values to unit_strings.[ch]
Change-Id: Id0da7b579403898d20c2667d6c4abcd59d5a48d4
Reviewed-on: https://code.wireshark.org/review/19241
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=e150235ef14cf6a9ada7d74c534e4a…
commit e150235ef14cf6a9ada7d74c534e4aee469f3ac5
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Dec 12 11:34:03 2016 -0800
Qt: Optionally restore our selected packet when thawing.
Stash the current row when we freeze the packet list. Make it possible
to restore it when thawing. Do so when the layout changes and when we
move a column.
Change-Id: I44cfb8bafcd4d49a46e1c89bf47aecf5ac139773
Reviewed-on: https://code.wireshark.org/review/19222
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=6f3fed904d0ceee39b086408117d7f…
commit 6f3fed904d0ceee39b086408117d7fc1f79ef63f
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Tue Dec 13 22:15:28 2016 +0100
win-setup.ps1: add missing zlib-1.2.8-ws folder
Change-Id: Ie32a231146365c11fe80e9e4f414ef7c464a8249
Reviewed-on: https://code.wireshark.org/review/19247
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=588f52537edb18a2488e1e16c87875…
commit 588f52537edb18a2488e1e16c8787507c034bfa1
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Tue Dec 13 11:39:16 2016 +0100
imf: fix no newline at end of file [-Wnewline-eof]
Change-Id: Ibddfbb049fdf8510ffc14fbadba7484300821888
Reviewed-on: https://code.wireshark.org/review/19236
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=31a53fdb9cce393a404c46599466ae…
commit 31a53fdb9cce393a404c46599466ae7da719a43c
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Mon Dec 12 20:30:29 2016 +0100
rtp_analysis_dialog.cpp: RTP Stream Analysis dialog shows same SSRC for forward and
reverse stream
Same SSRC is shown because of typo in variable name for reverse stream.
Bug: 13236
Change-Id: Idcba4d83c7b4358cd8ebf1ee5c5b5bde2fc2e48b
Reviewed-on: https://code.wireshark.org/review/19238
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4e97f74f1156db5c2cb139a404bc64…
commit 4e97f74f1156db5c2cb139a404bc6423cebf7236
Author: Michael Mann <mmann78(a)netscape.net>
Date: Sun Dec 11 19:16:52 2016 -0500
Add support for adding unit names to hf_ fields.
This was inspired by the
https://www.wireshark.org/lists/wireshark-dev/201505/msg00029.html thread.
Used TCP and NTP dissectors as the guinea pig with sample use.
Documentation updates includes some unrelated cleanup just because it was noticed.
Change-Id: I59b26e1ca3b95e3473e4757f1759d7ad82976965
Reviewed-on: https://code.wireshark.org/review/19211
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=97b41a494c214161b358cc99fad843…
commit 97b41a494c214161b358cc99fad843a6f061b283
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Tue Dec 13 09:52:31 2016 +0100
[RTP Analysis] calculate BW correctly whem IPv6 is used.
Change-Id: Ia53efa57042d199673a77c59491215c0e99c9e84
Reviewed-on: https://code.wireshark.org/review/19235
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=f530b58bb5579e2727f76efa4d72d5…
commit f530b58bb5579e2727f76efa4d72d5025ea6bad1
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sun Dec 11 14:18:55 2016 +0100
bthci_acl: Set src/dst addresses before reassembly.
Set all addresses before we do reassembly because sub-dissectors may set
their own addresses, and we don't want to override them again.
This fixes "Follow TCP Stream" and shows the correct IP addresses in the
Source and Destination columns when transporting IP packets.
Allocate the addresses in pinfo pool to avoid possible stack buffer overflow.
Bug: 13230
Change-Id: I3b81ccb02b38331add4773d9bb3d5e0f6dcf025e
Reviewed-on: https://code.wireshark.org/review/19201
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Stig Bjørlykke <stig(a)bjorlykke.org>
http://cgit.osmocom.org/wireshark/commit/?id=9d85c4f0b75ac40409423f1e82e82b…
commit 9d85c4f0b75ac40409423f1e82e82b4a154c0870
Author: Роман Донченко <dpb(a)corrigendum.ru>
Date: Fri Dec 9 00:19:25 2016 +0300
ssh: add dissection for Elliptic Curve Diffie-Hellman KEX
The protocol is actually nearly identical to ordinary Diffie-Hellman,
but the names are different, and the ephemeral keys are bytestrings
rather than integers.
Change-Id: I261b6426137dae12fe53686e74517080abd80bb3
Reviewed-on: https://code.wireshark.org/review/19210
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=79babc6f22879763d49ea2e802a44a…
commit 79babc6f22879763d49ea2e802a44ace0e89bd53
Author: Arjen Zonneveld <arjen(a)bz2.nl>
Date: Fri Dec 2 13:20:18 2016 +0100
Add BGP dissector support for draft-ietf-idr-shutdown-01
Parse the communication bits of a BGP Cease NOTIFICATION:
Border Gateway Protocol - NOTIFICATION Message
Marker: ffffffffffffffffffffffffffffffff
Length: 146
Type: NOTIFICATION Message (3)
Major error Code: Cease (6)
Minor error Code (Cease): Administratively Shutdown (2)
BGP Shutdown Communication Length: 124
Shutdown Communication: NTT will perform maintenance on this router. This is
tracked in TICKET-1-24824294. Contact noc(a)ntt.net for more information.
Draft at https://tools.ietf.org/html/draft-ietf-idr-shutdown-01, sample
file taken from from http://instituut.net/~job/shutdown.pcap
Change-Id: I2ab633883cc69e560ff79cb6239e02fcffd71e10
Reviewed-on: https://code.wireshark.org/review/19144
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=8d59678483bc90d0fad356338e3dc4…
commit 8d59678483bc90d0fad356338e3dc413e4655585
Author: Jakub Pawlowski <jpawlowski(a)google.com>
Date: Mon Dec 12 19:27:58 2016 -0800
Bluetooth: BTLE: Add new commands parsing
Add "LE Set Extended Advertising Parameters" and
"LE Set Extended Advertising Parameters" commands parsing.
Change-Id: Ibcc9f145694e54710da3a11ade237f7132674366
Reviewed-on: https://code.wireshark.org/review/19234
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=693dcd276e556033b1176d16f4ea25…
commit 693dcd276e556033b1176d16f4ea257ae3e68ea5
Author: Pascal Quantin <pascal.quantin(a)gmail.com>
Date: Mon Dec 12 21:42:14 2016 +0100
Build TRANSUM plugin
Add plugin to autofoo and CMake build systems and fix errors found
Add plugin to Windows installer (optional component activated by default)
Change-Id: Id1b777bdee04e53076b3291f6fb68d5abad6985d
Reviewed-on: https://code.wireshark.org/review/19228
Petri-Dish: Pascal Quantin <pascal.quantin(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=862905da1b84e1997e2b2a5d4ae8bb…
commit 862905da1b84e1997e2b2a5d4ae8bbaaedb804de
Author: David Barrera <davidbb(a)gmail.com>
Date: Mon Dec 12 11:06:42 2016 +0100
Change spaces to tab for recent wka entries
Commit 66549a9cacb29abdbb2c6fdaaf8235c4f34f6a13 added 3 new entries to
wka.tmpl, but used spaces instead of the default tab separator. This
inconsistency causes external tools that expect tabs in the manuf file
to behave unexpectedly.
The manuf file was re-generated after the fix to wka.tmpl.
Change-Id: I79bceac649e0fc29b3502fc2e074dcd513f29ff5
Reviewed-on: https://code.wireshark.org/review/19217
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=809523433df8134a22bca4a100c8c8…
commit 809523433df8134a22bca4a100c8c83e729214b3
Author: Jakub Pawlowski <jpawlowski(a)google.com>
Date: Mon Dec 12 17:56:32 2016 -0800
Bluetooth: BTLE: Add BT5.0 command and event name parsing
Change-Id: I830551959965896451ddc08f3e843b61f22eed67
Reviewed-on: https://code.wireshark.org/review/19233
Reviewed-by: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=9f9086c392d75487087c1acf2eac24…
commit 9f9086c392d75487087c1acf2eac246276b692a9
Author: Parav Pandit <paravpandit(a)yahoo.com>
Date: Sat Dec 10 03:00:09 2016 -0500
packet-infiniband: Update conversation src port for exact lookup
Dissectors above infiniband (such as RPC dissector)
performs exact lookup on saddr, daddr, sport, dport. They are unaware
that underlying transport is infiniband which doesn't have src_qp in
packets. Due to which srcport remains uninitialized and exact lookup
fails.
In order to get them work seemlessly, this fix updates the sport
to src_qp (similar to destport to dest_qp). With this upper level
dissectors can perform direct lookup similar to TCP. Those which need to
access private data of unidirectional CM messages, can still continue to
perform unidirectional lookup as before.
It also fixes the issue where req_qp and resp_qp were swapped during
bidirectional conversation creation. This was caught during testing with
packet-rpc.c by Chuck Lever.
Tested protocols:
1. nfs-rdma over Infiniband with trace of Bug 13213
2. ICMP packets over Infiniband
3. NVMe fabrics over RDMA
Tested with trace of Bug 13201 for Nvme.
Bug: 13202
Bug: 13213
Change-Id: Ica1b6aae3ccaa6642dc3b3edfa9a5a4c335cc5da
Tested-by: paravpandit(a)yahoo.com
Reviewed-on: https://code.wireshark.org/review/19190
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Chuck Lever <chuck.lever(a)oracle.com>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=dd816a121829f8129dc70b70c25d83…
commit dd816a121829f8129dc70b70c25d83eed08e279a
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Thu Dec 8 09:41:47 2016 -0800
Update to WinSparkle 0.5.3.
Update our WinSparkle package to 0.5.3. This fixes a file deletion bug.
Note that WinSparkle now supports application shutdown callbacks, which
should let us fix bugs 9687 and 12989.
Bug: 13217
Change-Id: I4b5f325c6dc251ce167f7bd344bbf3ca5ad3fe14
Reviewed-on: https://code.wireshark.org/review/19230
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=ce54bfe055a8f1f674f0fe19fa0236…
commit ce54bfe055a8f1f674f0fe19fa0236e89744cddd
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Dec 12 14:03:25 2016 -0800
Remove some GtkCList comments and code.
Remove some comments and hopefully-no-longer-necessary code specific to
GtkCList.
Change-Id: Ib62387f87e662798afba282cf95cbd215d60075e
Reviewed-on: https://code.wireshark.org/review/19227
Petri-Dish: Gerald Combs <gerald(a)wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=7ad655c9b69f017f880dfd1cd1d0ec…
commit 7ad655c9b69f017f880dfd1cd1d0ec4a04479e2b
Author: Jiri Novak <j.novak(a)netsystem.cz>
Date: Mon Dec 12 13:26:53 2016 +0100
rtp_player_dialog.cpp: fix usage of unsupported method QComboBox::setCurrentText with
Qt4.x
QComboBox::setCurrentText() method is available in Qt5.x.
Older versions code won't compile with it.
Bug: 13235
Change-Id: Ia2e2713fefe0f2be01a0b77ff1ac39c9162fd0d1
Reviewed-on: https://code.wireshark.org/review/19219
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Peter Wu <peter(a)lekensteyn.nl>
http://cgit.osmocom.org/wireshark/commit/?id=9e9b5ecc0c001b8f742746b2b9f010…
commit 9e9b5ecc0c001b8f742746b2b9f0104bab9a9d9a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Dec 12 13:12:26 2016 -0800
Move the declaration of packet_list_select_last_row() to ui/gtk/packet_list.h.
It's GTK+-only, so it shouldn't be in ui/ui_util.h. Get rid of the
unused Qt packet list implementation of it.
Change-Id: Ia9f8fe2209939dff5244e6948c36f29509340f68
Reviewed-on: https://code.wireshark.org/review/19226
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=334485f65b1f35b193b18780cb7c16…
commit 334485f65b1f35b193b18780cb7c166f62e1ffc9
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Dec 12 12:57:12 2016 -0800
Get rid of some GTK+-only routines in file.c.
Just directly call the packet_list_select_ routine from the GTK+ code.
Change-Id: I9146fb968c407d6186b146a86aa34678765f7352
Reviewed-on: https://code.wireshark.org/review/19225
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=eb1307a099ad1ed77cc70d501ab332…
commit eb1307a099ad1ed77cc70d501ab33284fcdb444d
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Mon Dec 12 12:34:26 2016 -0800
Mark routines GTK+ only.
Mark packet_list_select_last_row and cf_goto_bottom_frame GTK+ only.
Change-Id: I158814c2fa8c5fa8021b7156dded0945535c978a
Reviewed-on: https://code.wireshark.org/review/19223
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=128246bffbdfc2f30183689c2f9d9e…
commit 128246bffbdfc2f30183689c2f9d9e4f676ca520
Author: D. Ulis <daulis0(a)gmail.com>
Date: Sun Dec 11 18:52:26 2016 -0500
Do not set Qt Window focus when highlighting rows
Bug: 11890
Change-Id: I372f096c1ac0e483bf49cf95831e3df43621a642
Reviewed-on: https://code.wireshark.org/review/19209
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=d6d2b597310c610d5b53d8225f0d94…
commit d6d2b597310c610d5b53d8225f0d9494f800d706
Author: AndersBroman <anders.broman(a)ericsson.com>
Date: Mon Dec 12 14:21:03 2016 +0100
[RTP] In case no conversation is found, check if we have a dissecor for
the dynamic payload type defined. If so set the dynamic
payload_type_string to that dissectors name.
This is for RTP analysis to work if there is no setup information in the
file.
Change-Id: I7ae7b957cfa9eb6013f7d32d50563e2034210af6
Reviewed-on: https://code.wireshark.org/review/19220
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=b604fff1363e40f2327bd5765264f6…
commit b604fff1363e40f2327bd5765264f687eb1ec04a
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Dec 12 00:19:44 2016 -0800
Rename non-EBCDIC-specific routines.
Those routines can handle any single-byte character set whose characters
map to characters in the Basic Multilingual Plane; it could be used for
extended ASCII, but we have another routine for that, mapping only
characters with code points > 0x7f, so we just say "nonascii" rather
than "ebcdic".
Change-Id: I3d55b5d58e3e7ab08f3dfbfdb57a0301a30e71d4
Reviewed-on: https://code.wireshark.org/review/19214
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=7eea6f2f7cabade40647114cab0af7…
commit 7eea6f2f7cabade40647114cab0af75f375b849e
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Mon Dec 12 00:06:35 2016 -0800
Update for library changes.
Change-Id: Ibe63e79a2865c53be0aafbf1b53103267a502b7a
Reviewed-on: https://code.wireshark.org/review/19213
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=4d47c9a84144510a33747801cf4ef6…
commit 4d47c9a84144510a33747801cf4ef65f1b3da422
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sun Dec 11 21:49:14 2016 -0800
Fix handling of EBCDIC string fields.
Have a routine that takes a 256-element translation table and uses it to
map various flavors of EBCDIC to Unicode. Have separate translation
tables for "common" EBCDIC (everything that's the same in all EBCDIC
code pages that include the original EBCDIC characters) and EBCDIC code
page 037. Add ENC_EBCDIC_CP037 for code page 037.
Change-Id: Ia882b3c0abef9e30eb54cd47396e6fa0d6342044
Reviewed-on: https://code.wireshark.org/review/19212
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=6bc65121287e585d06755b3406c571…
commit 6bc65121287e585d06755b3406c571ad9ba4d766
Author: Роман Донченко <dpb(a)corrigendum.ru>
Date: Sun Dec 11 03:21:52 2016 +0300
ssh: correct inaccurate field names/abbrevs/id variable names
* kex_first_packet_follows -> first_kex_packet_follows
That's the name the spec (RFC 4253) uses.
* DH H signature -> H signature, DH host key -> host key
Neither the host key nor the H signature have much to do
with Diffie-Hellman. They're used in the same way in
every key exchange method that I know of, so their names
should be more generic.
* mpint_[ef] -> dh_[ef], mpint_[pg] -> dh_gex_[pg]
This is to make all key exchange method-specific fields follow
a consistent pattern with all names/abbrevs being prepended
by the method name.
Change-Id: Ic887fb92d8cbb6042e9b8e553cb5804db0ba4db8
Reviewed-on: https://code.wireshark.org/review/19199
Petri-Dish: Anders Broman <a.broman58(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=a494d1d51d9566dc12716086b61361…
commit a494d1d51d9566dc12716086b61361d7ac6b6390
Author: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Date: Sun Dec 11 21:00:06 2016 +0100
smb/tftp: fix no previous prototype for ‘tftp/smb_eo_cleanup’ [-Wmissing-prototypes]
Change-Id: I22ce7c49eab9232d38ace51a39fee098786f981d
Reviewed-on: https://code.wireshark.org/review/19206
Petri-Dish: Alexis La Goutte <alexis.lagoutte(a)gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Anders Broman <a.broman58(a)gmail.com>
http://cgit.osmocom.org/wireshark/commit/?id=035fbe21f9a3bc658f34ac65d9fd48…
commit 035fbe21f9a3bc658f34ac65d9fd4862364cdb07
Author: Gerald Combs <gerald(a)wireshark.org>
Date: Sun Dec 11 08:12:37 2016 -0800
[Automatic update for 2016-12-11]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: Ie1a890ea3d5cfab844bc486806303e0ea4417ec3
Reviewed-on: https://code.wireshark.org/review/19203
Reviewed-by: Gerald Combs <gerald(a)wireshark.org>
http://cgit.osmocom.org/wireshark/commit/?id=f27f048ee12b140b010f431dcfb9e5…
commit f27f048ee12b140b010f431dcfb9e588e130fcc8
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Dec 10 20:18:26 2016 -0800
Cleanup dissection of endpoint addresses.
All the pseudo-headers encode the endpoint as per a bEndpointAddress in
sections 9.6.6 "Endpoint" of the USB 2.0 spec and the USB 3.1 spec, with
a 4-bit endpoint number at the bottom and a 1-bit direction at the top
with 0 = OUT and 1 = IN.
Show the FreeBSD endpoint address the same way the other endpoint
addresses are shown; the FreeBSD one is shown as a 4-byte little-endian
value, but only the low-order (first) byte is used, so just show that
byte.
Call that field the "endpoint address", with the lower 4 bits being the
"endpoint number" and the uppermost bit the "endpoint direction".
Change-Id: Ic7358c7fb6b6df2502315b590eb5178cecb321d9
Reviewed-on: https://code.wireshark.org/review/19200
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=54abb36a340af211970fe1ad6dab16…
commit 54abb36a340af211970fe1ad6dab16af4e8fe83b
Author: Роман Донченко <dpb(a)corrigendum.ru>
Date: Sun Dec 11 02:40:27 2016 +0300
ssh: remove uninformative blurbs
For most of the fields, the blurb is just the name with "SSH" prepended,
which is not particularly useful. Replace a few of them with more
informative descriptions and remove the rest.
Change-Id: I15e95a42e897d09d3b6334022b32dd36f29e86a4
Reviewed-on: https://code.wireshark.org/review/19198
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=74bc8f8bc6d5191bae95c2b2d0ed6f…
commit 74bc8f8bc6d5191bae95c2b2d0ed6ff2a338c134
Author: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Date: Fri Dec 9 14:40:59 2016 -0800
Add a preference to control whether string and byte lengths appear in protocol tree
Change-Id: I6be13d9adb8871cbbf4604155e8e7175a74ddaa3
Reviewed-on: https://code.wireshark.org/review/19188
Petri-Dish: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Dmitry Lazurkin <dilaz03(a)gmail.com>
Reviewed-by: Martin Mathieson <martin.r.mathieson(a)googlemail.com>
http://cgit.osmocom.org/wireshark/commit/?id=4097c1075b91fdb189d8b6f566bacb…
commit 4097c1075b91fdb189d8b6f566bacb969fde4b97
Author: Harald Welte <laforge(a)gnumonks.org>
Date: Fri Dec 9 13:21:13 2016 -0500
gsmtap: Introduce a new packet-gsmtap.h header file
Move the GSMTAP protocol related #defines to packet-gsmtap.h, as there
are other dissectors (like packet-gsm_sim.c and future dissectors) need
access to some of those #defines.
Change-Id: Ibb3517bd773be63b7e3cd30104a5351427e22ebf
Reviewed-on: https://code.wireshark.org/review/19185
Petri-Dish: Michael Mann <mmann78(a)netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Michael Mann <mmann78(a)netscape.net>
http://cgit.osmocom.org/wireshark/commit/?id=2dfa603333416aec69719fb0743888…
commit 2dfa603333416aec69719fb074388886f0fc96b2
Author: Guy Harris <guy(a)alum.mit.edu>
Date: Sat Dec 10 10:37:07 2016 -0800
Initialize fd_head->frame in all cases where we allocate fd_head.
Also, sort the initializations of structure members by the order in the
structure, to make it easier to check that we've initialized them all.
Bug: 13231
Change-Id: Id2819940d916a5fd5a3f1bf2fc20bd3ee34a75f4
Reviewed-on: https://code.wireshark.org/review/19195
Reviewed-by: Guy Harris <guy(a)alum.mit.edu>
http://cgit.osmocom.org/wireshark/commit/?id=00223bc5b9f3c34a365759fceb4968…
commit 00223bc5b9f3c34a365759fceb49684b4496051a
Author: Stig Bjørlykke <stig(a)bjorlykke.org>
Date: Sat Dec 10 13:07:06 2016 +0100
Qt: Avoid infinite recursion in ExtcapArgument::loadValues
If configuring a extcap "value" sentence with {value=} then loadValues()
must not run in a infinite recursion trying to find it's children.
Change-Id: Ic2577b31d9312e8f6a099c4fe7c0672e801dbc89
Reviewed-on: https://code.wireshark.org/review/19192
Petri-Dish: Stig Bjørlykke <stig(a)bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply(a)wireshark.org>
Reviewed-by: Roland Knall <rknall(a)gmail.com>
-----------------------------------------------------------------------
hooks/post-receive
--
wireshark with Osmocom specific dissectors
2689
days inactive
2689
days old
osmocom-commitlog@lists.osmocom.org
0 comments
1 participants
participants (1)
-
gitosis＠osmocom.org