This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, sysmocom/revert_WAIT_ASSIGN has been updated discards 303be72c9fe3266214e3bf70852270ad45d3eb95 (commit) via 73f117861453745a83b229bd8f710ce51474a014 (commit) via 0ee31cfa381282d0d724fb36c48bae297a0647ac (commit) via 8e70bb5bb4751e3a7f33b95b2994bff410235844 (commit) via 22a901905c9749b03fceccda4d550f3da799d524 (commit) via 3463bd4adc1598462560ed84da837d04d0e8e20c (commit) via e26ee01d56b4c4c2da6abc6b649cb765d5787b98 (commit) via 024152683646f1b68c85de74f783b81db51d16b5 (commit) via 9f5f008aedc910ff0ce18bf3f92b9b74f0438bf8 (commit) via 8d2d9e89850e961affc998e984c3fc6ac7b8f7b1 (commit) via 9bbe1600cc02e1b538380393edb1dcdabe9247a2 (commit) via 16ddc90eabad423d247753f7d89639659e049d35 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (303be72c9fe3266214e3bf70852270ad45d3eb95) \ N -- N -- N (73f117861453745a83b229bd8f710ce51474a014) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=73f117861453745a83b229bd8f710ce5... commit 73f117861453745a83b229bd8f710ce51474a014 Author: Neels Hofmeyr <neels@hofmeyr.de> Date: Wed Jun 8 15:27:40 2016 +0200 Revert "tbf: Add state WAIT_ASSIGN" This reverts commit f1a7b8fc6651f92a8b7f3f27b7ca05d07f4e44e0. Conflicts: tests/tbf/TbfTest.err The commit broke GPRS service at least for osmo-bts-sysmo on a SysmoBTS 1002 with current master of osmo-bts (ef30f50d5d6d5f863fc147d05ccdceb89284934e). The error observed is the following log output (was viewing both osmo-bts-sysmo and osmo-pcu logs interleaved): <0002> tbf.cpp:874 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=WAIT ASSIGN) T3169 timeout during transsmission <0002> tbf.cpp:893 - Assignment was on CCCH <0002> tbf.cpp:899 - No uplink data received yet <0007> l1sap.c:904 RACH for packet access <0001> pcu_l1_if.cpp:311 RACH request received: sapi=1 qta=0, ra=121, fn=13653 [repeat] When removing this single commit from current osmo-pcu master, GPRS service works well on SysmoBTS, with current osmo-bts master. The TbfTest.err expected output needed adjustment after the revert. Disclaimer: I am not aware of adverse effects this commit may have. I have no idea what the WAIT_ASSIGN state is used for -- further review is required. Change-Id: I1532f8e93194368cdc1e3846f82afa6d68cd5fbd ----------------------------------------------------------------------- Summary of changes: src/bts.cpp | 3 +- src/csn1.cpp | 11 +- src/decoding.cpp | 7 +- src/gprs_ms.cpp | 17 +- src/osmo-bts-litecell15/lc15_l1_if.c | 4 +- src/sba.cpp | 4 + src/tbf.cpp | 27 ++-- src/tbf.h | 2 + src/tbf_dl.cpp | 22 ++- src/tbf_ul.cpp | 16 +- tests/alloc/AllocTest.cpp | 51 ++++++ tests/alloc/AllocTest.ok | 3 + tests/edge/EdgeTest.cpp | 18 +++ tests/rlcmac/RLCMACTest.cpp | 18 ++- tests/tbf/TbfTest.cpp | 160 +++++++++++++++++- tests/tbf/TbfTest.err | 305 +++++++++++++++++++++++++---------- tests/tbf/TbfTest.ok | 2 + 17 files changed, 536 insertions(+), 134 deletions(-) hooks/post-receive -- UNNAMED PROJECT