This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, laforge/pending has been updated via 5aa9e5bf2ade1f007b753ebc51e60555bc50c679 (commit) via b7767eaf1b0cc7038a47d1a25e88028c275a1112 (commit) via 75754afbbe0cdbe36628d0320f8c16ea1ad2fd6b (commit) via e95cab8501e57173aebafd2407c4b179839f43bd (commit) from f6552c5b7fea97287645c265f9692d0d2cbae324 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=5aa9e5bf2ade1f007b753ebc51e60555b... commit 5aa9e5bf2ade1f007b753ebc51e60555bc50c679 Author: Harald Welte <laforge@gnumonks.org> Date: Wed Apr 27 18:21:16 2016 +0200 osmo_oap_decode(): Use common argument ordering In general, if a function generates output data like a msgb (or in this case filling an osmo_oap_message structure), the output argument precedes the source. This is what we use all over libosmo*, and it is modelled after memcpy(), where dst is the first argument, before src. Let's align osmo_oap_decode(). Intestingly, osmo_oap_encode was already correct, so the encode/decode functions used different conventions before. http://cgit.osmocom.org/openbsc/commit/?id=b7767eaf1b0cc7038a47d1a25e88028c2... commit b7767eaf1b0cc7038a47d1a25e88028c275a1112 Author: Harald Welte <laforge@gnumonks.org> Date: Wed Apr 27 18:17:26 2016 +0200 OAP: Various coding style fixes * we always declare stack variables at the top of the function / block * 'switch' is not a function, so there's space ahead of the opening ( http://cgit.osmocom.org/openbsc/commit/?id=75754afbbe0cdbe36628d0320f8c16ea1... commit 75754afbbe0cdbe36628d0320f8c16ea1ad2fd6b Author: Harald Welte <laforge@gnumonks.org> Date: Wed Apr 27 18:14:14 2016 +0200 OAP: use osmo_oap_ prefix for OAP, rather than plain oap_ this is in preparation of moving related code to libosmocore. http://cgit.osmocom.org/openbsc/commit/?id=e95cab8501e57173aebafd2407c4b1798... commit e95cab8501e57173aebafd2407c4b179839f43bd Author: Harald Welte <laforge@gnumonks.org> Date: Wed Apr 27 15:17:14 2016 +0200 oap_message.h: Remove dependency to openbsc include This is a first step to moving oap_messages.h to libosmocore ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/oap.h | 4 ++-- openbsc/include/openbsc/oap_messages.h | 14 ++++++------ openbsc/src/gprs/oap.c | 39 ++++++++++++++++++---------------- openbsc/src/gprs/oap_messages.c | 7 +++--- openbsc/tests/oap/oap_test.c | 9 ++++---- 5 files changed, 38 insertions(+), 35 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)